179739 2007-05-25 12:06 0000 sys-kernel/genkernel does not recognize kernel config change when using --kernel-config 2007-08-28 19:42:51 0000 1 1 1 Unclassified Gentoo Hosted Projects genkernel unspecified All Linux RESOLVED FIXED P2 normal --- 1 gentoo@patdouble.com genkernel@gentoo.org gentoo@patdouble.com 2007-05-25 12:06:03 0000 catalyst 2.0.4 does not recognize kernel config change. I have already built a livecd-stage2 and later modify my kernel config. When building livecd-stage2 again a message states that no kernel config change has been detected. If I remove /var/tmp/catalyst/kerncache and build, the kernel indeed has my new config. Reproducible: Always Steps to Reproduce: 1. build livecd-stage2 2. change kernel config 3. build livecd-stage2 4. notice kernel is not rebuilt Actual Results: Stale kernel cache is usage. Expected Results: Kernel should be rebuilt. gentoo@patdouble.com 2007-06-04 14:02:38 0000 It looks like this bug is actually in genkernel. I am seeing it when using catalyst though. My machine doesn't use cache when building the kernel so I cannot comment on that setup. agaffney@gentoo.org 2007-06-04 14:26:06 0000 Please verify whether this is genkernel or catalyst's fault. Run genkernel a few times locally with the proper options for kerncache. That should tell you. Also, we just need more information in general. There is very little here to go on. It seems to work just fine for everyone else. gentoo@patdouble.com 2007-06-04 15:15:57 0000 I'll change summary back to catalyst until I can verify what's really going on here gentoo@patdouble.com 2007-06-05 16:25:39 0000 I added a patch to display the md5sum and head of the kernel configs when genkernel checks if the cache is valid. Here's what I get: * Linux Kernel 2.6.20-gentoo-r8 for x86... * WARNING: No mounted /boot partition detected! * Run mount /boot to mount it! * Kernel config (/var/tmp/genkernel/30832.1015.13720.30639/config-x86-2.6.20-gentoo-r8) MD5: a46b89c1bc1c38887562d6eef70954d8 # # Automatically generated make config: don't edit # Linux kernel version: 2.6.20-gentoo-r8 # Sun Jun 3 19:43:54 2007 # * Kernel cached (//usr/src/linux/.config) config MD5: a46b89c1bc1c38887562d6eef70954d8 # # Automatically generated make config: don't edit # Linux kernel version: 2.6.20-gentoo-r8 # Sun Jun 3 19:43:54 2007 # * No kernel configuration change, skipping kernel build... Yet my kernel config starts like (notice the date is missing, this is only for testing and it looks from the code that comments are considered in the md5 sum): # # Automatically generated make config: don't edit # Linux kernel version: 2.6.20-gentoo-r8 # # I'm not sure what's happening here. Either genkernel is not checking the right file, or catalyst is putting the config in the wrong, or whatever, I don't really know. But I do know if I clear the kernel cache the new kernel does use the correct config. gentoo@patdouble.com 2007-06-05 19:11:21 0000 Perhaps this code in /usr/share/genkernel/gen_configkernel.sh # If we're not cleaning, then we don't want to try to overwrite the configs there # or we might remove configurations someone is trying to test. if isTrue "${CLEAN}" then print_info 1 "config: Using config from ${KERNEL_CONFIG}" print_info 1 ' Previous config backed up to .config.bak' cp "${KERNEL_CONFIG}" "${KERNEL_DIR}/.config" || gen_die 'Could not copy configuration file!' fi That seems to prevent the kernel specified on the command line from being used if we're not cleaning. However, if --clean is given then will the cache be used at all?? gentoo@patdouble.com 2007-06-05 19:37:42 0000 Unless I'm really mistaken, this time I think it is genkernel. It appears it does not detect kernel config changes correctly when the config is specified using "--kernel-config". It always checks the .config in the kernel source directory. The config check is done before config_kernel is called, so the config file specified by --kernel-config is not copied to t gentoo@patdouble.com 2007-06-05 19:40:13 0000 I cannot upload, bugzilla error, here is the patch: Index: gen_package.sh =================================================================== --- gen_package.sh (revision 508) +++ gen_package.sh (working copy) @@ -150,12 +150,18 @@ else if [ -e "${KERNCACHE}" ] then + KERNEL_CONFIG="/${KERNEL_DIR}/.config" + if [ "${CMD_KERNEL_CONFIG}" != '' ] + then + KERNEL_CONFIG="${CMD_KERNEL_CONFIG}" + fi + /bin/tar -xj -f ${KERNCACHE} -C ${TEMP} - if [ -e ${TEMP}/config-${ARCH}-${KV} -a -e /${KERNEL_DIR}/.config ] + if [ -e ${TEMP}/config-${ARCH}-${KV} -a -e ${CMD_KERNEL_CONFIG} ] then test1=$(md5sum ${TEMP}/config-${ARCH}-${KV} | cut -d " " -f 1) - test2=$(md5sum /${KERNEL_DIR}/.config | cut -d " " -f 1) + test2=$(md5sum ${CMD_KERNEL_CONFIG} | cut -d " " -f 1) if [ "${test1}" == "${test2}" ] then gentoo@patdouble.com 2007-06-06 18:00:02 0000 Created an attachment (id=121340) patch for gen_package.sh This patch ignores comments in the kernel config when doing the md5sum. I need this as the config has the current date put into it which causes the cache to also look invalid. gentoo@patdouble.com 2007-06-07 15:50:02 0000 Created an attachment (id=121415) gen_package.patch Replaces previously bad patch that used the wrong env var for the new kernel config. wolf31o2@gentoo.org 2007-06-23 14:04:48 0000 Most of the caching code was written before my time as genkernel maintainer, so I'm not very familiar with it. I honestly don't know what it is supposed to do and it would require me to get up-to-speed on that portion of the code. I am working towards a 3.5 release for genkernel and would love to get this fixed before then. Unfortunately, my time is still very scarce, due to my taking a one-month "semi-vacation" from Gentoo where I was only working on the most important of things and my workload piling up on me. If I were to roll up a new genkernel version with your patch from current SVN, would you test it for me and see if this problem is fixed? I'd trust you on this and just don't have the time to spend for a still indeterminate amount of time to test this. Knowing you've tested it (and maybe someone else, if someone volunteers) and the problem is resolved will help me out greatly and will allow me to focus on other bugs that will likely require more of my direct energy. gentoo@patdouble.com 2007-06-23 14:11:33 0000 Yes, I'd be happy to test it. agaffney@gentoo.org 2007-07-26 02:53:17 0000 This patch looks simple and relatively harmless. In SVN! wolf31o2@gentoo.org 2007-08-22 19:54:09 0000 Please test genkernel 3.4.9_prer1 or better. This should be fixed now. gentoo@patdouble.com 2007-08-28 19:42:51 0000 Works for me. Thanks. 121340 2007-06-06 18:00 0000 patch for gen_package.sh gen_package.patch text/plain SW5kZXg6IGdlbl9wYWNrYWdlLnNoCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIGdlbl9wYWNrYWdlLnNoCShyZXZp c2lvbiA1MDgpCisrKyBnZW5fcGFja2FnZS5zaAkod29ya2luZyBjb3B5KQpAQCAtMTUwLDEyICsx NTAsMTggQEAKICAgICAgICAgZWxzZQogCQlpZiBbIC1lICIke0tFUk5DQUNIRX0iIF0gCiAJCXRo ZW4KKwkJCUtFUk5FTF9DT05GSUc9Ii8ke0tFUk5FTF9ESVJ9Ly5jb25maWciCisJCQlpZiBbICIk e0NNRF9LRVJORUxfQ09ORklHfSIgIT0gJycgXQorCQkJdGhlbgorCQkJCUtFUk5FTF9DT05GSUc9 IiR7Q01EX0tFUk5FTF9DT05GSUd9IgorCQkJZmkKKwogCQkJL2Jpbi90YXIgLXhqIC1mICR7S0VS TkNBQ0hFfSAtQyAke1RFTVB9Ci0JCQlpZiBbIC1lICR7VEVNUH0vY29uZmlnLSR7QVJDSH0tJHtL Vn0gLWEgLWUgLyR7S0VSTkVMX0RJUn0vLmNvbmZpZyBdCisJCQlpZiBbIC1lICR7VEVNUH0vY29u ZmlnLSR7QVJDSH0tJHtLVn0gLWEgLWUgJHtDTURfS0VSTkVMX0NPTkZJR30gXQogCQkJdGhlbgog CQotCQkJCXRlc3QxPSQobWQ1c3VtICR7VEVNUH0vY29uZmlnLSR7QVJDSH0tJHtLVn0gfCBjdXQg LWQgIiAiIC1mIDEpCi0JCQkJdGVzdDI9JChtZDVzdW0gLyR7S0VSTkVMX0RJUn0vLmNvbmZpZyB8 IGN1dCAtZCAiICIgLWYgMSkKKwkJCQl0ZXN0MT0kKGdyZXAgLXYgIl4jIiAke1RFTVB9L2NvbmZp Zy0ke0FSQ0h9LSR7S1Z9IHwgbWQ1c3VtIHwgY3V0IC1kICIgIiAtZiAxKQorCQkJCXRlc3QyPSQo Z3JlcCAtdiAiXiMiICR7Q01EX0tFUk5FTF9DT05GSUd9IHwgbWQ1c3VtIHwgY3V0IC1kICIgIiAt ZiAxKQogCQkJCWlmIFsgIiR7dGVzdDF9IiA9PSAiJHt0ZXN0Mn0iIF0KIAkJCQl0aGVuCiAJCg== 121415 2007-06-07 15:50 0000 gen_package.patch gen_package.patch text/plain SW5kZXg6IGdlbl9wYWNrYWdlLnNoCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIGdlbl9wYWNrYWdlLnNoCShyZXZp c2lvbiA1MDgpCisrKyBnZW5fcGFja2FnZS5zaAkod29ya2luZyBjb3B5KQpAQCAtMTUwLDEyICsx NTAsMTggQEAKICAgICAgICAgZWxzZQogCQlpZiBbIC1lICIke0tFUk5DQUNIRX0iIF0gCiAJCXRo ZW4KKwkJCUtFUk5FTF9DT05GSUc9Ii8ke0tFUk5FTF9ESVJ9Ly5jb25maWciCisJCQlpZiBbICIk e0NNRF9LRVJORUxfQ09ORklHfSIgIT0gJycgXQorCQkJdGhlbgorCQkJCUtFUk5FTF9DT05GSUc9 IiR7Q01EX0tFUk5FTF9DT05GSUd9IgorCQkJZmkKKwogCQkJL2Jpbi90YXIgLXhqIC1mICR7S0VS TkNBQ0hFfSAtQyAke1RFTVB9Ci0JCQlpZiBbIC1lICR7VEVNUH0vY29uZmlnLSR7QVJDSH0tJHtL Vn0gLWEgLWUgLyR7S0VSTkVMX0RJUn0vLmNvbmZpZyBdCisJCQlpZiBbIC1lICR7VEVNUH0vY29u ZmlnLSR7QVJDSH0tJHtLVn0gLWEgLWUgJHtLRVJORUxfQ09ORklHfSBdCiAJCQl0aGVuCiAJCi0J CQkJdGVzdDE9JChtZDVzdW0gJHtURU1QfS9jb25maWctJHtBUkNIfS0ke0tWfSB8IGN1dCAtZCAi ICIgLWYgMSkKLQkJCQl0ZXN0Mj0kKG1kNXN1bSAvJHtLRVJORUxfRElSfS8uY29uZmlnIHwgY3V0 IC1kICIgIiAtZiAxKQorCQkJCXRlc3QxPSQoZ3JlcCAtdiAiXiMiICR7VEVNUH0vY29uZmlnLSR7 QVJDSH0tJHtLVn0gfCBtZDVzdW0gfCBjdXQgLWQgIiAiIC1mIDEpCisJCQkJdGVzdDI9JChncmVw IC12ICJeIyIgJHtLRVJORUxfQ09ORklHfSB8IG1kNXN1bSB8IGN1dCAtZCAiICIgLWYgMSkKIAkJ CQlpZiBbICIke3Rlc3QxfSIgPT0gIiR7dGVzdDJ9IiBdCiAJCQkJdGhlbgogCQo=