179649 2007-05-24 14:56 0000 games-fps/quake3-1.34_rc3 fails on gcc-4.2 2007-07-18 09:51:26 0000 1 1 1 Unclassified Gentoo Linux GCC Porting unspecified All Linux RESOLVED FIXED P2 enhancement --- 162167 1 sefi@s-e-f-i.de games@gentoo.org esigra@gmail.com tenebrarum@gmail.com xake@rymdraket.net sefi@s-e-f-i.de 2007-05-24 14:56:32 0000 The file code/tools/asm/cmdlib.c contains two expressions that always evaluate to true because it compares an array against true (which actually converts the array into a pointer to the first element) which must not be zero. Because -Werror is set and gcc-4.2 has stricter warnings the build fails. I will attach a small patch to fix it. Reproducible: Always Steps to Reproduce: 1. switch to gcc-4.2 2. emerge quake3 sefi@s-e-f-i.de 2007-05-24 14:57:11 0000 Created an attachment (id=120194) Patch to fix the bug. nyhm@gentoo.org 2007-06-08 13:20:28 0000 I think it should be changed to do what was intended instead of removing it entirely. wolf31o2@gentoo.org 2007-06-20 01:32:11 0000 I completely agree. Also, upstream is very responsive with regards to bugs such as this, so any patches we apply will very likely be accepted upstream easily. vapier@gentoo.org 2007-06-22 02:06:41 0000 i'd just say drop the -Werror from the build ... that only causes trouble also, upstream has already accepted a bug fix from nyhm for this which ive added 120194 2007-05-24 14:57 0000 Patch to fix the bug. quake3-gcc-4.2.patch text/plain ZGlmZiAtTnVycCBpb3F1YWtlM18xLjM0LXJjMy9jb2RlL3Rvb2xzL2FzbS9jbWRsaWIuYyBpb3F1 YWtlM18xLjM0LXJjMy5uZXcvY29kZS90b29scy9hc20vY21kbGliLmMKLS0tIGlvcXVha2UzXzEu MzQtcmMzL2NvZGUvdG9vbHMvYXNtL2NtZGxpYi5jCTIwMDYtMTEtMjggMjM6MDU6MzIuMDAwMDAw MDAwICswMTAwCisrKyBpb3F1YWtlM18xLjM0LXJjMy5uZXcvY29kZS90b29scy9hc20vY21kbGli LmMJMjAwNy0wNS0yNCAxNjo0NTowNi4wMDAwMDAwMDAgKzAyMDAKQEAgLTMxMiw4ICszMTIsNiBA QCBjaGFyICpFeHBhbmRBcmcgKGNvbnN0IGNoYXIgKnBhdGgpCiBjaGFyICpFeHBhbmRQYXRoIChj b25zdCBjaGFyICpwYXRoKQogewogCXN0YXRpYyBjaGFyIGZ1bGxbMTAyNF07Ci0JaWYgKCFxZGly KQotCQlFcnJvciAoIkV4cGFuZFBhdGggY2FsbGVkIHdpdGhvdXQgcWRpciBzZXQiKTsKIAlpZiAo cGF0aFswXSA9PSAnLycgfHwgcGF0aFswXSA9PSAnXFwnIHx8IHBhdGhbMV0gPT0gJzonKSB7CiAJ CXN0cmNweSggZnVsbCwgcGF0aCApOwogCQlyZXR1cm4gZnVsbDsKQEAgLTMyNSw4ICszMjMsNiBA QCBjaGFyICpFeHBhbmRQYXRoIChjb25zdCBjaGFyICpwYXRoKQogY2hhciAqRXhwYW5kR2FtZVBh dGggKGNvbnN0IGNoYXIgKnBhdGgpCiB7CiAJc3RhdGljIGNoYXIgZnVsbFsxMDI0XTsKLQlpZiAo IXFkaXIpCi0JCUVycm9yICgiRXhwYW5kR2FtZVBhdGggY2FsbGVkIHdpdGhvdXQgcWRpciBzZXQi KTsKIAlpZiAocGF0aFswXSA9PSAnLycgfHwgcGF0aFswXSA9PSAnXFwnIHx8IHBhdGhbMV0gPT0g JzonKSB7CiAJCXN0cmNweSggZnVsbCwgcGF0aCApOwogCQlyZXR1cm4gZnVsbDsK