178430 2007-05-13 20:50 0000 net-misc/vnc-4.1.2-r3 ~x86-fbsd ebuild & keyword request 2008-11-10 14:43:41 0000 1 1 1 Unclassified Gentoo/Alt FreeBSD unspecified All FreeBSD NEW P2 enhancement --- 1 lavajoe@gentoo.org armin76@gentoo.org bsd@gentoo.org vapier@gentoo.org lavajoe@gentoo.org 2007-05-13 20:50:15 0000 1) Changed "cp -a" to "cp -RPp" for bsd compat (needed for "server" USE flag) 2) Tested both vncviewer and vncserver Requesting keyword ~x86-fbsd with this new ebuild (to be attached). Reproducible: Always lavajoe@gentoo.org 2007-05-13 20:51:01 0000 Created an attachment (id=119148) vnc-4.1.2-r3.ebuild (this is a diff) lavajoe@gentoo.org 2007-05-14 04:26:51 0000 Created an attachment (id=119171) files/vnc-4.1.2-freebsd.patch Patch to create xauth cookie on FreeBDS without the need for "mcookie" (only available in Linux). lavajoe@gentoo.org 2007-05-14 04:28:34 0000 Created an attachment (id=119173) vnc-4.1.2-r3.ebuild (diff) Incorporate patch that allows creation of xauth cookies on FreeBSD lavajoe@gentoo.org 2007-06-08 18:30:13 0000 Adding maintainer to CC armin76@gentoo.org 2007-06-09 19:06:32 0000 Patch and ebuild added, thanks. Keyword it :) lavajoe@gentoo.org 2007-06-09 19:49:41 0000 Keyworded (vnc-4.1.2-r3). Thanks! vapier@gentoo.org 2007-06-11 06:39:44 0000 wouldnt it be cleaner to try and use `mcookie` and if that fails, fall back to doing rand ? that way there would be no direct dependency on FreeBSD lavajoe@gentoo.org 2007-06-11 15:45:18 0000 Vapier, that sounds like it would work fine and yes, potentially then not be OS-based. The only downside I can think of is that by doing this, the Linux archs would either use mcookie or the other method, depending on if mcookie were installed. Maybe this doesn't matter, but there might be a good reason to have predictable cookie generation on a given arch. If so, it would probably be good to have vnc RDEPEND on the package containing mcookie... vapier@gentoo.org 2007-06-11 20:17:00 0000 which oddly enough is the util-linux package ... lavajoe@gentoo.org 2007-06-11 23:01:59 0000 Are you suggesting that we leave it as-is but that RDEPEND depend on util-linux for linux only? Or do you feel that this should be done at runtime by detecting a failure with mcookie? I'm re-assinging to Raúl for now, since he did the patch checkin and may want to weigh in on this. vapier@gentoo.org 2007-06-11 23:16:16 0000 the runtime code should see if mcookie works and if it does, use it ... otherwise it should generate its own considering the output is simply a md5 hash, there might be a better way than the current rand() ... maybe grab a few bytes from /dev/random and run md5 on that i dont think we need a direct depend on util-linux in RDEPEND since that package is required in the system target for all Linux profiles lavajoe@gentoo.org 2008-11-10 14:43:41 0000 Raúl, Just looking back at this bug; I think it is fixed, unless you had input (see comments 8-11). In other words, you can probably close this out unless you want to revisit. -Thanks, Joe 119148 2007-05-13 20:51 0000 vnc-4.1.2-r3.ebuild (this is a diff) vnc-4.1.2-r3.ebuild.diff text/plain LS0tIHZuYy00LjEuMi1yMy5lYnVpbGQub3JpZwkyMDA3LTA1LTEzIDE0OjQ3OjU1LjAwMDAwMDAw MCAtMDYwMAorKysgdm5jLTQuMS4yLXIzLmVidWlsZAkyMDA3LTA1LTEzIDE0OjQyOjM0LjAwMDAw MDAwMCAtMDYwMApAQCAtMTksNyArMTksNyBAQAogCiBMSUNFTlNFPSJHUEwtMiIKIFNMT1Q9IjAi Ci1LRVlXT1JEUz0ifmFscGhhIH5hbWQ2NCB+aHBwYSB+aWE2NCB+bWlwcyB+cHBjIH5wcGM2NCB+ c2ggfnNwYXJjIH54ODYiCitLRVlXT1JEUz0ifmFscGhhIH5hbWQ2NCB+aHBwYSB+aWE2NCB+bWlw cyB+cHBjIH5wcGM2NCB+c2ggfnNwYXJjIH54ODYgfng4Ni1mYnNkIgogSVVTRT0ic2VydmVyIgog CiBSREVQRU5EPSJzeXMtbGlicy96bGliCkBAIC05MiwxMyArOTIsMTMgQEAKIAllYXV0b3JlY29u ZgogCiAJaWYgdXNlIHNlcnZlciA7IHRoZW4KLQkJY3AgLWEgeGMvcHJvZ3JhbXMvWHNlcnZlci92 bmMvWHZuYy94dm5jLmNjIFwKKwkJY3AgLVJQcCB4Yy9wcm9ncmFtcy9Yc2VydmVyL3ZuYy9Ydm5j L3h2bmMuY2MgXAogCQkJeGMvcHJvZ3JhbXMvWHNlcnZlci9Ydm5jLm1hbiBcCiAJCQl4Yy9wcm9n cmFtcy9Yc2VydmVyL3ZuYy8qLntoLGNjfSBcCiAJCQl4b3JnLXgxMS1zZXJ2ZXItc291cmNlL2h3 L3ZuYwotCQljcCAtYSB4b3JnLXgxMS1zZXJ2ZXItc291cmNlL3tjZmIvY2ZiLmgsaHcvdm5jfQot CQljcCAtYSB4b3JnLXgxMS1zZXJ2ZXItc291cmNlL3tmYi9mYi5oLGh3L3ZuY30KLQkJY3AgLWEg eG9yZy14MTEtc2VydmVyLXNvdXJjZS97ZmIvZmJyb3AuaCxody92bmN9CisJCWNwIC1SUHAgeG9y Zy14MTEtc2VydmVyLXNvdXJjZS97Y2ZiL2NmYi5oLGh3L3ZuY30KKwkJY3AgLVJQcCB4b3JnLXgx MS1zZXJ2ZXItc291cmNlL3tmYi9mYi5oLGh3L3ZuY30KKwkJY3AgLVJQcCB4b3JnLXgxMS1zZXJ2 ZXItc291cmNlL3tmYi9mYnJvcC5oLGh3L3ZuY30KIAkJc2VkIC1pIC1lICdzLHhvcixjX3hvciwn IC1lICdzLGFuZCxjX2FuZCwnIFwKIAkJCXhvcmcteDExLXNlcnZlci1zb3VyY2UvaHcvdm5jL3tj ZmIsZmIsZmJyb3B9LmgKIAkJY2QgeG9yZy14MTEtc2VydmVyLXNvdXJjZQo= 119171 2007-05-14 04:26 0000 files/vnc-4.1.2-freebsd.patch vnc-4.1.2-freebsd.patch text/plain LS0tIHZuYy00XzFfMi11bml4c3JjL3VuaXgvdm5jc2VydmVyLm9yaWcJMjAwNy0wNS0xMyAyMDo0 Mjo1MCAtMDYwMAorKysgdm5jLTRfMV8yLXVuaXhzcmMvdW5peC92bmNzZXJ2ZXIJMjAwNy0wNS0x MyAyMDo0Mjo0MSAtMDYwMApAQCAtMTI3LDggKzEyNywyNCBAQAogJGRlc2t0b3BMb2cgPSAiJHZu Y1VzZXJEaXIvJGhvc3Q6JGRpc3BsYXlOdW1iZXIubG9nIjsKIHVubGluaygkZGVza3RvcExvZyk7 CiAKLSMgTWFrZSBhbiBYIHNlcnZlciBjb29raWUgLSB1c2UgbWNvb2tpZQotJGNvb2tpZSA9IGAv dXNyL2Jpbi9tY29va2llYDsKKyMgTWFrZSBhbiBYIHNlcnZlciBjb29raWUKKyMgICBGb3IgRnJl ZUJTRCwgZ2VuZXJhdGUgaXQgcmFuZG9tbHkKKyMgICBGb3IgTGludXgsIHVzZSBtY29va2llCitp ZiAoYC91c3IvYmluL3VuYW1lYCA9PSAnRnJlZUJTRCcpCit7CisgICAgc3JhbmQ7CisgICAgJGNv b2tpZSA9ICcnOworICAgIGZvciAoMS4uMTYpCisgICAgeworICAgICAgICAkY29va2llIC49IHNw cmludGYoIiUwMngiLCBpbnQocmFuZCgyNTYpKSk7CisgICAgfQorfQorZWxzZQoreworICAgICRj b29raWUgPSBgL3Vzci9iaW4vbWNvb2tpZWA7Cit9CisKKyMgTm93IHVzZSB0aGUgY29va2llIGlu IHRoZSB4YXV0aCBmaWxlCiBvcGVuIChYQVVUSCwgInx4YXV0aCAtZiAkeGF1dGhvcml0eUZpbGUg c291cmNlIC0iKTsKIHByaW50IFhBVVRIICJhZGQgJGhvc3Q6JGRpc3BsYXlOdW1iZXIgLiAkY29v a2llXG4iOwogcHJpbnQgWEFVVEggImFkZCAkaG9zdC91bml4OiRkaXNwbGF5TnVtYmVyIC4gJGNv b2tpZVxuIjsK 119173 2007-05-14 04:28 0000 vnc-4.1.2-r3.ebuild (diff) vnc-4.1.2-r3.ebuild.diff text/plain LS0tIC91c3IvcG9ydGFnZS9uZXQtbWlzYy92bmMvdm5jLTQuMS4yLXIzLmVidWlsZAkyMDA3LTA1 LTA4IDExOjM1OjU4IC0wNjAwCisrKyB2bmMtNC4xLjItcjMuZWJ1aWxkCTIwMDctMDUtMTMgMjA6 NDA6NTQgLTA2MDAKQEAgLTE5LDcgKzE5LDcgQEAKIAogTElDRU5TRT0iR1BMLTIiCiBTTE9UPSIw IgotS0VZV09SRFM9In5hbHBoYSB+YW1kNjQgfmhwcGEgfmlhNjQgfm1pcHMgfnBwYyB+cHBjNjQg fnNoIH5zcGFyYyB+eDg2IgorS0VZV09SRFM9In5hbHBoYSB+YW1kNjQgfmhwcGEgfmlhNjQgfm1p cHMgfnBwYyB+cHBjNjQgfnNoIH5zcGFyYyB+eDg2IH54ODYtZmJzZCIKIElVU0U9InNlcnZlciIK IAogUkRFUEVORD0ic3lzLWxpYnMvemxpYgpAQCAtOTIsMTggKzkyLDIxIEBACiAJZWF1dG9yZWNv bmYKIAogCWlmIHVzZSBzZXJ2ZXIgOyB0aGVuCi0JCWNwIC1hIHhjL3Byb2dyYW1zL1hzZXJ2ZXIv dm5jL1h2bmMveHZuYy5jYyBcCisJCWNwIC1SUHAgeGMvcHJvZ3JhbXMvWHNlcnZlci92bmMvWHZu Yy94dm5jLmNjIFwKIAkJCXhjL3Byb2dyYW1zL1hzZXJ2ZXIvWHZuYy5tYW4gXAogCQkJeGMvcHJv Z3JhbXMvWHNlcnZlci92bmMvKi57aCxjY30gXAogCQkJeG9yZy14MTEtc2VydmVyLXNvdXJjZS9o dy92bmMKLQkJY3AgLWEgeG9yZy14MTEtc2VydmVyLXNvdXJjZS97Y2ZiL2NmYi5oLGh3L3ZuY30K LQkJY3AgLWEgeG9yZy14MTEtc2VydmVyLXNvdXJjZS97ZmIvZmIuaCxody92bmN9Ci0JCWNwIC1h IHhvcmcteDExLXNlcnZlci1zb3VyY2Uve2ZiL2Zicm9wLmgsaHcvdm5jfQorCQljcCAtUlBwIHhv cmcteDExLXNlcnZlci1zb3VyY2Uve2NmYi9jZmIuaCxody92bmN9CisJCWNwIC1SUHAgeG9yZy14 MTEtc2VydmVyLXNvdXJjZS97ZmIvZmIuaCxody92bmN9CisJCWNwIC1SUHAgeG9yZy14MTEtc2Vy dmVyLXNvdXJjZS97ZmIvZmJyb3AuaCxody92bmN9CiAJCXNlZCAtaSAtZSAncyx4b3IsY194b3Is JyAtZSAncyxhbmQsY19hbmQsJyBcCiAJCQl4b3JnLXgxMS1zZXJ2ZXItc291cmNlL2h3L3ZuYy97 Y2ZiLGZiLGZicm9wfS5oCiAJCWNkIHhvcmcteDExLXNlcnZlci1zb3VyY2UKIAkJZWF1dG9yZWNv bmYKIAlmaQorCisgICAgICAgIGNkICIke1N9IgorICAgICAgICBlcGF0Y2ggJHtGSUxFU0RJUn0v JHtQfS1mcmVlYnNkLnBhdGNoCiB9CiAKIHNyY19jb21waWxlKCkgewo=