<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "http://bugs.gentoo.org/bugzilla.dtd">

<bugzilla version="2.22.7"
          urlbase="http://bugs.gentoo.org/"
          maintainer="bugzilla@gentoo.org"
>

    <bug>
          <bug_id>177107</bug_id>
          
          <creation_ts>2007-05-05 00:27 0000</creation_ts>
          <short_desc>gnome-base/gnome-vfs-2.18.1 depends unconditionally on gtk-doc</short_desc>
          <delta_ts>2007-07-30 06:59:52 0000</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>Gentoo Linux</product>
          <component>GNOME</component>
          <version>unspecified</version>
          <rep_platform>All</rep_platform>
          <op_sys>Linux</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <keywords>NeedPatch</keywords>
          <priority>P2</priority>
          <bug_severity>normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          
          <everconfirmed>1</everconfirmed>
          <reporter>alessandro.guido+bugzilla@gmail.com</reporter>
          <assigned_to>gnome@gentoo.org</assigned_to>
          <cc>jakub@gentoo.org</cc>

      

      
          <long_desc isprivate="0">
            <who>alessandro.guido+bugzilla@gmail.com</who>
            <bug_when>2007-05-05 00:27:24 0000</bug_when>
            <thetext>as subject says, gnome-base/gnome-vfs-2.18.1 pulls in a dependency on gtk-doc, which is not useful at all to the normal user.
Instead, it should use:
$(use_enable doc gtk-doc)
and a conditional rdep on gtk-doc

Reproducible: Always</thetext>
          </long_desc>
          <long_desc isprivate="0">
            <who>jakub@gentoo.org</who>
            <bug_when>2007-06-10 13:19:16 0000</bug_when>
            <thetext>Alessandro, you have a patch for this? As it is now, automake plain fails w/o gtk-doc:

&lt;snip&gt;
gtk-doc.make:7: GTK_DOC_USE_LIBTOOL does not appear in AM_CONDITIONAL
doc/Makefile.am:91:   `gtk-doc.make&apos; included from here
gtk-doc.make:43: ENABLE_GTK_DOC does not appear in AM_CONDITIONAL
doc/Makefile.am:91:   `gtk-doc.make&apos; included from here
gtk-doc.make:136: ENABLE_GTK_DOC does not appear in AM_CONDITIONAL
doc/Makefile.am:91:   `gtk-doc.make&apos; included from here
&lt;/snip&gt;</thetext>
          </long_desc>
          <long_desc isprivate="0">
            <who>alessandro.guido+bugzilla@gmail.com</who>
            <bug_when>2007-06-27 17:42:44 0000</bug_when>
            <thetext>(In reply to comment #1)
&gt; Alessandro, you have a patch for this? As it is now, automake plain fails w/o
&gt; gtk-doc:
&gt; 
&gt; &lt;snip&gt;
&gt; gtk-doc.make:7: GTK_DOC_USE_LIBTOOL does not appear in AM_CONDITIONAL
&gt; doc/Makefile.am:91:   `gtk-doc.make&apos; included from here
&gt; gtk-doc.make:43: ENABLE_GTK_DOC does not appear in AM_CONDITIONAL
&gt; doc/Makefile.am:91:   `gtk-doc.make&apos; included from here
&gt; gtk-doc.make:136: ENABLE_GTK_DOC does not appear in AM_CONDITIONAL
&gt; doc/Makefile.am:91:   `gtk-doc.make&apos; included from here
&gt; &lt;/snip&gt;
&gt; 

I see the ebuild regenerates the configure script, I only tried launching ./configure --disable-gtk-doc and worked fine. I&apos;ll try to cook up a patch</thetext>
          </long_desc>
          <long_desc isprivate="0">
            <who>leio@gentoo.org</who>
            <bug_when>2007-07-30 03:47:14 0000</bug_when>
            <thetext>This already worked in 2.18.0.1. I&apos;m not sure why compnerd backed this out for 2.18.1. I&apos;m probably going to just add the workaround back, as there is no reason given in ChangeLog or anywhere for the change.</thetext>
          </long_desc>
          <long_desc isprivate="0">
            <who>leio@gentoo.org</who>
            <bug_when>2007-07-30 05:21:02 0000</bug_when>
            <thetext>Discussed it with compnerd. It was changed because the method that was used is very fragile to break. A better solution is to get the m4 file from elsewhere, for example by putting it on mirrors and pulling it into a m4 directory and including that in the eautoreconf run, or just including it in $FILESDIR and copying in place.
Ideally of course we wouldn&apos;t need to patch configure.in to even need the eautoreconf in the first place.
I am going with stabling 2.18.0.1 for now, that still uses the fragile method for working around the dependency.
We need to get a solution for this bug ASAP, as gnome-vfs-2.18.1 improves copying speed a lot (and therefore copying of files in nautilus) compared to 2.18.0.1.</thetext>
          </long_desc>
          <long_desc isprivate="0">
            <who>compnerd@gentoo.org</who>
            <bug_when>2007-07-30 06:51:38 0000</bug_when>
            <thetext>committed a kludge to get around the macro issue..it will suffice for now, as it it less fragile than what we were previously doing.</thetext>
          </long_desc>
          <long_desc isprivate="0">
            <who>leio@gentoo.org</who>
            <bug_when>2007-07-30 06:59:52 0000</bug_when>
            <thetext>Thanks. Going with 2.18.1 for stabling then.</thetext>
          </long_desc>
      
    </bug>

</bugzilla>