173795 2007-04-08 20:04 0000 xfce-base/thunar-0.8.0-r2: Command chosen in UCA browse isn't quoted 2007-05-02 12:34:28 0000 1 1 1 Unclassified Gentoo Linux Applications 2006.1 All Linux RESOLVED FIXED http://bugzilla.xfce.org/show_bug.cgi?id=3105 P2 trivial --- 1 askwar@digitalprojects.com xfce@gentoo.org askwar@digitalprojects.com 2007-04-08 20:04:56 0000 In Thunar, a user can select a so-called "UCA" (User Configurable Action). In doing so, he can BROWSE to select a command which is to be run. If the path to command (including the actual filename) contains spaces, the command is to be put in quotes. If it's not, when the UCA is selected, nothing will happen, as the programm cannot be found. Attached patch fixes this issue. When a user selects (after browsing) a filename which contains spaces, the quotes (") are put before and after the filename. There's also a bug at upstream reg. this - http://bugzilla.xfce.org/show_bug.cgi?id=3105 askwar@digitalprojects.com 2007-04-08 20:06:12 0000 Created an attachment (id=115747) Patch against thunar-uca-editor.c, adding quotes The attached patch makes it so, that the filename has quotes (") before and after it, if quotes are required. Right now, it only checks for the occurance of space. askwar@digitalprojects.com 2007-04-08 20:07:04 0000 Forgot to mention the purpose of this bug - I'd like to suggest to add this patch to a (possible) r3, as it makes Thunar easier and better to use. ssuominen@gentoo.org 2007-04-13 12:18:41 0000 Alexander, We'll wait until upstream responses in http://bugzilla.xfce.org/show_bug.cgi?id=3105 before doing this change. ssuominen@gentoo.org 2007-04-23 12:18:18 0000 Upstream is here saying 'This bug should be marked INVALID'. http://bugzilla.xfce.org/show_bug.cgi?id=3105#c7 If they change their mind, let us know.. ty. ssuominen@gentoo.org 2007-04-25 12:08:02 0000 http://bugzilla.xfce.org/show_bug.cgi?id=3105#c11 , status has changed to upstream patch in form of unapplied patch attached to upstream bug. waiting for resolution. ssuominen@gentoo.org 2007-05-02 12:34:28 0000 (In reply to comment #2) > Forgot to mention the purpose of this bug - I'd like to suggest to add this > patch to a (possible) r3, as it makes Thunar easier and better to use. > I applied Nick Schermer's patch from upstream bug in -r3. Thanks for your work and reporting. 115747 2007-04-08 20:06 0000 Patch against thunar-uca-editor.c, adding quotes thunar-uca-editor_add-quotes.patch text/plain ZGlmZiAtdXIgVGh1bmFyLTAuOC4wX29yaWdpbmFsL3BsdWdpbnMvdGh1bmFyLXVjYS90aHVuYXIt dWNhLWVkaXRvci5jIFRodW5hci0wLjguMC9wbHVnaW5zL3RodW5hci11Y2EvdGh1bmFyLXVjYS1l ZGl0b3IuYwotLS0gVGh1bmFyLTAuOC4wX29yaWdpbmFsL3BsdWdpbnMvdGh1bmFyLXVjYS90aHVu YXItdWNhLWVkaXRvci5jCTIwMDctMDEtMjAgMjE6Mzk6MDcuMDAwMDAwMDAwICswMTAwCisrKyBU aHVuYXItMC44LjAvcGx1Z2lucy90aHVuYXItdWNhL3RodW5hci11Y2EtZWRpdG9yLmMJMjAwNy0w NC0wOCAyMTo0OTo1Mi4wNzE3MjE3MzggKzAyMDAKQEAgLTQ4NCw2ICs0ODQsNyBAQAogICBHdGtX aWRnZXQgICAgICpjaG9vc2VyOwogICBnY2hhciAgICAgICAgICpmaWxlbmFtZTsKICAgZ2NoYXIg ICAgICAgICAqczsKKyAgZ2NoYXIJCSpzYWZlX2ZpbGVuYW1lOwogCiAgIGdfcmV0dXJuX2lmX2Zh aWwgKFRIVU5BUl9VQ0FfSVNfRURJVE9SICh1Y2FfZWRpdG9yKSk7CiAKQEAgLTU4Miw5ICs1ODMs MTggQEAKICAgaWYgKGd0a19kaWFsb2dfcnVuIChHVEtfRElBTE9HIChjaG9vc2VyKSkgPT0gR1RL X1JFU1BPTlNFX0FDQ0VQVCkKICAgICB7CiAgICAgICBmaWxlbmFtZSA9IGd0a19maWxlX2Nob29z ZXJfZ2V0X2ZpbGVuYW1lIChHVEtfRklMRV9DSE9PU0VSIChjaG9vc2VyKSk7Ci0gICAgICBzID0g Z19zdHJjb25jYXQgKGZpbGVuYW1lLCAiICVmIiwgTlVMTCk7CisgICAgICAvKiBCdWcgMzEwNTog QWRkIHF1b3RlcywgaWYgdGhlIHBhdGggdG8gZmlsZW5hbWUgY29udGFpbnMgc3BhY2VzICovCisg ICAgICBpZiAoc3Ryc3RyIChmaWxlbmFtZSwgIiAiKSA9PSBOVUxMKQorICAgICAgICAvKiBObyBz cGFjZXMgaW4gZmlsZW5hbWUsIGl0J3Mgc2FmZSB0byB1c2UgdGhlIGZpbGVuYW1lIGFzIGl0IGlz ICovCisgICAgICAgIHNhZmVfZmlsZW5hbWUgPSBnX3N0cmR1cChmaWxlbmFtZSk7CisgICAgICBl bHNlCisgICAgICAgIC8qIGZpbGVuYW1lIGNvbnRhaW5zIHNwYWNlcywgYWRkIHF1b3RlcyAqLwor ICAgICAgICBzYWZlX2ZpbGVuYW1lID0gZ19zdHJkdXBfcHJpbnRmICgiXCIlc1wiIiwgZmlsZW5h bWUpOworICAgICAgCisgICAgICBzID0gZ19zdHJjb25jYXQgKHNhZmVfZmlsZW5hbWUsICIgJWYi LCBOVUxMKTsKICAgICAgIGd0a19lbnRyeV9zZXRfdGV4dCAoR1RLX0VOVFJZICh1Y2FfZWRpdG9y LT5jb21tYW5kX2VudHJ5KSwgcyk7CiAgICAgICBnX2ZyZWUgKGZpbGVuYW1lKTsKKyAgICAgIGdf ZnJlZSAoc2FmZV9maWxlbmFtZSk7CiAgICAgICBnX2ZyZWUgKHMpOwogICAgIH0KIAo=