173672 2007-04-07 14:08 0000 app-backup/flexbackup-1.2.1-r3 remote host buffer test is broken 2007-04-15 20:52:40 0000 1 1 1 Unclassified Gentoo Linux Applications 2006.1 All Linux RESOLVED FIXED P2 normal --- 1 john_r_graham@mindspring.com maintainer-needed@gentoo.org app-backup@gentoo.org john_r_graham@mindspring.com 2007-04-07 14:08:26 0000 The "flexbackup-1.2.1-secure-tempfile.patch" introduced in flexbackup-1.2.1-r2 to increase the uniqueness of the temporary files inadvertently broke the remote buffer test used when flexbackup backs up remote hosts. Although the patch author properly manages temporary files on the remote host during the actual backup, during the remote buffer test (in the test_bufferprog() function) the temporary directory is not created on the remote machine. There's also a weakness in the code that parses the messages retrieved from the remote host: flexbackup is actually not detecting the failure and is reporting success even though the remote buffer tests aren't actually run. I've included a patch that adds the code to properly create the temporary directory on the remote host (and delete it when the test is done) and improves the parsing of the results so that failures like this aren't missed. The patch was generated against flexbackup-1.2.1-r3 and is additive to all the patches that that ebuild currently applies. - John john_r_graham@mindspring.com 2007-04-07 14:41:17 0000 Created an attachment (id=115669) Patch fixes remote buffer test. john_r_graham@mindspring.com 2007-04-15 20:52:40 0000 This fix is in Portage now as flexbackup-1.2.1-r4 thanks to the help of the Gentoo Sunrise team. 115669 2007-04-07 14:41 0000 Patch fixes remote buffer test. flexbackup-1.2.1-remote-bufftest.patch text/plain ZGlmZiAtdWJCZCBmbGV4YmFja3VwLW9sZC9mbGV4YmFja3VwIGZsZXhiYWNrdXAtbmV3L2ZsZXhi YWNrdXAKLS0tIGZsZXhiYWNrdXAtb2xkL2ZsZXhiYWNrdXAJMjAwNy0wNC0wNyAxMDoyNjoxNC4w MDAwMDAwMDAgLTA0MDAKKysrIGZsZXhiYWNrdXAtbmV3L2ZsZXhiYWNrdXAJMjAwNy0wNC0wNyAx MDozNDoyMS4wMDAwMDAwMDAgLTA0MDAKQEAgLTUyNzYsNiArNTI3NCw3IEBACiAgICAgbXkgJHRt cF9zY3JpcHQgPSAiJGNmZzo6dG1wZGlyL2J1ZnRlc3QuJGhvc3QuJFBST0NFU1NfSUQuc2giOwog ICAgIG15ICRyZXR2YWwgPSAwOwogICAgIG15ICRwaXBlY21kOworCW15ICRleHBsaWNpdF9zdWNj ZXNzOwogCiAgICAgJGJ1ZmZlcl9jbWQgPX4gczpeXHMqXHxccyo6OjsKICAgICAkYnVmZmVyX2Nt ZCA9fiBzOlxzKlx8XHMqJDo6OwpAQCAtNTI5MCw3ICs1Mjg5LDcgQEAKICAgICBwcmludCBTQ1Ig InJlcz1cJD9cbiI7CiAgICAgcHJpbnQgU0NSICJvdXQ9XGBjYXQgXCR0bXBfZXJyXGBcbiI7CiAg ICAgcHJpbnQgU0NSICJpZiBbIFwkcmVzIC1lcSAwIF07IHRoZW5cbiI7Ci0gICAgcHJpbnQgU0NS ICIgICBlY2hvIHN1Y2Nlc3NmdWxcbiI7CisgICAgcHJpbnQgU0NSICIgICAgZWNobyBcInN1Y2Nl c3NmdWxcIlxuIjsKICAgICBwcmludCBTQ1IgImVsc2VcbiI7CiAgICAgcHJpbnQgU0NSICIgICBl Y2hvIFwidW5zdWNjZXNzZnVsOiBleGl0IGNvZGUgXCRyZXM6IFwkb3V0XCIgXG4iOwogICAgIHBy aW50IFNDUiAiZmlcbiI7CkBAIC01MzAyLDEzICs1MzAxLDE5IEBACiAJJHBpcGVjbWQgPSAic2gg JHRtcF9zY3JpcHQgIjsKICAgICB9IGVsc2UgewogCXByaW50ICQ6Om1zZyAifCBDaGVja2luZyAn JGNmZzo6YnVmZmVyJyBvbiBob3N0ICRob3N0Li4uICI7Ci0JJHBpcGVjbWQgPSAgImNhdCAkdG1w X3NjcmlwdCB8ICgkOjpyZW1vdGVzaGVsbCAkaG9zdCAnY2F0ID4gJHRtcF9zY3JpcHQ7IHNoICR0 bXBfc2NyaXB0OyBybSAtZiAkdG1wX3NjcmlwdCcpIjsKKwkkcGlwZWNtZCA9ICAiJDo6cmVtb3Rl c2hlbGwgJGhvc3QgJyQ6OnBhdGh7bWtkaXJ9IC1wICRjZmc6OnRtcGRpcic7IGNhdCAkdG1wX3Nj cmlwdCB8ICgkOjpyZW1vdGVzaGVsbCAkaG9zdCAnY2F0ID4gJHRtcF9zY3JpcHQ7IHNoICR0bXBf c2NyaXB0OyBybSAtcmYgJGNmZzo6dG1wZGlyJykiOwogICAgIH0KIAogICAgIGlmICghZGVmaW5l ZCgkOjpkZWJ1ZykpIHsKIAogCW9wZW4oUElQRSwiJHBpcGVjbWQgfCIpIHx8IGRpZTsKKworCSRl eHBsaWNpdF9zdWNjZXNzID0gMDsKIAl3aGlsZSAoPFBJUEU+KSB7CisJCWlmICgvXnN1Y2Nlc3Nm dWwkLykgeworCQkJJGV4cGxpY2l0X3N1Y2Nlc3MgPSAxOworCQkJbGFzdDsKKwkJfQogCSAgICBp ZiAoL151bnN1Y2Nlc3NmdWw6IGV4aXQgY29kZSAoXGQrKTogKC4qKS8pIHsKIAkJJHJldHZhbCA9 ICQxOwogCQlteSAkb3V0ID0gJDI7CkBAIC01MzM3LDExICs1MzQyLDE1IEBACiAJcHJpbnQgJDo6 bXNnICJcbihkZWJ1ZykgJHBpcGVjbWRcbiI7CiAgICAgfQogCi0gICAgaWYgKCRyZXR2YWwgPT0g MCkgeworCWlmICgkZXhwbGljaXRfc3VjY2VzcykgewogCXByaW50ICQ6Om1zZyAiT2tcbiI7CiAg ICAgfSAgZWxzZSB7CisJCWlmICgkcmV0dmFsID09IDApIHsKKwkJICAgIHB1c2goQDo6ZXJyb3Jz LCAiVW5hbnRpY2lwYXRlZCBwcm9ibGVtcyBlbmNvdW50ZXJlZCB0ZXN0aW5nICckY2ZnOjpidWZm ZXInIG9uIGhvc3QgJyRob3N0Jy4iKTsKKwkJfSAgZWxzZSB7CiAJcHJpbnQgJDo6bXNnICJGYWls ZWQhXG4iOwogICAgIH0KKwl9CiAgICAgdW5saW5rKCIkdG1wX3NjcmlwdCIpOwogCiAgICAgcmV0 dXJuKCRyZXR2YWwpOwo=