172472 2007-03-27 21:27 0000 app-admin/eselect-1.0.9: load_config() wrongly returns values from the environment 2007-06-17 10:06:58 0000 1 1 1 Unclassified Gentoo Hosted Projects Eselect unspecified All Linux RESOLVED FIXED P2 major --- 179880 181166 1 ulm@gentoo.org eselect@gentoo.org george@gentoo.org ulm@gentoo.org 2007-03-27 21:27:05 0000 "eselect env update" behaves differently from "env-update". Path elements are accumulated in profile.env and are not deleted, even if they are removed from the files in env.d. The following session illustrates the problem: # echo INFOPATH=foo >/etc/env.d/99test # env-update; . /etc/profile >>> Regenerating /etc/ld.so.cache... # echo $INFOPATH /usr/share/info:[...]:foo [O.K.] # echo INFOPATH=bar >/etc/env.d/99test # env-update; . /etc/profile >>> Regenerating /etc/ld.so.cache... # echo $INFOPATH /usr/share/info:[...]:bar [O.K.] # rm /etc/env.d/99test # env-update; . /etc/profile >>> Regenerating /etc/ld.so.cache... # echo $INFOPATH /usr/share/info:[...] [O.K.] # echo INFOPATH=foo >/etc/env.d/99test # eselect env update; . /etc/profile Regenerating /etc/ld.so.cache... # echo $INFOPATH /usr/share/info:[...]:foo [O.K.] # echo INFOPATH=bar >/etc/env.d/99test # eselect env update; . /etc/profile Regenerating /etc/ld.so.cache... # echo $INFOPATH /usr/share/info:[...]:foo:bar [This should contain "bar" only.] # rm /etc/env.d/99test # eselect env update; . /etc/profile Regenerating /etc/ld.so.cache... # echo $INFOPATH /usr/share/info:[...]:foo:bar [Should contain neither "foo" nor "bar".] # env-update; . /etc/profile >>> Regenerating /etc/ld.so.cache... # echo $INFOPATH /usr/share/info:[...] [O.K.] ulm@gentoo.org 2007-03-29 08:14:41 0000 Still the same in 1.0.9. george@gentoo.org 2007-05-19 12:11:48 0000 I observe the same. I tried to use "do_action env update &> /dev/null" in gnat.eselect module, but that pulls in active enc settings (like active PATH, ADA_INCLUDE_PATH, etc) which essentially breaks functionality of gnat.eselect module. This can be worked around by using env-update directly inside the gnat.eselect, however this is flagged "incorrect" in the eselect documentation (in developer-guide.html), plus it only makes sense to use eselect's own modules where possible. I could provide a gnat specific extra test case, but the one above is way more simple and represents the issue well enough (short version: add "do_action env update &> /dev/null" to the end of do_set and do_update functions of gnat.eselect module and try switching from e.g. x86_64-pc-linux-gnu-gnat-gcc-4.2 to x86_64-pc-linux-gnu-gnat-gcc-4.1 (gnat-gcc-4.1.2 and gnat-gcc-4.2.0 would need to be installed) and then do ". /etc/profile" in some shell without running env-update first and then check PATH and ADA_INCLUDE_PATH vars. They should not contain old (but that were active at the moment of running eselect gnat set or env update) values (4.1 when activating 4.2 or vice verse). I also upped the severity one notch, as eselect is an important package and env is a central its module and this is indeed a major issue for any package trying to utilize this functionality. George ulm@gentoo.org 2007-06-06 23:57:55 0000 Looks like the problem is in lib/config.bash, function load_config(). The ${key} variable misses a local declaration; so if it is not set in the config file, then its value will happily be taken from the environment. Attached patch should fix the problem. ulm@gentoo.org 2007-06-07 00:00:21 0000 Created an attachment (id=121363) Patch for eselect-1.0.9 ulm@gentoo.org 2007-06-07 00:12:48 0000 Created an attachment (id=121365) Patch for eselect-1.0.9 Quotation marks are not neccessary here. ulm@gentoo.org 2007-06-08 06:56:52 0000 george: Can you confirm if the patch fixes the problem for you? george@gentoo.org 2007-06-14 12:09:54 0000 Sorry for the delay, got carried out by other stuff. Yes, this fixes it. Thanks! Now we only need this fix to be picked up :). George ulm@gentoo.org 2007-06-16 20:49:49 0000 Changed summary since the problem is not in env.eselect, but in config.bash. kugelfang@gentoo.org 2007-06-17 10:06:58 0000 Fixed as of 1.0.10 121363 2007-06-07 00:00 0000 Patch for eselect-1.0.9 eselect.patch text/plain LS0tIGxpYnMvY29uZmlnLmJhc2guaW5+CTIwMDctMDMtMjggMTY6MzU6MDkuMDAwMDAwMDAwICsw MjAwCisrKyBsaWJzL2NvbmZpZy5iYXNoLmluCTIwMDctMDYtMDcgMDE6NDk6NTcuMDAwMDAwMDAw ICswMjAwCkBAIC05Miw2ICs5Miw3IEBACiAKICAgICBjb25maWdmaWxlPSR7MX0KICAgICBrZXk9 JHsyfQorICAgIGxvY2FsICIke2tleX0iCiAgICAgW1sgISAtZSAke2NvbmZpZ2ZpbGV9IF1dIFwK ICAgICAgICAgJiYgcmV0dXJuIDEKICAgICB2YWx1ZT0kKAo= 121365 2007-06-07 00:12 0000 Patch for eselect-1.0.9 eselect.patch text/plain LS0tIGxpYnMvY29uZmlnLmJhc2guaW5+CTIwMDctMDMtMjggMTY6MzU6MDkuMDAwMDAwMDAwICsw MjAwCisrKyBsaWJzL2NvbmZpZy5iYXNoLmluCTIwMDctMDYtMDcgMDE6NDk6NTcuMDAwMDAwMDAw ICswMjAwCkBAIC05Miw2ICs5Miw3IEBACiAKICAgICBjb25maWdmaWxlPSR7MX0KICAgICBrZXk9 JHsyfQorICAgIGxvY2FsICR7a2V5fQogICAgIFtbICEgLWUgJHtjb25maWdmaWxlfSBdXSBcCiAg ICAgICAgICYmIHJldHVybiAxCiAgICAgdmFsdWU9JCgK