170080 2007-03-09 10:23 0000 asterisk init.d scipt without bash 2007-03-09 21:00:56 0000 1 1 1 Unclassified Gentoo Linux Ebuilds unspecified All Linux RESOLVED FIXED P2 enhancement --- 1 natanael.copa@gmail.com voip@gentoo.org natanael.copa@gmail.com 2007-03-09 10:23:25 0000 asterisk init.d script uses bash specific features. Its trivial to make it run with busybox ash for embedded: diff -ruN data.orig/etc/init.d/asterisk data/etc/init.d/asterisk --- data.orig/etc/init.d/asterisk 2006-12-20 10:13:39 +0000 +++ data/etc/init.d/asterisk 2006-12-21 13:30:39 +0000 @@ -174,7 +174,7 @@ fi if [[ -n "${ASTERISK_USER}" ]]; then - USER=${ASTERISK_USER/:*/} + USER=$(echo $ASTERISK_USER | sed 's/:.*//') GROUP=$(echo $ASTERISK_USER | awk -F: '/.*:.*/ { print $2 }') if [[ -n "${USER}" ]]; then ASTERISK_OPTS="${ASTERISK_OPTS} -U ${USER}" @@ -191,15 +191,17 @@ if [[ "$(echo ${ASTERISK_WRAPPER} | tr [:upper:] [:lower:])" != "yes" ]]; then start-stop-daemon --start --exec /usr/sbin/asterisk \ ${OPTS} -- ${ASTERISK_OPTS} + result=$? else asterisk_run_loop ${ASTERISK_OPTS} 2>/dev/null & + result=$? fi if [[ $result -eq 0 ]]; then # 2 seconds should be enough for asterisk to start - sleep 2 - - result=$(is_running) + sleep 2 + is_running + result=$? fi eend $result natanael.copa@gmail.com 2007-03-09 13:19:47 0000 Created an attachment (id=112700) 00-unbash.patch The patch also replaces all [[ with [ solar@gentoo.org 2007-03-09 15:29:22 0000 Just a note: solar@here ~ $ echo FooBar | tr [:upper:] [:lower:] FooBar solar@here ~ $ echo FooBar | tr '[:upper:]' '[:lower:]' foobar natanael.copa@gmail.com 2007-03-09 15:36:28 0000 (In reply to comment #2) > Just a note: > > solar@here ~ $ echo FooBar | tr [:upper:] [:lower:] > FooBar > solar@here ~ $ echo FooBar | tr '[:upper:]' '[:lower:]' > foobar > what shell is that? # busybox ash $ echo FooBar | tr [:upper:] [:lower:] foobar Should I submit a new patch? solar@gentoo.org 2007-03-09 16:23:04 0000 > what shell is that? default shell was bash But I get the same behavior in both busybox and bash where it needs single ticks. > Should I submit a new patch? naa. I'll see if stkn is ok with me commiting your update. I or he will fix it then. solar@gentoo.org 2007-03-09 21:00:56 0000 09 Mar 2007; <solar@gentoo.org> files/1.2.0/asterisk.rc6: - posix compliant init.d script from Natanael Copa. bug 170080 Thanks. 112700 2007-03-09 13:19 0000 00-unbash.patch 00-unbash.patch text/plain ZGlmZiAtcnVOIGRhdGEub3JpZy9ldGMvaW5pdC5kL2FzdGVyaXNrIGRhdGEvZXRjL2luaXQuZC9h c3RlcmlzawotLS0gZGF0YS5vcmlnL2V0Yy9pbml0LmQvYXN0ZXJpc2sJMjAwNi0xMi0yMCAxMDox MzozOSArMDAwMAorKysgZGF0YS9ldGMvaW5pdC5kL2FzdGVyaXNrCTIwMDctMDMtMDkgMTM6MTc6 MDUgKzAwMDAKQEAgLTExLDEyICsxMSwxMiBAQAogfQogCiBpc19ydW5uaW5nKCkgewotCWlmIFtb IC16ICIkKHBpZG9mIGFzdGVyaXNrKSIgXV07IHRoZW4KKwlpZiBbIC16ICIkKHBpZG9mIGFzdGVy aXNrKSIgXTsgdGhlbgogCQlyZXR1cm4gMQogCWVsc2UKIAkJUElEPSIkKGNhdCAvdmFyL3J1bi9h c3Rlcmlzay9hc3Rlcmlzay5waWQpIgogCQlmb3IgeCBpbiAkKHBpZG9mIGFzdGVyaXNrKTsgZG8K LQkJCWlmIFtbICIke3h9IiA9ICIke1BJRH0iIF1dOyB0aGVuCisJCQlpZiBbICIke3h9IiA9ICIk e1BJRH0iIF07IHRoZW4KIAkJCQlyZXR1cm4gMAogCQkJZmkJCiAJCWRvbmUKQEAgLTM4LDE2ICsz OCwxNiBAQAogCSMgbWFuZ2xlIHllcy9ubyBvcHRpb25zCiAJQVNURVJJU0tfQ09OU09MRT0iJChl Y2hvICR7QVNURVJJU0tfQ09OU09MRX0gfCB0ciBbOmxvd2VyOl0gWzp1cHBlcjpdKSIKIAotCWlm IFtbIC1uICIke0FTVEVSSVNLX0NPUkVfU0laRX0iIF1dICYmCi0JICAgW1sgIiR7QVNURVJJU0tf Q09SRV9TSVpFfSIgIT0gIjAiIF1dOyB0aGVuCisJaWYgWyAtbiAiJHtBU1RFUklTS19DT1JFX1NJ WkV9IiBdICYmCisJICAgWyAiJHtBU1RFUklTS19DT1JFX1NJWkV9IiAhPSAiMCIgXTsgdGhlbgog CQl1bGltaXQgLWMgJHtBU1RFUklTS19DT1JFX1NJWkV9CiAKLQkJaWYgW1sgLW4gIiR7QVNURVJJ U0tfQ09SRV9ESVJ9IiBdXSAmJiBcCi0JCSAgIFtbICEgLWQgIiR7QVNURVJJU0tfQ09SRV9ESVJ9 IiBdXQorCQlpZiBbIC1uICIke0FTVEVSSVNLX0NPUkVfRElSfSIgXSAmJiBcCisJCSAgIFsgISAt ZCAiJHtBU1RFUklTS19DT1JFX0RJUn0iIF0KIAkJdGhlbgogCQkJbWtkaXIgLW03NTAgLXAgIiR7 QVNURVJJU0tfQ09SRV9ESVJ9IgogCi0JCQlpZiBbWyAtbiAiJHtBU1RFUklTS19VU0VSfSIgXV07 IHRoZW4KKwkJCWlmIFsgLW4gIiR7QVNURVJJU0tfVVNFUn0iIF07IHRoZW4KIAkJCQljaG93biAt UiAiJHtBU1RFUklTS19VU0VSfSIgIiR7QVNURVJJU0tfQ09SRV9ESVJ9IgogCQkJZmkKIAkJZmkK QEAgLTU4LDE4ICs1OCwxOCBAQAogCQllY2hvICIgICBDb3JlIGR1bXAgbG9jYXRpb24gICAgICAg IDogJHtBU1RFUklTS19DT1JFX0RJUn0iCiAJZmkKIAotCWlmIFtbIC1uICIke0FTVEVSSVNLX01B WF9GRH0iIF1dOyB0aGVuCisJaWYgWyAtbiAiJHtBU1RFUklTS19NQVhfRkR9IiBdOyB0aGVuCiAJ CXVsaW1pdCAtbiAke0FTVEVSSVNLX01BWF9GRH0KIAkJZWNobyAiICAgTWF4IG9wZW4gZmlsZWRl c2NyaXB0b3JzICA6ICR7QVNURVJJU0tfTUFYX0ZEfSIKIAlmaQogCi0JaWYgW1sgLW4gIiR7QVNU RVJJU0tfTklDRX0iIF1dOyB0aGVuCisJaWYgWyAtbiAiJHtBU1RFUklTS19OSUNFfSIgXTsgdGhl bgogCQllY2hvICIgICBOaWNlIGxldmVsICAgICAgICAgICAgICAgIDogJHtBU1RFUklTS19OSUNF fSIKIAkJTklDRT0iL2Jpbi9uaWNlIC1uICR7QVNURVJJU0tfTklDRX0gLS0iCiAJZmkKIAotCWlm IFtbIC1uICIke0FTVEVSSVNLX05PVElGWV9FTUFJTH0iIF1dOyB0aGVuCi0JCWlmIFtbIC14IC91 c3Ivc2Jpbi9zZW5kbWFpbCBdXTsgdGhlbgorCWlmIFsgLW4gIiR7QVNURVJJU0tfTk9USUZZX0VN QUlMfSIgXTsgdGhlbgorCQlpZiBbIC14IC91c3Ivc2Jpbi9zZW5kbWFpbCBdOyB0aGVuCiAJCQll Y2hvICIgICBFbWFpbCBub3RpZmljYXRpb25zIGdvIHRvIDogJHtBU1RFUklTS19OT1RJRllfRU1B SUx9IgogCQllbHNlCiAJCQllY2hvICIgICBOb3RpZmljYXRpb25zIGRpc2FibGVkLCAvdXNyL3Ni aW4vc2VuZG1haWwgZG9lc24ndCBleGlzdCBvciBpcyBub3QgZXhlY3V0YWJsZSEiCkBAIC03Nywy MCArNzcsMjAgQEAKIAkJZmkKIAlmaQogCi0JaWYgW1sgLW4gIiR7QVNURVJJU0tfVFRZfSIgXV07 IHRoZW4KKwlpZiBbIC1uICIke0FTVEVSSVNLX1RUWX0iIF07IHRoZW4KIAkJZm9yIHggaW4gJHtB U1RFUklTS19UVFl9IFwKIAkJCSAvZGV2L3R0eSR7QVNURVJJU0tfVFRZfSBcCiAJCQkgL2Rldi92 Yy8ke0FTVEVSSVNLX1RUWX0KIAkJZG8KLQkJCWlmIFtbIC1jICIke3h9IiBdXTsgdGhlbgorCQkJ aWYgWyAtYyAiJHt4fSIgXTsgdGhlbgogCQkJCVRUWT0iJHt4fSIKIAkJCWZpCiAJCWRvbmUKLQkJ W1sgLW4gIiR7VFRZfSIgXV0gJiYgXAorCQlbIC1uICIke1RUWX0iIF0gJiYgXAogCQkJZWNobyAi ICAgTWVzc2FnZXMgYXJlIHNlbnQgdG8gICAgICA6ICR7VFRZfSIKIAlmaQogCi0JaWYgW1sgIiR7 QVNURVJJU0tfQ09OU09MRX0iID0gIllFUyIgXV0gJiYgW1sgLW4gIiR7VFRZfSIgXV07IHRoZW4K KwlpZiBbICIke0FTVEVSSVNLX0NPTlNPTEV9IiA9ICJZRVMiIF0gJiYgWyAtbiAiJHtUVFl9IiBd OyB0aGVuCiAJCWVjaG8gIiAgIFN0YXJ0aW5nIEFzdGVyaXNrIGNvbnNvbGUgOiAke0FTVEVSSVNL X0NPTlNPTEV9IgogCQlPUFRTPSIke09QVFN9IC1jIgogCWZpCkBAIC05OSw3ICs5OSw3IEBACiAK IAl3aGlsZSA6OyBkbwogCi0JCWlmIFtbIC1uICIke1RUWX0iIF1dOyB0aGVuCisJCWlmIFsgLW4g IiR7VFRZfSIgXTsgdGhlbgogCQkJL3Vzci9iaW4vc3R0eSAtRiAke1RUWX0gc2FuZQogCQkJJHtO SUNFfSAvdXNyL3NiaW4vYXN0ZXJpc2sgJHtPUFRTfSA+JHtUVFl9IDI+JjEgPCR7VFRZfQogCQkJ cmVzdWx0PSQ/CkBAIC0xMDgsMzAgKzEwOCwzMCBAQAogCQkJcmVzdWx0PSQ/CiAJCWZpCQkKIAot CQlpZiBbWyAkcmVzdWx0IC1lcSAwIF1dOyB0aGVuCisJCWlmIFsgJHJlc3VsdCAtZXEgMCBdOyB0 aGVuCiAJCQllY2hvICJBc3RlcmlzayB0ZXJtaW5hdGVkIG5vcm1hbGx5IgogCQkJYnJlYWsKIAkJ ZWxzZQotCQkJaWYgW1sgJHJlc3VsdCAtZ3QgMTI4IF1dOyB0aGVuCisJCQlpZiBbICRyZXN1bHQg LWd0IDEyOCBdOyB0aGVuCiAJCQkJc2lnbmFsPSQoKHJlc3VsdCAtICAxMjgpKQogCQkJCU1TRz0i QXN0ZXJpc2sgdGVybWluYXRlZCB3aXRoIFNpZ25hbDogJHNpZ25hbCIKIAogCQkJCUNPUkVfVEFS R0VUPSJjb3JlLSQoZGF0ZSAiKyVZJW0lZC0laCVNJXMiKSIKIAogCQkJCWxvY2FsIENPUkVfRFVN UEVEPTAKLQkJCQlpZiBbWyAtZiAiJHtBU1RFUklTS19DT1JFX0RJUn0vY29yZSIgXV07IHRoZW4K KwkJCQlpZiBbIC1mICIke0FTVEVSSVNLX0NPUkVfRElSfS9jb3JlIiBdOyB0aGVuCiAJCQkJCW12 ICIke0FTVEVSSVNLX0NPUkVfRElSfS9jb3JlIiBcCiAJCQkJCSAgICIke0FTVEVSSVNLX0NPUkVf RElSfS8ke0NPUkVfVEFSR0VUfSIKIAkJCQkJQ09SRV9EVU1QRUQ9MQogCi0JCQkJZWxpZiBbWyAt ZiAiJHtBU1RFUklTS19DT1JFX0RJUn0vY29yZS4ke1BJRH0iIF1dOyB0aGVuCisJCQkJZWxpZiBb IC1mICIke0FTVEVSSVNLX0NPUkVfRElSfS9jb3JlLiR7UElEfSIgXTsgdGhlbgogCQkJCQltdiAi JHtBU1RFUklTS19DT1JFX0RJUn0vY29yZS4ke1BJRH0iIFwKIAkJCQkJICAgIiR7QVNURVJJU0tf Q09SRV9ESVJ9LyR7Q09SRV9UQVJHRVR9IgogCQkJCQlDT1JFX0RVTVBFRD0xCiAKIAkJCQlmaQog Ci0JCQkJW1sgJENPUkVfRFVNUEVEIC1lcSAxIF1dICYmIFwKKwkJCQlbICRDT1JFX0RVTVBFRCAt ZXEgMSBdICYmIFwKIAkJCQkJTVNHPSIke01TR31cblxyQ29yZSBkdW1wZWQ6ICR7QVNURVJJU0tf Q09SRV9ESVJ9LyR7Q09SRV9UQVJHRVR9IgogCQkJZWxzZQogCQkJCU1TRz0iQXN0ZXJpc2sgdGVy bWluYXRlZCB3aXRoIHJldHVybiBjb2RlOiAkcmVzdWx0IgpAQCAtMTQzLDEzICsxNDMsMTMgQEAK IAkJCWRvbmUKIAkJZmkKIAotCQlbWyAtbiAiJHtUVFl9IiBdXSBcCisJCVsgLW4gIiR7VFRZfSIg XSBcCiAJCQkmJiBlY2hvICIke01TR30iID4ke1RUWX0gXAogCQkJfHwgZWNobyAiJHtNU0d9Igog CiAKLQkJaWYgW1sgLW4gIiR7QVNURVJJU0tfTk9USUZZX0VNQUlMfSIgXV0gJiYgXAotCQkgICBb WyAteCAvdXNyL3NiaW4vc2VuZG1haWwgXV07IHRoZW4KKwkJaWYgWyAtbiAiJHtBU1RFUklTS19O T1RJRllfRU1BSUx9IiBdICYmIFwKKwkJICAgWyAteCAvdXNyL3NiaW4vc2VuZG1haWwgXTsgdGhl bgogCQkJZWNobyAtZSAtbiAiU3ViamVjdDogQXN0ZXJpc2sgY3Jhc2hlZFxuXHIke01TR31cblxy IiB8XAogCQkJCSAvdXNyL3NiaW4vc2VuZG1haWwgIiR7QVNURVJJU0tfTk9USUZZX0VNQUlMfSIK IAkJZmkKQEAgLTE2Myw5ICsxNjMsOSBAQAogCWxvY2FsIE9QVFMgVVNFUiBHUk9VUCBQSUQKIAls b2NhbCB0bXAgeAogCi0JaWYgW1sgLW4gIiR7QVNURVJJU0tfTklDRX0iIF1dOyB0aGVuCi0JCWlm IFtbICR7QVNURVJJU0tfTklDRX0gLWdlIC0yMCBdXSAmJiBcCi0JCSAgIFtbICR7QVNURVJJU0tf TklDRX0gLWxlICAxOSBdXTsgdGhlbiAKKwlpZiBbIC1uICIke0FTVEVSSVNLX05JQ0V9IiBdOyB0 aGVuCisJCWlmIFsgJHtBU1RFUklTS19OSUNFfSAtZ2UgLTIwIF0gJiYgXAorCQkgICBbICR7QVNU RVJJU0tfTklDRX0gLWxlICAxOSBdOyB0aGVuIAogCQkJT1BUUz0iLS1uaWNlbGV2ZWwgJHtBU1RF UklTS19OSUNFfSIKIAkJZWxzZQogCQkJZWVycm9yICJOaWNlIHZhbHVlIG11c3QgYmUgYmV0d2Vl biAtMjAgYW5kIDE5IgpAQCAtMTczLDEzICsxNzMsMTMgQEAKIAkJZmkKIAlmaQogCi0JaWYgW1sg LW4gIiR7QVNURVJJU0tfVVNFUn0iIF1dOyB0aGVuCi0JCVVTRVI9JHtBU1RFUklTS19VU0VSLzoq L30KKwlpZiBbIC1uICIke0FTVEVSSVNLX1VTRVJ9IiBdOyB0aGVuCisJCVVTRVI9JChlY2hvICRB U1RFUklTS19VU0VSIHwgc2VkICdzLzouKi8vJykKIAkJR1JPVVA9JChlY2hvICRBU1RFUklTS19V U0VSIHwgYXdrIC1GOiAnLy4qOi4qLyB7IHByaW50ICQyIH0nKQotCQlpZiBbWyAtbiAiJHtVU0VS fSIgXV07IHRoZW4KKwkJaWYgWyAtbiAiJHtVU0VSfSIgXTsgdGhlbgogCQkJQVNURVJJU0tfT1BU Uz0iJHtBU1RFUklTS19PUFRTfSAtVSAke1VTRVJ9IgogCQlmaQotCQlpZiBbWyAtbiAiJHtHUk9V UH0iIF1dOyB0aGVuCisJCWlmIFsgLW4gIiR7R1JPVVB9IiBdOyB0aGVuCiAJCQlBU1RFUklTS19P UFRTPSIke0FTVEVSSVNLX09QVFN9IC1HICR7R1JPVVB9IgogCQkJR1JPVVA9Ijoke0dST1VQfSIJ IyBtYWtlIGl0IGxvb2sgbmljZS4uLgogCQlmaQpAQCAtMTg4LDE4ICsxODgsMjAgQEAKIAkJZWJl Z2luICJTdGFydGluZyBhc3RlcmlzayBQQlggKGFzIHJvb3QpIgogCWZpCiAKLQlpZiBbWyAiJChl Y2hvICR7QVNURVJJU0tfV1JBUFBFUn0gfCB0ciBbOnVwcGVyOl0gWzpsb3dlcjpdKSIgIT0gInll cyIgXV07IHRoZW4KKwlpZiBbICIkKGVjaG8gJHtBU1RFUklTS19XUkFQUEVSfSB8IHRyIFs6dXBw ZXI6XSBbOmxvd2VyOl0pIiAhPSAieWVzIiBdOyB0aGVuCiAJCXN0YXJ0LXN0b3AtZGFlbW9uIC0t c3RhcnQgLS1leGVjIC91c3Ivc2Jpbi9hc3RlcmlzayBcCiAJCQkke09QVFN9IC0tICR7QVNURVJJ U0tfT1BUU30KKwkJcmVzdWx0PSQ/CiAJZWxzZQogCQlhc3Rlcmlza19ydW5fbG9vcCAke0FTVEVS SVNLX09QVFN9IDI+L2Rldi9udWxsICYKKwkJcmVzdWx0PSQ/CiAJZmkKIAotCWlmIFtbICRyZXN1 bHQgLWVxIDAgXV07IHRoZW4KKwlpZiBbICRyZXN1bHQgLWVxIDAgXTsgdGhlbgogCQkjIDIgc2Vj b25kcyBzaG91bGQgYmUgZW5vdWdoIGZvciBhc3RlcmlzayB0byBzdGFydAotCQlzbGVlcCAyCi0K LQkJcmVzdWx0PSQoaXNfcnVubmluZykKKwkJc2xlZXAgMiAKKwkJaXNfcnVubmluZworCQlyZXN1 bHQ9JD8KIAlmaQogCiAJZWVuZCAkcmVzdWx0Cg==