168442 2007-02-26 10:26 0000 app-portage/portage-utils-0.1.24 does not properly parse the profile location 2007-06-21 14:02:04 0000 1 1 1 Unclassified Portage Development Tools 2.1 All Linux RESOLVED FIXED InCVS P2 normal --- 1 chutz@gg3.net portage-utils@gentoo.org chutz@gg3.net 2007-02-26 10:26:18 0000 While looking at bug #168334 I found this one. Not exactly a showstopper nor have I discovered any unexpected behavior but anyway portage-utils tries to follow the location pointed to by /etc/make.profile but when this is a relative location (as set by eselect for example) it doesn't always work out. For example running the debugging version of "q" from /root (or /usr or /etc) gives me: profile ../usr/portage/profiles/default-linux/amd64/2006.1/make.defaults profile ../usr/portage/profiles/default-linux/amd64/2006.1/../make.defaults profile ../usr/portage/profiles/default-linux/amd64/2006.1/../../make.defaults profile ../usr/portage/profiles/default-linux/amd64/2006.1/../../../base/make.defaults profile /etc/make.globals profile /etc/make.conf which is right, but when running from two levels or more deep (like $HOME for a non-root user for example) I get: profile ../usr/portage/profiles/default-linux/amd64/2006.1/make.defaults profile /etc/make.globals profile /etc/make.conf It's trivial to fix with a chdir("/etc") in main.c. solar@gentoo.org 2007-02-26 18:22:24 0000 Please attach a patch. chutz@gg3.net 2007-02-27 00:08:54 0000 Created an attachment (id=111367) portae-utils-chdir.patch Fair enough, here is the patch. I don't know if changing the directory is the proper way to do it, but the current working directory doesn't seem to affect anything else so why not. chutz@gg3.net 2007-02-27 00:12:34 0000 Created an attachment (id=111369) portage-utils-chdir.patch Oh, what the hell, the chdir should have been outside the loop (not that it makes any differnece). solar@gentoo.org 2007-02-27 00:30:12 0000 Thanks. This should be in the 0.1.25 solar@gentoo.org 2007-04-05 18:42:17 0000 This is released in 0.1.25 Bug #168334 ; q -r dies with a segfault after emerge --sync Bug #168442 ; does not properly parse the profile location Bug #170795 ; add a -E/--eclass option to qgrep Bug #170797 ; add a -s/--skip-comments option to qgrep Bug #171024 ; opening '/usr/portage/.metadata.x' failed Bug #171374 ; Misc enhancements for qgrep Bug #172240 ; -A/-B options for qgrep (context lines) Bug #172338 ; qgrepping through installed ebuilds (in the VDB) Bug #173005 ; Colorized output for qgrep. solar@gentoo.org 2007-04-05 18:43:01 0000 Closing solar@gentoo.org 2007-04-09 22:58:57 0000 This change breaks things. We will have to revert it and or come up with a new patch. solar@gentoo.org 2007-04-09 23:08:50 0000 This patch comes from vapier to address the breakage caused by your patch. --- main.c 8 Apr 2007 19:45:41 -0000 1.136 +++ main.c 9 Apr 2007 23:01:13 -0000 @@ -508,7 +508,10 @@ void initialize_portage_env(void) f = 0; if (readlink("/etc/make.profile", profile, sizeof(profile)) == -1) strcpy(profile, "/etc/make.profile"); - chdir("/etc"); + if (profile[0] != '/') { + memmove(profile+5, profile, strlen(profile)); + memcpy(profile, "/etc/", 5); + } do { if (f == 0) snprintf(portage_file, sizeof(portage_file), "%s/make.defaults", profile); solar@gentoo.org 2007-06-21 14:02:04 0000 Closing bug 111367 2007-02-27 00:08 0000 portae-utils-chdir.patch putils-chdir.patch text/plain ZGlmZiAtcnUgcG9ydGFnZS11dGlscy0wLjEuMjQub3JpZy9tYWluLmMgcG9ydGFnZS11dGlscy0w LjEuMjQvbWFpbi5jCi0tLSBwb3J0YWdlLXV0aWxzLTAuMS4yNC5vcmlnL21haW4uYwkyMDA3LTAy LTEyIDA3OjMzOjQ2LjAwMDAwMDAwMCArMDkwMAorKysgcG9ydGFnZS11dGlscy0wLjEuMjQvbWFp bi5jCTIwMDctMDItMjcgMDk6MDQ6NDkuMDAwMDAwMDAwICswOTAwCkBAIC01MDYsNiArNTA2LDcg QEAKIAlpZiAocmVhZGxpbmsoIi9ldGMvbWFrZS5wcm9maWxlIiwgcHJvZmlsZSwgc2l6ZW9mKHBy b2ZpbGUpKSA9PSAtMSkKIAkJc3RyY3B5KHByb2ZpbGUsICIvZXRjL21ha2UucHJvZmlsZSIpOwog CWRvIHsKKwkJY2hkaXIoIi9ldGMiKTsKIAkJaWYgKGYgPT0gMCkKIAkJCXNucHJpbnRmKHBvcnRh Z2VfZmlsZSwgc2l6ZW9mKHBvcnRhZ2VfZmlsZSksICIlcy9tYWtlLmRlZmF1bHRzIiwgcHJvZmls ZSk7CiAJCUlGX0RFQlVHKGZwcmludGYoc3RkZXJyLCAicHJvZmlsZSAlc1xuIiwgZmlsZXNbZl0p KTsKT25seSBpbiBwb3J0YWdlLXV0aWxzLTAuMS4yNDogcQpPbmx5IGluIHBvcnRhZ2UtdXRpbHMt MC4xLjI0OiBxYXRvbQpPbmx5IGluIHBvcnRhZ2UtdXRpbHMtMC4xLjI0OiBxY2FjaGUKT25seSBp biBwb3J0YWdlLXV0aWxzLTAuMS4yNDogcWNoZWNrCk9ubHkgaW4gcG9ydGFnZS11dGlscy0wLjEu MjQ6IHFkZXBlbmRzCk9ubHkgaW4gcG9ydGFnZS11dGlscy0wLjEuMjQ6IHFmaWxlCk9ubHkgaW4g cG9ydGFnZS11dGlscy0wLjEuMjQ6IHFnbHNhCk9ubHkgaW4gcG9ydGFnZS11dGlscy0wLjEuMjQ6 IHFncmVwCk9ubHkgaW4gcG9ydGFnZS11dGlscy0wLjEuMjQ6IHFsaXN0Ck9ubHkgaW4gcG9ydGFn ZS11dGlscy0wLjEuMjQ6IHFsb3AKT25seSBpbiBwb3J0YWdlLXV0aWxzLTAuMS4yNDogcW1lcmdl Ck9ubHkgaW4gcG9ydGFnZS11dGlscy0wLjEuMjQ6IHFwa2cKT25seSBpbiBwb3J0YWdlLXV0aWxz LTAuMS4yNDogcXB5Ck9ubHkgaW4gcG9ydGFnZS11dGlscy0wLjEuMjQ6IHFzZWFyY2gKT25seSBp biBwb3J0YWdlLXV0aWxzLTAuMS4yNDogcXNpemUKT25seSBpbiBwb3J0YWdlLXV0aWxzLTAuMS4y NDogcXRiejIKT25seSBpbiBwb3J0YWdlLXV0aWxzLTAuMS4yNDogcXVzZQpPbmx5IGluIHBvcnRh Z2UtdXRpbHMtMC4xLjI0OiBxeHBhawo= 111369 2007-02-27 00:12 0000 portage-utils-chdir.patch putils-chdir.patch text/plain ZGlmZiAtcnUgcG9ydGFnZS11dGlscy0wLjEuMjQub3JpZy9tYWluLmMgcG9ydGFnZS11dGlscy0w LjEuMjQvbWFpbi5jCi0tLSBwb3J0YWdlLXV0aWxzLTAuMS4yNC5vcmlnL21haW4uYwkyMDA3LTAy LTEyIDA3OjMzOjQ2LjAwMDAwMDAwMCArMDkwMAorKysgcG9ydGFnZS11dGlscy0wLjEuMjQvbWFp bi5jCTIwMDctMDItMjcgMDk6MTA6NDIuMDAwMDAwMDAwICswOTAwCkBAIC01MDUsNiArNTA1LDcg QEAKIAlmID0gMDsKIAlpZiAocmVhZGxpbmsoIi9ldGMvbWFrZS5wcm9maWxlIiwgcHJvZmlsZSwg c2l6ZW9mKHByb2ZpbGUpKSA9PSAtMSkKIAkJc3RyY3B5KHByb2ZpbGUsICIvZXRjL21ha2UucHJv ZmlsZSIpOworCWNoZGlyKCIvZXRjIik7CiAJZG8gewogCQlpZiAoZiA9PSAwKQogCQkJc25wcmlu dGYocG9ydGFnZV9maWxlLCBzaXplb2YocG9ydGFnZV9maWxlKSwgIiVzL21ha2UuZGVmYXVsdHMi LCBwcm9maWxlKTsK