166050 2007-02-09 10:48 0000 Fix for amarok's lyrc script brokeness (stray ") 2007-06-08 19:52:58 0000 1 1 1 Unclassified Gentoo Linux KDE unspecified All All RESOLVED FIXED P2 normal --- 1 jan@spitalnik.net flameeyes@gentoo.org kde@gentoo.org jan@spitalnik.net 2007-02-09 10:48:48 0000 Hi, In latest amarok-1.4.5, lyrc.rb is broken as it fails to fetchs over proxy due to a stray double-quote in the script on line 115. Fix attached. Cheers, spity Reproducible: Always Steps to Reproduce: 1.Run amarok behind proxy 2.Select Lyrics tab 3.Boom :-) Actual Results: sh: -c: line 0: unexpected EOF while looking for matching `"' sh: -c: line 1: syntax error: unexpected end of file /usr/lib/ruby/1.8/net/http.rb:560:in `initialize': No route to host - connect(2) (Errno::EHOSTUNREACH) from /usr/lib/ruby/1.8/net/http.rb:560:in `open' from /usr/lib/ruby/1.8/net/http.rb:560:in `connect' from /usr/lib/ruby/1.8/timeout.rb:48:in `timeout' from /usr/lib/ruby/1.8/timeout.rb:76:in `timeout' from /usr/lib/ruby/1.8/net/http.rb:560:in `connect' from /usr/lib/ruby/1.8/net/http.rb:553:in `do_start' from /usr/lib/ruby/1.8/net/http.rb:542:in `start' from /usr/lib/ruby/1.8/net/http.rb:1032:in `request' from /usr/lib/ruby/1.8/net/http.rb:769:in `get' from /usr/share/apps/amarok/scripts/lyrics_lyrc/lyrics_lyrc.rb:124:in `fetchLyrics' from /usr/share/apps/amarok/scripts/lyrics_lyrc/lyrics_lyrc.rb:190 from /usr/share/apps/amarok/scripts/lyrics_lyrc/lyrics_lyrc.rb:176:in `loop' from /usr/share/apps/amarok/scripts/lyrics_lyrc/lyrics_lyrc.rb:176 Expected Results: Lyrics? :-) jan@spitalnik.net 2007-02-09 10:49:25 0000 Created an attachment (id=109611) Lyrc script patch hydrogen@notyetimplemented.com 2007-03-16 23:16:57 0000 Thank you. I just committed your fix upstream and it will be in amarok-1.4.6. davidgrant@gmail.com 2007-03-18 22:18:51 0000 close as this is fixed in UPSTREAM. thanks jmbsvicetto hydrogen@notyetimplemented.com 2007-03-19 04:33:42 0000 It probably should still be applied to the amarok ebuild--1.4.6 is most likely a ways off (if it gets released at all) as all attention is currently on 2.0 flameeyes@gentoo.org 2007-06-07 18:31:53 0000 Will be in 1.4.5-r2. flameeyes@gentoo.org 2007-06-08 19:52:58 0000 This is in both 1.4.5-r2 and 1.4.6_pre. 109611 2007-02-09 10:49 0000 Lyrc script patch lyrics_lyrc.rb.patch text/plain LS0tIGx5cmljc19seXJjLnJiLm9yaWcJMjAwNy0wMi0wNyAxNDoxOTo0My4wMDAwMDAwMDAgKzAx MDAKKysrIGx5cmljc19seXJjLnJiCTIwMDctMDItMDkgMTE6NDM6MTIuMDAwMDAwMDAwICswMTAw CkBAIC0xMTIsNyArMTEyLDcgQEAgZGVmIGZldGNoTHlyaWNzKCBhcnRpc3QsIHRpdGxlLCB1cmwg KQogICAgIHByb3h5X2hvc3QgPSBuaWwKICAgICBwcm94eV9wb3J0ID0gbmlsCiAgICAgaWYgKCBA cHJveHkgPT0gbmlsICkKLSAgICAgICAgQHByb3h5ID0gYGRjb3AgYW1hcm9rIHNjcmlwdCBwcm94 eUZvclVybCAje0BwYWdlX3VybC5zaGVsbHF1b3RlfSJgCisgICAgICAgIEBwcm94eSA9IGBkY29w IGFtYXJvayBzY3JpcHQgcHJveHlGb3JVcmwgI3tAcGFnZV91cmwuc2hlbGxxdW90ZX1gCiAgICAg ZW5kCiAgICAgcHJveHlfdXJpID0gVVJJLnBhcnNlKCBAcHJveHkgKQogICAgIGlmICggcHJveHlf dXJpLmNsYXNzICE9IFVSSTo6R2VuZXJpYyApCg==