<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "http://bugs.gentoo.org/bugzilla.dtd">

<bugzilla version="2.22.7"
          urlbase="http://bugs.gentoo.org/"
          maintainer="bugzilla@gentoo.org"
>

    <bug>
          <bug_id>164986</bug_id>
          
          <creation_ts>2007-02-02 14:40 0000</creation_ts>
          <short_desc>app-portage/cfg-update-1.8.0-r5 checks for merge tool even when it won&apos;t be called</short_desc>
          <delta_ts>2007-02-03 07:44:26 0000</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>Gentoo Linux</product>
          <component>Applications</component>
          <version>2006.1</version>
          <rep_platform>AMD64</rep_platform>
          <op_sys>Linux</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          
          <priority>P2</priority>
          <bug_severity>trivial</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          
          <everconfirmed>1</everconfirmed>
          <reporter>dpblnt@gmail.com</reporter>
          <assigned_to>truedfx@gentoo.org</assigned_to>
          <cc>xentric@zeelandnet.nl</cc>

      

      
          <long_desc isprivate="0">
            <who>dpblnt@gmail.com</who>
            <bug_when>2007-02-02 14:40:25 0000</bug_when>
            <thetext>as root when i emerge, i don&apos;t always have X available, but i have meld in my cfg-update.conf, so i can sux cfg-update with it.
cfg-update when it should just check for config files, and not do update (so it does not need meld) complains before my emerge process:

* GUI not available, unable to run the mergetool set in /etc/cfg-update.conf!
  Run cfg-update from within an X-terminal if you want to use a GUI mergetool.
  If you are getting this from within an X-terminal, you should try running
  &quot;xhost +localhost&quot; as the user who started the X-server.
  If you use this script on a system without an X-server you should permanently
  set the MERGETOOL variable in /etc/cfg-update.conf to vimdiff or sdiff.
  I recommend the more advanced vimdiff on systems without an X-server.
  See http://people.zeelandnet.nl/xentric for vimdiff usage instructions.

this is not desired.


Reproducible: Always

Steps to Reproduce:



Expected Results:  
clean as it was.</thetext>
          </long_desc>
          <long_desc isprivate="0">
            <who>jakub@gentoo.org</who>
            <bug_when>2007-02-02 14:47:08 0000</bug_when>
            <thetext>What exactly are you complaining about here? If you don&apos;t want to use GUI, then don&apos;t stick a GUI diff tool into cfg-update.conf?! Anything unclear about the message? Sigh...</thetext>
          </long_desc>
          <long_desc isprivate="0">
            <who>truedfx@gentoo.org</who>
            <bug_when>2007-02-02 18:37:05 0000</bug_when>
            <thetext>Stephan, what are your thoughts on this? Should the check for the merge tool be skipped when not merging?</thetext>
          </long_desc>
          <long_desc isprivate="0">
            <who>xentric@zeelandnet.nl</who>
            <bug_when>2007-02-02 19:22:43 0000</bug_when>
            <thetext>Balint is right, I have just fixed it like this:

The GUI is only needed for updating without the -a option.
So I&apos;ve put the GUI-check in a separate subroutine that is only called from within the update_files subroutine, and only if the -a or -p flag is not found.

So &quot;cfg-update -l&quot; works because itwithout a GUI and no message is displayed.
&quot;cfg-update -au&quot; works because automatic-only-updating doesn&apos;t need the GUI.
&quot;cfg-update -pu&quot; works because pretend-update doesn&apos;t need the GUI.
But with &quot;cfg-update -u&quot; it will display the message and exit.

Will post cfg-update-1.8.0-r6 soon...

A temporary workaround is to use &quot;cfg-update -l -t diff&quot;, that sets the mergetool to CLI diff.

Thanks Balint for reporting this :)
</thetext>
          </long_desc>
          <long_desc isprivate="0">
            <who>xentric@zeelandnet.nl</who>
            <bug_when>2007-02-02 20:29:36 0000</bug_when>
            <thetext>Harald, I&apos;ve posted an update (1.8.0-r6)
See bug #165041

This bug can be closed.</thetext>
          </long_desc>
          <long_desc isprivate="0">
            <who>dpblnt@gmail.com</who>
            <bug_when>2007-02-03 06:29:46 0000</bug_when>
            <thetext>you&apos;re fast :)
thanks
</thetext>
          </long_desc>
          <long_desc isprivate="0">
            <who>truedfx@gentoo.org</who>
            <bug_when>2007-02-03 07:44:26 0000</bug_when>
            <thetext>And... added.</thetext>
          </long_desc>
      
    </bug>

</bugzilla>