161089 2007-01-09 10:21 0000 [PATCH for gnome-vfs] gnome_vfs_url_show_with_env does not work if entry in *.desktop is empty Path: 'Path='. 2007-01-22 20:56:54 0000 1 1 1 Unclassified Gentoo Linux GNOME unspecified All Linux RESOLVED FIXED http://bugzilla.gnome.org/show_bug.cgi?id=389273 P2 normal --- 1 pva@gentoo.org gnome@gentoo.org pva@gentoo.org 2007-01-09 10:21:20 0000 I was assured that there will be no gnome-vfs releases for 2.16 so I'd like to see this patch added into current gnome-vfs. The patch is applied upstream so I think it's good idea to follow. :) If gnome herd permits I could add this patch. Patch for gnome-vfs and ebuild follow. And this is mail from gnome-vfs maintainer Alexander Larsson where he suggests to add it into our tree: **************************begin of mail******************************** On Mon, 2007-01-08 at 20:17 +0300, Peter Volkov (pva) wrote: > On Пнд, 2007-01-08 at 15:31 +0100, Alexander Larsson wrote: > > On Mon, 2006-12-25 at 17:17 +0300, Peter Volkov (pva) wrote: > > > There is a bug in gnome-vfs when it does not work in the case when there > > > is the 'Path=' entry in .desktop file. > > > > I'm commiting something similar: > > > > + if (app->priv->path != NULL && *app->priv->path == 0) { > > + g_free (app->priv->path); > > + app->priv->path = NULL; > > + } > > Thank you. A short question: are you going to release gnome-vfs-2.16.4? > Or is it a good idea to apply this patch for gnome-vfs-2.16.3 in gentoo? There is no 2.16 release planned soon, so patching it sounds better. =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-= Alexander Larsson Red Hat, Inc ***************************end of mail********************************* pva@gentoo.org 2007-01-09 10:39:12 0000 Created an attachment (id=106177) gnome-vfs-2.16.3-empty-desktop-entry-Path.diff cp this patch into files dir. pva@gentoo.org 2007-01-09 10:40:25 0000 Created an attachment (id=106179) gnome-vfs-2.16.3-r1.ebuild.patch Patch for ebuild to apply patch. Thank you. pva@gentoo.org 2007-01-21 16:21:49 0000 Any progress here? I could commit this by myself, but I'd like to have permission from gnome team. This patch IS commited upstream. ;) dang@gentoo.org 2007-01-22 19:35:36 0000 Sorry, I was going to test and commit this, buy my dev box is broken and not booting. The patch looks simple enough, go ahead and commit it. pva@gentoo.org 2007-01-22 20:56:54 0000 Thank you for reviewing the patch. commited. :) Hope, you'll fix your box soon. 106177 2007-01-09 10:39 0000 gnome-vfs-2.16.3-empty-desktop-entry-Path.diff gnome-vfs-2.16.3-empty-desktop-entry-Path.diff text/plain ZGlmZiAtTmF1ciBnbm9tZS12ZnMtMi4xNi4zLm9yaS9saWJnbm9tZXZmcy9nbm9tZS12ZnMtbWlt ZS1oYW5kbGVycy5jIGdub21lLXZmcy0yLjE2LjMvbGliZ25vbWV2ZnMvZ25vbWUtdmZzLW1pbWUt aGFuZGxlcnMuYwotLS0gZ25vbWUtdmZzLTIuMTYuMy5vcmkvbGliZ25vbWV2ZnMvZ25vbWUtdmZz LW1pbWUtaGFuZGxlcnMuYwkyMDA2LTExLTIwIDEwOjQ0OjEzLjAwMDAwMDAwMCArMDMwMAorKysg Z25vbWUtdmZzLTIuMTYuMy9saWJnbm9tZXZmcy9nbm9tZS12ZnMtbWltZS1oYW5kbGVycy5jCTIw MDYtMTItMjUgMTY6NDQ6MTEuMDAwMDAwMDAwICswMzAwCkBAIC0xNDIzLDYgKzE0MjMsMTIgQEAK IAlhcHAtPnByaXYtPnBhdGggPSBnX2tleV9maWxlX2dldF9zdHJpbmcgKGtleV9maWxlLCBERVNL VE9QX0VOVFJZX0dST1VQLAogCQkJCQkJICJQYXRoIiwgTlVMTCk7CiAKKwkvKiAnUGF0aD0nIC5k ZXNrdG9wIGl0ZW0gaXMgbm90IHdvcmtpbmcuIGJ1Z3ppbGxhLmdub21lLm9yZy8zODkyNzMgKi8K KwlpZiAoYXBwLT5wcml2LT5wYXRoICE9IE5VTEwgJiYgKmFwcC0+cHJpdi0+cGF0aCA9PSAwKSB7 CisJCWdfZnJlZSAoYXBwLT5wcml2LT5wYXRoKTsKKwkJYXBwLT5wcml2LT5wYXRoID0gTlVMTDsK Kwl9CisKIAlhcHAtPnJlcXVpcmVzX3Rlcm1pbmFsID0gZ19rZXlfZmlsZV9nZXRfYm9vbGVhbgog CQkJKGtleV9maWxlLCBERVNLVE9QX0VOVFJZX0dST1VQLCAiVGVybWluYWwiLCAmZXJyKTsKIAlp ZiAoZXJyKSB7Cg== 106179 2007-01-09 10:40 0000 gnome-vfs-2.16.3-r1.ebuild.patch gnome-vfs-2.16.3-r1.ebuild.patch text/plain LS0tIC91c3IvcG9ydGFnZS9nbm9tZS1iYXNlL2dub21lLXZmcy9nbm9tZS12ZnMtMi4xNi4zLmVi dWlsZAkyMDA3LTAxLTA4IDAzOjM4OjA3LjAwMDAwMDAwMCArMDMwMAorKysgZ25vbWUtdmZzLTIu MTYuMy1yMS5lYnVpbGQJMjAwNy0wMS0wOSAxMzoyNDozNS4wMDAwMDAwMDAgKzAzMDAKQEAgLTg1 LDYgKzg1LDkgQEAKIAkjIEZpeCBmb3IgY3Jhc2hlcyBydW5uaW5nIHByb2dyYW1zIHZpYSBzdWRv CiAJZXBhdGNoICIke0ZJTEVTRElSfSIvJHtQTn0tMi4xNi4wLW5vLWRidXMtY3Jhc2gucGF0Y2gK IAorCSMgRml4IGdub21lX3Zmc191cmxfc2hvd193aXRoX2VudiB3aXRoICdQYXRoPScgaW4gLmRl c2t0b3AgKGJ1ZyAxNjEwODkpCisJZXBhdGNoICIke0ZJTEVTRElSfSIvJHtQfS1lbXB0eS1kZXNr dG9wLWVudHJ5LVBhdGguZGlmZgorCiAJIyBGb3IgZ3RrLWRvYyBtYWNybyBmYWlsdXJlIHdoZW4g aXQncyBub3QgaW5zdGFsbGVkCiAJY3AgYWNsb2NhbC5tNCBvbGRfbWFjcm9zLm00CiAJQVRfTTRE SVI9Ii4iCg==