157826 2006-12-11 07:03 0000 dev-java/swt patching 2007-03-05 14:12:47 0000 1 1 1 Unclassified Gentoo Linux Ebuilds unspecified All Linux RESOLVED FIXED https://overlays.gentoo.org/proj/java/browser/other/eclipse-patches/3.2.1/eclipse-sdk-3.2.1-swt-rm-ON_TOP.patch P2 normal --- 1 h.mth@web.de java@gentoo.org h.mth@web.de 2006-12-11 07:03:35 0000 Hi! The patch on URL should be applied for dev-java/swt, shouldn't it? Btw, isn't that xpcomgcc4 patch obsolete? Fedora, at least, does not apply it anymore. Just wondering. :) jakub@gentoo.org 2006-12-11 13:57:06 0000 Sigh, how about describing what you want to patch and why? h.mth@web.de 2006-12-11 14:22:53 0000 Sigh, why should one version of swt (the one from eclipse-sdk) be patched and the external from dev-java/swt not? ;) Well, looking at the bugreport [1] it is fixed in 3.2.1. So it can be dropped from eclipse-sdk-3.2.1(-r1). Still, I am wondering about eclipse-sdk-3.2.1-libswt-xpcomgcc4.patch, see bugreport [2]. [1] https://bugs.eclipse.org/bugs/show_bug.cgi?id=142861 [2] https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=200929 h.mth@web.de 2006-12-12 00:36:15 0000 I built dev-java/swt against firefox 2.0 and the SWT Browser does fine without that xpcomgcc4 patch. So, for x86 that patch is obsoleted by Fedoras firefox patch. I guess for other archs, too. caster@gentoo.org 2006-12-12 03:57:42 0000 We are currently building against seamonkey and there the patch is needed (see bug 156716, bug 156716, bug 157510 ...) h.mth@web.de 2006-12-12 07:10:40 0000 Right, firefox.patch is correct, xpcomgcc4.patch is obsolete. h.mth@web.de 2006-12-12 07:17:57 0000 I mean, if you have had a look at Fedoras bugreport you would have seen that the xpcomgcc4.patch is obsoleted by the firefox.patch. Fedora build swt without xpcomgcc4.patch for any arch. I bet they have no magic there. ;) h.mth@web.de 2006-12-23 03:02:55 0000 Created an attachment (id=104621) more cairo signedness warning fixes; arch-independent? betelgeuse@gentoo.org 2007-03-04 14:09:28 0000 (In reply to comment #7) > Created an attachment (id=104621) [edit] > more cairo signedness warning fixes; arch-independent? > Is this something you wrote or already upstream? I would like to see as much going upstream as possible. h.mth@web.de 2007-03-04 14:39:01 0000 I use swt-3.3M5 now. There are no signedness patches needed anymore afair. And that xpcomgcc4.patch code went upstream, too. betelgeuse@gentoo.org 2007-03-05 12:36:55 0000 (In reply to comment #9) > I use swt-3.3M5 now. There are no signedness patches needed anymore afair. > And that xpcomgcc4.patch code went upstream, too. > I guess it's best to wait for 3.3* and the warnings will go away there. Is your cairo patch needed for anything else than silencing warnings? But to me casting around problems looks nasty. h.mth@web.de 2007-03-05 12:57:16 0000 Nothing else did the other patches do. ;) betelgeuse@gentoo.org 2007-03-05 14:12:47 0000 (In reply to comment #11) > Nothing else did the other patches do. ;) > Heh. Your patch applied on ppc and amd64 so I added it to 3.2.2. I dropped the xpcom4 patch from all but amd64 because I guess it could be still needed there. If there is anything you want to change in 3.2.2 wrt patches please let me know. https://overlays.gentoo.org/svn/proj/java/other/swt-patches 104621 2006-12-23 03:02 0000 more cairo signedness warning fixes; arch-independent? swt-3.2-cairo-signedness.patch text/plain LS0tIGNhaXJvLmMJMjAwNi0wNy0xNiAxOToxNjoyNy4wMDAwMDAwMDAgLTA1MDAKKysrIGNhaXJv LmMJMjAwNi0wNy0xNiAxOToxODoxNS4wMDAwMDAwMDAgLTA1MDAKQEAgLTExMzYsNyArMTEzNiw3 IEBACiAJamJ5dGUgKmxwYXJnMT1OVUxMOwogCUNhaXJvX05BVElWRV9FTlRFUihlbnYsIHRoYXQs IGNhaXJvXzFzZWxlY3RfMWZvbnRfMWZhY2VfRlVOQyk7CiAJaWYgKGFyZzEpIGlmICgobHBhcmcx ID0gKCplbnYpLT5HZXRCeXRlQXJyYXlFbGVtZW50cyhlbnYsIGFyZzEsIE5VTEwpKSA9PSBOVUxM KSBnb3RvIGZhaWw7Ci0JY2Fpcm9fc2VsZWN0X2ZvbnRfZmFjZSgoY2Fpcm9fdCAqKWFyZzAsIGxw YXJnMSwgYXJnMiwgYXJnMyk7CisJY2Fpcm9fc2VsZWN0X2ZvbnRfZmFjZSgoY2Fpcm9fdCAqKWFy ZzAsIChjaGFyICopbHBhcmcxLCBhcmcyLCBhcmczKTsKIGZhaWw6CiAJaWYgKGFyZzEgJiYgbHBh cmcxKSAoKmVudiktPlJlbGVhc2VCeXRlQXJyYXlFbGVtZW50cyhlbnYsIGFyZzEsIGxwYXJnMSwg MCk7CiAJQ2Fpcm9fTkFUSVZFX0VYSVQoZW52LCB0aGF0LCBjYWlyb18xc2VsZWN0XzFmb250XzFm YWNlX0ZVTkMpOwpAQCAtMTM2Miw3ICsxMzYyLDcgQEAKIAlqYnl0ZSAqbHBhcmcxPU5VTEw7CiAJ Q2Fpcm9fTkFUSVZFX0VOVEVSKGVudiwgdGhhdCwgY2Fpcm9fMXNob3dfMXRleHRfRlVOQyk7CiAJ aWYgKGFyZzEpIGlmICgobHBhcmcxID0gKCplbnYpLT5HZXRCeXRlQXJyYXlFbGVtZW50cyhlbnYs IGFyZzEsIE5VTEwpKSA9PSBOVUxMKSBnb3RvIGZhaWw7Ci0JY2Fpcm9fc2hvd190ZXh0KChjYWly b190ICopYXJnMCwgbHBhcmcxKTsKKwljYWlyb19zaG93X3RleHQoKGNhaXJvX3QgKilhcmcwLCAo Y2hhciAqKWxwYXJnMSk7CiBmYWlsOgogCWlmIChhcmcxICYmIGxwYXJnMSkgKCplbnYpLT5SZWxl YXNlQnl0ZUFycmF5RWxlbWVudHMoZW52LCBhcmcxLCBscGFyZzEsIDApOwogCUNhaXJvX05BVElW RV9FWElUKGVudiwgdGhhdCwgY2Fpcm9fMXNob3dfMXRleHRfRlVOQyk7CkBAIC0xNTIxLDcgKzE1 MjEsNyBAQAogCUNhaXJvX05BVElWRV9FTlRFUihlbnYsIHRoYXQsIGNhaXJvXzF0ZXh0XzFleHRl bnRzX0ZVTkMpOwogCWlmIChhcmcxKSBpZiAoKGxwYXJnMSA9ICgqZW52KS0+R2V0Qnl0ZUFycmF5 RWxlbWVudHMoZW52LCBhcmcxLCBOVUxMKSkgPT0gTlVMTCkgZ290byBmYWlsOwogCWlmIChhcmcy KSBpZiAoKGxwYXJnMiA9IGdldGNhaXJvX3RleHRfZXh0ZW50c190RmllbGRzKGVudiwgYXJnMiwg Jl9hcmcyKSkgPT0gTlVMTCkgZ290byBmYWlsOwotCWNhaXJvX3RleHRfZXh0ZW50cygoY2Fpcm9f dCAqKWFyZzAsIGxwYXJnMSwgKGNhaXJvX3RleHRfZXh0ZW50c190ICopbHBhcmcyKTsKKwljYWly b190ZXh0X2V4dGVudHMoKGNhaXJvX3QgKilhcmcwLCAoY2hhciAqKWxwYXJnMSwgKGNhaXJvX3Rl eHRfZXh0ZW50c190ICopbHBhcmcyKTsKIGZhaWw6CiAJaWYgKGFyZzIgJiYgbHBhcmcyKSBzZXRj YWlyb190ZXh0X2V4dGVudHNfdEZpZWxkcyhlbnYsIGFyZzIsIGxwYXJnMik7CiAJaWYgKGFyZzEg JiYgbHBhcmcxKSAoKmVudiktPlJlbGVhc2VCeXRlQXJyYXlFbGVtZW50cyhlbnYsIGFyZzEsIGxw YXJnMSwgMCk7CkBAIC0xNTQ4LDcgKzE1NDgsNyBAQAogCWpieXRlICpscGFyZzE9TlVMTDsKIAlD YWlyb19OQVRJVkVfRU5URVIoZW52LCB0aGF0LCBjYWlyb18xdGV4dF8xcGF0aF9GVU5DKTsKIAlp ZiAoYXJnMSkgaWYgKChscGFyZzEgPSAoKmVudiktPkdldEJ5dGVBcnJheUVsZW1lbnRzKGVudiwg YXJnMSwgTlVMTCkpID09IE5VTEwpIGdvdG8gZmFpbDsKLQljYWlyb190ZXh0X3BhdGgoKGNhaXJv X3QgKilhcmcwLCBscGFyZzEpOworCWNhaXJvX3RleHRfcGF0aCgoY2Fpcm9fdCAqKWFyZzAsIChj aGFyICopbHBhcmcxKTsKIGZhaWw6CiAJaWYgKGFyZzEgJiYgbHBhcmcxKSAoKmVudiktPlJlbGVh c2VCeXRlQXJyYXlFbGVtZW50cyhlbnYsIGFyZzEsIGxwYXJnMSwgMCk7CiAJQ2Fpcm9fTkFUSVZF X0VYSVQoZW52LCB0aGF0LCBjYWlyb18xdGV4dF8xcGF0aF9GVU5DKTsK