<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "http://bugs.gentoo.org/bugzilla.dtd">

<bugzilla version="2.22.7"
          urlbase="http://bugs.gentoo.org/"
          maintainer="bugzilla@gentoo.org"
>

    <bug>
          <bug_id>156783</bug_id>
          
          <creation_ts>2006-12-01 03:48 0000</creation_ts>
          <short_desc>stabilize - net-dialup/slmodem-2.9.11_pre20051101-r2 failed with kernel-2.6.19</short_desc>
          <delta_ts>2006-12-20 11:54:14 0000</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>Gentoo Linux</product>
          <component>Ebuilds</component>
          <version>2006.1</version>
          <rep_platform>All</rep_platform>
          <op_sys>Linux</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          
          <priority>P3</priority>
          <bug_severity>normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          <blocked>156669</blocked>
          
          <everconfirmed>1</everconfirmed>
          <reporter>parmigio@2ainfo.it</reporter>
          <assigned_to>net-dialup@gentoo.org</assigned_to>
          <cc>dsd@gentoo.org</cc>

      

      
          <long_desc isprivate="0">
            <who>parmigio@2ainfo.it</who>
            <bug_when>2006-12-01 03:48:12 0000</bug_when>
            <thetext>CC [M]  /var/tmp/portage/net-dialup/slmodem-2.9.11_pre20051101-r2/work/ungrab-winmodem/ungrab-winmodem.o
/var/tmp/portage/net-dialup/slmodem-2.9.11_pre20051101-r2/work/ungrab-winmodem/ungrab-winmodem.c:14:26: error: linux/config.h: No such file or directory
/var/tmp/portage/net-dialup/slmodem-2.9.11_pre20051101-r2/work/ungrab-winmodem/ungrab-winmodem.c: In function &apos;softmodem_release_init&apos;:
/var/tmp/portage/net-dialup/slmodem-2.9.11_pre20051101-r2/work/ungrab-winmodem/ungrab-winmodem.c:60: warning: passing argument 1 of &apos;pci_match_device&apos; from incompatible pointer type
make[2]: *** [/var/tmp/portage/net-dialup/slmodem-2.9.11_pre20051101-r2/work/ungrab-winmodem/ungrab-winmodem.o] Error 1
make[1]: *** [_module_/var/tmp/portage/net-dialup/slmodem-2.9.11_pre20051101-r2/work/ungrab-winmodem] Error 2
make[1]: Leaving directory `/usr/src/linux-2.6.19-gentoo&apos;
make: *** [all] Error 2</thetext>
          </long_desc>
          <long_desc isprivate="0">
            <who>parmigio@2ainfo.it</who>
            <bug_when>2006-12-01 04:49:26 0000</bug_when>
            <thetext>Created an attachment (id=103119)
compile fix for kernel 2.6.19

fixes compile with kernel 2.6.19</thetext>
          </long_desc>
          <long_desc isprivate="0">
            <who>mrness@gentoo.org</who>
            <bug_when>2006-12-01 08:44:58 0000</bug_when>
            <thetext>Question is, does it work? If it does, what module do you use?</thetext>
          </long_desc>
          <long_desc isprivate="0">
            <who>parmigio@2ainfo.it</who>
            <bug_when>2006-12-01 18:14:17 0000</bug_when>
            <thetext>unfortunately i don&apos;t have the chance to test it :(
anyway other packages fixed that way (ati-drivers and fbsplash in the kernel) are working fine.</thetext>
          </long_desc>
          <long_desc isprivate="0">
            <who>mrness@gentoo.org</who>
            <bug_when>2006-12-02 00:26:18 0000</bug_when>
            <thetext>Fixed in slmodem-2.9.11_pre20061021.

I&apos;ve replaced config.h with autoconf.h - the source files depend on a few CONFIGs.
It should be compilable with any 2.[4-6].* kernel.</thetext>
          </long_desc>
          <long_desc isprivate="0">
            <who>mrness@gentoo.org</who>
            <bug_when>2006-12-06 08:04:51 0000</bug_when>
            <thetext>reopen the bug. 
At dsd&apos;s request, it will be closed when the version fixing this will be stabilized.</thetext>
          </long_desc>
          <long_desc isprivate="0">
            <who>genstef@gentoo.org</who>
            <bug_when>2006-12-07 11:58:02 0000</bug_when>
            <thetext>x86: please stabilize the new version</thetext>
          </long_desc>
          <long_desc isprivate="0">
            <who>maekke@gentoo.org</who>
            <bug_when>2006-12-07 12:42:02 0000</bug_when>
            <thetext>net-dialup/slmodem-2.9.11_pre20061021-r1  USE=&quot;alsa -usb&quot;
1. emerges on x86
2. passes collision test

Portage 2.1.1-r2 (default-linux/x86/2006.1/desktop, gcc-4.1.1, glibc-2.4-r4, 2.6.18.4 i686)
=================================================================
System uname: 2.6.18.4 i686 Genuine Intel(R) CPU           T2300  @ 1.66GHz
Gentoo Base System version 1.12.6
Last Sync: Thu, 07 Dec 2006 17:30:01 +0000
ccache version 2.3 [disabled]
app-admin/eselect-compiler: [Not Present]
dev-java/java-config: 1.3.7, 2.0.30
dev-lang/python:     2.3.5-r3, 2.4.3-r4
dev-python/pycrypto: 2.0.1-r5
dev-util/ccache:     2.3
dev-util/confcache:  [Not Present]
sys-apps/sandbox:    1.2.17
sys-devel/autoconf:  2.13, 2.60
sys-devel/automake:  1.4_p6, 1.5, 1.6.3, 1.7.9-r1, 1.8.5-r3, 1.9.6-r2
sys-devel/binutils:  2.16.1-r3
sys-devel/gcc-config: 1.3.13-r4
sys-devel/libtool:   1.5.22
virtual/os-headers:  2.6.17-r2
ACCEPT_KEYWORDS=&quot;x86&quot;
AUTOCLEAN=&quot;yes&quot;
CBUILD=&quot;i686-pc-linux-gnu&quot;
CFLAGS=&quot;-O2 -march=prescott -pipe -fomit-frame-pointer&quot;
CHOST=&quot;i686-pc-linux-gnu&quot;
CONFIG_PROTECT=&quot;/etc /usr/kde/3.5/env /usr/kde/3.5/share/config /usr/kde/3.5/shutdown /usr/share/X11/xkb /usr/share/config /var/qmail/alias /var/qmail/control&quot;
CONFIG_PROTECT_MASK=&quot;/etc/env.d /etc/env.d/java/ /etc/gconf /etc/java-config/vms/ /etc/revdep-rebuild /etc/terminfo /etc/texmf/web2c&quot;
CXXFLAGS=&quot;-O2 -march=prescott -pipe -fomit-frame-pointer&quot;
DISTDIR=&quot;/usr/portage/distfiles&quot;
EMERGE_DEFAULT_OPTS=&quot;--nospinner&quot;
FEATURES=&quot;autoconfig collision-protect distlocks metadata-transfer parallel-fetch sandbox sfperms strict test userfetch userpriv usersandbox&quot;
GENTOO_MIRRORS=&quot;http://mirror.switch.ch/mirror/gentoo/ http://gentoo.inode.at/&quot;
LINGUAS=&quot;en de en_GB de_CH&quot;
MAKEOPTS=&quot;-j3&quot;
PKGDIR=&quot;/usr/portage/packages&quot;
PORTAGE_RSYNC_OPTS=&quot;--recursive --links --safe-links --perms --times --compress --force --whole-file --delete --delete-after --stats --timeout=180 --exclude=&apos;/distfiles&apos; --exclude=&apos;/local&apos; --exclude=&apos;/packages&apos;&quot;
PORTAGE_TMPDIR=&quot;/var/tmp&quot;
PORTDIR=&quot;/usr/portage&quot;
SYNC=&quot;rsync://rsync.gentoo.org/gentoo-portage&quot;
USE=&quot;x86 X a52 aac acpi alsa apache2 asf berkdb bitmap-fonts cairo cdr cdrom cli cracklib crypt cups dbus divx dlloader dri dts dvd dvdr dvdread eds elibc_glibc emboss encode fam ffmpeg firefox flac fortran gdbm gif gnome gpm gstreamer gtk hal iconv input_devices_keyboard input_devices_mouse ipv6 isdnlog java jpeg kde kdeenablefinal kernel_linux ldap libg++ linguas_de linguas_de_CH linguas_en linguas_en_GB mad mikmod mmx mono mp3 mpeg ncurses nls nptl nptlonly ogg opengl oss pam pcre perl png ppds pppd python qt3 qt4 quicktime readline reflection rtsp ruby samba sdl session smp spell spl sse sse2 sse3 ssl svg tcpd test tetex theora threads truetype truetype-fonts type1-fonts udev unicode userland_GNU vcd video_cards_fbdev video_cards_i810 video_cards_vesa vorbis win32codecs wxwindows x264 xine xml xorg xprint xv xvid zlib&quot;
Unset:  CTARGET, INSTALL_MASK, LANG, LC_ALL, LDFLAGS, PORTAGE_RSYNC_EXTRA_OPTS, PORTDIR_OVERLAY</thetext>
          </long_desc>
          <long_desc isprivate="0">
            <who>fauli@gentoo.org</who>
            <bug_when>2006-12-08 03:42:57 0000</bug_when>
            <thetext>x86 done</thetext>
          </long_desc>
          <long_desc isprivate="0">
            <who>dsd@gentoo.org</who>
            <bug_when>2006-12-19 15:28:15 0000</bug_when>
            <thetext>Just a small note: the patch is partially redundant, you do not need to include autoconf.h on new kernels, it is included on the command line</thetext>
          </long_desc>
          <long_desc isprivate="0">
            <who>mrness@gentoo.org</who>
            <bug_when>2006-12-20 00:00:36 0000</bug_when>
            <thetext>(In reply to comment #9)
&gt; Just a small note: the patch is partially redundant, you do not need to include
&gt; autoconf.h on new kernels, it is included on the command line

Is this proposition true for all kernel versions &gt;=2.4 ?
If not, I find replacing config.h with autoconf.h THE solution for this kind of problem.</thetext>
          </long_desc>
          <long_desc isprivate="0">
            <who>dsd@gentoo.org</who>
            <bug_when>2006-12-20 05:22:41 0000</bug_when>
            <thetext>Not all, but every kernel post-2.6.14 or so. This is what I am recommending for these situations:

#include &lt;linux/version.h&gt;
#if LINUX_VERSION_CODE &lt;= KERNEL_VERSION(2,6,18)
#include &lt;linux/config.h&gt;
#endif

This will work on all current kernel versions and is also future-proof (there is discussion of changing the autoconf stuff again, this should not matter because nobody should be explicitly relying on that file now, instead they are relying on the config being available automatically).</thetext>
          </long_desc>
          <long_desc isprivate="0">
            <who>mrness@gentoo.org</who>
            <bug_when>2006-12-20 11:54:14 0000</bug_when>
            <thetext>Point taken.
I&apos;ve updated net-dialup/{slmodem,ltmodem,misdn,bewan-adsl} patches to your solution.</thetext>
          </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>103119</attachid>
            <date>2006-12-01 04:49 0000</date>
            <desc>compile fix for kernel 2.6.19</desc>
            <filename>slmodem-2.9.11-kernel-2.6.19.patch</filename>
            <type>text/plain</type>
            <data encoding="base64">ZGlmZiAtTmF1ciB1bmdyYWItd2lubW9kZW0vdW5ncmFiLXdpbm1vZGVtLmMgdW5ncmFiLXdpbm1v
ZGVtL3VuZ3JhYi13aW5tb2RlbS5jCi0tLSB1bmdyYWItd2lubW9kZW0vdW5ncmFiLXdpbm1vZGVt
LmMJMjAwNS0wOS0wNiAxNToyOToxMS4wMDAwMDAwMDAgKzAyMDAKKysrIHVuZ3JhYi13aW5tb2Rl
bS91bmdyYWItd2lubW9kZW0uYwkyMDA2LTEyLTAxIDEzOjM2OjU5LjAwMDAwMDAwMCArMDEwMApA
QCAtMTEsNyArMTEsNiBAQAogICoKICAqLwogCi0jaW5jbHVkZSA8bGludXgvY29uZmlnLmg+CiAj
aW5jbHVkZSA8bGludXgvbW9kdWxlLmg+CiAjaW5jbHVkZSA8bGludXgvdmVyc2lvbi5oPgogI2lu
Y2x1ZGUgPGxpbnV4L2luaXQuaD4KZGlmZiAtTmF1ciBzbG1vZGVtLTIuOS4xMS0yMDA1MTEwMS5v
cmlnL2RyaXZlcnMvYW1ybW9faW5pdC5jIHNsbW9kZW0tMi45LjExLTIwMDUxMTAxL2RyaXZlcnMv
YW1ybW9faW5pdC5jCi0tLSBzbG1vZGVtLTIuOS4xMS0yMDA1MTEwMS5vcmlnL2RyaXZlcnMvYW1y
bW9faW5pdC5jCTIwMDYtMTItMDEgMTM6NDU6MDcuMDAwMDAwMDAwICswMTAwCisrKyBzbG1vZGVt
LTIuOS4xMS0yMDA1MTEwMS9kcml2ZXJzL2Ftcm1vX2luaXQuYwkyMDA2LTEyLTAxIDEzOjQ2OjM3
LjAwMDAwMDAwMCArMDEwMApAQCAtNDMsNyArNDMsNiBAQAogCiAvKioqKioqKioqKioqKioqKioq
KioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioq
KiovCiAKLSNpbmNsdWRlIDxsaW51eC9jb25maWcuaD4KICNpbmNsdWRlIDxsaW51eC9tb2R1bGUu
aD4KICNpbmNsdWRlIDxsaW51eC92ZXJzaW9uLmg+CiAjaW5jbHVkZSA8bGludXgvaW5pdC5oPgo=
</data>        

          </attachment>
    </bug>

</bugzilla>