153487 2006-10-30 15:43 0000 app-crypt/rainbowcrack default charset.txt file path in code 2006-11-01 11:26:30 0000 1 1 1 Unclassified Gentoo Linux Unspecified 2006.1 All Linux RESOLVED FIXED P2 enhancement --- 1 rogerw@gmail.com dragonheart@gentoo.org crypto@gentoo.org rogerw@gmail.com 2006-10-30 15:43:34 0000 rainbowcrack, a password hash algorithm, has no default charset.txt path in its code. In Gentoo, the charset.txt file gets installed to /usr/share/rainbowcrack/charset.txt, but this file is never (automatically) chosen - it fails if one is not found in the local path (i.e. where the code is executed from). While this is normal for most uses of the program, it is somewhat expected that programs will try and use a set of "Defaults" especially when first running a program and before customizations begin. Some uses might not even require this patch - but it would help usability, in general. I'm sure there is a standard way to patch this, but here's the patch I came up with that makes it work (tm) :). Please respond with patch format questions, mainly because I'd like to fix the patch even if its not accepted into Gentoo, to know how to do it in the future. -Roger Ward -- rainbowcrack-1.2-src-charsetpath.patch -- diff -rU9 rainbowcrack-1.2-src/src/ChainWalkContext.cpp rainbowcrack-1.2-src.orig/src/ChainWalkContext.cpp --- rainbowcrack-1.2-src/src/ChainWalkContext.cpp 2006-10-30 18:39:55.000000000 -0500 +++ rainbowcrack-1.2-src.orig/src/ChainWalkContext.cpp 2003-11-23 00:33:44.000000000 -0500 @@ -52,25 +52,19 @@ for (i = 0x00; i <= 0xff; i++) m_PlainCharset[i] = i; m_nPlainCharsetLen = 256; m_sPlainCharsetName = sName; m_sPlainCharsetContent = "0x00, 0x01, ... 0xff"; return true; } vector<string> vLine; - if (!ReadLinesFromFile("charset.txt", vLine)) - { - ReadLinesFromFile("/usr/share/rainbowcrack/charset.txt", vLine); - if (vLine.size()>0) - printf("Read charset.txt from default /usr/share/rainbowcrack/\n"); - } - if (vLine.size()>0) + if (ReadLinesFromFile("charset.txt", vLine)) { int i; for (i = 0; i < vLine.size(); i++) { // Filter comment if (vLine[i][0] == '#') continue; vector<string> vPart; rogerw@gmail.com 2006-10-30 15:46:55 0000 Created an attachment (id=100834) Patch to hardcode the default path of charset.txt as an *alternative* into rtgen and rtdump alonbl@gentoo.org 2006-11-01 11:26:30 0000 Thanks! Added rainbowcrack-1.2-r1. Fixed somewhat differently, please check it out. 100834 2006-10-30 15:46 0000 Patch to hardcode the default path of charset.txt as an *alternative* into rtgen and rtdump rainbowcrack-1.2-src-charsetpatch.patch text/plain ZGlmZiAtclU5IHJhaW5ib3djcmFjay0xLjItc3JjL3NyYy9DaGFpbldhbGtDb250ZXh0LmNwcCBy YWluYm93Y3JhY2stMS4yLXNyYy5vcmlnL3NyYy9DaGFpbldhbGtDb250ZXh0LmNwcAotLS0gcmFp bmJvd2NyYWNrLTEuMi1zcmMvc3JjL0NoYWluV2Fsa0NvbnRleHQuY3BwCTIwMDYtMTAtMzAgMTg6 Mzk6NTUuMDAwMDAwMDAwIC0wNTAwCisrKyByYWluYm93Y3JhY2stMS4yLXNyYy5vcmlnL3NyYy9D aGFpbldhbGtDb250ZXh0LmNwcAkyMDAzLTExLTIzIDAwOjMzOjQ0LjAwMDAwMDAwMCAtMDUwMApA QCAtNTIsMjUgKzUyLDE5IEBACiAJCWZvciAoaSA9IDB4MDA7IGkgPD0gMHhmZjsgaSsrKQ0KIAkJ CW1fUGxhaW5DaGFyc2V0W2ldID0gaTsNCiAJCW1fblBsYWluQ2hhcnNldExlbiA9IDI1NjsNCiAJ CW1fc1BsYWluQ2hhcnNldE5hbWUgPSBzTmFtZTsNCiAJCW1fc1BsYWluQ2hhcnNldENvbnRlbnQg PSAiMHgwMCwgMHgwMSwgLi4uIDB4ZmYiOw0KIAkJcmV0dXJuIHRydWU7DQogCX0NCiANCiAJdmVj dG9yPHN0cmluZz4gdkxpbmU7DQotCWlmICghUmVhZExpbmVzRnJvbUZpbGUoImNoYXJzZXQudHh0 IiwgdkxpbmUpKQ0KLQl7DQotCQlSZWFkTGluZXNGcm9tRmlsZSgiL3Vzci9zaGFyZS9yYWluYm93 Y3JhY2svY2hhcnNldC50eHQiLCB2TGluZSk7DQotCQlpZiAgKHZMaW5lLnNpemUoKT4wKQ0KLQkJ CXByaW50ZigiUmVhZCBjaGFyc2V0LnR4dCBmcm9tIGRlZmF1bHQgL3Vzci9zaGFyZS9yYWluYm93 Y3JhY2svXG4iKTsNCi0JfQ0KLQlpZiAodkxpbmUuc2l6ZSgpPjApDQorCWlmIChSZWFkTGluZXNG cm9tRmlsZSgiY2hhcnNldC50eHQiLCB2TGluZSkpDQogCXsNCiAJCWludCBpOw0KIAkJZm9yIChp ID0gMDsgaSA8IHZMaW5lLnNpemUoKTsgaSsrKQ0KIAkJew0KIAkJCS8vIEZpbHRlciBjb21tZW50 DQogCQkJaWYgKHZMaW5lW2ldWzBdID09ICcjJykNCiAJCQkJY29udGludWU7DQogDQogCQkJdmVj dG9yPHN0cmluZz4gdlBhcnQ7DQo=