150169 2006-10-05 07:39 0000 app-editors/nvi has trouble loading unicode files 2006-10-06 06:59:10 0000 1 1 1 Unclassified Gentoo Linux Applications unspecified All Linux RESOLVED FIXED P2 normal --- 1 t4y68ds02@sneakemail.com truedfx@gentoo.org t4y68ds02@sneakemail.com 2006-10-05 07:39:34 0000 nvi does not use the correct call to read wide characters from a file. I have patched it and submitted the patch upstream and told the author that I would also submit the patch to the gentoo developers. t4y68ds02@sneakemail.com 2006-10-05 07:41:02 0000 Created an attachment (id=98842) patch to fix unicode read in nvi I have tried this patch against both the stable version and the soon to be released eselect version of nvi. It works for me. truedfx@gentoo.org 2006-10-06 04:50:36 0000 While that patch seems sane to me, could you give a quick example of when it is necessary? (I can use nvi to edit my UTF-8 encoded files, without problems yet.) t4y68ds02@sneakemail.com 2006-10-06 05:02:55 0000 Create a file containing utf-8 characters. Save it. Bring up nvi and then load that file in via :r file. The utf-8 will be garbled. truedfx@gentoo.org 2006-10-06 05:28:31 0000 Thanks, fixed in 1.81.5-r5. I know that's in package.mask, but eselect-vi is supposed to be unmasked soon. If it's not, I'll add another non-eselect revision as well. t4y68ds02@sneakemail.com 2006-10-06 06:59:10 0000 Perfect. Thanks. 98842 2006-10-05 07:41 0000 patch to fix unicode read in nvi nvi-1.81.5-wide.patch text/plain KioqIGV4L2V4X3V0aWwuYy5vcmlnCTIwMDEtMDYtMjUgMDg6MTk6MjEuMDAwMDAwMDAwIC0wNzAw Ci0tLSBleC9leF91dGlsLmMJMjAwNi0wNS0yNCAwNzo0NjowNy4wMDAwMDAwMDAgLTA3MDAKKioq KioqKioqKioqKioqCioqKiA2Nyw3MyAqKioqCiAgCQkJQklOQ19SRVRXKHNwLCBleHAtPmlicCwg ZXhwLT5pYnBfbGVuLCBvZmYgKyAxKTsKICAJCQlwID0gZXhwLT5pYnAgKyBvZmY7CiAgCQl9CiEg CQlpZiAoKGNoID0gZ2V0YyhmcCkpID09IEVPRiAmJiAhZmVvZihmcCkpIHsKICAJCQlpZiAoZXJy bm8gPT0gRUlOVFIpIHsKICAJCQkJZXJybm8gPSAwOwogIAkJCQljbGVhcmVycihmcCk7Ci0tLSA2 Nyw3MyAtLS0tCiAgCQkJQklOQ19SRVRXKHNwLCBleHAtPmlicCwgZXhwLT5pYnBfbGVuLCBvZmYg KyAxKTsKICAJCQlwID0gZXhwLT5pYnAgKyBvZmY7CiAgCQl9CiEgCQlpZiAoKGNoID0gR0VUQyhm cCkpID09IFZJX0VPRiAmJiAhZmVvZihmcCkpIHsKICAJCQlpZiAoZXJybm8gPT0gRUlOVFIpIHsK ICAJCQkJZXJybm8gPSAwOwogIAkJCQljbGVhcmVycihmcCk7CioqKioqKioqKioqKioqKgoqKiog NzUsODIgKioqKgogIAkJCX0KICAJCQlyZXR1cm4gKDEpOwogIAkJfQohIAkJaWYgKGNoID09IEVP RiB8fCBjaCA9PSAnXG4nKSB7CiEgCQkJaWYgKGNoID09IEVPRiAmJiAhb2ZmKQogIAkJCQlyZXR1 cm4gKDEpOwogIAkJCSpsZW5wID0gb2ZmOwogIAkJCXJldHVybiAoMCk7Ci0tLSA3NSw4MiAtLS0t CiAgCQkJfQogIAkJCXJldHVybiAoMSk7CiAgCQl9CiEgCQlpZiAoY2ggPT0gVklfRU9GIHx8IGNo ID09ICdcbicpIHsKISAJCQlpZiAoY2ggPT0gVklfRU9GICYmICFvZmYpCiAgCQkJCXJldHVybiAo MSk7CiAgCQkJKmxlbnAgPSBvZmY7CiAgCQkJcmV0dXJuICgwKTsKKioqIHZpL3ZfdWxjYXNlLmMu b3JpZwkyMDAxLTA2LTI1IDA4OjE5OjM2LjAwMDAwMDAwMCAtMDcwMAotLS0gdmkvdl91bGNhc2Uu YwkyMDA2LTA1LTI0IDA3OjQ0OjU3LjAwMDAwMDAwMCAtMDcwMAoqKioqKioqKioqKioqKioKKioq IDE1NCwxNjQgKioqKgogIAljaGFuZ2UgPSBydmFsID0gMDsKICAJZm9yIChwID0gYnAgKyBzY25v LCB0ID0gYnAgKyBlY25vICsgMTsgcCA8IHQ7ICsrcCkgewogIAkJY2ggPSAqKHVfY2hhciAqKXA7 CiEgCQlpZiAoaXNsb3dlcihjaCkpIHsKISAJCQkqcCA9IHRvdXBwZXIoY2gpOwogIAkJCWNoYW5n ZSA9IDE7CiEgCQl9IGVsc2UgaWYgKGlzdXBwZXIoY2gpKSB7CiEgCQkJKnAgPSB0b2xvd2VyKGNo KTsKICAJCQljaGFuZ2UgPSAxOwogIAkJfQogIAl9Ci0tLSAxNTQsMTY0IC0tLS0KICAJY2hhbmdl ID0gcnZhbCA9IDA7CiAgCWZvciAocCA9IGJwICsgc2NubywgdCA9IGJwICsgZWNubyArIDE7IHAg PCB0OyArK3ApIHsKICAJCWNoID0gKih1X2NoYXIgKilwOwohIAkJaWYgKElTTE9XRVIoKnApKSB7 CiEgCQkJKnAgPSBUT1VQUEVSKCpwKTsKICAJCQljaGFuZ2UgPSAxOwohIAkJfSBlbHNlIGlmIChJ U1VQUEVSKCpwKSkgewohIAkJCSpwID0gVE9MT1dFUigqcCk7CiAgCQkJY2hhbmdlID0gMTsKICAJ CX0KICAJfQoqKiogY29tbW9uL211bHRpYnl0ZS5oLm9yaWcJMjAwMS0wNi0yOCAwOTowMjoyOS4w MDAwMDAwMDAgLTA3MDAKLS0tIGNvbW1vbi9tdWx0aWJ5dGUuaAkyMDA2LTA1LTI0IDA3OjQ0OjQz LjAwMDAwMDAwMCAtMDcwMAoqKioqKioqKioqKioqKioKKioqIDE5LDI1ICoqKioKLS0tIDE5LDMw IC0tLS0KICAjZGVmaW5lIFNUUkNNUAkJd2NzY21wCiAgI2RlZmluZSBTVFJQQlJLCQl3Y3NwYnJr CiAgI2RlZmluZSBUT1VQUEVSCQl0b3d1cHBlcgorICNkZWZpbmUgVE9MT1dFUgkJdG93bG93ZXIK KyAjZGVmaW5lIElTVVBQRVIJCWlzd3VwcGVyCisgI2RlZmluZSBJU0xPV0VSCQlpc3dsb3dlcgog ICNkZWZpbmUgU1RSU0VUCQl3bWVtc2V0CisgI2RlZmluZSBHRVRDCQlnZXR3YworICNkZWZpbmUg VklfRU9GCQlXRU9GCiAgCiAgI2RlZmluZSBMKGNoKQkJTCAjIyBjaAogIAoqKioqKioqKioqKioq KioKKioqIDM4LDQ0ICoqKioKLS0tIDQzLDU0IC0tLS0KICAjZGVmaW5lIFNUUkNNUAkJc3RyY21w CiAgI2RlZmluZSBTVFJQQlJLCQlzdHJwYnJrCiAgI2RlZmluZSBUT1VQUEVSCQl0b3VwcGVyCisg I2RlZmluZSBUT0xPV0VSCQl0b2xvd2VyCisgI2RlZmluZSBJU1VQUEVSCQlpc3VwcGVyCisgI2Rl ZmluZSBJU0xPV0VSCQlpc2xvd2VyCiAgI2RlZmluZSBTVFJTRVQJCW1lbXNldAorICNkZWZpbmUg R0VUQwkJZ2V0YworICNkZWZpbmUgVklfRU9GCQlFT0YKICAKICAjZGVmaW5lIEwoY2gpCQljaAog IAoqKiogZXgvZXhfc3Vic3QuYy5vcmlnCTIwMDEtMDYtMjUgMDg6MTk6MjAuMDAwMDAwMDAwIC0w NzAwCi0tLSBleC9leF9zdWJzdC5jCTIwMDYtMDUtMjQgMTA6Mjg6NDEuMDAwMDAwMDAwIC0wNzAw CioqKioqKioqKioqKioqKgoqKiogOTA5LDkxNSAqKioqCiAgCX0KICAJaWYgKExGX0lTU0VUKFNF QVJDSF9JQ0wpKSB7CiAgaWNsb3dlcjoJZm9yIChwID0gcHRybiwgbGVuID0gcGxlbjsgbGVuID4g MDsgKytwLCAtLWxlbikKISAJCQlpZiAoaXN1cHBlcigqcCkpCiAgCQkJCWJyZWFrOwogIAkJaWYg KGxlbiA9PSAwKQogIAkJCXJlZmxhZ3MgfD0gUkVHX0lDQVNFOwotLS0gOTA5LDkxNSAtLS0tCiAg CX0KICAJaWYgKExGX0lTU0VUKFNFQVJDSF9JQ0wpKSB7CiAgaWNsb3dlcjoJZm9yIChwID0gcHRy biwgbGVuID0gcGxlbjsgbGVuID4gMDsgKytwLCAtLWxlbikKISAJCQlpZiAoSVNVUFBFUigqcCkp CiAgCQkJCWJyZWFrOwogIAkJaWYgKGxlbiA9PSAwKQogIAkJCXJlZmxhZ3MgfD0gUkVHX0lDQVNF OwoqKioqKioqKioqKioqKioKKioqIDEzNjMsMTM3NyAqKioqCiAgCQkJY29udiA9IENfTk9UU0VU OwkJCQlcCiAgCQkJLyogRkFMTFRIUk9VR0ggKi8JCQkJXAogIAkJY2FzZSBDX0xPV0VSOgkJCQkJ CVwKISAJCQlpZiAoaXN1cHBlcihfX2NoKSkJCQkJXAohIAkJCQlfX2NoID0gdG9sb3dlcihfX2No KTsJCQlcCiAgCQkJYnJlYWs7CQkJCQkJXAogIAkJY2FzZSBDX09ORVVQUEVSOgkJCQkJXAogIAkJ CWNvbnYgPSBDX05PVFNFVDsJCQkJXAogIAkJCS8qIEZBTExUSFJPVUdIICovCQkJCVwKICAJCWNh c2UgQ19VUFBFUjoJCQkJCQlcCiEgCQkJaWYgKGlzbG93ZXIoX19jaCkpCQkJCVwKISAJCQkJX19j aCA9IHRvdXBwZXIoX19jaCk7CQkJXAogIAkJCWJyZWFrOwkJCQkJCVwKICAJCWRlZmF1bHQ6CQkJ CQkJXAogIAkJCWFib3J0KCk7CQkJCQlcCi0tLSAxMzYzLDEzNzcgLS0tLQogIAkJCWNvbnYgPSBD X05PVFNFVDsJCQkJXAogIAkJCS8qIEZBTExUSFJPVUdIICovCQkJCVwKICAJCWNhc2UgQ19MT1dF UjoJCQkJCQlcCiEgCQkJaWYgKElTVVBQRVIoX19jaCkpCQkJCVwKISAJCQkJX19jaCA9IFRPTE9X RVIoX19jaCk7CQkJXAogIAkJCWJyZWFrOwkJCQkJCVwKICAJCWNhc2UgQ19PTkVVUFBFUjoJCQkJ CVwKICAJCQljb252ID0gQ19OT1RTRVQ7CQkJCVwKICAJCQkvKiBGQUxMVEhST1VHSCAqLwkJCQlc CiAgCQljYXNlIENfVVBQRVI6CQkJCQkJXAohIAkJCWlmIChJU0xPV0VSKF9fY2gpKQkJCQlcCiEg CQkJCV9fY2ggPSBUT1VQUEVSKF9fY2gpOwkJCVwKICAJCQlicmVhazsJCQkJCQlcCiAgCQlkZWZh dWx0OgkJCQkJCVwKICAJCQlhYm9ydCgpOwkJCQkJXAo=