<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "http://bugs.gentoo.org/bugzilla.dtd">

<bugzilla version="2.22.7"
          urlbase="http://bugs.gentoo.org/"
          maintainer="bugzilla@gentoo.org"
>

    <bug>
          <bug_id>149197</bug_id>
          
          <creation_ts>2006-09-26 10:51 0000</creation_ts>
          <short_desc>openswan-2.4.4 does not cope with suspend2-sources-2.6.18</short_desc>
          <delta_ts>2006-10-15 19:47:26 0000</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>Gentoo Linux</product>
          <component>Ebuilds</component>
          <version>2006.0</version>
          <rep_platform>All</rep_platform>
          <op_sys>Linux</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          
          <priority>P2</priority>
          <bug_severity>normal</bug_severity>
          <target_milestone>---</target_milestone>
          <dependson>134484</dependson>
          <blocked>148429</blocked>
          
          <everconfirmed>1</everconfirmed>
          <reporter>dominik.buerkle@web.de</reporter>
          <assigned_to>maintainer-needed@gentoo.org</assigned_to>
          <cc>cilly@cilly.mine.nu</cc>
    
    <cc>dsd@gentoo.org</cc>
    
    <cc>pfeifer@gentoo.org</cc>

      

      
          <long_desc isprivate="0">
            <who>dominik.buerkle@web.de</who>
            <bug_when>2006-09-26 10:51:27 0000</bug_when>
            <thetext>Hi,

openswan-2.4.4 complains about &quot;kernel version not supported&quot;, because the ebuild depends on UTS_RELEASE in linux/include/linux/version.h.

That line is missing in suspend2-sources-2.6.18.

UTS_RELEASE comes before LINUX_VERSION_CODE in suspend2-sources-2.6.17-r5, the following patch is depending on this order. I can write another patch, if this can not be guaranteed.

Works for me. :-)</thetext>
          </long_desc>
          <long_desc isprivate="0">
            <who>dominik.buerkle@web.de</who>
            <bug_when>2006-09-26 10:52:37 0000</bug_when>
            <thetext>Created an attachment (id=98152)
patch with modified awk command, to accept 2.6.18 (+?) kernel versions

</thetext>
          </long_desc>
          <long_desc isprivate="0">
            <who>dominik.buerkle@web.de</who>
            <bug_when>2006-09-26 10:56:23 0000</bug_when>
            <thetext>Please check if the awk command is sufficient. Can be adapted to &quot;accept UTS_RELEASE, if anywhere in the file, else use LINUX_VERSION_CODE&quot;.</thetext>
          </long_desc>
          <long_desc isprivate="0">
            <who>dominik.buerkle@web.de</who>
            <bug_when>2006-09-26 10:58:55 0000</bug_when>
            <thetext>KV_major/minor/micro (or whatever) should be inherited from sth. like kernel-dependencies.eclass, imho.</thetext>
          </long_desc>
          <long_desc isprivate="0">
            <who>jakub@gentoo.org</who>
            <bug_when>2006-09-26 10:59:09 0000</bug_when>
            <thetext>Please, don&apos;t resolve bugs that are not fixed in portage.</thetext>
          </long_desc>
          <long_desc isprivate="0">
            <who>dominik.buerkle@web.de</who>
            <bug_when>2006-09-26 12:37:24 0000</bug_when>
            <thetext>Created an attachment (id=98165)
new awk command

copes with any &quot;version.h&quot; that has either UTS_RELEASE or LINUX_VERSION_CODE.
Prefers UTS_RELEASE over LINUX_VERSION_CODE (which includes EXTRAVERSION, in my case &quot;-suspend2-r5&quot; with 2.6.17-suspend2-r5) - quite like before.

Though EXTRAVERSION is cut off in this specific ebuild, it might be used in other places, if that code was copied from somewhere else.

However, EXTRAVERSION cannot be recovered from version.h if UTS_RELEASE is not included, so ebuilds that use this string have to choose some other method of determining EXTRAVERSION... e.g.

$ cd /usr/src/linux; make kernelrelease
2.6.18-suspend2
$ 

$ cd /usr/src/; for d in linux-*; do (echo $d:; cd $d; make kernelrelease); done
linux-2.6.16-suspend2-r8:
2.6.16-suspend2-r8
linux-2.6.17-suspend2-r4:
2.6.17-suspend2-r4
linux-2.6.17-suspend2-r5:
2.6.17-suspend2-r5
linux-2.6.18-suspend2:
2.6.18-suspend2
$

...</thetext>
          </long_desc>
          <long_desc isprivate="0">
            <who>dominik.buerkle@web.de</who>
            <bug_when>2006-09-26 12:42:19 0000</bug_when>
            <thetext>Consider this Makefile snippet:


kernelrelease:
        $(if $(wildcard include/config/kernel.release), $(Q)echo $(KERNELRELEASE), \
        $(error kernelrelease not valid - run &apos;make prepare&apos; to update it))
kernelversion:
        @echo $(KERNELVERSION)


so something like

KV_full=&quot;$(cd /usr/src/linux &amp;&amp; make kernelrelease)&quot;
eerror $? &quot;kernel not configured&quot;

would be possible, wouldn&apos;t it?</thetext>
          </long_desc>
          <long_desc isprivate="0">
            <who>jakub@gentoo.org</who>
            <bug_when>2006-10-01 23:50:28 0000</bug_when>
            <thetext>*** Bug 149786 has been marked as a duplicate of this bug. ***</thetext>
          </long_desc>
          <long_desc isprivate="0">
            <who>dsd@gentoo.org</who>
            <bug_when>2006-10-15 18:56:28 0000</bug_when>
            <thetext>This package should be fixed to use linux-info or linux-mod</thetext>
          </long_desc>
          <long_desc isprivate="0">
            <who>dsd@gentoo.org</who>
            <bug_when>2006-10-15 19:46:54 0000</bug_when>
            <thetext>now uses linux-info</thetext>
          </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>98152</attachid>
            <date>2006-09-26 10:52 0000</date>
            <desc>patch with modified awk command, to accept 2.6.18 (+?) kernel versions</desc>
            <filename>openswan-2.4.4.ebuild.diff</filename>
            <type>text/plain</type>
            <data encoding="base64">LS0tIC91c3IvcG9ydGFnZS9uZXQtbWlzYy9vcGVuc3dhbi9vcGVuc3dhbi0yLjQuNC5lYnVpbGQJ
MjAwNS0xMS0yOSAxNjowNjowMi4wMDAwMDAwMDAgKzAxMDAKKysrIC91c3IvbG9jYWwvcG9ydGFn
ZS9uZXQtbWlzYy9vcGVuc3dhbi9vcGVuc3dhbi0yLjQuNC5lYnVpbGQJMjAwNi0wOS0yNiAxOTo0
MjoyOS4wMDAwMDAwMDAgKzAyMDAKQEAgLTM3LDcgKzM3LDE0IEBACiAJY2hlY2tfdmVyc2lvbl9o
CiAKIAkjIEdldCB0aGUga2VybmVsIHZlcnNpb24gb2Ygc291cmNlcyBpbiAvdXNyL3NyYy9saW51
eCAuLi4KLQlleHBvcnQgS1ZfZnVsbD0iJChhd2sgJy9VVFNfUkVMRUFTRS8geyBnc3ViKCJcIiIs
ICIiLCAkMyk7IHByaW50ICQzIH0nIFwKKwlleHBvcnQgS1ZfZnVsbD0iJChhd2sgJy9VVFNfUkVM
RUFTRS8geyBnc3ViKCJcIiIsICIiLCAkMyk7IHByaW50ICQzOyBuZXh0ZmlsZX07IFwKKwkgICAg
ICAgICAgICAgICAgICAgICAgIC9MSU5VWF9WRVJTSU9OX0NPREUvIHsgXAorCQkJCQkJICAgICAg
IG1ham9yPXJzaGlmdCggJDMsIDE2ICk7IFwKKwkJCQkJCSAgICAgICBtaW5vcj1hbmQoIHJzaGlm
dCggJDMsIDggKSwgMjU1ICk7IFwKKwkJCQkJCQkgICBtaWNybz1hbmQoICQzLCAyNTUpOyBcCisJ
CQkJCQkJICAgcHJpbnRmKCAiJWQuJWQuJWRcbiIsIG1ham9yLCBtaW5vciwgbWljcm8gKTsgXAor
CQkJCQkJCSAgIG5leHRmaWxlOyBcCisJCQkJCSAgICAgICB9JyBcCiAJCSIke1JPT1R9L3Vzci9z
cmMvbGludXgvaW5jbHVkZS9saW51eC92ZXJzaW9uLmgiKSIKIAlleHBvcnQgS1ZfbWFqb3I9IiQo
ZWNobyAiJHtLVl9mdWxsfSIgfCBjdXQgLWQuIC1mMSkiCiAJZXhwb3J0IEtWX21pbm9yPSIkKGVj
aG8gIiR7S1ZfZnVsbH0iIHwgY3V0IC1kLiAtZjIpIgo=
</data>        

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>98165</attachid>
            <date>2006-09-26 12:37 0000</date>
            <desc>new awk command</desc>
            <filename>openswan-2.4.4.ebuild.diff</filename>
            <type>text/plain</type>
            <data encoding="base64">LS0tIC91c3IvcG9ydGFnZS9uZXQtbWlzYy9vcGVuc3dhbi9vcGVuc3dhbi0yLjQuNC5lYnVpbGQJ
MjAwNS0xMS0yOSAxNjowNjowMi4wMDAwMDAwMDAgKzAxMDAKKysrIC91c3IvbG9jYWwvcG9ydGFn
ZS9uZXQtbWlzYy9vcGVuc3dhbi9vcGVuc3dhbi0yLjQuNC5lYnVpbGQJMjAwNi0wOS0yNiAyMToy
NDoyMS4wMDAwMDAwMDAgKzAyMDAKQEAgLTM3LDcgKzM3LDE1IEBACiAJY2hlY2tfdmVyc2lvbl9o
CiAKIAkjIEdldCB0aGUga2VybmVsIHZlcnNpb24gb2Ygc291cmNlcyBpbiAvdXNyL3NyYy9saW51
eCAuLi4KLQlleHBvcnQgS1ZfZnVsbD0iJChhd2sgJy9VVFNfUkVMRUFTRS8geyBnc3ViKCJcIiIs
ICIiLCAkMyk7IHByaW50ICQzIH0nIFwKKwlleHBvcnQgS1ZfZnVsbD0iJChhd2sgJy9VVFNfUkVM
RUFTRS8geyBnc3ViKCJcIiIsICIiLCAkMyk7IHV0c3JlbGVhc2U9JDN9OyBcCisJICAgICAgICAg
ICAgICAgICAgICAgICAvTElOVVhfVkVSU0lPTl9DT0RFLyB7IFwKKwkJCQkJCSAgICAgICBtYWpv
cj1yc2hpZnQoICQzLCAxNiApOyBcCisJCQkJCQkgICAgICAgbWlub3I9YW5kKCByc2hpZnQoICQz
LCA4ICksIDI1NSApOyBcCisJCQkJCQkJICAgbWljcm89YW5kKCAkMywgMjU1KTsgXAorCQkJCQkJ
CSAgIGxpbnV4dmVyc2lvbj1tYWpvciIuIm1pbm9yIi4ibWljcm87IFwKKwkJCQkJICAgICAgIH07
IFwKKwkJCQkJCSAgIEVORCB7aWYgKHV0c3JlbGVhc2UpIHtwcmludCB1dHNyZWxlYXNlfSBcCisJ
CQkJCSAgICAgICAgICAgIGVsc2Uge2lmIChsaW51eHZlcnNpb24pIHtwcmludCBsaW51eHZlcnNp
b259fX0nIFwKIAkJIiR7Uk9PVH0vdXNyL3NyYy9saW51eC9pbmNsdWRlL2xpbnV4L3ZlcnNpb24u
aCIpIgogCWV4cG9ydCBLVl9tYWpvcj0iJChlY2hvICIke0tWX2Z1bGx9IiB8IGN1dCAtZC4gLWYx
KSIKIAlleHBvcnQgS1ZfbWlub3I9IiQoZWNobyAiJHtLVl9mdWxsfSIgfCBjdXQgLWQuIC1mMiki
Cg==
</data>        

          </attachment>
    </bug>

</bugzilla>