<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "http://bugs.gentoo.org/bugzilla.dtd">

<bugzilla version="2.22.7"
          urlbase="http://bugs.gentoo.org/"
          maintainer="bugzilla@gentoo.org"
>

    <bug>
          <bug_id>148784</bug_id>
          
          <creation_ts>2006-09-23 08:17 0000</creation_ts>
          <short_desc>Add support for VIA padlock in sys-fs/loop-aes</short_desc>
          <delta_ts>2006-10-04 08:51:42 0000</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>Gentoo Linux</product>
          <component>Ebuilds</component>
          <version>unspecified</version>
          <rep_platform>All</rep_platform>
          <op_sys>Linux</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          
          <priority>P2</priority>
          <bug_severity>enhancement</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          
          <everconfirmed>1</everconfirmed>
          <reporter>LittleThor@xsw.terminator.net</reporter>
          <assigned_to>genstef@gentoo.org</assigned_to>
          <cc>alonbl@gentoo.org</cc>

      

      
          <long_desc isprivate="0">
            <who>LittleThor@xsw.terminator.net</who>
            <bug_when>2006-09-23 08:17:05 0000</bug_when>
            <thetext>Please consider adding support for the VIA padlock hardware AES acceleration in loop-aes. From the loop-aes README:

&quot;If you want enable VIA padlock hardware AES xcrypt instructions, specify
PADLOCK=y on make command line. If enabled, presence of VIA padlock
instructions is detected at run time, but code still works on non-padlock
processors too.&quot;

I see two options here, either make PADLOCK=y the default (should still run on other processors) or (probably more preferable) add a padlock USE flag and do something like:

use padlock &amp;&amp; BUILD_PARAMS=&quot;${BUILD_PARAMS} PADLOCK=y&quot;</thetext>
          </long_desc>
          <long_desc isprivate="0">
            <who>jakub@gentoo.org</who>
            <bug_when>2006-09-23 10:59:09 0000</bug_when>
            <thetext>*** This bug has been marked as a duplicate of 145537 ***

*** This bug has been marked as a duplicate of 145537 ***</thetext>
          </long_desc>
          <long_desc isprivate="0">
            <who>LittleThor@xsw.terminator.net</who>
            <bug_when>2006-09-23 11:41:19 0000</bug_when>
            <thetext>Bug 145537 does not appear to be related?

Padlock support in loop-aes would neither use nor require support in openssl.

Upstream loop-aes already contains it&apos;s own padlock implementation as a compile time option but the ebuild does not enable it. All that&apos;s needed is for the ebuild to allow that compile time option to be set?</thetext>
          </long_desc>
          <long_desc isprivate="0">
            <who>genstef@gentoo.org</who>
            <bug_when>2006-09-23 13:05:10 0000</bug_when>
            <thetext>CCing main contributor for this :)

can you please contribute a patch?</thetext>
          </long_desc>
          <long_desc isprivate="0">
            <who>alonbl@gentoo.org</who>
            <bug_when>2006-09-23 13:49:52 0000</bug_when>
            <thetext>Created an attachment (id=97891)
loop-aes-3.1d.ebuild.diff

Sure!
Although I don&apos;t have the hardware to test it, it seems to work without the hardware, but I notice a performance impact.

Add new use flag, padlock:
Use VIA padlock instructions, detected at run time, code still works on non-padlock processors too.
</thetext>
          </long_desc>
          <long_desc isprivate="0">
            <who>LittleThor@xsw.terminator.net</who>
            <bug_when>2006-09-24 03:55:46 0000</bug_when>
            <thetext>Works great, thanks! Nearly triples the IO speed on a C7.

If you need any testing on this hardware in the future please feel free to CC me.</thetext>
          </long_desc>
          <long_desc isprivate="0">
            <who>genstef@gentoo.org</who>
            <bug_when>2006-10-04 08:51:42 0000</bug_when>
            <thetext>thanks, fixed</thetext>
          </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>97891</attachid>
            <date>2006-09-23 13:49 0000</date>
            <desc>loop-aes-3.1d.ebuild.diff</desc>
            <filename>loop-aes-3.1d.ebuild.diff</filename>
            <type>text/plain</type>
            <data encoding="base64">LS0tIGxvb3AtYWVzLTMuMWQuZWJ1aWxkCTIwMDYtMDktMTUgMDg6MDY6MTguMDAwMDAwMDAwICsw
MzAwCisrKyBsb29wLWFlcy0zLjFkLmVidWlsZAkyMDA2LTA5LTIzIDIzOjE3OjE3LjAwMDAwMDAw
MCArMDMwMApAQCAtMTEsMTAgKzExLDEwIEBAIFNSQ19VUkk9Im1pcnJvcjovL3NvdXJjZWZvcmdl
L2xvb3AtYWVzLyQKIAogTElDRU5TRT0iR1BMLTIiCiBTTE9UPSIwIgotSVVTRT0ia2V5c2NydWIi
CitJVVNFPSJrZXlzY3J1YiBwYWRsb2NrIgogS0VZV09SRFM9In5hbWQ2NCB+aHBwYSB+cHBjIHg4
NiIKIAotUz0ke1dPUktESVJ9LyR7TVlfUH0KK1M9IiR7V09SS0RJUn0vJHtNWV9QfSIKIAogQ09O
RklHX0NIRUNLPSIhQkxLX0RFVl9MT09QIgogTU9EVUxFX05BTUVTPSJsb29wKGJsb2NrOikiCkBA
IC00MSw2ICs0MSw3IEBAIHBrZ19zZXR1cCgpIHsKIAogCUJVSUxEX1BBUkFNUz0iTElOVVhfU09V
UkNFPSR7S1ZfRElSfSBNT0RJTlNUPW4gUlVORE09biIKIAl1c2Uga2V5c2NydWIgJiYgQlVJTERf
UEFSQU1TPSIke0JVSUxEX1BBUkFNU30gS0VZU0NSVUI9eSIKKwl1c2UgcGFkbG9jayAmJiBCVUlM
RF9QQVJBTVM9IiR7QlVJTERfUEFSQU1TfSBQQURMT0NLPXkiCiB9CiAKIHNyY191bnBhY2sgKCkg
ewo=
</data>        

          </attachment>
    </bug>

</bugzilla>