<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "http://bugs.gentoo.org/bugzilla.dtd">

<bugzilla version="2.22.7"
          urlbase="http://bugs.gentoo.org/"
          maintainer="bugzilla@gentoo.org"
>

    <bug>
          <bug_id>148778</bug_id>
          
          <creation_ts>2006-09-23 07:10 0000</creation_ts>
          <short_desc>net-libs/gnutls-1.4.4-r1 depends on sys-devel/gettext in non-nls build</short_desc>
          <delta_ts>2006-09-23 15:16:13 0000</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>Gentoo Linux</product>
          <component>Ebuilds</component>
          <version>unspecified</version>
          <rep_platform>All</rep_platform>
          <op_sys>Linux</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          
          <priority>P2</priority>
          <bug_severity>normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          
          <everconfirmed>1</everconfirmed>
          <reporter>timo@kamph.org</reporter>
          <assigned_to>liquidx@gentoo.org</assigned_to>
          <cc>crypto@gentoo.org</cc>
    
    <cc>jakub@gentoo.org</cc>

      

      
          <long_desc isprivate="0">
            <who>timo@kamph.org</who>
            <bug_when>2006-09-23 07:10:51 0000</bug_when>
            <thetext>Problem:
The gnutls-1.4.4-r1 ebuild unconditionally (r)depends on gettext, even if the nls use flag is not set.

Solution:
The ebuild should check the nls use flag and only add sys-devel/gettext to RDEPEND if the flag is set.

I&apos;ll attatch a fixed ebuild.</thetext>
          </long_desc>
          <long_desc isprivate="0">
            <who>timo@kamph.org</who>
            <bug_when>2006-09-23 07:13:41 0000</bug_when>
            <thetext>Created an attachment (id=97852)
Fixed ebuild

</thetext>
          </long_desc>
          <long_desc isprivate="0">
            <who>timo@kamph.org</who>
            <bug_when>2006-09-23 07:17:39 0000</bug_when>
            <thetext>Created an attachment (id=97854)
Fix as patch

This is a diff between the original and the fixed ebuild file.</thetext>
          </long_desc>
          <long_desc isprivate="0">
            <who>jakub@gentoo.org</who>
            <bug_when>2006-09-23 07:18:57 0000</bug_when>
            <thetext>(From update of attachment 97852)
How exactly will this work? You didn&apos;t change anything except for adding the use flag. 

You need $(use_enable nls) there (and no, I didn&apos;t check if it&apos;s even honored by the build system).</thetext>
          </long_desc>
          <long_desc isprivate="0">
            <who>jakub@gentoo.org</who>
            <bug_when>2006-09-23 07:22:58 0000</bug_when>
            <thetext>Plus gettext shouldn&apos;t be in RDEPEND:

RDEPEND=&quot;nls? ( virtual/libintl )
   ....&quot;

DEPEND=&quot;${RDEPEND}
   nls? ( sys-devel/gettext )&quot;


</thetext>
          </long_desc>
          <long_desc isprivate="0">
            <who>timo@kamph.org</who>
            <bug_when>2006-09-23 07:39:27 0000</bug_when>
            <thetext>(In reply to comment #3)
&gt; (From update of attachment 97852 [edit])
&gt; How exactly will this work? You didn&apos;t change anything except for adding the
&gt; use flag. 

I added a check to RDEPEND, this is how it&apos;s done in other ebuilds and with the other use flags in the gnutls ebuild. The important part of the fix is:

-	sys-devel/gettext&quot;
+	nls? ( sys-devel/gettext )&quot;

in RDEPEND=...

So please check it again.</thetext>
          </long_desc>
          <long_desc isprivate="0">
            <who>timo@kamph.org</who>
            <bug_when>2006-09-23 07:41:52 0000</bug_when>
            <thetext>(In reply to comment #4)
&gt; Plus gettext shouldn&apos;t be in RDEPEND:
&gt; 
&gt; RDEPEND=&quot;nls? ( virtual/libintl )
&gt;    ....&quot;
&gt; 
&gt; DEPEND=&quot;${RDEPEND}
&gt;    nls? ( sys-devel/gettext )&quot;
&gt; 

Well, I just want to get gettext out of my non-nls system.
Someone else put in into RDEPNED in the first place.</thetext>
          </long_desc>
          <long_desc isprivate="0">
            <who>dragonheart@gentoo.org</who>
            <bug_when>2006-09-23 15:16:13 0000</bug_when>
            <thetext>by bad. Thanks Timo for bringing it to my attentioned. Problem should be fixed now.</thetext>
          </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="0"
              isprivate="0"
          >
            <attachid>97852</attachid>
            <date>2006-09-23 07:13 0000</date>
            <desc>Fixed ebuild</desc>
            <filename>gnutls-1.4.4-r1.ebuild</filename>
            <type>text/plain</type>
            <data encoding="base64">IyBDb3B5cmlnaHQgMTk5OS0yMDA2IEdlbnRvbyBGb3VuZGF0aW9uCiMgRGlzdHJpYnV0ZWQgdW5k
ZXIgdGhlIHRlcm1zIG9mIHRoZSBHTlUgR2VuZXJhbCBQdWJsaWMgTGljZW5zZSB2MgojICRIZWFk
ZXI6IC92YXIvY3Zzcm9vdC9nZW50b28teDg2L25ldC1saWJzL2dudXRscy9nbnV0bHMtMS40LjQt
cjEuZWJ1aWxkLHYgMS43IDIwMDYvMDkvMjMgMDA6MDE6Mzkga2xvZXJpIEV4cCAkCgppbmhlcml0
IGV1dGlscyBhdXRvdG9vbHMKCkRFU0NSSVBUSU9OPSJBIFRMUyAxLjAgYW5kIFNTTCAzLjAgaW1w
bGVtZW50YXRpb24gZm9yIHRoZSBHTlUgcHJvamVjdCIKSE9NRVBBR0U9Imh0dHA6Ly93d3cuZ251
dGxzLm9yZy8iClNSQ19VUkk9Imh0dHA6Ly9qb3NlZnNzb24ub3JnL2dudXRscy9yZWxlYXNlcy8k
e1B9LnRhci5iejIiCgojIEdQTC0yIGZvciB0aGUgZ251dGxzLWV4dHJhcyBsaWJyYXJ5IGFuZCBM
R1BMIGZvciB0aGUgZ251dGxzIGxpYnJhcnkuCkxJQ0VOU0U9IkxHUEwtMi4xIEdQTC0yIgpTTE9U
PSIwIgpLRVlXT1JEUz0iYWxwaGEgYW1kNjQgfmFybSBocHBhIGlhNjQgfm02OGsgfm1pcHMgcHBj
IH5wcGMtbWFjb3MgcHBjNjQgfnMzOTAgfnNoIH5zcGFyYyB4ODYiCklVU0U9Im5scyB6bGliIGRv
YyIKClJERVBFTkQ9Ij49ZGV2LWxpYnMvbGliZ2NyeXB0LTEuMi4yCgk+PWFwcC1jcnlwdC9vcGVu
Y2RrLTAuNS41Cgl6bGliPyAoID49c3lzLWxpYnMvemxpYi0xLjEgKQoJdmlydHVhbC9saWJjCgk+
PWRldi1saWJzL2x6by0yCglkZXYtbGlicy9saWJncGctZXJyb3IKCT49ZGV2LWxpYnMvbGlidGFz
bjEtMC4zLjQKCW5scz8gKCBzeXMtZGV2ZWwvZ2V0dGV4dCApIgojPj1zeXMtZGV2ZWwvZ2V0dGV4
dC0wLjE0LjUiIGF1dG9jb25mIGluZGljYXRlcyB0aGlzIHZlcnNpb24gYnV0IGl0IHdvcmtzCiMg
d2l0aG91dCBpdApERVBFTkQ9IiR7UkRFUEVORH0KCXN5cy1kZXZlbC9saWJ0b29sCglkb2M/ICgg
ZGV2LXV0aWwvZ3RrLWRvYyApIgoKc3JjX3VucGFjaygpIHsKCXVucGFjayAke0F9CgljZCAiJHtT
fSIKCWVwYXRjaCAiJHtGSUxFU0RJUn0iLyR7UH0tc2VsZmxpbmsucGF0Y2gKCWVsaWJ0b29saXpl
CgllYXV0b21ha2UKfQoKc3JjX2NvbXBpbGUoKSB7Cglsb2NhbCBteWNvbmY9IiIKCgllY29uZiAg
XAoJCSQodXNlX3dpdGggemxpYikgXAoJCS0td2l0aG91dC1pbmNsdWRlZC1taW5pbHpvIFwKCQkt
LXdpdGhvdXQtaW5jbHVkZWQtb3BlbmNkayBcCgkJJCh1c2VfZW5hYmxlIGRvYyBndGstZG9jKSBc
CgkJJHtteWNvbmZ9IHx8IGRpZQoJZW1ha2UgfHwgZGllCn0KCnNyY19pbnN0YWxsKCkgewoJZW1h
a2UgLWoxIERFU1RESVI9IiR7RH0iIGluc3RhbGwgfHwgZGllCgoJZG9kb2MgQVVUSE9SUyBDaGFu
Z2VMb2cgTkVXUyBcCgkJUkVBRE1FIFRIQU5LUyBkb2MvVE9ETwoKCWlmIHVzZSBkb2MgOyB0aGVu
CgkJZG9kb2MgZG9jL1JFQURNRS5hdXRvY29uZiBkb2MvdGV4L2dudXRscy5wcwoJCWRvY2ludG8g
ZXhhbXBsZXMKCQlkb2RvYyBkb2MvZXhhbXBsZXMvKi5jCglmaQp9Cgpwa2dfcG9zdGluc3QoKSB7
CglpZiBbWyAtZSAiJHtST09UfSIvdXNyLyQoZ2V0X2xpYmRpcikvbGliZ251dGxzLnNvLjEyIF1d
IDsgdGhlbgoJCWV3YXJuICJZb3UgbXVzdCByZS1jb21waWxlIGFsbCBwYWNrYWdlcyB0aGF0IGFy
ZSBsaW5rZWQgYWdhaW5zdCIKCQlld2FybiAiR251dGxzLTEuMi4xMSBieSB1c2luZyByZXZkZXAt
cmVidWlsZCBmcm9tIGdlbnRvb2xraXQ6IgoJCWV3YXJuICIjIHJldmRlcC1yZWJ1aWxkIC0tbGli
cmFyeSBsaWJnbnV0bHMuc28uMTIiCglmaQp9Cg==
</data>        

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>97854</attachid>
            <date>2006-09-23 07:17 0000</date>
            <desc>Fix as patch</desc>
            <filename>gnutls-1.4.4-r1.ebuild.patch</filename>
            <type>text/plain</type>
            <data encoding="base64">LS0tIC91c3IvcG9ydGFnZS9uZXQtbGlicy9nbnV0bHMvZ251dGxzLTEuNC40LXIxLmVidWlsZAky
MDA2LTA5LTIzIDAyOjEwOjM5LjAwMDAwMDAwMCArMDIwMAorKysgZ251dGxzLTEuNC40LXIxLmVi
dWlsZAkyMDA2LTA5LTIzIDE2OjA0OjQ2LjAwMDAwMDAwMCArMDIwMApAQCAtMTIsNyArMTIsNyBA
QAogTElDRU5TRT0iTEdQTC0yLjEgR1BMLTIiCiBTTE9UPSIwIgogS0VZV09SRFM9ImFscGhhIGFt
ZDY0IH5hcm0gaHBwYSBpYTY0IH5tNjhrIH5taXBzIHBwYyB+cHBjLW1hY29zIHBwYzY0IH5zMzkw
IH5zaCB+c3BhcmMgeDg2IgotSVVTRT0iemxpYiBkb2MiCitJVVNFPSJubHMgemxpYiBkb2MiCiAK
IFJERVBFTkQ9Ij49ZGV2LWxpYnMvbGliZ2NyeXB0LTEuMi4yCiAJPj1hcHAtY3J5cHQvb3BlbmNk
ay0wLjUuNQpAQCAtMjEsNyArMjEsNyBAQAogCT49ZGV2LWxpYnMvbHpvLTIKIAlkZXYtbGlicy9s
aWJncGctZXJyb3IKIAk+PWRldi1saWJzL2xpYnRhc24xLTAuMy40Ci0Jc3lzLWRldmVsL2dldHRl
eHQiCisJbmxzPyAoIHN5cy1kZXZlbC9nZXR0ZXh0ICkiCiAjPj1zeXMtZGV2ZWwvZ2V0dGV4dC0w
LjE0LjUiIGF1dG9jb25mIGluZGljYXRlcyB0aGlzIHZlcnNpb24gYnV0IGl0IHdvcmtzCiAjIHdp
dGhvdXQgaXQKIERFUEVORD0iJHtSREVQRU5EfQo=
</data>        

          </attachment>
    </bug>

</bugzilla>