147033 2006-09-10 01:52 0000 sci-physics/xfoil-6.94-r1 fails to compile with GCC 4.1.1 2007-05-23 20:18:09 0000 1 1 1 Unclassified Gentoo Linux Applications 2006.1 x86 Linux RESOLVED FIXED P3 normal --- 117482 1 ke6fis@arrl.net robbat2@gentoo.org gcc-porting@gentoo.org sci-physics@gentoo.org ke6fis@arrl.net 2006-09-10 01:52:01 0000 gfortran -o xfoil xfoil.o xpanel.o xoper.o xtcam.o xgdes.o xqdes.o xmdes.o xsolv e.o xbl.o xblsys.o xpol.o xplots.o xgeom.o xutils.o modify.o polplt.o aread.o na ca.o spline.o plutil.o iopol.o gui.o sort.o dplot.o profil.o userio.o ../plotlib /libPlt.a -L/usr/X11R6/lib -lX11 -lblas ../plotlib/libPlt.a(ps_subs.o): In function `bitpat_': ps_subs.f:(.text+0x77): undefined reference to `rshift_' ps_subs.f:(.text+0xee): undefined reference to `rshift_' collect2: ld returned 1 exit status make: *** [xfoil] Error 1 !!! ERROR: sci-physics/xfoil-6.94-r1 failed. Call stack: ebuild.sh, line 1539: Called dyn_compile ebuild.sh, line 939: Called src_compile xfoil-6.94-r1.ebuild, line 56: Called die !!! failed to build xfoil !!! If you need support, post the topmost build error, and the call stack if rel evant. This is apparently the result of this gcc issue: http://gcc.gnu.org/bugzilla/show_bug.cgi?id=19292 which is a meta-bug report that shows the fortran rshift intrinsic is not yet implemented in gfortran, the new GCC 4 fortran replacement for the older F77 compiler. rshift is only being called twice, and it's only right-shifting by 1 each time. It shouldn't be too hard to fix the source code to avoid the use of the intrinsic for the time being until the gfortran compiler gets fixed. I'll have a look at it and see if I can come up with a patch. ke6fis@arrl.net 2006-09-10 22:40:19 0000 Created an attachment (id=96662) Patch to 6.94-r1 to fix missing rshift intrinsic I'm no fortran expert, but I found this URL: http://gcc.gnu.org/onlinedocs/gcc-3.4.1/g77/IShft-Intrinsic.html#IShft%20Intrinsic which seems to exist in 4.1.1 even though it is not in the online docs yet. This patch replaces the rshift intrinsic with this ishft intrinsic. This code seems to compile and run OK. I tried some test cases with this new version versus the old code compiled with gcc 3.4.6 and everything appears to work. I'm no expert with this code though so I would hardly call it an exhaustive analysis. On a related note, I notice that xfoil is now at 6.96: http://web.mit.edu/drela/Public/web/xfoil/ I downloaded this new code and see it has the same rshift issue. Making an ebuild for this new code will be tricky since it doesn't use autoconfig and requires Makefile modifications for paths to binaries, compiler, etc. etc. I'm beginning to wonder if xfoil should even be in portage. It's so specialized I suspect few Gentoo users even know what it's for. It's a pain to configure, and if you *really* are going to use it you probably want to run a number of test cases to verify that the compiler-du-jour on your Gentoo box is actually producting correct output. If none of the developers have time to stay on top of it maybe it shouldn't even be in the portage tree. gregoire.favre@gmail.com 2006-09-17 07:48:27 0000 Thank you very much for the patch :) bicatali@gentoo.org 2007-05-06 17:36:06 0000 Created an attachment (id=118365) xfoil-6.96.ebuild Here is an ebuild for a newer version, with some changes and a patch for the gfortran bug. It compiles fine on my amd64, but I have no idea on how to test the package. Let me know if it works for you. bicatali@gentoo.org 2007-05-06 17:36:50 0000 Created an attachment (id=118366) xfoil-6.96-gfortran.patch bicatali@gentoo.org 2007-05-23 20:18:09 0000 fixed in cvs with a few changes from the proposed patch. 96662 2006-09-10 22:40 0000 Patch to 6.94-r1 to fix missing rshift intrinsic fix-missing-rshift.patch text/plain LS0tIFhGT0lMNjk0Lm9yaWcvcGxvdGxpYi9wc19zdWJzLmYJMjAwNi0wOS0xMCAyMjowNDoyNC4w MDAwMDAwMDAgLTA3MDAKKysrIFhGT0lMNjk0L3Bsb3RsaWIvcHNfc3Vicy5mCTIwMDYtMDktMTAg MjI6MDc6NDcuMDAwMDAwMDAwIC0wNzAwCkBAIC01NTksOCArNTU5LDggQEAKIGMgICAgICAgICAg ICAgICAgICAgaW4gdGhlIGlvdXQgYXJyYXkgKDMsMSwzLDEsMywxLDMsMSkKIGMgICAgIE5vdGU6 IHRoZSBiaXQgbWFzayBpcyBzaGlmdGVkIHRvIGFsd2F5cyBzdGFydCBjb3VudGluZyBvbiBhICcx JyBiaXQuCiBjCi1jLS0tICBVc2VzIHRoZSBsaWJyYXJ5IHJvdXRpbmVzIGFuZCgpIGFuZCByc2hp ZnQoKSBmb3IgYml0IG1hbmlwdWxhdGlvbiAKLWMgICAgIHdoaWNoIGFyZSBwcmVzZW50IGluIG1v c3QgZm9ydHJhbiBsaWJyYXJpZXMgYXMgZXh0ZW5zaW9ucyB0byBmNzcuCitjLS0tICBVc2VzIHRo ZSBsaWJyYXJ5IHJvdXRpbmVzIGFuZCgpIGFuZCBpc2hmdCgpIGZvciBiaXQgbWFuaXB1bGF0aW9u IAorYy0tLSAgd2hpY2ggYXJlIHByZXNlbnQgaW4gZ2ZvcnRyYW4uCiBjCiAgICAgICBkaW1lbnNp b24gaW91dCgqKQogYwpAQCAtNTcwLDcgKzU3MCw3IEBACiAgICAgICAgIGliaXRvbGQgPSBhbmQo MSxpbWFzaykKICAgICAgICAgaWYoaWJpdG9sZC5ORS4wKSBnbyB0byA1CiAgICAgICAgICAgbnNo ZnQgPSBuCi0gICAgICAgICAgaW1hc2sgPSByc2hpZnQoaW1hc2ssMSkKKyAgICAgICAgICBpbWFz ayA9IGlzaGZ0KGltYXNrLC0xKQogICAgICAgZW5kIGRvCiBjCiAgNSAgICBub3V0ICA9IDAKQEAg LTU5NCw3ICs1OTQsNyBAQAogYwogICAgICAgICBpYml0b2xkID0gaWJpdAogICAgICAgICBuYml0 cyA9IG5iaXRzICsgMQotICAgICAgICBpbWFzayA9IHJzaGlmdChpbWFzaywxKQorICAgICAgICBp bWFzayA9IGlzaGZ0KGltYXNrLC0xKQogICAgICAgZW5kIGRvCiBjLS0tIEFkZCBmaW5hbCBiaXQo cykgdG8gZW5kIG9mIDE2IGJpdHMgY2hlY2tlZAogYy0tLSBOb3cgYXBwZW5kIGFueSB6ZXJvIGJp dHMgc2hpZnRlZCBvdXQgb3JpZ2luYWxseQo= 118365 2007-05-06 17:36 0000 xfoil-6.96.ebuild xfoil-6.96.ebuild text/plain IyBDb3B5cmlnaHQgMTk5OS0yMDA3IEdlbnRvbyBGb3VuZGF0aW9uCiMgRGlzdHJpYnV0ZWQgdW5k ZXIgdGhlIHRlcm1zIG9mIHRoZSBHTlUgR2VuZXJhbCBQdWJsaWMgTGljZW5zZSB2MgojICRIZWFk ZXI6ICQKCmluaGVyaXQgdG9vbGNoYWluLWZ1bmNzIGZvcnRyYW4KCkRFU0NSSVBUSU9OPSJEZXNp Z24gYW5kIGFuYWx5c2lzIG9mIHN1YnNvbmljIGlzb2xhdGVkIGFpcmZvaWxzIgpIT01FUEFHRT0i aHR0cDovL3JhcGhhZWwubWl0LmVkdS94Zm9pbC8iClNSQ19VUkk9Imh0dHA6Ly93ZWIubWl0LmVk dS9kcmVsYS9QdWJsaWMvd2ViLyR7UE59LyR7UE59JHtQVn0udGFyLmd6IgoKTElDRU5TRT0iR1BM LTIiClNMT1Q9IjAiCktFWVdPUkRTPSJ+eDg2IH5hbWQ2NCB+cHBjIgpJVVNFPSIiCgpERVBFTkQ9 Inx8ICggeDExLWxpYnMvbGliWDExIHZpcnR1YWwveDExICkiCgpTPSR7V09SS0RJUn0vWGZvaWwK CnNyY191bnBhY2soKSB7Cgl1bnBhY2sgJHtBfQoJY2QgIiR7U30iCglbIC16ICIke0ZGTEFHU30i IF0gJiYgRkZMQUdTPSIke0NGTEFHU30iCgoJIyBBcyBkZWZpbmVkIGluIHRvb2xjaGFpbi1mdW5j cy5lY2xhc3MKCWVjaG8gIkNDID0gJCh0Yy1nZXRDQykiID4+IHBsb3RsaWIvY29uZmlnLm1ha2UK CgkjIEFzIGRlZmluZWQgaW4gZm9ydHJhbi5lY2xhc3MKCWVjaG8gIkZDID0gJHtGT1JUUkFOQ30i ID4+IHBsb3RsaWIvY29uZmlnLm1ha2UKCQoJZWNobyAiQ0ZMQUdTICs9ICR7Q0ZMQUdTfSIgPj4g cGxvdGxpYi9jb25maWcubWFrZQoJZWNobyAiRkZMQUdTICs9ICR7RkZMQUdTfSIgPj4gcGxvdGxp Yi9jb25maWcubWFrZQoKCXNlZCAtaSBcCgkJLWUgInMvXlwoRkMuKlwpL0ZDID0gJHtGT1JUUkFO Q30vZyIgXAoJCS1lICJzL15cKENDLipcKS9DQyA9ICQodGMtZ2V0Q0MpL2ciIFwKCQktZSAicy9e XChGRkxBR1MgLipcKS9GRkxBR1MgPSAke0ZGTEFHU30vZyIgXAoJCS1lICJzL15cKEZGTE9QVCAu KlwpL0ZGTE9QVCA9IFwkKEZGTEFHUykvZyIgXAoJCS1lICJzL15cKEZGTEFHUzIgLipcKS9GRkxB R1MyID0gXCQoRkZMQUdTKS9nIiBcCgkJYmluL01ha2VmaWxlIG9ycnMvYmluL01ha2VmaWxlIHx8 IGRpZSAic2VkIGZhaWxlZCIKCQoJIyBmaXggYnVnICMxNDcwMzMKCVtbICIke0ZPUlRSQU5DfSIg PT0gImdmb3J0cmFuIiBdXSAmJiBlcGF0Y2ggIiR7RklMRVNESVJ9Ii8ke1B9LWdmb3J0cmFuLnBh dGNoCgoJIyBtYWtlIGV2ZXJ5dGhpbmcgZG91YmxlIHByZWNpc2lvbgoJc2VkIC1pIFwKCQktZSAn czovdmFyL2xvY2FsL2NvZGVzL29ycnMvb3NtYXAuZGF0Oi91c3Ivc2hhcmUveGZvaWwvb3Jycy9v c21hcC5kYXQ6JyBcCgkJLWUgJ3M6UkVBTCo0OlJFQUw6ZycgXAoJCW9ycnMvc3JjL29zbWFwLmYg fHwgZGllICJzZWQgb3NtYXAuZiBmYWlsZWQiCn0KCnNyY19jb21waWxlKCkgewoJY2QgIiR7U30i L29ycnMvYmluCgllbWFrZSBGTEc9IiR7RkZMQUdTfSIgRlROTElCPSIiIE9TIHx8IGRpZSAiZmFp bGVkIHRvIGJ1aWxkIG9ycnMiCgljZCAiJHtTfSIvcGxvdGxpYgoJZW1ha2UgRFA9IiIgfHwgZGll ICJmYWlsZWQgdG8gYnVpbGQgcGxvdGxpYiIKCWNkICIke1N9Ii9iaW4KCWZvciBpIGluIHhmb2ls IHBwbG90IHB4cGxvdDsgZG8KCQllbWFrZSBDRkxBR1M9IiR7Q0ZMQUdTfSAtRFVOREVSU0NPUkUi ICR7aX0gfHwgZGllICJmYWlsZWQgdG8gYnVpbGQgJHtpfSIKCWRvbmUKfQoKc3JjX2luc3RhbGwo KSB7Cglkb2JpbiBiaW4vcHBsb3QgYmluL3B4cGxvdCBiaW4veGZvaWwgfHwgZGllICJkb2JpbiBm YWlsZWQiCgkuL2Jpbi9vc2dlbiBvc21hcHNfbnMubHN0CglpbnNpbnRvIC91c3Ivc2hhcmUveGZv aWwvb3JycwoJZG9pbnMgb3Jycy9vc20qCglkb2RvYyAqLnR4dCBSRUFETUUKCWRvY2ludG8gcnVu cwoJZG9kb2MgcnVucy8qCn0K 118366 2007-05-06 17:36 0000 xfoil-6.96-gfortran.patch xfoil-6.96-gfortran.patch text/plain LS0tIHBsb3RsaWIvcHNfc3Vicy5mLm9yaWcJMjAwNC0wOC0yMSAxOTowMjo0NC4wMDAwMDAwMDAg KzAxMDAKKysrIHBsb3RsaWIvcHNfc3Vicy5mCTIwMDctMDUtMDMgMTk6MTQ6MjguOTAxNDkwNzUw ICswMTAwCkBAIC01NTksNyArNTU5LDcgQEAKIGMgICAgICAgICAgICAgICAgICAgaW4gdGhlIGlv dXQgYXJyYXkgKDMsMSwzLDEsMywxLDMsMSkKIGMgICAgIE5vdGU6IHRoZSBiaXQgbWFzayBpcyBz aGlmdGVkIHRvIGFsd2F5cyBzdGFydCBjb3VudGluZyBvbiBhICcxJyBiaXQuCiBjCi1jLS0tICBV c2VzIHRoZSBsaWJyYXJ5IHJvdXRpbmVzIGFuZCgpIGFuZCByc2hpZnQoKSBmb3IgYml0IG1hbmlw dWxhdGlvbiAKK2MtLS0gIFVzZXMgdGhlIGxpYnJhcnkgcm91dGluZXMgYW5kKCkgYW5kIGlzaGZ0 KCkgZm9yIGJpdCBtYW5pcHVsYXRpb24gCiBjICAgICB3aGljaCBhcmUgcHJlc2VudCBpbiBtb3N0 IGZvcnRyYW4gbGlicmFyaWVzIGFzIGV4dGVuc2lvbnMgdG8gZjc3LgogYwogICAgICAgZGltZW5z aW9uIGlvdXQoKikKQEAgLTU3MCw3ICs1NzAsNyBAQAogICAgICAgICBpYml0b2xkID0gYW5kKDEs aW1hc2spCiAgICAgICAgIGlmKGliaXRvbGQuTkUuMCkgZ28gdG8gNQogICAgICAgICAgIG5zaGZ0 ID0gbgotICAgICAgICAgIGltYXNrID0gcnNoaWZ0KGltYXNrLDEpCisgICAgICAgICAgaW1hc2sg PSBpc2hmdChpbWFzaywtMSkKICAgICAgIGVuZCBkbwogYwogIDUgICAgbm91dCAgPSAwCkBAIC01 OTQsNyArNTk0LDcgQEAKIGMKICAgICAgICAgaWJpdG9sZCA9IGliaXQKICAgICAgICAgbmJpdHMg PSBuYml0cyArIDEKLSAgICAgICAgaW1hc2sgPSByc2hpZnQoaW1hc2ssMSkKKyAgICAgICAgaW1h c2sgPSBpc2hmdChpbWFzaywtMSkKICAgICAgIGVuZCBkbwogYy0tLSBBZGQgZmluYWwgYml0KHMp IHRvIGVuZCBvZiAxNiBiaXRzIGNoZWNrZWQKIGMtLS0gTm93IGFwcGVuZCBhbnkgemVybyBiaXRz IHNoaWZ0ZWQgb3V0IG9yaWdpbmFsbHkK