146647 2006-09-06 22:42 0000 migrate dev-libs/cyrus-sasl-2.1.22 to generation-2 2007-02-03 15:07:58 0000 1 1 1 Unclassified Gentoo Linux Ebuilds unspecified All Linux RESOLVED FIXED P2 enhancement --- 1 alonbl@gentoo.org net-mail@gentoo.org java@gentoo.org alonbl@gentoo.org 2006-09-06 22:42:04 0000 cyrus-sasl-2.1.22 forces jdk-1.4, while there is no need to. You should force >=jdk-1.4 for stable, so people may use jdk-1.5. But better migrate to the new java build system and allow >=jdk-1.4 alonbl@gentoo.org 2006-09-06 22:56:51 0000 Created an attachment (id=96248) cyrus-sasl-2.1.22.ebuild.diff using generation 2 java eclass langthang@gentoo.org 2006-09-07 16:13:07 0000 (In reply to comment #0) > cyrus-sasl-2.1.22 forces jdk-1.4, while there is no need to. > You should force >=jdk-1.4 for stable, so people may use jdk-1.5. > > But better migrate to the new java build system and allow >=jdk-1.4 > I don't know if your modification would work for both java generation. CC java team for comment. alonbl@gentoo.org 2006-09-07 16:48:33 0000 For generation-22 I supply the attachment#96248. The problem is that the generation-2 is not stable. Since your package is stable, just add the right dependency >=jdk-1.4. It is working with generation-1 if the user have jdk-1.5 configured as generation one. And it does not hurt the current users. alonbl@gentoo.org 2006-09-07 16:49:26 0000 Created an attachment (id=96338) cyrus-sasl-2.1.22.ebuild.diff - generation-1 This is for generation-1 (stable) alonbl@gentoo.org 2006-09-07 16:50:03 0000 (From update of attachment 96248) This is for generation-2 (unstable) langthang@gentoo.org 2006-09-07 17:02:12 0000 $ earch jdk-1.4.1: jdk-1.4.2: ppc amd64 ppc64 ia64 x86 jdk-1.5.0: ~amd64 ~x86 ~x86-fbsd ~ia64 ~ppc ~ppc64 ~s390 virtual/jdk-1.4 is not stable on any arch yet. how about I do a revision bump for generation-2 and leave the stable ebuild alone? caster@gentoo.org 2006-09-07 17:19:48 0000 Patch from comment 4 would slightly improve the deps for stable ebuild so that user doesn't need a JDK for runtime where JRE is enough. Changing '=' to '>=' doesn't really mean anything for generation-1 ebuild. For the future we will of course want revision bump migrated to generation-2 but not the one from comment 5. Just looking at it I see "use java && java-pkg-opt-2_pkg_setup" - this is not how it should be done. I will see about a proper gen-2 ebuild tomorrow. alonbl@gentoo.org 2006-09-07 17:28:43 0000 (In reply to comment #6) > virtual/jdk-1.4 is not stable on any arch yet. how about I do a revision bump > for generation-2 and leave the stable ebuild alone? That would be great! alonbl@gentoo.org 2006-09-07 17:37:50 0000 (In reply to comment #7) > Patch from comment 4 would slightly improve the deps for stable ebuild so that > user doesn't need a JDK for runtime where JRE is enough. Changing '=' to '>=' > doesn't really mean anything for generation-1 ebuild. It does... Since we can modify jdk-1.5 to be generation-1 and then have only one jvm on your machine. If there is no explicit reason why support only 1.4, I don't see why explicit downgrade. > For the future we will of course want revision bump migrated to generation-2 > but not the one from comment 5. Just looking at it I see "use java && > java-pkg-opt-2_pkg_setup" - this is not how it should be done. I will see about > a proper gen-2 ebuild tomorrow. OK... Thanks... And then it needs to be documented why it is wrong... Since from http://www.gentoo.org/proj/en/java/java-devel.xml I cannot understand why. nichoj@gentoo.org 2006-09-07 21:20:24 0000 (In reply to comment #9) > OK... Thanks... And then it needs to be documented why it is wrong... Since > from http://www.gentoo.org/proj/en/java/java-devel.xml I cannot understand why. > It is already documented how to use optional java support. There is even an example of it. http://www.gentoo.org/proj/en/java/java-devel.xml#java-pkg-opt-2.eclass example under 'Typical Examples' nichoj@gentoo.org 2006-09-07 21:23:26 0000 As for why not to do use java && java-pkg-opt-2_pkg_setup, java-pkg-opt-2_pkg_setup already does the appropriate conditional for you. The docs actually should mention that the java-pkg-2's pkg_setup does need to be called if you override the default pkg_setup. Separate issue (ie new bug) for that though. alonbl@gentoo.org 2006-09-15 00:32:00 0000 Created an attachment (id=97033) cyrus-sasl-2.1.22.ebuild.diff - generation-2 This is modified generation-2, without use java && Please approve. alonbl@gentoo.org 2006-09-15 00:35:32 0000 (In reply to comment #11) > The docs actually should mention that the java-pkg-2's pkg_setup does need to > be called if you override the default pkg_setup. Separate issue (ie new bug) > for that though. Will you fix documentation, open a bug to your-self, or wish someone else to open bug for this? caster@gentoo.org 2006-09-20 14:58:04 0000 Created an attachment (id=97579) patch for generation 2 revbumped ebuild Aside from the usual stuff it was needed to pass the right JAVACFLAGS to ensure 1.4 bytecode for the .jar produced. Because this buildsystem doesn't seem to have a way to pass flags for JAVAC separately, I was forced to stick them to the JAVAC variable, which is honored. Seems to work fine. alonbl@gentoo.org 2006-10-21 03:14:55 0000 Reminder: java generation 2 is stable, can fix this. alonbl@gentoo.org 2006-10-30 21:23:34 0000 Please... At least correct dependency for generation 1. caster@gentoo.org 2006-10-31 01:08:01 0000 Yeah, you could revbump with patch from comment 14, please. alonbl@gentoo.org 2006-12-11 13:39:15 0000 PPPPPlease.... please revbump. alonbl@gentoo.org 2007-01-02 12:45:59 0000 Hello? Is there anyone here? ticho@gentoo.org 2007-01-02 13:21:47 0000 (In reply to comment #17) > Yeah, you could revbump with patch from comment 14, please. > Why does the path remove java from IUSE, yet it continues to use the flag in (R)DEPEND ? ticho@gentoo.org 2007-01-02 13:22:24 0000 (In reply to comment #20) > (In reply to comment #17) > > Yeah, you could revbump with patch from comment 14, please. > > > > Why does the path remove java from IUSE, yet it continues to use the flag in > (R)DEPEND ? > s/path/patch/, obviously, sorry about that. alonbl@gentoo.org 2007-01-02 13:32:12 0000 Look at java-pkg-opt-2.eclass: JAVA_PKG_OPT_USE=${JAVA_PKG_OPT_USE:-java} IUSE="${JAVA_PKG_OPT_USE}" alonbl@gentoo.org 2007-01-16 19:37:02 0000 This should not be difficult to close... Any reason why leave this open so much time? alonbl@gentoo.org 2007-02-03 15:07:58 0000 OK. Finish waiting. Fixed QA issues and upgraded to new java build. CC me if anyone have problem with this modification. 96248 2006-09-06 22:56 0000 cyrus-sasl-2.1.22.ebuild.diff - generation-2 cyrus-sasl-2.1.22.ebuild.diff text/plain LS0tIGN5cnVzLXNhc2wtMi4xLjIyLmVidWlsZAkyMDA2LTA5LTA2IDIxOjM1OjQ2LjAwMDAwMDAw MCArMDMwMAorKysgY3lydXMtc2FzbC0yLjEuMjIuZWJ1aWxkCTIwMDYtMDktMDcgMDg6NTI6MzYu MDAwMDAwMDAwICswMzAwCkBAIC0yLDcgKzIsNyBAQAogIyBEaXN0cmlidXRlZCB1bmRlciB0aGUg dGVybXMgb2YgdGhlIEdOVSBHZW5lcmFsIFB1YmxpYyBMaWNlbnNlIHYyCiAjICRIZWFkZXI6IC92 YXIvY3Zzcm9vdC9nZW50b28teDg2L2Rldi1saWJzL2N5cnVzLXNhc2wvY3lydXMtc2FzbC0yLjEu MjIuZWJ1aWxkLHYgMS4xMCAyMDA2LzA5LzA2IDE4OjMxOjA3IHRzdW5hbSBFeHAgJAogCi1pbmhl cml0IGV1dGlscyBnbnVjb25maWcgZmxhZy1vLW1hdGljIGphdmEtcGtnIG11bHRpbGliCitpbmhl cml0IGV1dGlscyBnbnVjb25maWcgZmxhZy1vLW1hdGljIGphdmEtcGtnLW9wdC0yIG11bHRpbGli CiAKIG50bG1fcGF0Y2g9JHtQfS1udGxtX2ltcGwtc3BuZWdvLnBhdGNoLmd6CiBTQVNMQVVUSERf Q09ORl9WRVI9Mi4xLjIxCkBAIC0zNCwxOCArMzQsMTkgQEAgUkRFUEVORD0idmlydHVhbC9saWJj CiAJCQk+PW1haWwtbXRhL2NvdXJpZXItMC40NgogCQkpCiAJKQotCWphdmE/ICggPXZpcnR1YWwv amRrLTEuNCogKQorCWphdmE/ICggPj12aXJ0dWFsL2pyZS0xLjQgKQogCW50bG1fdW5zdXBwb3J0 ZWRfcGF0Y2g/ICggPj1uZXQtZnMvc2FtYmEtMy4wLjkgKSIKIAogREVQRU5EPSIke1JERVBFTkR9 CiAJPj1zeXMtYXBwcy9zZWQtNAogCT49c3lzLWRldmVsL2F1dG9jb25mLTIuNTgKIAlzeXMtZGV2 ZWwvYXV0b21ha2UKLQlzeXMtZGV2ZWwvbGlidG9vbCIKKwlzeXMtZGV2ZWwvbGlidG9vbAorCWph dmE/ICggPj12aXJ0dWFsL2pkay0xLjQgKSIKIAogcGtnX3NldHVwKCkgewogCi0JdXNlIGphdmEg JiYgamF2YS1wa2dfcGtnX3NldHVwCisJdXNlIGphdmEgJiYgamF2YS1wa2ctb3B0LTJfcGtnX3Nl dHVwCiAKIAlpZiB1c2UgZ2RibSAmJiB1c2UgYmVya2RiOyB0aGVuCiAJCWVjaG8K 96338 2006-09-07 16:49 0000 cyrus-sasl-2.1.22.ebuild.diff - generation-1 cyrus-sasl-2.1.22.ebuild.diff text/plain LS0tIGN5cnVzLXNhc2wtMi4xLjIyLmVidWlsZAkyMDA2LTA5LTA2IDIxOjM1OjQ2LjAwMDAwMDAw MCArMDMwMAorKysgY3lydXMtc2FzbC0yLjEuMjIuZWJ1aWxkCTIwMDYtMDktMDcgMDg6NTc6MDQu MDAwMDAwMDAwICswMzAwCkBAIC0zNCwxNCArMzQsMTUgQEAgUkRFUEVORD0idmlydHVhbC9saWJj CiAJCQk+PW1haWwtbXRhL2NvdXJpZXItMC40NgogCQkpCiAJKQotCWphdmE/ICggPXZpcnR1YWwv amRrLTEuNCogKQorCWphdmE/ICggPj12aXJ0dWFsL2pyZS0xLjQgKQogCW50bG1fdW5zdXBwb3J0 ZWRfcGF0Y2g/ICggPj1uZXQtZnMvc2FtYmEtMy4wLjkgKSIKIAogREVQRU5EPSIke1JERVBFTkR9 CiAJPj1zeXMtYXBwcy9zZWQtNAogCT49c3lzLWRldmVsL2F1dG9jb25mLTIuNTgKIAlzeXMtZGV2 ZWwvYXV0b21ha2UKLQlzeXMtZGV2ZWwvbGlidG9vbCIKKwlzeXMtZGV2ZWwvbGlidG9vbAorCWph dmE/ICggPj12aXJ0dWFsL2pkay0xLjQgKSIKIAogcGtnX3NldHVwKCkgewogCg== 97033 2006-09-15 00:32 0000 cyrus-sasl-2.1.22.ebuild.diff - generation-2 cyrus-sasl-2.1.22.ebuild.diff text/plain LS0tIGN5cnVzLXNhc2wtMi4xLjIyLmVidWlsZAkyMDA2LTA5LTA2IDIxOjM1OjQ2LjAwMDAwMDAw MCArMDMwMAorKysgY3lydXMtc2FzbC0yLjEuMjIuZWJ1aWxkCTIwMDYtMDktMDcgMDg6NTI6MzYu MDAwMDAwMDAwICswMzAwCkBAIC0yLDcgKzIsNyBAQAogIyBEaXN0cmlidXRlZCB1bmRlciB0aGUg dGVybXMgb2YgdGhlIEdOVSBHZW5lcmFsIFB1YmxpYyBMaWNlbnNlIHYyCiAjICRIZWFkZXI6IC92 YXIvY3Zzcm9vdC9nZW50b28teDg2L2Rldi1saWJzL2N5cnVzLXNhc2wvY3lydXMtc2FzbC0yLjEu MjIuZWJ1aWxkLHYgMS4xMCAyMDA2LzA5LzA2IDE4OjMxOjA3IHRzdW5hbSBFeHAgJAogCi1pbmhl cml0IGV1dGlscyBnbnVjb25maWcgZmxhZy1vLW1hdGljIGphdmEtcGtnIG11bHRpbGliCitpbmhl cml0IGV1dGlscyBnbnVjb25maWcgZmxhZy1vLW1hdGljIGphdmEtcGtnLW9wdC0yIG11bHRpbGli CiAKIG50bG1fcGF0Y2g9JHtQfS1udGxtX2ltcGwtc3BuZWdvLnBhdGNoLmd6CiBTQVNMQVVUSERf Q09ORl9WRVI9Mi4xLjIxCkBAIC0zNCwxOCArMzQsMTkgQEAgUkRFUEVORD0idmlydHVhbC9saWJj CiAJCQk+PW1haWwtbXRhL2NvdXJpZXItMC40NgogCQkpCiAJKQotCWphdmE/ICggPXZpcnR1YWwv amRrLTEuNCogKQorCWphdmE/ICggPj12aXJ0dWFsL2pyZS0xLjQgKQogCW50bG1fdW5zdXBwb3J0 ZWRfcGF0Y2g/ICggPj1uZXQtZnMvc2FtYmEtMy4wLjkgKSIKIAogREVQRU5EPSIke1JERVBFTkR9 CiAJPj1zeXMtYXBwcy9zZWQtNAogCT49c3lzLWRldmVsL2F1dG9jb25mLTIuNTgKIAlzeXMtZGV2 ZWwvYXV0b21ha2UKLQlzeXMtZGV2ZWwvbGlidG9vbCIKKwlzeXMtZGV2ZWwvbGlidG9vbAorCWph dmE/ICggPj12aXJ0dWFsL2pkay0xLjQgKSIKIAogcGtnX3NldHVwKCkgewogCi0JdXNlIGphdmEg JiYgamF2YS1wa2dfcGtnX3NldHVwCisJamF2YS1wa2ctb3B0LTJfcGtnX3NldHVwCiAKIAlpZiB1 c2UgZ2RibSAmJiB1c2UgYmVya2RiOyB0aGVuCiAJCWVjaG8K 97579 2006-09-20 14:58 0000 patch for generation 2 revbumped ebuild cyrus-sasl-2.1.22-r1.ebuild.patch text/plain LS0tIGN5cnVzLXNhc2wtMi4xLjIyLmVidWlsZAkyMDA2LTA5LTE5IDAwOjEzOjQwLjAwMDAwMDAw MCArMDIwMAorKysgY3lydXMtc2FzbC0yLjEuMjItcjEuZWJ1aWxkCTIwMDYtMDktMjAgMjI6MDg6 NDUuMDAwMDAwMDAwICswMjAwCkBAIC0yLDcgKzIsNyBAQAogIyBEaXN0cmlidXRlZCB1bmRlciB0 aGUgdGVybXMgb2YgdGhlIEdOVSBHZW5lcmFsIFB1YmxpYyBMaWNlbnNlIHYyCiAjICRIZWFkZXI6 IC92YXIvY3Zzcm9vdC9nZW50b28teDg2L2Rldi1saWJzL2N5cnVzLXNhc2wvY3lydXMtc2FzbC0y LjEuMjIuZWJ1aWxkLHYgMS4xMiAyMDA2LzA5LzE2IDIxOjA3OjU5IHZhcGllciBFeHAgJAogCi1p bmhlcml0IGV1dGlscyBnbnVjb25maWcgZmxhZy1vLW1hdGljIGphdmEtcGtnIG11bHRpbGliCitp bmhlcml0IGV1dGlscyBnbnVjb25maWcgZmxhZy1vLW1hdGljIG11bHRpbGliIGphdmEtcGtnLW9w dC0yCiAKIG50bG1fcGF0Y2g9JHtQfS1udGxtX2ltcGwtc3BuZWdvLnBhdGNoLmd6CiBTQVNMQVVU SERfQ09ORl9WRVI9Mi4xLjIxCkBAIC0xNiw3ICsxNiw3IEBACiBTTE9UPSIyIgogS0VZV09SRFM9 In5hbHBoYSBhbWQ2NCBhcm0gfmhwcGEgfmlhNjQgbWlwcyBwcGMgcHBjNjQgczM5MCBzaCBzcGFy YyB4ODYgfng4Ni1mYnNkIgogIyBSZW1vdmVkICdzdGF0aWMnIFVTRSBmbGFnIGJlY2F1c2UgaXQg aXMgYnJva2VuIHVwc3RyZWFtLCBCdWcgIzk0MTM3Ci1JVVNFPSJiZXJrZGIgY3J5cHQgZ2RibSBs ZGFwIG15c3FsIHBvc3RncmVzIGtlcmJlcm9zIHNzbCBqYXZhIHBhbSBhdXRoZGFlbW9uZCBzYW1w bGUgdXJhbmRvbSBzcnAgbnRsbV91bnN1cHBvcnRlZF9wYXRjaCIKK0lVU0U9ImJlcmtkYiBjcnlw dCBnZGJtIGxkYXAgbXlzcWwgcG9zdGdyZXMga2VyYmVyb3Mgc3NsIHBhbSBhdXRoZGFlbW9uZCBz YW1wbGUgdXJhbmRvbSBzcnAgbnRsbV91bnN1cHBvcnRlZF9wYXRjaCIKIAogUkRFUEVORD0iYmVy a2RiPyAoID49c3lzLWxpYnMvZGItMy4yICkKIAlnZGJtPyAoID49c3lzLWxpYnMvZ2RibS0xLjgu MCApCkBAIC0zMiwxOCArMzIsMTYgQEAKIAkJCT49bWFpbC1tdGEvY291cmllci0wLjQ2CiAJCSkK IAkpCi0JamF2YT8gKCA9dmlydHVhbC9qZGstMS40KiApCisJamF2YT8gKCA+PXZpcnR1YWwvanJl LTEuNCApCiAJbnRsbV91bnN1cHBvcnRlZF9wYXRjaD8gKCA+PW5ldC1mcy9zYW1iYS0zLjAuOSAp IgogREVQRU5EPSIke1JERVBFTkR9CiAJPj1zeXMtYXBwcy9zZWQtNAogCT49c3lzLWRldmVsL2F1 dG9jb25mLTIuNTgKIAlzeXMtZGV2ZWwvYXV0b21ha2UKLQlzeXMtZGV2ZWwvbGlidG9vbCIKKwlz eXMtZGV2ZWwvbGlidG9vbAorCWphdmE/ICggPj12aXJ0dWFsL2pkay0xLjQgKSIKIAogcGtnX3Nl dHVwKCkgewotCi0JdXNlIGphdmEgJiYgamF2YS1wa2dfcGtnX3NldHVwCi0KIAlpZiB1c2UgZ2Ri bSAmJiB1c2UgYmVya2RiOyB0aGVuCiAJCWVjaG8KIAkJZXdhcm4gIllvdSBoYXZlIGJvdGggXCJn ZGJtXCIgYW5kIFwiYmVya2RiXCIgaW4geW91ciBVU0UgZmxhZ3MuIgpAQCAtNjcsNyArNjUsNiBA QAogc3JjX3VucGFjaygpIHsKIAl1bnBhY2sgJHtBfSAmJiBjZCAiJHtTfSIKIAotCiAJIyBGaXgg ZGVmYXVsdCBwb3J0IG5hbWUgZm9yIHJpbWFwIGF1dGggbWVjaGFuaXNtLgogCXNlZCAtZSAnL2Rl ZmluZSBERUZBVUxUX1JFTU9URV9TRVJWSUNFL3M6aW1hcDppbWFwMjonIFwKIAkJLWkgc2FzbGF1 dGhkL2F1dGhfcmltYXAuYyB8fCBkaWUgInNlZCBmYWlsZWQiCkBAIC0xMTUsNiArMTEyLDggQEAK IH0KIAogc3JjX2NvbXBpbGUoKSB7CisJdXNlIGphdmEgJiYgZXhwb3J0IEpBVkFDPSIke0pBVkFD fSAke0pBVkFDRkxBR1N9IgorCiAJbG9jYWwgbXljb25mPSItLWVuYWJsZS1sb2dpbiAtLWVuYWJs ZS1udGxtIC0tZW5hYmxlLWF1dGgtc2FzbGRiIC0tZGlzYWJsZS1rcmI0IC0tZGlzYWJsZS1vdHAi CiAjCW15Y29uZj0iJHtteWNvbmZ9IGB1c2VfZW5hYmxlIHN0YXRpY2AiIC0tIGRvZXNuJ3Qgd29y ayB1cHN0cmVhbSBCdWcgIzk0MTM3CiAJbXljb25mPSIke215Y29uZn0gYHVzZV93aXRoIHNzbCBv cGVuc3NsYCIKQEAgLTIxNywxMCArMjE2LDEwIEBACiAJCXJtIC1yZiAiJHtEfS91c3IvJChnZXRf bGliZGlyKS9qYXZhIgogCQlkb2NpbnRvIGphdmEKIAkJZG9kb2MgIiR7U30vamF2YS9SRUFETUUi ICIke0ZJTEVTRElSfS9qYXZhLlJFQURNRS5nZW50b28iICIke1N9Ii9qYXZhL2RvYy8qCi0JCW1r ZGlyICIke0R9L3Vzci9zaGFyZS9kb2MvJHtQRn0vamF2YS9UZXN0LyIgXAotCQkJfHwgZGllICJm YWlsZWQgdG8gY3JlYXRlICR7RH0vdXNyL3NoYXJlL2RvYy8ke1BGfS9qYXZhL1Rlc3QvIgorCQlk b2RpciAvdXNyL3NoYXJlL2RvYy8ke1BGfS9qYXZhL1Rlc3QKIAkJY3AgIiR7U30iL2phdmEvVGVz dC8qLmphdmEgIiR7RH0vdXNyL3NoYXJlL2RvYy8ke1BGfS9qYXZhL1Rlc3QvIiBcCiAJCQl8fCBk aWUgImZhaWxlZCB0byBjb3B5IGphdmEgZmlsZXMgdG8gJHtEfS91c3Ivc2hhcmUvZG9jLyR7UEZ9 L2phdmEvVGVzdC8iCisJCWphdmEtcGtnX3JlZ3NvICIke0R9L3Vzci8kKGdldF9saWJkaXIpL2xp YmphdmFzYXNsLnNvIgogCWZpCiAKIAlkb2NpbnRvICIiCg==