146316 2006-09-04 14:32 0000 dev-libs/openssl-0.9.8b uses installed headers to build 2007-09-30 12:08:55 0000 1 1 1 Unclassified Gentoo/Alt FreeBSD unspecified All FreeBSD RESOLVED FIXED P2 normal --- 176058 1 flameeyes@gentoo.org base-system@gentoo.org bsd@gentoo.org jakub@gentoo.org flameeyes@gentoo.org 2006-09-04 14:32:58 0000 This seems to be true on both Linux and FreeBSD. I'm not sure while that don't break on Linux x86 (maybe size_t there is 32-bit?), but it does break on FreeBSD x86 at least, as sizeof(unsigned long) != sizeof(size_t), thus the old and the new prototype are actually incompatible: i686-gentoo-freebsd6.1-ar r ../../libcrypto.a sha_dgst.o sha1dgst.o sha_one.o sha1_one.o sha256.o sha512.o sx86-elf.o i686-gentoo-freebsd6.1-ranlib ../../libcrypto.a || echo Never mind. gmake[2]: Leaving directory `/var/tmp/portage/openssl-0.9.8b/work/openssl-0.9.8b/crypto/sha' making all in crypto/mdc2... gmake[2]: Entering directory `/var/tmp/portage/openssl-0.9.8b/work/openssl-0.9.8b/crypto/mdc2' gmake[2]: warning: jobserver unavailable: using -j1. Add `+' to parent make rule. gcc -I.. -I../.. -I../../include -fPIC -DOPENSSL_PIC -DZLIB_SHARED -DZLIB -DOPENSSL_THREADS -pthread -D_THREAD_SAFE -D_REENTRANT -DDSO_DLFCN -DHAVE_DLFCN_H -DL_ENDIAN -DTERMIOS -Wall -DOPENSS L_BN_ASM_PART_WORDS -DSHA1_ASM -DMD5_ASM -DRMD160_ASM -DAES_ASM -O2 -march=athlon-tbird -ggdb -fno-inline -Wa,--noexecstack -c -o mdc2dgst.o mdc2dgst.c mdc2dgst.c:88: error: conflicting types for 'MDC2_Update' /usr/include/openssl/mdc2.h:87: error: previous declaration of 'MDC2_Update' was here distcc[79672] ERROR: compile mdc2dgst.c on farragut failed gmake[2]: *** [mdc2dgst.o] Error 1 gmake[2]: Leaving directory `/var/tmp/portage/openssl-0.9.8b/work/openssl-0.9.8b/crypto/mdc2' gmake[1]: *** [subdirs] Error 1 gmake[1]: Leaving directory `/var/tmp/portage/openssl-0.9.8b/work/openssl-0.9.8b/crypto' gmake: *** [build_crypto] Error 1 trying to add -I. to INCLUDES seems not to work (don't appear on the command line). flameeyes@gentoo.org 2006-09-04 14:41:45 0000 From crypto/mdc2/mdc2dgst.c: #include <openssl/des.h> #include <openssl/mdc2.h> Not only it uses the installed copy, but it's likely to die if I try to build it without OpenSSL already installed, too (not that I can try right now, wouldn't like cutting myself out of ssh). flameeyes@gentoo.org 2006-09-05 15:24:35 0000 Created an attachment (id=96119) openssl-0.9.8-build.patch The problem seems to be that the ./Configure stage fails during run of "make links" (on both my Linux and FreeBSD boxes), so it has to be ran by hand to make sure that the links are created. The attached patch solves the issue (and updates the config script to work for the new FreeBSD target names). vapier@gentoo.org 2006-09-05 22:02:05 0000 ive committed the gentoo.config updates vapier@gentoo.org 2006-09-05 22:11:34 0000 Configure runs the 'links' target just fine on my linux machine the_paya@gentoo.org 2006-09-16 13:30:03 0000 Created an attachment (id=97176) openssl-0.9.8c-gmake.patch the Configure perl script runs 'make depend' which 'partially' works in bsd. As the depend target also runs the links target, the latter gets 'correctly' run until it reaches the first subdir of the crypto/ directory (crypto/objects) where it first fails. After this, by running emake depend again, it doesn't see the missing 'links' targets as the first one (crypto/) was already run. The patch just changes 'make depend' in Configure for 'gmake depend'. the_paya@gentoo.org 2006-09-16 14:25:12 0000 Created an attachment (id=97182) gentoo-config.patch This one corrects the build system for freebsd in the gentoo.config script. vapier@gentoo.org 2006-09-16 23:34:26 0000 why does it fail ? vapier@gentoo.org 2006-09-16 23:35:06 0000 (From update of attachment 97182) merged the_paya@gentoo.org 2006-09-17 03:42:48 0000 (In reply to comment #7) > why does it fail ? > It fails exactly like this: http://www.nabble.com/crypt-des-dx86-out.s-fails-on-NetBSD-p202913.html vapier@gentoo.org 2006-09-17 23:22:25 0000 that isnt what i meant why does the current make system not run the links targets properly uberlord@gentoo.org 2007-02-27 16:11:25 0000 Created an attachment (id=111431) Don't set TOP when making links Further analysis shows that something in the chain is clobbering TOP. As to where or why I still don't know, but it ONLY gets clobbered when make is called from the ebuild - on the command line it works just fine. This patch stops TOP being set on the links target. vapier@gentoo.org 2007-06-22 02:38:09 0000 maybe something specific to BSD ? going by Diego's comment #1, doing: # rm -rf /usr/include/openssl # emerge openssl works for me in Linux with 0.9.8e ... uberlord@gentoo.org 2007-08-08 13:22:50 0000 If so I have no idea where. swapping /bin/sh to be bash and using gmake still results in a failure to make the links target when used in portage. Even if we rm /usr/include/openssl, the links target fails to build because it once it goes down a directory it cannot use $TOP correctly in the Makefile for whatever reason. This line is the one in question though $(CLEARENV) && $(MAKE) -e $(BUILDENV) TOP=.. DIR=$$dir $$target Just the act of removing TOP makes it work - and this is ONLY necessary inside portage environment. uberlord@gentoo.org 2007-08-08 13:57:00 0000 sed -i -e 's/TOP=\.\.//g' Makefile.org Adding that to src_unpack fixes things for us quite nicely. uberlord@gentoo.org 2007-08-08 15:55:54 0000 Or, just unset MAKE Portage - or something - is setting MAKE to gmake and this is the root cause. So either 1) we unset MAKE in the openssl ebuild before Configure 2) Stop portage from forcing MAKE env var on ebuilds Why does portage export MAKE anyway? Don't we have configure autotool foo for that anyway? uberlord@gentoo.org 2007-08-08 16:07:23 0000 (In reply to comment #15) > Or, just unset MAKE > Portage - or something - is setting MAKE to gmake and this is the root cause. Turns out it's the FreeBSD profile that's setting it :/ Let's see if we can punt that now vapier@gentoo.org 2007-08-08 23:47:42 0000 i'm 99% sure you cant punt that ... the default `make` invokes the BSD make which does not support GNU extensions which is what many packages require dostrow hooked me up with a shell account on a bsd box so i can actually research this now :P uberlord@gentoo.org 2007-08-09 06:40:43 0000 Yeah, I realise that :P One solution I'm currently working on is this getting emake to default to gmake, if gmake is available otherwise make. vapier@gentoo.org 2007-08-10 04:30:09 0000 i really dont think that's the solution either what may work though is something like: exec env -uMAKE ${MAKE:-make} ${MAKEOPTS} ${EXTRA_EMAKE} "$@" otherwise i'll dig through the build system and see why MAKE isnt properly being incremented when MAKE is set in the env vapier@gentoo.org 2007-09-30 12:08:55 0000 it seems to stem from the fact that the links target is executed by the perl Configure script and it starts off by executing `make`, not $MAKE, and certainly not `emake` you can reproduce this by unpacking the openssl tarball on a BSD box, exporting MAKE to gmake, and then running the Configure script followed by `make links` doing `gmake links` or `$MAKE links` works just peachy so the correct fix here is to change the Configure perl script to execute `$ENV{'MAKE'}` rather than `make` by default ... ive added this to openssl-0.9.8e-r3, so re-open the bug if that version does not work for you 96119 2006-09-05 15:24 0000 openssl-0.9.8-build.patch openssl-0.9.8-build.patch text/plain SW5kZXg6IG9wZW5zc2wtMC45LjhjLmVidWlsZAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09ClJDUyBmaWxlOiAvdmFyL2N2 c3Jvb3QvZ2VudG9vLXg4Ni9kZXYtbGlicy9vcGVuc3NsL29wZW5zc2wtMC45LjhjLmVidWlsZCx2 CnJldHJpZXZpbmcgcmV2aXNpb24gMS40CmRpZmYgLXUgLUIgLXIxLjQgb3BlbnNzbC0wLjkuOGMu ZWJ1aWxkCi0tLSBvcGVuc3NsLTAuOS44Yy5lYnVpbGQJNSBTZXAgMjAwNiAxOToxNzozNSAtMDAw MAkxLjQKKysrIG9wZW5zc2wtMC45LjhjLmVidWlsZAk1IFNlcCAyMDA2IDIyOjIzOjE5IC0wMDAw CkBAIC0xMCw3ICsxMCw3IEBACiAKIExJQ0VOU0U9Im9wZW5zc2wiCiBTTE9UPSIwIgotS0VZV09S RFM9Ii0qIGFscGhhIGFtZDY0IH5taXBzIH5wcGMgcHBjNjQgfnNwYXJjIH54ODYiCitLRVlXT1JE Uz0iLSogYWxwaGEgYW1kNjQgfm1pcHMgfnBwYyBwcGM2NCB+c3BhcmMgfng4NiB+eDg2LWZic2Qi CiBJVVNFPSJlbWFjcyB0ZXN0IGJpbmRpc3QgemxpYiIKIAogUkRFUEVORD0iIgpAQCAtOTksNiAr OTksNyBAQAogCiAJIyBkZXBlbmQgaXMgbmVlZGVkIHRvIHVzZSAkY29uZm9wdHMKIAkjIHJlaGFz aCBpcyBuZWVkZWQgdG8gcHJlcCB0aGUgY2VydHMvIGRpcgorCWVtYWtlIC1qMSBsaW5rcyB8fCBk aWUgIm1ha2UgbGlua3MgZmFpbGVkIgogCWVtYWtlIC1qMSBkZXBlbmQgfHwgZGllICJkZXBlbmQg ZmFpbGVkIgogCWVtYWtlIGFsbCByZWhhc2ggfHwgZGllICJtYWtlIGFsbCBmYWlsZWQiCiAKSW5k ZXg6IGZpbGVzL2dlbnRvby5jb25maWctMC45LjgKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQpSQ1MgZmlsZTogL3Zhci9j dnNyb290L2dlbnRvby14ODYvZGV2LWxpYnMvb3BlbnNzbC9maWxlcy9nZW50b28uY29uZmlnLTAu OS44LHYKcmV0cmlldmluZyByZXZpc2lvbiAxLjYKZGlmZiAtdSAtQiAtcjEuNiBnZW50b28uY29u ZmlnLTAuOS44Ci0tLSBmaWxlcy9nZW50b28uY29uZmlnLTAuOS44CTIgU2VwIDIwMDYgMDA6MTk6 MDkgLTAwMDAJMS42CisrKyBmaWxlcy9nZW50b28uY29uZmlnLTAuOS44CTUgU2VwIDIwMDYgMjI6 MjM6MTkgLTAwMDAKQEAgLTE3LDEwICsxNywxMCBAQAogCQkiYXJtdjViLWxpbnV4LWdudSAgICAg ICAgICAgICB8bGludXgtZ2VuZXJpYzMyIC1EQl9FTkRJQU4iIFwKIAkJIng4Nl82NC1wYy1saW51 eC1nbnUgICAgICAgICAgfGxpbnV4LXg4Nl82NCIgXAogCQkiYWxwaGFldjU2LXVua25vd24tbGlu dXgtZ251ICB8bGludXgtYWxwaGErYnd4LWdjYyIgXAotCQkid2hhdGV2ZXItZ2VudG9vLWZyZWVi c2RYLlkgICB8RnJlZUJTRC1lbGYiIFwKLQkJInNwYXJjNjQtYWxwaGEtZnJlZWJzZFguWSAgICAg fEZyZWVCU0Qtc3BhcmM2NCIgXAotCQkiaWE2NC1nZW50b28tZnJlZWJzZDUuOTkyMzQgICB8RnJl ZUJTRC1pYTY0IiBcCi0JCSJ4ODZfNjQtZ2VudG9vLWZyZWVic2RYLlkgICAgIHxGcmVlQlNELWFt ZDY0IiBcCisJCSJ3aGF0ZXZlci1nZW50b28tZnJlZWJzZFguWSAgIHxCU0QtZ2VuZXJpYzMyIiBc CisJCSJzcGFyYzY0LWFscGhhLWZyZWVic2RYLlkgICAgIHxCU0Qtc3BhcmM2NCIgXAorCQkiaWE2 NC1nZW50b28tZnJlZWJzZDUuOTkyMzQgICB8QlNELWlhNjQiIFwKKwkJIng4Nl82NC1nZW50b28t ZnJlZWJzZFguWSAgICAgfEJTRC14ODZfNjQiIFwKIAkJImhwcGE2NC1hbGRzRi1saW51eC1nbnU1 LjMgICAgfGxpbnV4LXBhcmlzYyIgXAogCQkicG93ZXJwYy1nZW50T08tbGludXgtdWNsaWJjICB8 bGludXgtcHBjIiBcCiAJCSJwb3dlcnBjNjQtdW5rLWxpbnV4LWdudSAgICAgIHxsaW51eC1wcGM2 NCIgXApAQCAtNDUsNyArNDUsNyBAQAogIyBEZXRlY3QgdGhlIG9wZXJhdGluZyBzeXN0ZW0KIGNh c2UgJHtDSE9TVH0gaW4KIAkqLWxpbnV4KikgICAgc3lzdGVtPSJsaW51eCI7OwotCSotZnJlZWJz ZCopICBzeXN0ZW09IkZyZWVCU0QiOzsKKwkqLWZyZWVic2QqKSAgc3lzdGVtPSJCU0QiOzsKIAkq KSAgICAgICAgICAgZXhpdCAwOzsKIGVzYWMKIApAQCAtOTMsOSArOTMsMTAgQEAKIAljYXNlICR7 Y2hvc3RfbWFjaGluZX0gaW4KIAkJc3BhcmM2NCopICAgICBtYWNoaW5lPXNwYXJjNjQ7OwogCQlp YTY0KikgICAgICAgIG1hY2hpbmU9aWE2NDs7Ci0JCWFscGhhKikgICAgICAgbWFjaGluZT1hbHBo YTs7Ci0JCXg4Nl82NCopICAgICAgbWFjaGluZT1hbWQ2NDs7Ci0JCSopICAgICAgICAgICAgbWFj aGluZT1lbGY7OworCQlhbHBoYSopICAgICAgIG1hY2hpbmU9Z2VuZXJpYzY0OzsKKwkJeDg2XzY0 KikgICAgICBtYWNoaW5lPXg4Nl82NDs7CisJCWlbNi05XTg2KikgICAgbWFjaGluZT14ODY7Owor CQkqKSAgICAgICAgICAgIG1hY2hpbmU9Z2VuZXJpYzMyOzsKIAllc2FjCiAJOzsKIGVzYWMK 97176 2006-09-16 13:30 0000 openssl-0.9.8c-gmake.patch openssl-0.9.8c-gmake.patch text/plain LS0tIG9wZW5zc2wtMC45LjhjL0NvbmZpZ3VyZS5vcmlnCTIwMDYtMDktMTYgMTc6MDA6MzggLTAz MDAKKysrIG9wZW5zc2wtMC45LjhjL0NvbmZpZ3VyZQkyMDA2LTA5LTE2IDE3OjAwOjUxIC0wMzAw CkBAIC0xNTU0LDcgKzE1NTQsNyBAQAogRU9GCiAJY2xvc2UoT1VUKTsKIH0gZWxzZSB7Ci0JbXkg JG1ha2VfY29tbWFuZCA9ICJtYWtlIFBFUkw9XCckcGVybFwnIjsKKwlteSAkbWFrZV9jb21tYW5k ID0gImdtYWtlIFBFUkw9XCckcGVybFwnIjsKIAlteSAkbWFrZV90YXJnZXRzID0gIiI7CiAJJG1h a2VfdGFyZ2V0cyAuPSAiIGxpbmtzIiBpZiAkc3ltbGluazsKIAkkbWFrZV90YXJnZXRzIC49ICIg ZGVwZW5kIiBpZiAkZGVwZmxhZ3MgbmUgJGRlZmF1bHRfZGVwZmxhZ3MgJiYgJG1ha2VfZGVwZW5k Owo= 97182 2006-09-16 14:25 0000 gentoo-config.patch gentoo-config.patch text/plain LS0tIGZpbGVzL2dlbnRvby5jb25maWctMC45LjgJMjAwNi0wOS0xNCAyMjozNTo1NiAtMDMwMAor KysgZmlsZXMvZ2VudG9vLmNvbmZpZy0wLjkuOAkyMDA2LTA5LTE2IDE4OjA3OjA0IC0wMzAwCkBA IC0xOSw2ICsxOSw3IEBACiAJCSJhbHBoYWV2NTYtdW5rbm93bi1saW51eC1nbnUgIHxsaW51eC1h bHBoYStid3gtZ2NjIiBcCiAJCSJpNjg2LXBjLWxpbnV4LWdudSAgICAgICAgICAgIHxsaW51eC1l bGYiIFwKIAkJIndoYXRldmVyLWdlbnRvby1mcmVlYnNkWC5ZICAgfEJTRC1nZW5lcmljMzIiIFwK KwkJImk2ODYtZ2VudG9vLWZyZWVic2RYLlkJICAgICAgfEJTRC14ODYtZWxmIiBcCiAJCSJzcGFy YzY0LWFscGhhLWZyZWVic2RYLlkgICAgIHxCU0Qtc3BhcmM2NCIgXAogCQkiaWE2NC1nZW50b28t ZnJlZWJzZDUuOTkyMzQgICB8QlNELWlhNjQiIFwKIAkJIng4Nl82NC1nZW50b28tZnJlZWJzZFgu WSAgICAgfEJTRC14ODZfNjQiIFwKQEAgLTkyLDcgKzkzLDcgQEAKIEJTRCkKIAljYXNlICR7Y2hv c3RfbWFjaGluZX0gaW4KIAkJYWxwaGEqKSAgICAgICBtYWNoaW5lPWdlbmVyaWM2NDs7Ci0JCWlb Ni05XTg2KikgICAgbWFjaGluZT14ODY7OworCQlpWzYtOV04NiopICAgIG1hY2hpbmU9eDg2LWVs Zjs7CiAJCWlhNjQqKSAgICAgICAgbWFjaGluZT1pYTY0OzsKIAkJc3BhcmM2NCopICAgICBtYWNo aW5lPXNwYXJjNjQ7OwogCQl4ODZfNjQqKSAgICAgIG1hY2hpbmU9eDg2XzY0OzsK 111431 2007-02-27 16:11 0000 Don't set TOP when making links x text/plain LS0tIE1ha2VmaWxlLm9yZy5vcmlnCTIwMDctMDItMjcgMTU6MDM6NDYgKzAwMDAKKysrIE1ha2Vm aWxlLm9yZwkyMDA3LTAyLTI3IDE1OjI2OjQ2ICswMDAwCkBAIC0yMTAsNyArMjEwLDkgQEAKICMg aXMgZ2l2ZW4gdGhyb3VnaCB0aGUgc2hlbGwgdmFyaWFibGUgYHRhcmdldCcuCiBCVUlMRF9DTUQ9 ICBpZiBbIC1kICIkJGRpciIgXTsgdGhlbiBcCiAJICAgICgJY2QgJCRkaXIgJiYgZWNobyAibWFr aW5nICQkdGFyZ2V0IGluICQkZGlyLi4uIiAmJiBcCi0JCSQoQ0xFQVJFTlYpICYmICQoTUFLRSkg LWUgJChCVUlMREVOVikgVE9QPS4uIERJUj0kJGRpciAkJHRhcmdldCBcCisJCSQoQ0xFQVJFTlYp ICYmIFsgIiQkdGFyZ2V0IiA9ICJsaW5rcyIgXSAmJiBcCisJCSQoTUFLRSkgLWUgJChCVUlMREVO VikgRElSPSQkZGlyICQkdGFyZ2V0IHx8IFwKKwkJJChNQUtFKSAtZSAkKEJVSUxERU5WKSBUT1A9 Li4gRElSPSQkZGlyICQkdGFyZ2V0IFwKIAkgICAgKSB8fCBleGl0IDE7IFwKIAkgICAgZmkKIFJF Q1VSU0lWRV9CVUlMRF9DTUQ9Zm9yIGRpciBpbiAkKERJUlMpOyBkbyAkKEJVSUxEX0NNRCk7IGRv bmUK