146307 2006-09-04 13:19 0000 media-video/transcode-1.0.2-r2 export to dvraw messes up audio 2007-02-01 03:38:44 0000 1 1 1 Unclassified Gentoo Linux Ebuilds unspecified All Linux RESOLVED FIXED P2 normal --- 1 craig.lawson@alum.mit.edu media-video@gentoo.org craig.lawson@alum.mit.edu 2006-09-04 13:19:51 0000 I submitted this to transcode-devel. Didn't get a reply, and I don't want it to get lost. When exporting to rawdv format, encoder->samples_this_frame was set to the number of audio bytes in the frame, not the number of samples. This causes audio samples to be either dropped or added, and when samples are added, they contain stack junk. Example: the DV format encodes the number of audio samples as (nSamples - 1580) & 0x3F. At 48KHz NTSC, a typical frame contains 1602 samples, and is encoded as 22. Transcode was incorrectly specifying 1602 * 4 = 6408 samples, which is encoded as 28 -- adding 6 extra samples! The solution is to divide by 2 * size(int16_t) = 4 (because transcode always passes 2 channels to dv_encode_full_audio). Example command: transcode -i movie.avi -y dvraw -uyvy -o movie.dv craig.lawson@alum.mit.edu 2006-09-04 13:21:03 0000 Created an attachment (id=96005) transcode 1.0.2 patch to fix dvraw audio export flameeyes@gentoo.org 2006-10-02 00:40:39 0000 Can you please submit this as an unified diff? craig.lawson@alum.mit.edu 2006-10-04 22:31:15 0000 Created an attachment (id=98812) transcode 1.0.2 patch to fix dvraw audio export (unified diff) Patch resubmitted in unified diff format. beandog@gentoo.org 2007-02-01 03:38:44 0000 Fixed in -r4 in CVS, thanks Craig 96005 2006-09-04 13:21 0000 transcode 1.0.2 patch to fix dvraw audio export transcode-1.0.2-dvraw.patch text/plain KioqIHRyYW5zY29kZS0xLjAuMi5vbGQvZXhwb3J0L2V4cG9ydF9kdnJhdy5jCTIwMDUtMDctMDQg MDA6MDk6MzIuMDAwMDAwMDAwIC0wNzAwCi0tLSB0cmFuc2NvZGUtMS4wLjIvZXhwb3J0L2V4cG9y dF9kdnJhdy5jCTIwMDYtMDgtMzEgMDA6MDI6MzEuMDAwMDAwMDAwIC0wNzAwCioqKioqKioqKioq KioqKgoqKiogMzIzLDMyOSAqKioqCiAgICAgICAgCiAgICAgIH0vL25vIHBhc3MtdGhyb3VnaAog ICNpZmRlZiBMSUJEVl8wOTkKISAgICAgICBlbmNvZGVyLT5zYW1wbGVzX3RoaXNfZnJhbWU9cGFy YW0tPnNpemU7CiAgI2VuZGlmCiAgICAgICAgZHZfZW5jb2RlX21ldGFkYXRhKHRhcmdldCwgZW5j b2Rlci0+aXNQQUwsIGVuY29kZXItPmlzMTZ4OSwgJm5vdywgMCk7CiAgICAgICAgZHZfZW5jb2Rl X3RpbWVjb2RlKHRhcmdldCwgZW5jb2Rlci0+aXNQQUwsIDApOwotLS0gMzIzLDMyOSAtLS0tCiAg ICAgICAgCiAgICAgIH0vL25vIHBhc3MtdGhyb3VnaAogICNpZmRlZiBMSUJEVl8wOTkKISAgICAg ICBlbmNvZGVyLT5zYW1wbGVzX3RoaXNfZnJhbWU9cGFyYW0tPnNpemUvNDsKICAjZW5kaWYKICAg ICAgICBkdl9lbmNvZGVfbWV0YWRhdGEodGFyZ2V0LCBlbmNvZGVyLT5pc1BBTCwgZW5jb2Rlci0+ aXMxNng5LCAmbm93LCAwKTsKICAgICAgICBkdl9lbmNvZGVfdGltZWNvZGUodGFyZ2V0LCBlbmNv ZGVyLT5pc1BBTCwgMCk7Cg== 98812 2006-10-04 22:31 0000 transcode 1.0.2 patch to fix dvraw audio export (unified diff) transcode-1.0.2-dvraw.patch text/plain LS0tIHRyYW5zY29kZS0xLjAuMi5vcmlnL2V4cG9ydC9leHBvcnRfZHZyYXcuYwkyMDA1LTA3LTA0 IDAwOjA5OjMyLjAwMDAwMDAwMCAtMDcwMAorKysgdHJhbnNjb2RlLTEuMC4yL2V4cG9ydC9leHBv cnRfZHZyYXcuYwkyMDA2LTEwLTA0IDIyOjEzOjU3LjAwMDAwMDAwMCAtMDcwMApAQCAtMzIzLDcg KzMyMyw3IEBACiAgICAgICAKICAgICB9Ly9ubyBwYXNzLXRocm91Z2gKICNpZmRlZiBMSUJEVl8w OTkKLSAgICAgIGVuY29kZXItPnNhbXBsZXNfdGhpc19mcmFtZT1wYXJhbS0+c2l6ZTsKKyAgICAg IGVuY29kZXItPnNhbXBsZXNfdGhpc19mcmFtZT1wYXJhbS0+c2l6ZS80OwogI2VuZGlmCiAgICAg ICBkdl9lbmNvZGVfbWV0YWRhdGEodGFyZ2V0LCBlbmNvZGVyLT5pc1BBTCwgZW5jb2Rlci0+aXMx Nng5LCAmbm93LCAwKTsKICAgICAgIGR2X2VuY29kZV90aW1lY29kZSh0YXJnZXQsIGVuY29kZXIt PmlzUEFMLCAwKTsK