146284 2006-09-04 09:36 0000 Kernel deadlock triggered by sandbox 2006-09-04 11:48:54 0000 1 1 1 Unclassified Gentoo/Alt FreeBSD unspecified All FreeBSD RESOLVED FIXED http://unleashed.amule.org/soc/2006/09/04/deadlock-dies/ P2 major --- 1 unledev+b.g.o@gmail.com bsd@gentoo.org unledev+b.g.o@gmail.com 2006-09-04 09:36:09 0000 Gentoo's sandbox triggers at random points a deadlock in FreeBSD 6.1-RELEASE and 6-STABLE in devfs code resulting in the system being unable to touch the filesystem. There is a patch as a result of my bug report to upstream fixing this deadlock which will be applied to both -CURRENT and 6-STABLE. If we want people to enable sandbox under FreeBSD we should be patching freebsd-sources with this patch until 6.2 gets released. Note that the author of the patch, Konstantin Belousov, says "this trades the deadlock for a race at unmount time", which is however much better than the current state of things. Dirty details: http://www.freebsd.org/cgi/query-pr.cgi?pr=102335 http://marc.theaimsgroup.com/?l=freebsd-hackers&m=115592944408531&w=2 http://unleashed.amule.org/soc/2006/07/15/deadlock-driving-me-mad/ http://unleashed.amule.org/soc/2006/09/04/deadlock-dies/ Patch against 6.1-RELEASE to follow as attachment. In the FreeBSD link you can find a patch against -CURRENT. unledev+b.g.o@gmail.com 2006-09-04 09:37:09 0000 Created an attachment (id=95973) Patch against 6.1-RELEASE fixing the deadlock (but racing at unmount time) flameeyes@gentoo.org 2006-09-04 11:48:54 0000 Added in 6.1-r4. 95973 2006-09-04 09:37 0000 Patch against 6.1-RELEASE fixing the deadlock (but racing at unmount time) kernel-fix-devfs-deadlock.patch text/plain ZGlmZiAtTmF1ciBkZXZmcy9kZXZmcy5oIGRldmZzYi9kZXZmcy5oCi0tLSBkZXZmcy9kZXZmcy5o CTIwMDYtMDgtMTggMTc6MjM6MDAgKzAwMDAKKysrIGRldmZzYi9kZXZmcy5oCTIwMDYtMDktMDMg MTk6MzQ6NTcgKzAwMDAKQEAgLTE2Myw3ICsxNjMsNyBAQAogdm9pZCBkZXZmc19ydWxlc19hcHBs eShzdHJ1Y3QgZGV2ZnNfbW91bnQgKmRtLCBzdHJ1Y3QgZGV2ZnNfZGlyZW50ICpkZSk7CiB2b2lk IGRldmZzX3J1bGVzX2NsZWFudXAgKHN0cnVjdCBkZXZmc19tb3VudCAqZG0pOwogaW50IGRldmZz X3J1bGVzX2lvY3RsKHN0cnVjdCBkZXZmc19tb3VudCAqZG0sIHVfbG9uZyBjbWQsIGNhZGRyX3Qg ZGF0YSwgc3RydWN0IHRocmVhZCAqdGQpOwotaW50IGRldmZzX2FsbG9jdiAoc3RydWN0IGRldmZz X2RpcmVudCAqZGUsIHN0cnVjdCBtb3VudCAqbXAsIHN0cnVjdCB2bm9kZSAqKnZwcCwgc3RydWN0 IHRocmVhZCAqdGQpOworaW50IGRldmZzX2FsbG9jdiAoc3RydWN0IGRldmZzX2RpcmVudCAqZGUs IHN0cnVjdCBtb3VudCAqbXAsIHN0cnVjdCB2bm9kZSAqKnZwcCwgaW50ICpkbV91bmxvY2ssIHN0 cnVjdCB0aHJlYWQgKnRkKTsKIHN0cnVjdCBjZGV2ICoqZGV2ZnNfaXRvZCAoaW50IGlub2RlKTsK IHN0cnVjdCBkZXZmc19kaXJlbnQgKipkZXZmc19pdG9kZSAoc3RydWN0IGRldmZzX21vdW50ICpk bSwgaW50IGlub2RlKTsKIHZvaWQgZGV2ZnNfZGVsZXRlKHN0cnVjdCBkZXZmc19tb3VudCAqZG0s IHN0cnVjdCBkZXZmc19kaXJlbnQgKmRlKTsKZGlmZiAtTmF1ciBkZXZmcy9kZXZmc192ZnNvcHMu YyBkZXZmc2IvZGV2ZnNfdmZzb3BzLmMKLS0tIGRldmZzL2RldmZzX3Zmc29wcy5jCTIwMDYtMDgt MTggMTc6MjM6MDAgKzAwMDAKKysrIGRldmZzYi9kZXZmc192ZnNvcHMuYwkyMDA2LTA5LTAzIDE5 OjM0OjU3ICswMDAwCkBAIC0xMzksOSArMTM5LDExIEBACiAJaW50IGVycm9yOwogCXN0cnVjdCB2 bm9kZSAqdnA7CiAJc3RydWN0IGRldmZzX21vdW50ICpkbXA7CisJaW50IGRtX3VubG9jazsKIAog CWRtcCA9IFZGU1RPREVWRlMobXApOwotCWVycm9yID0gZGV2ZnNfYWxsb2N2KGRtcC0+ZG1fcm9v dGRpciwgbXAsICZ2cCwgdGQpOworCWRtX3VubG9jayA9IDA7CisJZXJyb3IgPSBkZXZmc19hbGxv Y3YoZG1wLT5kbV9yb290ZGlyLCBtcCwgJnZwLCAmZG1fdW5sb2NrLCB0ZCk7CiAJaWYgKGVycm9y KQogCQlyZXR1cm4gKGVycm9yKTsKIAl2cC0+dl92ZmxhZyB8PSBWVl9ST09UOwpkaWZmIC1OYXVy IGRldmZzL2RldmZzX3Zub3BzLmMgZGV2ZnNiL2RldmZzX3Zub3BzLmMKLS0tIGRldmZzL2RldmZz X3Zub3BzLmMJMjAwNi0wOC0xOCAxNzoyMzowMCArMDAwMAorKysgZGV2ZnNiL2RldmZzX3Zub3Bz LmMJMjAwNi0wOS0wMyAxOTozNDo1NyArMDAwMApAQCAtMTI0LDE2ICsxMjQsMjMgQEAKIH0KIAog aW50Ci1kZXZmc19hbGxvY3Yoc3RydWN0IGRldmZzX2RpcmVudCAqZGUsIHN0cnVjdCBtb3VudCAq bXAsIHN0cnVjdCB2bm9kZSAqKnZwcCwgc3RydWN0IHRocmVhZCAqdGQpCitkZXZmc19hbGxvY3Yo c3RydWN0IGRldmZzX2RpcmVudCAqZGUsIHN0cnVjdCBtb3VudCAqbXAsIHN0cnVjdCB2bm9kZSAq KnZwcCwKKwlpbnQgKmRtX3VubG9jaywgc3RydWN0IHRocmVhZCAqdGQpCiB7CiAJaW50IGVycm9y OwogCXN0cnVjdCB2bm9kZSAqdnA7CiAJc3RydWN0IGNkZXYgKmRldjsKKwlzdHJ1Y3QgZGV2ZnNf bW91bnQgKmRtcDsKIAogCUtBU1NFUlQodGQgPT0gY3VydGhyZWFkLCAoImRldmZzX2FsbG9jdjog dGQgIT0gY3VydGhyZWFkIikpOworCWRtcCA9IFZGU1RPREVWRlMobXApOwogbG9vcDoKIAl2cCA9 IGRlLT5kZV92bm9kZTsKIAlpZiAodnAgIT0gTlVMTCkgeworCQlpZiAoKmRtX3VubG9jaykgewor CQkJc3hfeHVubG9jaygmZG1wLT5kbV9sb2NrKTsKKwkJCSpkbV91bmxvY2sgPSAwOworCQl9CiAJ CWlmICh2Z2V0KHZwLCBMS19FWENMVVNJVkUsIHRkKSkKIAkJCWdvdG8gbG9vcDsKIAkJKnZwcCA9 IHZwOwpAQCAtMTczLDYgKzE4MCwxMCBAQAogCX0KIAl2cC0+dl9kYXRhID0gZGU7CiAJZGUtPmRl X3Zub2RlID0gdnA7CisJaWYgKCpkbV91bmxvY2spIHsKKwkJc3hfeHVubG9jaygmZG1wLT5kbV9s b2NrKTsKKwkJKmRtX3VubG9jayA9IDA7CisJfQogCXZuX2xvY2sodnAsIExLX0VYQ0xVU0lWRSB8 IExLX1JFVFJZLCB0ZCk7CiAjaWZkZWYgTUFDCiAJbWFjX2Fzc29jaWF0ZV92bm9kZV9kZXZmcyht cCwgZGUsIHZwKTsKQEAgLTQ1Myw3ICs0NjQsNyBAQAogfQogCiBzdGF0aWMgaW50Ci1kZXZmc19s b29rdXB4KHN0cnVjdCB2b3BfbG9va3VwX2FyZ3MgKmFwKQorZGV2ZnNfbG9va3VweChzdHJ1Y3Qg dm9wX2xvb2t1cF9hcmdzICphcCwgaW50ICpkbV91bmxvY2spCiB7CiAJc3RydWN0IGNvbXBvbmVu dG5hbWUgKmNucDsKIAlzdHJ1Y3Qgdm5vZGUgKmR2cCwgKip2cHA7CkBAIC01MDQsNyArNTE1LDcg QEAKIAkJZGUgPSBUQUlMUV9GSVJTVCgmZGQtPmRlX2RsaXN0KTsJLyogIi4iICovCiAJCWRlID0g VEFJTFFfTkVYVChkZSwgZGVfbGlzdCk7CQkvKiAiLi4iICovCiAJCWRlID0gZGUtPmRlX2RpcjsK LQkJZXJyb3IgPSBkZXZmc19hbGxvY3YoZGUsIGR2cC0+dl9tb3VudCwgdnBwLCB0ZCk7CisJCWVy cm9yID0gZGV2ZnNfYWxsb2N2KGRlLCBkdnAtPnZfbW91bnQsIHZwcCwgZG1fdW5sb2NrLCB0ZCk7 CiAJCXZuX2xvY2soZHZwLCBMS19FWENMVVNJVkUgfCBMS19SRVRSWSwgdGQpOwogCQlyZXR1cm4g KGVycm9yKTsKIAl9CkBAIC01NjEsNyArNTcyLDcgQEAKIAkJCXJldHVybiAoMCk7CiAJCX0KIAl9 Ci0JZXJyb3IgPSBkZXZmc19hbGxvY3YoZGUsIGR2cC0+dl9tb3VudCwgdnBwLCB0ZCk7CisJZXJy b3IgPSBkZXZmc19hbGxvY3YoZGUsIGR2cC0+dl9tb3VudCwgdnBwLCBkbV91bmxvY2ssIHRkKTsK IAlyZXR1cm4gKGVycm9yKTsKIH0KIApAQCAtNTcwLDExICs1ODEsMTQgQEAKIHsKIAlpbnQgajsK IAlzdHJ1Y3QgZGV2ZnNfbW91bnQgKmRtcDsKKwlpbnQgZG1fdW5sb2NrOwogCiAJZG1wID0gVkZT VE9ERVZGUyhhcC0+YV9kdnAtPnZfbW91bnQpOworCWRtX3VubG9jayA9IDE7CiAJc3hfeGxvY2so JmRtcC0+ZG1fbG9jayk7Ci0JaiA9IGRldmZzX2xvb2t1cHgoYXApOwotCXN4X3h1bmxvY2soJmRt cC0+ZG1fbG9jayk7CisJaiA9IGRldmZzX2xvb2t1cHgoYXAsICZkbV91bmxvY2spOworCWlmIChk bV91bmxvY2sgPT0gMSkKKwkJc3hfeHVubG9jaygmZG1wLT5kbV9sb2NrKTsKIAlyZXR1cm4gKGop OwogfQogCkBAIC01ODYsNiArNjAwLDcgQEAKIAlzdHJ1Y3QgdGhyZWFkICp0ZDsKIAlzdHJ1Y3Qg ZGV2ZnNfZGlyZW50ICpkZCwgKmRlOwogCXN0cnVjdCBkZXZmc19tb3VudCAqZG1wOworCWludCBk bV91bmxvY2s7CiAJaW50IGVycm9yOwogCiAJLyoKQEAgLTU5Nyw2ICs2MTIsNyBAQAogCWR2cCA9 IGFwLT5hX2R2cDsKIAlkbXAgPSBWRlNUT0RFVkZTKGR2cC0+dl9tb3VudCk7CiAJc3hfeGxvY2so JmRtcC0+ZG1fbG9jayk7CisJZG1fdW5sb2NrID0gMTsKIAogCWNucCA9IGFwLT5hX2NucDsKIAl2 cHAgPSBhcC0+YV92cHA7CkBAIC02MTcsOSArNjMzLDEwIEBACiAJaWYgKGRlID09IE5VTEwpCiAJ CWdvdG8gbm90Zm91bmQ7CiAJZGUtPmRlX2ZsYWdzICY9IH5ERV9XSElURU9VVDsKLQllcnJvciA9 IGRldmZzX2FsbG9jdihkZSwgZHZwLT52X21vdW50LCB2cHAsIHRkKTsKKwllcnJvciA9IGRldmZz X2FsbG9jdihkZSwgZHZwLT52X21vdW50LCB2cHAsICZkbV91bmxvY2ssIHRkKTsKIG5vdGZvdW5k OgotCXN4X3h1bmxvY2soJmRtcC0+ZG1fbG9jayk7CisJaWYgKGRtX3VubG9jayA9PSAxKQorCQlz eF94dW5sb2NrKCZkbXAtPmRtX2xvY2spOwogCXJldHVybiAoZXJyb3IpOwogfQogCkBAIC0xMTAx LDYgKzExMTgsNyBAQAogCXN0cnVjdCBkZXZmc19kaXJlbnQgKmRlOwogCXN0cnVjdCBkZXZmc19t b3VudCAqZG1wOwogCXN0cnVjdCB0aHJlYWQgKnRkOworCWludCBkbV91bmxvY2s7CiAKIAl0ZCA9 IGFwLT5hX2NucC0+Y25fdGhyZWFkOwogCUtBU1NFUlQodGQgPT0gY3VydGhyZWFkLCAoImRldmZz X3N5bWxpbms6IHRkICE9IGN1cnRocmVhZCIpKTsKQEAgLTExMTksMTIgKzExMzcsMTQgQEAKIAlk ZS0+ZGVfc3ltbGluayA9IG1hbGxvYyhpLCBNX0RFVkZTLCBNX1dBSVRPSyk7CiAJYmNvcHkoYXAt PmFfdGFyZ2V0LCBkZS0+ZGVfc3ltbGluaywgaSk7CiAJc3hfeGxvY2soJmRtcC0+ZG1fbG9jayk7 CisJZG1fdW5sb2NrID0gMTsKICNpZmRlZiBNQUMKIAltYWNfY3JlYXRlX2RldmZzX3N5bWxpbmso YXAtPmFfY25wLT5jbl9jcmVkLCBkbXAtPmRtX21vdW50LCBkZCwgZGUpOwogI2VuZGlmCiAJVEFJ TFFfSU5TRVJUX1RBSUwoJmRkLT5kZV9kbGlzdCwgZGUsIGRlX2xpc3QpOwotCWRldmZzX2FsbG9j dihkZSwgYXAtPmFfZHZwLT52X21vdW50LCBhcC0+YV92cHAsIHRkKTsKLQlzeF94dW5sb2NrKCZk bXAtPmRtX2xvY2spOworCWRldmZzX2FsbG9jdihkZSwgYXAtPmFfZHZwLT52X21vdW50LCBhcC0+ YV92cHAsICZkbV91bmxvY2ssIHRkKTsKKwlpZiAoZG1fdW5sb2NrID09IDEpCisJCXN4X3h1bmxv Y2soJmRtcC0+ZG1fbG9jayk7CiAJcmV0dXJuICgwKTsKIH0KIAo=