145897 2006-09-01 13:25 0000 app-text/a2ps-4.13-r2 segfaults on amd64 2006-09-01 13:28:36 0000 1 1 1 Unclassified Gentoo Linux Printing unspecified AMD64 Linux RESOLVED FIXED P2 normal --- 1 kevquinn@gentoo.org cjk@gentoo.org amd64@gentoo.org printing@gentoo.org kevquinn@gentoo.org 2006-09-01 13:25:24 0000 This shows up if the tests are run; the test that fails just does: $ a2ps --list=options which segfaults because the code is copying a va_list with memcpy, which is not valid. It'll fail on any platform for which va_list is a 1-element array of a structure (see stdarg(3) for details). Patch to follow. kevquinn@gentoo.org 2006-09-01 13:27:12 0000 Created an attachment (id=95671) Replace incorrect use of memcpy with va_copy(). kevquinn@gentoo.org 2006-09-01 13:28:36 0000 Huh - fix is already in for later versions - oh well, I learned something even if it wasn't necessary to do anything! 95671 2006-09-01 13:27 0000 Replace incorrect use of memcpy with va_copy(). a2ps-4.13-vacopy.patch text/plain CUl0IGlzIG5vdCB2YWxpZCB0byBjb3B5IHZhX2xpc3Qgc3RydWN0dXJlcyB2aWEgbWVtY3B5OyBv biBzb21lCglhcmNoaXRlY3R1cmVzIHZhX2xpc3QgaXMgYSAxLWVsZW1lbnQgYXJyYXkgb2YgYSBz dHJ1Y3R1cmUgKHNlZQoJc3RkYXJnKDMpIGZvciBkZXRhaWxzKS4gIFRoZSBjb3JyZWN0IHdheSB0 byBkdXBsaWNhdGUgYSB2YV9saXN0CglpcyB0byB1c2UgdmFfY29weSgpLiAgTm90ZSB0aGlzIGlz IG9ubHkgYXZhaWxhYmxlIGluIEM5OS4KCU5vdGU7IHRoZSBjb250ZW50cyBvZiBpbnRfcHJpbnRm bGVuIGNhbiBiZSBtb3ZlZCB0byB2cHJpbnRmbGVuCglhbmQgaW50X3ByaW50ZmxlbiBkZWxldGVk LgoKCUtldmluIEYuIFF1aW5uIDxrZXZxdWlubkBnZW50b28ub3JnPiAyMDA2LTA5LTAxCgpkaWZm IC11ciBhMnBzLTQuMTMub3JpZy9saWIvcHJpbnRsZW4uYyBhMnBzLTQuMTMvbGliL3ByaW50bGVu LmMKLS0tIGEycHMtNC4xMy5vcmlnL2xpYi9wcmludGxlbi5jCTIwMDYtMDktMDEgMjI6MDg6MTQu MDAwMDAwMDAwICswMjAwCisrKyBhMnBzLTQuMTMvbGliL3ByaW50bGVuLmMJMjAwNi0wOS0wMSAy MjoxMzo1MC4wMDAwMDAwMDAgKzAyMDAKQEAgLTI4LDE0ICsyOCwxNCBAQAogdW5zaWduZWQgbG9u ZyBzdHJ0b3VsICgpOwogCiBzdGF0aWMgaW50Ci1pbnRfcHJpbnRmbGVuIChjb25zdCBjaGFyICpm b3JtYXQsIHZhX2xpc3QgKmFyZ3MpCitpbnRfcHJpbnRmbGVuIChjb25zdCBjaGFyICpmb3JtYXQs IHZhX2xpc3QgYXJncykKIHsKICAgY29uc3QgY2hhciAqY3A7CiAgIGludCB0b3RhbF93aWR0aCA9 IDA7CiAgIGludCB3aWR0aCA9IDA7CiAgIHZhX2xpc3QgYXA7CiAKLSAgbWVtY3B5ICgmYXAsIGFy Z3MsIHNpemVvZiAodmFfbGlzdCkpOworICB2YV9jb3B5KGFwLCBhcmdzKTsKIAogICBmb3IgKGNw ID0gZm9ybWF0IDsgKmNwIDsgY3ArKykKICAgICB7CkBAIC05MywxMyArOTMsMTQgQEAKIAkgICAg fQogCX0KICAgICB9CisgIHZhX2VuZChhcCk7CiAgIHJldHVybiB0b3RhbF93aWR0aDsKIH0KIAog aW50CiB2cHJpbnRmbGVuIChjb25zdCBjaGFyICpmb3JtYXQsICB2YV9saXN0IGFyZ3MpCiB7Ci0g IHJldHVybiBpbnRfcHJpbnRmbGVuIChmb3JtYXQsICZhcmdzKTsKKyAgcmV0dXJuIGludF9wcmlu dGZsZW4gKGZvcm1hdCwgYXJncyk7CiB9CiAKIGludAo=