<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "http://bugs.gentoo.org/bugzilla.dtd">

<bugzilla version="2.22.7"
          urlbase="http://bugs.gentoo.org/"
          maintainer="bugzilla@gentoo.org"
>

    <bug>
          <bug_id>142203</bug_id>
          
          <creation_ts>2006-07-30 11:09 0000</creation_ts>
          <short_desc>media-video/ogmrip spooky pkg_setup()</short_desc>
          <delta_ts>2006-08-30 09:21:00 0000</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>Gentoo Linux</product>
          <component>Ebuilds</component>
          <version>2006.0</version>
          <rep_platform>All</rep_platform>
          <op_sys>Linux</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          
          <priority>P1</priority>
          <bug_severity>major</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          
          <everconfirmed>1</everconfirmed>
          <reporter>jakub@gentoo.org</reporter>
          <assigned_to>media-video@gentoo.org</assigned_to>
          

      

      
          <long_desc isprivate="0">
            <who>jakub@gentoo.org</who>
            <bug_when>2006-07-30 11:09:32 0000</bug_when>
            <thetext>&lt;snip&gt;
pkg_setup() {
        if ! which mencoder &gt; /dev/null 2&gt;&amp;1; then
                eerror &quot;Unable to find mencoder in the PATH. You need mencoder to use OGMRip.&quot;
                eerror &quot;Please, add encode to your USE flags and emerge mplayer again.&quot;
                die &quot;Unable to find mencoder in the PATH. You need mencoder to use OGMRip.&quot;
        fi
        if ! mencoder -ovc help 2&gt; /dev/null | grep -q &quot;^ *xvid *- .*$&quot;; then
                echo
                eerror &quot;Mplayer is not build with XviD support. OGMRip requires XviD support in mplayer.&quot;
                eerror &quot;Please, add xvid to your USE flags and emerge mplayer again.&quot;
                die &quot;Mplayer is not build with XviD support. OGMRip requires XviD support in mplayer.&quot;
        fi
}
&lt;/snip&gt;

Err...

1/ mplayer is in RDEPEND, why would one miss mencoder? What are you after here?
2/ Use built_with_use check from eutils eclass, perhaps?</thetext>
          </long_desc>
          <long_desc isprivate="0">
            <who>jakub@gentoo.org</who>
            <bug_when>2006-07-30 11:24:19 0000</bug_when>
            <thetext>Created an attachment (id=93074)
ogmrip-0.9.0-r2.ebuild.diff

- fix pkg_setup()
- add quoting
- do not dodoc COPYING INSTALL
</thetext>
          </long_desc>
          <long_desc isprivate="0">
            <who>billl@users.sf.net</who>
            <bug_when>2006-08-17 13:37:37 0000</bug_when>
            <thetext>Created an attachment (id=94473)
An updated version of the patch

</thetext>
          </long_desc>
          <long_desc isprivate="0">
            <who>zzam@gentoo.org</who>
            <bug_when>2006-08-30 09:21:00 0000</bug_when>
            <thetext>Added this to ogmrip-0.9.0-r1.ebuild.</thetext>
          </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>93074</attachid>
            <date>2006-07-30 11:24 0000</date>
            <desc>ogmrip-0.9.0-r2.ebuild.diff</desc>
            <filename>ogmrip-0.9.0-r1.ebuild.diff</filename>
            <type>text/plain</type>
            <data encoding="base64">LS0tIG9nbXJpcC0wLjkuMC1yMS5lYnVpbGQJMjAwNi0wNi0wMiAxNzozNjowMC4wMDAwMDAwMDAg
KzAyMDAKKysrIG9nbXJpcC0wLjkuMC1yMi5lYnVpbGQJMjAwNi0wNy0zMCAyMDoyMDoyOC4wMDAw
MDAwMDAgKzAyMDAKQEAgLTEsNiArMSw2IEBACiAjIENvcHlyaWdodCAxOTk5LTIwMDYgR2VudG9v
IEZvdW5kYXRpb24KICMgRGlzdHJpYnV0ZWQgdW5kZXIgdGhlIHRlcm1zIG9mIHRoZSBHTlUgR2Vu
ZXJhbCBQdWJsaWMgTGljZW5zZSB2MgotIyAkSGVhZGVyOiAvdmFyL2N2c3Jvb3QvZ2VudG9vLXg4
Ni9tZWRpYS12aWRlby9vZ21yaXAvb2dtcmlwLTAuOS4wLXIxLmVidWlsZCx2IDEuMiAyMDA2LzA2
LzAyIDE1OjE0OjI0IHNicmllc2VuIEV4cCAkCisjICRIZWFkZXI6IEV4cCAkCiAKIGluaGVyaXQg
YXV0b3Rvb2xzIGV1dGlscyBnbm9tZTIKIApAQCAtMzQsMjcgKzM0LDIxIEBACiAKIEcyQ09ORj0i
JHtHMkNPTkZ9ICQodXNlX2VuYWJsZSBnbm9tZSBnbm9tZS1zdXBwb3J0KSAkKHVzZV9lbmFibGUg
ZGVidWcgbWFpbnRhaW5lci1tb2RlKSAkKHVzZV9lbmFibGUgc3VicCBlbmNoYW50LXN1cHBvcnQp
ICQodXNlX2VuYWJsZSBoYWwgaGFsLXN1cHBvcnQpIgogCi1ET0NTPSJBVVRIT1JTIENoYW5nZUxv
ZyBDT1BZSU5HIFJFQURNRSBJTlNUQUxMIE5FV1MgVE9ETyIKK0RPQ1M9IkFVVEhPUlMgQ2hhbmdl
TG9nIFJFQURNRSBORVdTIFRPRE8iCiAKIHBrZ19zZXR1cCgpIHsKLQlpZiAhIHdoaWNoIG1lbmNv
ZGVyID4gL2Rldi9udWxsIDI+JjE7IHRoZW4KLQkJZWVycm9yICJVbmFibGUgdG8gZmluZCBtZW5j
b2RlciBpbiB0aGUgUEFUSC4gWW91IG5lZWQgbWVuY29kZXIgdG8gdXNlIE9HTVJpcC4iCi0JCWVl
cnJvciAiUGxlYXNlLCBhZGQgZW5jb2RlIHRvIHlvdXIgVVNFIGZsYWdzIGFuZCBlbWVyZ2UgbXBs
YXllciBhZ2Fpbi4iCi0JCWRpZSAiVW5hYmxlIHRvIGZpbmQgbWVuY29kZXIgaW4gdGhlIFBBVEgu
IFlvdSBuZWVkIG1lbmNvZGVyIHRvIHVzZSBPR01SaXAuIgotCWZpCi0JaWYgISBtZW5jb2RlciAt
b3ZjIGhlbHAgMj4gL2Rldi9udWxsIHwgZ3JlcCAtcSAiXiAqeHZpZCAqLSAuKiQiOyB0aGVuCi0J
CWVjaG8KLQkJZWVycm9yICJNcGxheWVyIGlzIG5vdCBidWlsZCB3aXRoIFh2aUQgc3VwcG9ydC4g
T0dNUmlwIHJlcXVpcmVzIFh2aUQgc3VwcG9ydCBpbiBtcGxheWVyLiIKLQkJZWVycm9yICJQbGVh
c2UsIGFkZCB4dmlkIHRvIHlvdXIgVVNFIGZsYWdzIGFuZCBlbWVyZ2UgbXBsYXllciBhZ2Fpbi4i
Ci0JCWRpZSAiTXBsYXllciBpcyBub3QgYnVpbGQgd2l0aCBYdmlEIHN1cHBvcnQuIE9HTVJpcCBy
ZXF1aXJlcyBYdmlEIHN1cHBvcnQgaW4gbXBsYXllci4iCisJaWYgISBidWlsdF93aXRoX3VzZSAt
YSBtZWRpYS12aWRlby9tcGxheWVyIGVuY29kZSB4dmlkIDsgdGhlbgorCQllZXJyb3IgIiR7UE59
IHJlcXVpcmVzIG1wbGF5ZXIgd2l0aCB4dmlkIGFuZCBlbmNvZGUgc3VwcG9ydC4iCisJCWVlcnJv
ciAiUGxlYXNlLCBhZGQgeHZpZCBhbmQgZW5jb2RlIHRvIHlvdXIgVVNFIGZsYWdzIGFuZCBlbWVy
Z2UgbXBsYXllciBhZ2Fpbi4iCisJCWRpZSAiJHtQTn0gcmVxdWlyZXMgbXBsYXllciB3aXRoIHh2
aWQgYW5kIGVuY29kZSBzdXBwb3J0LiIKIAlmaQogfQogc3JjX3VucGFjaygpIHsKIAl1bnBhY2sg
JHtBfQotCWNkICR7U30KLQllcGF0Y2ggJHtGSUxFU0RJUn0vJHtQfS1sYW5nLnBhdGNoCi0JZXBh
dGNoICR7RklMRVNESVJ9LyR7UH0tZ2NjNC5wYXRjaAotCWVwYXRjaCAke0ZJTEVTRElSfS8ke1B9
LW1wbGF5ZXJjdnMucGF0Y2gKLQllcGF0Y2ggJHtGSUxFU0RJUn0vJHtQfS10eXBlcy5wYXRjaAor
CWNkICIke1N9IgorCWVwYXRjaCAiJHtGSUxFU0RJUn0vJHtQfS1sYW5nLnBhdGNoIgorCWVwYXRj
aCAiJHtGSUxFU0RJUn0vJHtQfS1nY2M0LnBhdGNoIgorCWVwYXRjaCAiJHtGSUxFU0RJUn0vJHtQ
fS1tcGxheWVyY3ZzLnBhdGNoIgorCWVwYXRjaCAiJHtGSUxFU0RJUn0vJHtQfS10eXBlcy5wYXRj
aCIKIAllYXV0b3JlY29uZgogfQo=
</data>        

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>94473</attachid>
            <date>2006-08-17 13:37 0000</date>
            <desc>An updated version of the patch</desc>
            <filename>ogmrip-0.9.0-r1.ebuild.patch</filename>
            <type>text/plain</type>
            <data encoding="base64">LS0tIG9nbXJpcC0wLjkuMC1yMS5lYnVpbGQub3JpZwkyMDA2LTA4LTE3IDIyOjMzOjM2LjAwMDAw
MDAwMCArMDIwMAorKysgb2dtcmlwLTAuOS4wLXIxLmVidWlsZAkyMDA2LTA4LTE3IDIyOjM2OjIy
LjAwMDAwMDAwMCArMDIwMApAQCAtMzQsMjAgKzM0LDEzIEBACiAKIEcyQ09ORj0iJHtHMkNPTkZ9
ICQodXNlX2VuYWJsZSBnbm9tZSBnbm9tZS1zdXBwb3J0KSAkKHVzZV9lbmFibGUgZGVidWcgbWFp
bnRhaW5lci1tb2RlKSAkKHVzZV9lbmFibGUgc3VicCBlbmNoYW50LXN1cHBvcnQpICQodXNlX2Vu
YWJsZSBoYWwgaGFsLXN1cHBvcnQpIgogCi1ET0NTPSJBVVRIT1JTIENoYW5nZUxvZyBDT1BZSU5H
IFJFQURNRSBJTlNUQUxMIE5FV1MgVE9ETyIKK0RPQ1M9IkFVVEhPUlMgQ2hhbmdlTG9nIFJFQURN
RSBORVdTIFRPRE8iCiAKIHBrZ19zZXR1cCgpIHsKLQlpZiAhIHdoaWNoIG1lbmNvZGVyID4gL2Rl
di9udWxsIDI+JjE7IHRoZW4KLQkJZWVycm9yICJVbmFibGUgdG8gZmluZCBtZW5jb2RlciBpbiB0
aGUgUEFUSC4gWW91IG5lZWQgbWVuY29kZXIgdG8gdXNlIE9HTVJpcC4iCi0JCWVlcnJvciAiUGxl
YXNlLCBhZGQgZW5jb2RlIHRvIHlvdXIgVVNFIGZsYWdzIGFuZCBlbWVyZ2UgbXBsYXllciBhZ2Fp
bi4iCi0JCWRpZSAiVW5hYmxlIHRvIGZpbmQgbWVuY29kZXIgaW4gdGhlIFBBVEguIFlvdSBuZWVk
IG1lbmNvZGVyIHRvIHVzZSBPR01SaXAuIgotCWZpCi0JaWYgISBtZW5jb2RlciAtb3ZjIGhlbHAg
Mj4gL2Rldi9udWxsIHwgZ3JlcCAtcSAiXiAqeHZpZCAqLSAuKiQiOyB0aGVuCi0JCWVjaG8KLQkJ
ZWVycm9yICJNcGxheWVyIGlzIG5vdCBidWlsZCB3aXRoIFh2aUQgc3VwcG9ydC4gT0dNUmlwIHJl
cXVpcmVzIFh2aUQgc3VwcG9ydCBpbiBtcGxheWVyLiIKLQkJZWVycm9yICJQbGVhc2UsIGFkZCB4
dmlkIHRvIHlvdXIgVVNFIGZsYWdzIGFuZCBlbWVyZ2UgbXBsYXllciBhZ2Fpbi4iCi0JCWRpZSAi
TXBsYXllciBpcyBub3QgYnVpbGQgd2l0aCBYdmlEIHN1cHBvcnQuIE9HTVJpcCByZXF1aXJlcyBY
dmlEIHN1cHBvcnQgaW4gbXBsYXllci4iCi0JZmkKKwlpZiAhIGJ1aWx0X3dpdGhfdXNlIC1hIG1l
ZGlhLXZpZGVvL21wbGF5ZXIgZHZkIGVuY29kZSB4dmlkOyB0aGVuCisJCWVlcnJvciAiUGxlYXNl
LCBjaGVjayB0aGF0IHlvdXIgVVNFIGZsYWdzIGNvbnRhaW4gJ2R2ZCcsICdlbmNvZGUnIGFuZCAn
eHZpZCcgYW5kIGVtZXJnZSBtcGxheWVyIGFnYWluLiIKKwkJZGllICJNcGxheWVyIGlzIG5vdCBi
dWlsZCB3aXRoIGR2ZCwgZW5jb2Rpbmcgb3IgeHZpZCBzdXBwb3J0LiBPR01SaXAgcmVxdWlyZXMg
ZHZkLCBlbmNvZGluZyBhbmQgeHZpZCBzdXBwb3J0IGluIG1wbGF5ZXIuIgorZmkKIH0KIHNyY191
bnBhY2soKSB7CiAJdW5wYWNrICR7QX0K
</data>        

          </attachment>
    </bug>

</bugzilla>