<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "http://bugs.gentoo.org/bugzilla.dtd">

<bugzilla version="2.22.7"
          urlbase="http://bugs.gentoo.org/"
          maintainer="bugzilla@gentoo.org"
>

    <bug>
          <bug_id>139477</bug_id>
          
          <creation_ts>2006-07-06 13:30 0000</creation_ts>
          <short_desc>net-dialup/ppp setuid() issue (CVE-2006-2194)</short_desc>
          <delta_ts>2006-07-07 01:07:41 0000</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>Gentoo Security</product>
          <component>Vulnerabilities</component>
          <version>unspecified</version>
          <rep_platform>All</rep_platform>
          <op_sys>Linux</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          <bug_file_loc>http://www.ubuntu.com/usn/usn-310-1</bug_file_loc>
          <status_whiteboard>C1 [noglsa] Falco</status_whiteboard>
          
          <priority>P2</priority>
          <bug_severity>major</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          
          <everconfirmed>1</everconfirmed>
          <reporter>jaervosz@gentoo.org</reporter>
          <assigned_to>security@gentoo.org</assigned_to>
          <cc>net-dialup@gentoo.org</cc>

      

      
          <long_desc isprivate="0">
            <who>jaervosz@gentoo.org</who>
            <bug_when>2006-07-06 13:30:52 0000</bug_when>
            <thetext>Marcus Meissner discovered that the winbind plugin of pppd does not
check the result of the setuid() call. On systems that configure PAM
limits for the maximum number of user processes and enable the winbind
plugin, a local attacker could exploit this to execute the winbind
NTLM authentication helper as root. Depending on the local winbind
configuration, this could potentially lead to privilege escalation.</thetext>
          </long_desc>
          <long_desc isprivate="0">
            <who>falco@gentoo.org</who>
            <bug_when>2006-07-06 15:06:23 0000</bug_when>
            <thetext>--&gt; C because it does not affect the default conf (pam limits + winbind plugin)

--&gt; *1 because there is a possible privilege escalation

i don&apos;t understand how CVE can reference ppp 2.4.4 as vulnerable, since from the officiel web site :

&quot;ppp 2.4.3
The latest version of ppp is version 2.4.3, released on 14 November 2004.&quot;
http://samba.org/ppp/

--&gt; setting to [upstream] status. Waiting.</thetext>
          </long_desc>
          <long_desc isprivate="0">
            <who>falco@gentoo.org</who>
            <bug_when>2006-07-06 15:23:34 0000</bug_when>
            <thetext>C1 -&gt; major, the policy says.</thetext>
          </long_desc>
          <long_desc isprivate="0">
            <who>mrness@gentoo.org</who>
            <bug_when>2006-07-06 23:31:16 0000</bug_when>
            <thetext>I understand that patch available at http://lists.opensuse.org/archive/opensuse-commit/2006-Jun/0117.html fixes this problem. Btw, I find it strange that upstream wasn&apos;t informed about it.

Can someone enlighten me how could setuid(getuid()) be exploited? If the effective user is root, it will always succeed, isn&apos;t so?</thetext>
          </long_desc>
          <long_desc isprivate="0">
            <who>frilled@gentoo.org</who>
            <bug_when>2006-07-06 23:34:34 0000</bug_when>
            <thetext>No, we had a couple of those lately. It&apos;s not guaranteed that you can drop privs. If user&apos;s process limit is exceeded, for example, dropping fails. If you don&apos;t check the return code, your code will run as root as opposed to the unprivileged user you wanted to change to.</thetext>
          </long_desc>
          <long_desc isprivate="0">
            <who>frilled@gentoo.org</who>
            <bug_when>2006-07-06 23:37:47 0000</bug_when>
            <thetext>BTW, good reading IMHO: http://www.csl.sri.com/users/ddean/papers/usenix02.pdf</thetext>
          </long_desc>
          <long_desc isprivate="0">
            <who>mrness@gentoo.org</who>
            <bug_when>2006-07-07 00:11:48 0000</bug_when>
            <thetext>Created an attachment (id=91097)
winbind-drop-privs.patch

Would this patch be OK from the security pov?</thetext>
          </long_desc>
          <long_desc isprivate="0">
            <who>frilled@gentoo.org</who>
            <bug_when>2006-07-07 00:32:57 0000</bug_when>
            <thetext>Looks ok to me. Any different POVs?</thetext>
          </long_desc>
          <long_desc isprivate="0">
            <who>falco@gentoo.org</who>
            <bug_when>2006-07-07 00:49:14 0000</bug_when>
            <thetext>
&gt; 
&gt; Would this patch be OK from the security pov?
&gt; 

it&apos;s OK for me
</thetext>
          </long_desc>
          <long_desc isprivate="0">
            <who>mrness@gentoo.org</who>
            <bug_when>2006-07-07 01:01:27 0000</bug_when>
            <thetext>Fixed in ppp-2.4.3-r16 (give it a couple of hours till patches tarball is uploaded on our mirrors from dev.g.o:/space/distfiles-local).

The stable version (2.4.2-r15) isn&apos;t affected by this bug since it doesn&apos;t have winbind plugin.</thetext>
          </long_desc>
          <long_desc isprivate="0">
            <who>falco@gentoo.org</who>
            <bug_when>2006-07-07 01:07:41 0000</bug_when>
            <thetext>&gt; Fixed in ppp-2.4.3-r16 (give it a couple of hours till patches tarball is
&gt; uploaded on our mirrors from dev.g.o:/space/distfiles-local).

good, thanks

&gt; The stable version (2.4.2-r15) isn&apos;t affected by this bug since it doesn&apos;t have
&gt; winbind plugin.

there will be no glsa then; closing. Thank you for the fastness, Alin.
As usual, feel free to reopen if needed.</thetext>
          </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>91097</attachid>
            <date>2006-07-07 00:11 0000</date>
            <desc>winbind-drop-privs.patch</desc>
            <filename>winbind-drop-privs.patch</filename>
            <type>text/plain</type>
            <data encoding="base64">ZGlmZiAtTnJ1IHBwcC0yLjQuMy5vcmlnL3BwcGQvcGx1Z2lucy93aW5iaW5kLmMgcHBwLTIuNC4z
L3BwcGQvcGx1Z2lucy93aW5iaW5kLmMKLS0tIHBwcC0yLjQuMy5vcmlnL3BwcGQvcGx1Z2lucy93
aW5iaW5kLmMJMjAwNi0wNS0wOSAxNDozOTo0OS4wMDAwMDAwMDAgKzAzMDAKKysrIHBwcC0yLjQu
My9wcHBkL3BsdWdpbnMvd2luYmluZC5jCTIwMDYtMDctMDcgMTA6MDk6MTAuMDAwMDAwMDAwICsw
MzAwCkBAIC0zMDAsOCArMzAwLDEwIEBACiAJCWNsb3NlKGNoaWxkX2luWzFdKTsKIAogCQkvKiBy
dW4gd2luYmluZCBhcyB0aGUgdXNlciB0aGF0IGludm9rZWQgcHBwZCAqLwotCQlzZXRnaWQoZ2V0
Z2lkKCkpOwotCQlzZXR1aWQoZ2V0dWlkKCkpOworCQlpZiAoc2V0Z2lkKGdldGdpZCgpKSA8IDAg
fHwgc2V0dWlkKGdldHVpZCgpKSA8IDApIHsKKwkJCXBlcnJvcigicHBwZC93aW5iaW5kOiBmYWls
ZWQgdG8gZHJvcCBwcml2aWxlZ2VzIik7CisJCQlleGl0KDEpOworCQl9CiAJCWV4ZWNsKCIvYmlu
L3NoIiwgInNoIiwgIi1jIiwgbnRsbV9hdXRoLCBOVUxMKTsgIAogCQlwZXJyb3IoInBwcGQvd2lu
YmluZDogY291bGQgbm90IGV4ZWMgL2Jpbi9zaCIpOwogCQlleGl0KDEpOwo=
</data>        

          </attachment>
    </bug>

</bugzilla>