138688 2006-07-01 04:12 0000 The setuid patch for x11-base/xorg-server-1.0.2 is broken. 2007-01-24 21:26:19 0000 1 1 1 Unclassified Gentoo Linux Applications unspecified All Linux RESOLVED FIXED P2 normal --- 1 rudo@matfyz.cz x11@gentoo.org dberkholz@gentoo.org rudo@matfyz.cz rudo@matfyz.cz 2006-07-01 04:12:30 0000 Hi, I have looked at the x11-base/xorg-server/files/x11r7.0-setuid.diff file in the portage tree and found the patch broken. As of revision 1.1 of the file in portage CVS, the write.c hunk says: - setuid(getuid()); + if (setuid(getuid() == -1) + FatalError("xf86writeConfigFile(): " Note the missing closing parenthesis after getuid(). I wonder how it could even compile (haven't tried it myself though). Please fix the patch. Bye for now. Rudo. joshuabaergen@gentoo.org 2006-07-01 09:31:06 0000 It probably doesn't compile the parser, then. I'll fix this up anyway. Good catch :) Donnie, this is broken in the 1.1 patch as well, which probably means it's broken in git upstream. dberkholz@gentoo.org 2006-07-01 12:43:10 0000 I've also committed your fix upstream. curtlee2002@gmail.com 2007-01-24 21:26:19 0000 Created an attachment (id=108057) dev-perl:XML-Parser-2.34:20070124-212406.log 108057 2007-01-24 21:26 0000 dev-perl:XML-Parser-2.34:20070124-212406.log dev-perl:XML-Parser-2.34:20070124-212406.log text/plain Pj4+IFVucGFja2luZyBzb3VyY2UuLi4KPj4+IFVucGFja2luZyBYTUwtUGFyc2VyLTIuMzQudGFy Lmd6IHRvIC92YXIvdG1wL3BvcnRhZ2UvZGV2LXBlcmwvWE1MLVBhcnNlci0yLjM0L3dvcmsKPj4+ IFNvdXJjZSB1bnBhY2tlZC4KPj4+IENvbXBpbGluZyBzb3VyY2UgaW4gL3Zhci90bXAvcG9ydGFn ZS9kZXYtcGVybC9YTUwtUGFyc2VyLTIuMzQvd29yay9YTUwtUGFyc2VyLTIuMzQgLi4uCi92YXIv dG1wL3BvcnRhZ2UvZGV2LXBlcmwvWE1MLVBhcnNlci0yLjM0L3dvcmsvWE1MLVBhcnNlci0yLjM0 CiAbWzMyOzAxbSobWzBtIFVzaW5nIEV4dFV0aWxzOjpNYWtlTWFrZXIKQ2hlY2tpbmcgaWYgeW91 ciBraXQgaXMgY29tcGxldGUuLi4KTG9va3MgZ29vZApXcml0aW5nIE1ha2VmaWxlIGZvciBYTUw6 OlBhcnNlcjo6RXhwYXQKV3JpdGluZyBNYWtlZmlsZSBmb3IgWE1MOjpQYXJzZXIKY3AgUGFyc2Vy L0VuY29kaW5ncy94LXNqaXMtY3A5MzIuZW5jIGJsaWIvbGliL1hNTC9QYXJzZXIvRW5jb2Rpbmdz L3gtc2ppcy1jcDkzMi5lbmMKY3AgUGFyc2VyL0VuY29kaW5ncy9pc28tODg1OS03LmVuYyBibGli L2xpYi9YTUwvUGFyc2VyL0VuY29kaW5ncy9pc28tODg1OS03LmVuYwpjcCBQYXJzZXIvU3R5bGUv VHJlZS5wbSBibGliL2xpYi9YTUwvUGFyc2VyL1N0eWxlL1RyZWUucG0KY3AgUGFyc2VyL0VuY29k aW5ncy9pc28tODg1OS05LmVuYyBibGliL2xpYi9YTUwvUGFyc2VyL0VuY29kaW5ncy9pc28tODg1 OS05LmVuYwpjcCBQYXJzZXIvRW5jb2RpbmdzL3gtZXVjLWpwLXVuaWNvZGUuZW5jIGJsaWIvbGli L1hNTC9QYXJzZXIvRW5jb2RpbmdzL3gtZXVjLWpwLXVuaWNvZGUuZW5jCmNwIFBhcnNlci9FbmNv ZGluZ3MvUkVBRE1FIGJsaWIvbGliL1hNTC9QYXJzZXIvRW5jb2RpbmdzL1JFQURNRQpjcCBQYXJz ZXIvRW5jb2RpbmdzL2V1Yy1rci5lbmMgYmxpYi9saWIvWE1ML1BhcnNlci9FbmNvZGluZ3MvZXVj LWtyLmVuYwpjcCBQYXJzZXIvRW5jb2RpbmdzL3dpbmRvd3MtMTI1MC5lbmMgYmxpYi9saWIvWE1M L1BhcnNlci9FbmNvZGluZ3Mvd2luZG93cy0xMjUwLmVuYwpjcCBQYXJzZXIvRW5jb2RpbmdzL3dp bmRvd3MtMTI1Mi5lbmMgYmxpYi9saWIvWE1ML1BhcnNlci9FbmNvZGluZ3Mvd2luZG93cy0xMjUy LmVuYwpjcCBQYXJzZXIvRW5jb2RpbmdzL2JpZzUuZW5jIGJsaWIvbGliL1hNTC9QYXJzZXIvRW5j b2RpbmdzL2JpZzUuZW5jCmNwIFBhcnNlci9FbmNvZGluZ3MvaXNvLTg4NTktMy5lbmMgYmxpYi9s aWIvWE1ML1BhcnNlci9FbmNvZGluZ3MvaXNvLTg4NTktMy5lbmMKY3AgUGFyc2VyL0VuY29kaW5n cy9KYXBhbmVzZV9FbmNvZGluZ3MubXNnIGJsaWIvbGliL1hNTC9QYXJzZXIvRW5jb2RpbmdzL0ph cGFuZXNlX0VuY29kaW5ncy5tc2cKY3AgUGFyc2VyL0VuY29kaW5ncy9pc28tODg1OS04LmVuYyBi bGliL2xpYi9YTUwvUGFyc2VyL0VuY29kaW5ncy9pc28tODg1OS04LmVuYwpjcCBQYXJzZXIvRW5j b2RpbmdzL2lzby04ODU5LTQuZW5jIGJsaWIvbGliL1hNTC9QYXJzZXIvRW5jb2RpbmdzL2lzby04 ODU5LTQuZW5jCmNwIFBhcnNlci9TdHlsZS9TdWJzLnBtIGJsaWIvbGliL1hNTC9QYXJzZXIvU3R5 bGUvU3Vicy5wbQpjcCBQYXJzZXIvRW5jb2RpbmdzL3gtZXVjLWpwLWppc3gwMjIxLmVuYyBibGli L2xpYi9YTUwvUGFyc2VyL0VuY29kaW5ncy94LWV1Yy1qcC1qaXN4MDIyMS5lbmMKY3AgUGFyc2Vy L0VuY29kaW5ncy94LXNqaXMtamRrMTE3LmVuYyBibGliL2xpYi9YTUwvUGFyc2VyL0VuY29kaW5n cy94LXNqaXMtamRrMTE3LmVuYwpjcCBQYXJzZXIvRW5jb2RpbmdzL2lzby04ODU5LTIuZW5jIGJs aWIvbGliL1hNTC9QYXJzZXIvRW5jb2RpbmdzL2lzby04ODU5LTIuZW5jCmNwIFBhcnNlci9FbmNv ZGluZ3MveC1zamlzLXVuaWNvZGUuZW5jIGJsaWIvbGliL1hNTC9QYXJzZXIvRW5jb2RpbmdzL3gt c2ppcy11bmljb2RlLmVuYwpjcCBQYXJzZXIvTFdQRXh0ZXJuRW50LnBsIGJsaWIvbGliL1hNTC9Q YXJzZXIvTFdQRXh0ZXJuRW50LnBsCmNwIFBhcnNlci9TdHlsZS9PYmplY3RzLnBtIGJsaWIvbGli L1hNTC9QYXJzZXIvU3R5bGUvT2JqZWN0cy5wbQpjcCBQYXJzZXIucG0gYmxpYi9saWIvWE1ML1Bh cnNlci5wbQpjcCBQYXJzZXIvU3R5bGUvRGVidWcucG0gYmxpYi9saWIvWE1ML1BhcnNlci9TdHls ZS9EZWJ1Zy5wbQpjcCBQYXJzZXIvRW5jb2RpbmdzL3gtc2ppcy1qaXN4MDIyMS5lbmMgYmxpYi9s aWIvWE1ML1BhcnNlci9FbmNvZGluZ3MveC1zamlzLWppc3gwMjIxLmVuYwpjcCBQYXJzZXIvU3R5 bGUvU3RyZWFtLnBtIGJsaWIvbGliL1hNTC9QYXJzZXIvU3R5bGUvU3RyZWFtLnBtCmNwIFBhcnNl ci9FbmNvZGluZ3MvaXNvLTg4NTktNS5lbmMgYmxpYi9saWIvWE1ML1BhcnNlci9FbmNvZGluZ3Mv aXNvLTg4NTktNS5lbmMKbWFrZVsxXTogRW50ZXJpbmcgZGlyZWN0b3J5IGAvdmFyL3RtcC9wb3J0 YWdlL2Rldi1wZXJsL1hNTC1QYXJzZXItMi4zNC93b3JrL1hNTC1QYXJzZXItMi4zNC9FeHBhdCcK Y3AgRXhwYXQucG0gLi4vYmxpYi9saWIvWE1ML1BhcnNlci9FeHBhdC5wbQovdXNyL2Jpbi9wZXJs NS44LjggL3Vzci9saWIvcGVybDUvNS44LjgvRXh0VXRpbHMveHN1YnBwIC1ub3Byb3RvdHlwZXMg LXR5cGVtYXAgL3Vzci9saWIvcGVybDUvNS44LjgvRXh0VXRpbHMvdHlwZW1hcCAtdHlwZW1hcCB0 eXBlbWFwICBFeHBhdC54cyA+IEV4cGF0LnhzYyAmJiBtdiBFeHBhdC54c2MgRXhwYXQuYwppMzg2 LXBjLWxpbnV4LWdudS1nY2MgLWMgICAtZm5vLXN0cmljdC1hbGlhc2luZyAtcGlwZSAtV2RlY2xh cmF0aW9uLWFmdGVyLXN0YXRlbWVudCAtRF9MQVJHRUZJTEVfU09VUkNFIC1EX0ZJTEVfT0ZGU0VU X0JJVFM9NjQgLUkvdXNyL2luY2x1ZGUvZ2RibSAtTzIgLW10dW5lPWk2ODYgLXBpcGUgICAtRFZF UlNJT049XCIyLjM0XCIgLURYU19WRVJTSU9OPVwiMi4zNFwiIC1mUElDICItSS91c3IvbGliL3Bl cmw1LzUuOC44L2kzODYtbGludXgvQ09SRSIgICBFeHBhdC5jCmdjYy1jb25maWcgZXJyb3I6IENv dWxkIG5vdCBydW4vbG9jYXRlICJpMzg2LXBjLWxpbnV4LWdudS1nY2MiCm1ha2VbMV06ICoqKiBb RXhwYXQub10gRXJyb3IgMQptYWtlWzFdOiBMZWF2aW5nIGRpcmVjdG9yeSBgL3Zhci90bXAvcG9y dGFnZS9kZXYtcGVybC9YTUwtUGFyc2VyLTIuMzQvd29yay9YTUwtUGFyc2VyLTIuMzQvRXhwYXQn Cm1ha2U6ICoqKiBbc3ViZGlyc10gRXJyb3IgMgoKISEhIEVSUk9SOiBkZXYtcGVybC9YTUwtUGFy c2VyLTIuMzQgZmFpbGVkLgpDYWxsIHN0YWNrOgogIGVidWlsZC5zaCwgbGluZSAxNjExOiAgIENh bGxlZCBkeW5fY29tcGlsZQogIGVidWlsZC5zaCwgbGluZSA5Njg6ICAgQ2FsbGVkIHFhX2NhbGwg J3NyY19jb21waWxlJwogIGVudmlyb25tZW50LCBsaW5lIDMyMDg6ICAgQ2FsbGVkIHNyY19jb21w aWxlCiAgZWJ1aWxkLnNoLCBsaW5lIDEzMDE6ICAgQ2FsbGVkIHBlcmwtbW9kdWxlX3NyY19jb21w aWxlCiAgcGVybC1tb2R1bGUuZWNsYXNzLCBsaW5lIDEzODogICBDYWxsZWQgZGllCgohISEgY29t cGlsYXRpb24gZmFpbGVkCiEhISBJZiB5b3UgbmVlZCBzdXBwb3J0LCBwb3N0IHRoZSB0b3Btb3N0 IGJ1aWxkIGVycm9yLCBhbmQgdGhlIGNhbGwgc3RhY2sgaWYgcmVsZXZhbnQuCiEhISBBIGNvbXBs ZXRlIGJ1aWxkIGxvZyBpcyBsb2NhdGVkIGF0ICcvdmFyL3RtcC9wb3J0YWdlL2Rldi1wZXJsOlhN TC1QYXJzZXItMi4zNDoyMDA3MDEyNC0yMTI0MDYubG9nJy4KCg==