135051 2006-05-31 08:22 0000 stage2 tries untaring a stage1root directory if seedache is not specified in config 2006-06-08 17:48:19 0000 1 1 1 Unclassified Gentoo Hosted Projects Catalyst unspecified All Other RESOLVED FIXED InCVS P2 normal --- 1 kumba@gentoo.org catalyst@gentoo.org kumba@gentoo.org 2006-05-31 08:22:30 0000 Logic in modules/generic_stage_target.py:575 attempts to deduce if both SEEDCACHE is defined in the catalyst config AND if the source_path is a directory. If both are true, then it is supposed to rsync the stage1root directory over as the stage2 build directory. If false, it attempts to run a tar extraction. In the event SEEDCACHE is not defined, but stage1root exists, catalyst inadvertently tries to run a tar extraction on a directory, which bombs most fantastically. Example: Using seed-stage from /usr/catalyst/tmp/default/stage1-mips3-2006.1-pre/tmp/stage1root/ Delete this folder if you wish to use a seed stage tarball instead The autoresume path is /usr/catalyst/tmp/default/.autoresume-stage2-mips3-2006.1-pre/ Location of the package cache is /usr/catalyst/packages/default/stage2-mips3-2006.1-pre/ Location of the kerncache is /usr/catalyst/kerncache/default/stage2-mips3-2006.1-pre/ Checking for processes running in chroot and killing them. Running action sequence: unpack Starting tar extract from /usr/catalyst/tmp/default/stage1-mips3-2006.1-pre/tmp/stage1root/ to /usr/catalyst/tmp/default/stage2-mips3-2006.1-pre/ (This may take some time) ... tar: /usr/catalyst/tmp/default/stage1-mips3-2006.1-pre/tmp/stage1root/: Cannot read: Is a directory tar: At beginning of tape, quitting now tar: Error is not recoverable: exiting now bzip2: Compressed file ends unexpectedly; perhaps it is corrupted? *Possible* reason follows. bzip2: Invalid argument Input file = (stdin), output file = (stdout) [snip] To resolve this, a patch is attached the re-writes the logic of this conditional block as such (abbreviated hacky C logic): if has_key(SEEDCACHE) { kumba@gentoo.org 2006-05-31 08:22:30 0000 Logic in modules/generic_stage_target.py:575 attempts to deduce if both SEEDCACHE is defined in the catalyst config AND if the source_path is a directory. If both are true, then it is supposed to rsync the stage1root directory over as the stage2 build directory. If false, it attempts to run a tar extraction. In the event SEEDCACHE is not defined, but stage1root exists, catalyst inadvertently tries to run a tar extraction on a directory, which bombs most fantastically. Example: Using seed-stage from /usr/catalyst/tmp/default/stage1-mips3-2006.1-pre/tmp/stage1root/ Delete this folder if you wish to use a seed stage tarball instead The autoresume path is /usr/catalyst/tmp/default/.autoresume-stage2-mips3-2006.1-pre/ Location of the package cache is /usr/catalyst/packages/default/stage2-mips3-2006.1-pre/ Location of the kerncache is /usr/catalyst/kerncache/default/stage2-mips3-2006.1-pre/ Checking for processes running in chroot and killing them. Running action sequence: unpack Starting tar extract from /usr/catalyst/tmp/default/stage1-mips3-2006.1-pre/tmp/stage1root/ to /usr/catalyst/tmp/default/stage2-mips3-2006.1-pre/ (This may take some time) ... tar: /usr/catalyst/tmp/default/stage1-mips3-2006.1-pre/tmp/stage1root/: Cannot read: Is a directory tar: At beginning of tape, quitting now tar: Error is not recoverable: exiting now bzip2: Compressed file ends unexpectedly; perhaps it is corrupted? *Possible* reason follows. bzip2: Invalid argument Input file = (stdin), output file = (stdout) [snip] To resolve this, a patch is attached the re-writes the logic of this conditional block as such (abbreviated hacky C logic): if has_key(SEEDCACHE) { ··· if isdir(source_path) { ······ /* Directory exists, use rsync */ ······ run rsync(); ··· } else { ······ /* Directory does not exist, or is not a ······ ** directory. Attempt tar extract instead ······ **/ ······ run tar_extract(); ··· } } else { ··· /* No SEEDCACHE, extract tarball */ ··· run tar_extract(); } kumba@gentoo.org 2006-05-31 08:23:23 0000 Created an attachment (id=87988) Rewrite SEEDCACHE extraction logic wolf31o2@gentoo.org 2006-06-08 14:27:09 0000 I've added this to CVS wolf31o2@gentoo.org 2006-06-08 17:48:19 0000 Fixed in 2.0_rc47 87988 2006-05-31 08:23 0000 Rewrite SEEDCACHE extraction logic cat2-fix-seedcache.patch text/plain LS0tIG1vZHVsZXMvZ2VuZXJpY19zdGFnZV90YXJnZXQucHkub3JpZwkyMDA2LTA1LTMwIDAyOjE4 OjQ3IC0wNDAwCisrKyBtb2R1bGVzL2dlbmVyaWNfc3RhZ2VfdGFyZ2V0LnB5LnJzeW5jCTIwMDYt MDUtMzEgMTU6MjI6MjcgLTA0MDAKQEAgLTU3MiwxMiArNTcyLDIyIEBAIGNsYXNzIGdlbmVyaWNf c3RhZ2VfdGFyZ2V0KGdlbmVyaWNfdGFyZ2UKIAogCQljbHN0X3VucGFja19oYXNoPXJlYWRfZnJv bV9jbHN0KHNlbGYuc2V0dGluZ3NbImF1dG9yZXN1bWVfcGF0aCJdKyJ1bnBhY2siKQogCQkKLQkJ aWYgc2VsZi5zZXR0aW5ncy5oYXNfa2V5KCJTRUVEQ0FDSEUiKSBhbmQgb3MucGF0aC5pc2Rpcihz ZWxmLnNldHRpbmdzWyJzb3VyY2VfcGF0aCJdKTogCi0JCQl1bnBhY2tfY21kPSJyc3luYyAtYSAt LWRlbGV0ZSAiK3NlbGYuc2V0dGluZ3NbInNvdXJjZV9wYXRoIl0rIiAiK3NlbGYuc2V0dGluZ3Nb ImNocm9vdF9wYXRoIl0KLQkJCWRpc3BsYXlfbXNnPSJcblN0YXJ0aW5nIHJzeW5jIGZyb20gIitz ZWxmLnNldHRpbmdzWyJzb3VyY2VfcGF0aCJdKyJcbnRvICIrXAotCQkJCXNlbGYuc2V0dGluZ3Nb ImNocm9vdF9wYXRoIl0rIiAoVGhpcyBtYXkgdGFrZSBzb21lIHRpbWUpIC4uLlxuIgotCQkJZXJy b3JfbXNnPSJSc3luYyBvZiAiK3NlbGYuc2V0dGluZ3NbInNvdXJjZV9wYXRoIl0rIiB0byAiK3Nl bGYuc2V0dGluZ3NbImNocm9vdF9wYXRoIl0rIiBmYWlsZWQuIgorCQlpZiBzZWxmLnNldHRpbmdz Lmhhc19rZXkoIlNFRURDQUNIRSIpOgorCQkJaWYgb3MucGF0aC5pc2RpcihzZWxmLnNldHRpbmdz WyJzb3VyY2VfcGF0aCJdKTogCisJCQkJIyBTRUVEQ0FDSEUgSXMgYSBkaXJlY3RvcnksIHVzZSBS c3luYworCQkJCXVucGFja19jbWQ9InJzeW5jIC1hIC0tZGVsZXRlICIrc2VsZi5zZXR0aW5nc1si c291cmNlX3BhdGgiXSsiICIrc2VsZi5zZXR0aW5nc1siY2hyb290X3BhdGgiXQorCQkJCWRpc3Bs YXlfbXNnPSJcblN0YXJ0aW5nIHJzeW5jIGZyb20gIitzZWxmLnNldHRpbmdzWyJzb3VyY2VfcGF0 aCJdKyJcbnRvICIrXAorCQkJCQlzZWxmLnNldHRpbmdzWyJjaHJvb3RfcGF0aCJdKyIgKFRoaXMg bWF5IHRha2Ugc29tZSB0aW1lKSAuLi5cbiIKKwkJCQllcnJvcl9tc2c9IlJzeW5jIG9mICIrc2Vs Zi5zZXR0aW5nc1sic291cmNlX3BhdGgiXSsiIHRvICIrc2VsZi5zZXR0aW5nc1siY2hyb290X3Bh dGgiXSsiIGZhaWxlZC4iCisJCQllbHNlOgorCQkJCSMgU0VFRENBQ0hFIGlzIGEgbm90IGEgZGly ZWN0b3J5LCB0cnkgdW50YXInaW5nCisJCQkJcHJpbnQgIlJlZmVyZW5jZWQgU0VFRENBQ0hFIGRv ZXMgbm90IGFwcGVhciB0byBiZSBhIGRpcmVjdG9yeSwgdHJ5aW5nIHRvIHVudGFyLi4uIgorCQkJ CWRpc3BsYXlfbXNnPSJcblN0YXJ0aW5nIHRhciBleHRyYWN0IGZyb20gIitzZWxmLnNldHRpbmdz WyJzb3VyY2VfcGF0aCJdKyJcbnRvICIrXAorCQkJCQlzZWxmLnNldHRpbmdzWyJjaHJvb3RfcGF0 aCJdKyIgKFRoaXMgbWF5IHRha2Ugc29tZSB0aW1lKSAuLi5cbiIKKwkJCQl1bnBhY2tfY21kPSJ0 YXIgeGpwZiAiK3NlbGYuc2V0dGluZ3NbInNvdXJjZV9wYXRoIl0rIiAtQyAiK3NlbGYuc2V0dGlu Z3NbImNocm9vdF9wYXRoIl0KKwkJCQllcnJvcl9tc2c9IlRhcmJhbGwgZXh0cmFjdGlvbiBvZiAi K3NlbGYuc2V0dGluZ3NbInNvdXJjZV9wYXRoIl0rIiB0byAiK3NlbGYuc2V0dGluZ3NbImNocm9v dF9wYXRoIl0rIiBmYWlsZWQuIgogCQllbHNlOgorCQkJIyBObyBTRUVEQ0FDSEUsIHVzZSB0YXIK IAkJCWRpc3BsYXlfbXNnPSJcblN0YXJ0aW5nIHRhciBleHRyYWN0IGZyb20gIitzZWxmLnNldHRp bmdzWyJzb3VyY2VfcGF0aCJdKyJcbnRvICIrXAogCQkJCXNlbGYuc2V0dGluZ3NbImNocm9vdF9w YXRoIl0rIiAoVGhpcyBtYXkgdGFrZSBzb21lIHRpbWUpIC4uLlxuIgogCQkJdW5wYWNrX2NtZD0i dGFyIHhqcGYgIitzZWxmLnNldHRpbmdzWyJzb3VyY2VfcGF0aCJdKyIgLUMgIitzZWxmLnNldHRp bmdzWyJjaHJvb3RfcGF0aCJdCg==