133538 2006-05-16 14:25 0000 games-strategy/freelords-0.3.7 does not compile with gcc-4.1; patch inside + patch for a freelordsrc problem 2006-09-06 13:36:03 0000 1 1 1 Unclassified Gentoo Linux Games 2006.0 All Linux RESOLVED FIXED P2 normal --- 140707 1 aballier@gentoo.org games@gentoo.org hkbst@gentoo.org aballier@gentoo.org 2006-05-16 14:25:55 0000 I've encoutered compile time problems, and runtime problems; two patches will follow, fixing it for me. Here is my emerge --info (This is weird, it shows gcc beta but I've 4.1-r1): Portage 2.1_rc1-r2 (default-linux/amd64/2006.0, gcc-4.1.0-beta20060106, glibc-2.4-r3, 2.6.16 x86_64) ================================================================= System uname: 2.6.16 x86_64 AMD Athlon(tm) 64 Processor 3200+ Gentoo Base System version 1.12.0_pre19 distcc 2.18.3 x86_64-pc-linux-gnu (protocols 1 and 2) (default port 3632) [disabled] ccache version 2.4 [enabled] dev-lang/python: 2.4.3-r1 dev-python/pycrypto: 2.0.1-r5 dev-util/ccache: 2.4-r1 dev-util/confcache: [Not Present] sys-apps/sandbox: 1.2.17 sys-devel/autoconf: 2.13, 2.59-r7 sys-devel/automake: 1.4_p6, 1.5, 1.6.3, 1.7.9-r1, 1.8.5-r3, 1.9.6-r2 sys-devel/binutils: 2.16.1-r2 sys-devel/libtool: 1.5.22 virtual/os-headers: 2.6.11-r3 ACCEPT_KEYWORDS="amd64 ~amd64" AUTOCLEAN="yes" CBUILD="x86_64-pc-linux-gnu" CFLAGS="-march=athlon64 -O2 -pipe -funroll-loops" CHOST="x86_64-pc-linux-gnu" CONFIG_PROTECT="/etc /usr/kde/2/share/config /usr/kde/3.4/env /usr/kde/3.4/share/config /usr/kde/3.4/shutdown /usr/kde/3.5/env /usr/kde/3.5/share/config /usr/kde/3.5/shutdown /usr/kde/3/share/config /usr/lib64/mozilla/defaults/pref /usr/share/X11/xkb /usr/share/config /var/qmail/control" CONFIG_PROTECT_MASK="/etc/eselect/compiler /etc/gconf /etc/terminfo /etc/texmf/web2c /etc/env.d" CXXFLAGS="-march=athlon64 -O2 -pipe -funroll-loops" DISTDIR="/share/distfiles" FEATURES="autoconfig buildsyspkg ccache distlocks fixpackages metadata-transfer sfperms strict userpriv" GENTOO_MIRRORS="http://mir.zyrianes.net/gentoo/ http://www.ibiblio.org/pub/Linux/distributions/gentoo" LANG="fr_FR.UTF-8" LC_ALL="fr_FR.UTF-8" MAKEOPTS="-j5" PKGDIR="/usr/portage/packages" PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --compress --force --whole-file --delete --delete-after --stats --timeout=180 --exclude='/distfiles' --exclude='/local' --exclude='/packages'" PORTAGE_TMPDIR="/var/tmp" PORTDIR="/usr/portage" PORTDIR_OVERLAY="/usr/local/portage" SYNC="rsync://rsync.gentoo.org/gentoo-portage" USE="amd64 X a52 aac aalib alsa apache2 audiofile avi bash-completion berkdb bitmap-fonts bluetooth bzip2 cddb cdr cli crypt cups custom-cflags dba directfb divx4linux dri dv dvd dvdr dvdread eds emboss encode escreen faad fbdev ffmpeg flac foomaticdb fortran fping gd gif gimp gnutls gpm gstreamer gtk gtk2 hal ide imagemagick imap imlib ipv6 irmc isdnlog ithreads jpeg jpeg2k latex lcms libcaca lirc lzo lzw lzw-tiff mad maildir mozilla mp3 mp4 mpeg mplayer myqsl mysql ncurses nls nowin nptl nptlonly nsplugin nvidia offensive ogg oggvorbis opengl opie pam pcre pdflib perl png ppds pppd python quicktime readline reflection rtc samba sdl session slang sms softmmu spell spl ssl stroke subtitles subversion tcpd threads tiff truetype truetype-fonts type1-fonts udev unicode usb utf8 v4l2 vchroot vorbis x264 xml2 xorg xpm xprint xv xvid xvmc zlib elibc_glibc input_devices_keyboard input_devices_mouse kernel_linux userland_GNU video_cards_vesa video_cards_nv video_cards_nvidia" Unset: ASFLAGS, CTARGET, EMERGE_DEFAULT_OPTS, INSTALL_MASK, LDFLAGS, LINGUAS, PORTAGE_RSYNC_EXTRA_OPTS aballier@gentoo.org 2006-05-16 14:29:39 0000 Created an attachment (id=86882) The patch for compile time problems. It's mostly trivial fixes. All changes but the "int -> long" should be arch independant. The int -> long is an amd64 specific fix, a pointer was casted into an int, what caused a compile error. Casting it into a long fixes the issue and should also be arch independant. aballier@gentoo.org 2006-05-16 14:33:00 0000 Created an attachment (id=86885) The freelordsrc patch. freelordsrc generation was not good for the savegame dir, what caused problem with perms when trying to run freelords because it tried to write to /var/tmp/portage/.... This patch simply removes the line about savegames location, by default they go to ~/.freelords/ so that solves the issue. aballier@gentoo.org 2006-05-16 14:34:56 0000 Created an attachment (id=86886) The ebuild that applies those patches. This only adds two epatch lines to the current freelords-0.3.7 ebuild. With this, freelords runs perfectly on my system ;) hkbst@gentoo.org 2006-06-07 08:51:38 0000 I confirm that freelords fails to compile with gcc-4.1.1 v1.5 of the ebuild freelords-0.3.7 has this line epatch "${FILESDIR}/${P}"-gcc41.patch but your new version (based on 1.4 apparently) has epatch ${FILESDIR}/${P}.gcc41.patch So apparently there are already some patches for gcc-4.1, which maybe aren't used? Should your patch be appended to this file or replace it or something other? Did you send a patch to the freelords developers? aballier@gentoo.org 2006-06-09 08:00:38 0000 I've had a look at the patch in portage, it is the same as the one I submitted but without the amd64 fix. The dev who added this patch probably did not look for bugs here. I've not sent it upstream since it's only trivial fixes. hkbst@gentoo.org 2006-08-14 03:07:07 0000 hmm, it's been three months and this patch has still not been merged :( Specifically this patch is missing from portage: diff -N -u -r freelords-0.3.7-old/src/OptionsDialog.cpp freelords-0.3.7/src/OptionsDialog.cpp --- freelords-0.3.7-old/src/OptionsDialog.cpp 2006-05-16 22:38:32.921421416 +0200 +++ freelords-0.3.7/src/OptionsDialog.cpp 2006-05-16 22:46:17.083151544 +0200 @@ -245,7 +245,7 @@ d_smooth_scrolling->Hide(); d_show_next_player->Hide(); - unsigned int mode = (unsigned int)item->GetUserData(); + unsigned long mode = (unsigned long)item->GetUserData(); switch(mode) { hkbst@gentoo.org 2006-08-14 03:26:42 0000 Using Alexis' ebuild and patches freelords compiles and runs. I did get a segmentation fault when clicking languages. wasowski@data.pl 2006-09-06 03:11:58 0000 In fact 0.3.4 does not compile with gcc 4.1 either. This means that the stable ebuild cannot be compiled on a regular stable system any more :( (Unfortunately, I do not have time at the moment to see whether the patch provided applies cleanly to 0.3.4). wolf31o2@gentoo.org 2006-09-06 13:36:03 0000 Updated GCC 4.1.1 patch and added the other patch... emerge --sync in an hour to get the newer version... I am also marking it stable where necessary so it will work with the stable tree... 86882 2006-05-16 14:29 0000 The patch for compile time problems. freelords-0.3.7.gcc41.patch text/plain ZGlmZiAtTiAtdSAtciBmcmVlbG9yZHMtMC4zLjctb2xkL3NyYy9haV9zbWFydC5oIGZyZWVsb3Jk cy0wLjMuNy9zcmMvYWlfc21hcnQuaAotLS0gZnJlZWxvcmRzLTAuMy43LW9sZC9zcmMvYWlfc21h cnQuaAkyMDA2LTA1LTE2IDIyOjM4OjMyLjQ2MTUyMjc0NyArMDIwMAorKysgZnJlZWxvcmRzLTAu My43L3NyYy9haV9zbWFydC5oCTIwMDYtMDUtMTYgMjI6NDI6NTMuMTgwMDc3OTk5ICswMjAwCkBA IC0xMDYsNyArMTA2LDcgQEAKICAgICAgICAgVGhyZWF0ICpnZXRCaWdnZXN0RGFuZ2VyVG8oQ2l0 eSAqY2l0eSwgVGhyZWF0bGlzdCAqdGhyZWF0cyk7CiAgICAgICAgIAogICAgICAgICAvLyBleGFt aW5lIGNpdGllcyB0byBzZWUgaWYgd2UgbmVlZCB0byBjaGFuZ2UgcHJvZHVjdGlvbgotICAgICAg ICB2b2lkIEFJX1NtYXJ0OjpleGFtaW5lQ2l0aWVzKCk7CisgICAgICAgIHZvaWQgZXhhbWluZUNp dGllcygpOwogfTsKIAogI2VuZGlmIC8vIEFJX1NNQVJUX0gKZGlmZiAtTiAtdSAtciBmcmVlbG9y ZHMtMC4zLjctb2xkL3NyYy9PcHRpb25zRGlhbG9nLmNwcCBmcmVlbG9yZHMtMC4zLjcvc3JjL09w dGlvbnNEaWFsb2cuY3BwCi0tLSBmcmVlbG9yZHMtMC4zLjctb2xkL3NyYy9PcHRpb25zRGlhbG9n LmNwcAkyMDA2LTA1LTE2IDIyOjM4OjMyLjkyMTQyMTQxNiArMDIwMAorKysgZnJlZWxvcmRzLTAu My43L3NyYy9PcHRpb25zRGlhbG9nLmNwcAkyMDA2LTA1LTE2IDIyOjQ2OjE3LjA4MzE1MTU0NCAr MDIwMApAQCAtMjQ1LDcgKzI0NSw3IEBACiAgICAgZF9zbW9vdGhfc2Nyb2xsaW5nLT5IaWRlKCk7 CiAgICAgZF9zaG93X25leHRfcGxheWVyLT5IaWRlKCk7CiAKLSAgICB1bnNpZ25lZCBpbnQgbW9k ZSA9ICh1bnNpZ25lZCBpbnQpaXRlbS0+R2V0VXNlckRhdGEoKTsKKyAgICB1bnNpZ25lZCBsb25n IG1vZGUgPSAodW5zaWduZWQgbG9uZylpdGVtLT5HZXRVc2VyRGF0YSgpOwogCiAgICAgc3dpdGNo KG1vZGUpCiAgICAgewpkaWZmIC1OIC11IC1yIGZyZWVsb3Jkcy0wLjMuNy1vbGQvc3JjL3BhdGgu aCBmcmVlbG9yZHMtMC4zLjcvc3JjL3BhdGguaAotLS0gZnJlZWxvcmRzLTAuMy43LW9sZC9zcmMv cGF0aC5oCTIwMDYtMDUtMTYgMjI6Mzg6MzIuNDY1NTIxODY2ICswMjAwCisrKyBmcmVlbG9yZHMt MC4zLjcvc3JjL3BhdGguaAkyMDA2LTA1LTE2IDIyOjQwOjI4LjY1NTkyMTM1NSArMDIwMApAQCAt NjAsNyArNjAsNyBAQAogICAgICAgICAvKiBUaGlzIGZ1bmN0aW9uIGlzIHVzZWQgdG8gdmVyaWZ5 IGlmIHRoZSBzdGFjayBjYW4gbW92ZSBvbiB0aGUgVGlsZQogICAgICAgICAgKiBvZiB0aGUgZ2l2 ZW4gZGVzdGluYXRpb24gcG9pbnQKICAgICAgICAgICovCi0gICAgICAgIGJvb2wgUGF0aDo6Y2Fu TW92ZVRoZXJlKFN0YWNrKiBzLCBQR19Qb2ludCogZGVzdCk7CisgICAgICAgIGJvb2wgY2FuTW92 ZVRoZXJlKFN0YWNrKiBzLCBQR19Qb2ludCogZGVzdCk7CiAKICAgICAgICAgLyoqIFZhbGlkYXRl cyBhbiBleGlzdGluZyBwYXRoLgogICAgICAgICAgICogCmRpZmYgLU4gLXUgLXIgZnJlZWxvcmRz LTAuMy43LW9sZC9zcmMvc2Nyb2xsZXIuaCBmcmVlbG9yZHMtMC4zLjcvc3JjL3Njcm9sbGVyLmgK LS0tIGZyZWVsb3Jkcy0wLjMuNy1vbGQvc3JjL3Njcm9sbGVyLmgJMjAwNi0wNS0xNiAyMjozODoz Mi45Mzc0MTc4OTIgKzAyMDAKKysrIGZyZWVsb3Jkcy0wLjMuNy9zcmMvc2Nyb2xsZXIuaAkyMDA2 LTA1LTE2IDIyOjQ0OjI0LjI0NDAxMzY2MyArMDIwMApAQCAtMzksNyArMzksNyBAQAogICAgICAg ICB2b2lkIGV2ZW50TW91c2VMZWF2ZSgpOwogCiAgICAgICAgIC8vISBCZWdpbiB0aGUgc2Nyb2xs Ci0gICAgICAgIFVpbnQzMiBTY3JvbGxlcjo6ZXZlbnRUaW1lciAoSUQgaWQsIFVpbnQzMiBpbnRl cnZhbCk7CisgICAgICAgIFVpbnQzMiBldmVudFRpbWVyIChJRCBpZCwgVWludDMyIGludGVydmFs KTsKIAogICAgICAgICBVaW50MzIgZF90aW1lcjsKICAgICAgICAgU21hbGxNYXAgKiBkX3NtYXA7 CmRpZmYgLU4gLXUgLXIgZnJlZWxvcmRzLTAuMy43LW9sZC9zcmMvdG9vbHRpcC5oIGZyZWVsb3Jk cy0wLjMuNy9zcmMvdG9vbHRpcC5oCi0tLSBmcmVlbG9yZHMtMC4zLjctb2xkL3NyYy90b29sdGlw LmgJMjAwNi0wNS0xNiAyMjozODozMi41MDU1MTMwNTUgKzAyMDAKKysrIGZyZWVsb3Jkcy0wLjMu Ny9zcmMvdG9vbHRpcC5oCTIwMDYtMDUtMTYgMjI6NDQ6NDkuNDI2NDY1MTUzICswMjAwCkBAIC01 NSw3ICs1NSw3IEBACiAgICAgICAgIGJvb2wgZXZlbnRNb3VzZU1vdGlvbihjb25zdCBTRExfTW91 c2VNb3Rpb25FdmVudCogZXZlbnQpOwogICAgICAgICBib29sIGV2ZW50TW91c2VCdXR0b25Eb3du KGNvbnN0IFNETF9Nb3VzZUJ1dHRvbkV2ZW50KiBldmVudCk7CiAgICAgICAgIC8vISBTaG93cyB0 aGUgdG9vbHRpcCBhZnRlciBUT09MVElQX1dBSVQgbWlsbGlzZWNvbmRzCi0gICAgICAgIFVpbnQz MiBUb29sVGlwOjpldmVudFRpbWVyIChJRCBpZCwgVWludDMyIGludGVydmFsKTsKKyAgICAgICAg VWludDMyIGV2ZW50VGltZXIgKElEIGlkLCBVaW50MzIgaW50ZXJ2YWwpOwogCiAgICAgICAgIFVp bnQzMiBkX3RpbWVyOwogICAgICAgICBpbnQgZF9tb3ZlY291bnRlcjsK 86885 2006-05-16 14:33 0000 The freelordsrc patch. freelords-0.3.7.freelordsrcin.patch text/plain ZGlmZiAtTiAtdSAtciBmcmVlbG9yZHMtMC4zLjctb2xkL2ZyZWVsb3Jkc3JjLmluIGZyZWVsb3Jk cy0wLjMuNy9mcmVlbG9yZHNyYy5pbgotLS0gZnJlZWxvcmRzLTAuMy43LW9sZC9mcmVlbG9yZHNy Yy5pbgkyMDA2LTA1LTE2IDIzOjIxOjQ4LjcwOTQ4NTE3NiArMDIwMAorKysgZnJlZWxvcmRzLTAu My43L2ZyZWVsb3Jkc3JjLmluCTIwMDYtMDUtMTYgMjM6MjI6MTAuNzEyNjM3MTY5ICswMjAwCkBA IC0xLDcgKzEsNyBAQAogPD94bWwgdmVyc2lvbj0iMS4wIj8+CiA8ZnJlZWxvcmRzcmMgdmVyc2lv bj0iQFZFUlNJT05AIj4KICAgICA8ZF9kYXRhcGF0aD5ARlJFRUxPUkRTX0RBVEFESVJAPC9kX2Rh dGFwYXRoPgotICAgIDxkX3NhdmVwYXRoPkBIT01FQC8uZnJlZWxvcmRzPC9kX3NhdmVwYXRoPgor CiAgICAgPGRfbGFuZz5DPC9kX2xhbmc+CiAgICAgPGRfcmVzb2x1dGlvbj5AU0NSRUVOX1JFU09M VVRJT05APC9kX3Jlc29sdXRpb24+CiAgICAgPGRfZnVsbHNjcmVlbj5AVVNFX0ZVTExTQ1JFRU5A PC9kX2Z1bGxzY3JlZW4+Cg== 86886 2006-05-16 14:34 0000 The ebuild that applies those patches. freelords-0.3.7-r1.ebuild text/plain IyBDb3B5cmlnaHQgMTk5OS0yMDA2IEdlbnRvbyBGb3VuZGF0aW9uCiMgRGlzdHJpYnV0ZWQgdW5k ZXIgdGhlIHRlcm1zIG9mIHRoZSBHTlUgR2VuZXJhbCBQdWJsaWMgTGljZW5zZSB2MgojICRIZWFk ZXI6IC92YXIvY3Zzcm9vdC9nZW50b28teDg2L2dhbWVzLXN0cmF0ZWd5L2ZyZWVsb3Jkcy9mcmVl bG9yZHMtMC4zLjcuZWJ1aWxkLHYgMS40IDIwMDYvMDQvMjggMjE6MjU6NDYgbXJfYm9uZXNfIEV4 cCAkCgppbmhlcml0IGV1dGlscyBnYW1lcwoKREVTQ1JJUFRJT049IkZyZWUgV2FybG9yZHMgY2xv bmUiCkhPTUVQQUdFPSJodHRwOi8vd3d3LmZyZWVsb3Jkcy5vcmcvIgpTUkNfVVJJPSJtaXJyb3I6 Ly9zb3VyY2Vmb3JnZS9mcmVlbG9yZHMvJHtQfS50YXIuYnoyIgoKS0VZV09SRFM9In5hbWQ2NCB+ cHBjIH54ODYiCkxJQ0VOU0U9IkdQTC0yIgpTTE9UPSIwIgpJVVNFPSJlZGl0b3IgbmxzIgoKUkRF UEVORD0iZGV2LWxpYnMvZXhwYXQKCW1lZGlhLWxpYnMvc2RsLW1peGVyCgk+PW1lZGlhLWxpYnMv bGlic2RsLTEuMgoJPj1tZWRpYS1saWJzL3NkbC1pbWFnZS0xLjIKCT49bWVkaWEtbGlicy9mcmVl dHlwZS0yCgk+PW1lZGlhLWxpYnMvcGFyYWd1aS0xLjEuOAoJIT1tZWRpYS1saWJzL3BhcmFndWkt MS4wKgoJPWRldi1saWJzL2xpYnNpZ2MrKy0xLjIqIgpERVBFTkQ9IiR7UkRFUEVORH0KCW5scz8g KCBzeXMtZGV2ZWwvZ2V0dGV4dCApCglkZXYtdXRpbC9wa2djb25maWciCgpwa2dfc2V0dXAoKSB7 CglpZiAhIGJ1aWx0X3dpdGhfdXNlIC1vIG1lZGlhLWxpYnMvc2RsLW1peGVyIHZvcmJpcyBvZ2d2 b3JiaXMgOyB0aGVuCgkJZGllICJQbGVhc2UgZW1lcmdlIHNkbG1peGVyIHdpdGggVVNFPXZvcmJp cyIKCWZpCglnYW1lc19wa2dfc2V0dXAKfQoKc3JjX3VucGFjaygpIHsKCXVucGFjayAke0F9Cglj ZCAiJHtTfSIKCXNlZCAtaSBcCgkJLWUgInM6XCJmcmVlbG9yZHNyY1wiOlwiJHtHQU1FU19TWVND T05GRElSfS9mcmVlbG9yZHNyY1wiOiIgXAoJCXNyYy9tYWluLmNwcCBcCgkJfHwgZGllICJzZWQg c3JjL21haW4uY3BwIGZhaWxlZCIKCXNlZCAtaSBcCgkJLWUgJy9ebG9jYWxlZGlyLyBzOiQoZGF0 YWRpcik6L3Vzci9zaGFyZTonIFwKCQktZSAnczokKHByZWZpeCkvc2hhcmUvbG9jYWxlOi91c3Iv c2hhcmUvbG9jYWxlOicgc3JjL01ha2VmaWxlLmluIFwKCQl8fCBkaWUgInNlZCBzcmMvTWFrZWZp bGUuaW4gZmFpbGVkIgoJZXBhdGNoICR7RklMRVNESVJ9LyR7UH0uZ2NjNDEucGF0Y2gKCWVwYXRj aCAke0ZJTEVTRElSfS8ke1B9LmZyZWVsb3Jkc3JjaW4ucGF0Y2gKfQoKc3JjX2NvbXBpbGUoKSB7 CgllZ2FtZXNjb25mIFwKCQktLWRpc2FibGUtZGVwZW5kZW5jeS10cmFja2luZyBcCgkJLS1kaXNh YmxlLXBhcmFndWl0ZXN0IFwKCQkkKHVzZV9lbmFibGUgZWRpdG9yKSBcCgkJJCh1c2VfZW5hYmxl IG5scykgXAoJCXx8IGRpZQoJZW1ha2UgXAoJCWxvY2FsZWRpcj0iL3Vzci9zaGFyZS9sb2NhbGUi IFwKCQlDWFhGTEFHUz0iJHtDWFhGTEFHU30iIHx8IGRpZSAiZW1ha2UgZmFpbGVkIgp9CgpzcmNf aW5zdGFsbCgpIHsKCW1ha2UgXAoJCURFU1RESVI9IiR7RH0iIFwKCQlsb2NhbGVkaXI9Ii91c3Iv c2hhcmUvbG9jYWxlIiBcCgkJZmxkZXNrdG9wZGlyPSIvdXNyL3NoYXJlL2FwcGxpY2F0aW9ucyIg XAoJCWluc3RhbGwgfHwgZGllICJtYWtlIGluc3RhbGwgZmFpbGVkIgoJZG9kb2MgQVVUSE9SUyBC VUdTIENoYW5nZUxvZyBERVBFTkRFTkNJRVMgSEFDS0VSIE5FV1MgUkVBRE1FIFRPRE8gXAoJCWRv Yy9bWzp1cHBlcjpdXSoKCXByZXBnYW1lc2RpcnMKfQo=