133176 2006-05-13 01:12 0000 code2html does not recognize Ada identifiers (partial fix attached) 2009-05-30 16:41:20 0000 1 1 1 Unclassified Gentoo Linux Applications unspecified All Linux CLOSED FIXED P2 normal --- 1 esigra@gmail.com leonardop@gentoo.org esigra@gmail.com 2006-05-13 01:12:13 0000 Upstream bug report at: https://sourceforge.net/tracker/index.php?func=detail&aid=1487803&group_id=2902&atid=102902 Ada identifiers are not correctly recognized. The first problem is that it detects words like A__B and B_ as Ada identifiers, which they are not. The second problem is that it does not detect words like T esigra@gmail.com 2006-05-13 01:12:13 0000 Upstream bug report at: https://sourceforge.net/tracker/index.php?func=detail&aid=1487803&group_id=2902&atid=102902 Ada identifiers are not correctly recognized. The first problem is that it detects words like A__B and B_ as Ada identifiers, which they are not. The second problem is that it does not detect words like Täthet and Anlaß as identifiers, which they are. esigra@gmail.com 2006-05-13 01:13:30 0000 Created an attachment (id=86687) Fix for the first part of the problem. esigra@gmail.com 2006-05-13 10:03:27 0000 Created an attachment (id=86708) Patch that fixes the first part of the problem. After getting some help at http://www.nntp.perl.org/group/perl.beginners/83569 I have modified the partial fix: * use character class [:alpha:] * use more compact and clever character class [^\W_] * use the non-capturing group (?:) The second problem is more complicated. Perl expects input in UTF-8 encoding. Since Ada sourcecode is in latin1 (comments can be in any encoding), an input layer is needed. An output layer is probably also needed, since HTML should have things like "å". esigra@gmail.com 2006-05-14 04:40:37 0000 Now I finally made a patch that fixes all the problem cases for me. It adds "use locale;". I also added character set headers to the HTML templates. I had to make sure that LANG is set to swedish in the shell where I run code2html to make it work. esigra@gmail.com 2006-05-14 04:41:34 0000 Created an attachment (id=86744) Patch that fixes the problem for me if I have LANG set to swedish. leonardop@gentoo.org 2006-05-17 13:45:26 0000 Thanks, committed for code2html-0.9.1-r1. 86687 2006-05-13 01:13 0000 Fix for the first part of the problem. ada_identifiers_fix_partial-1.diff text/plain LS0tIGNvZGUyaHRtbAkyMDA2LTA1LTEzIDAzOjE3OjM1LjAwMDAwMDAwMCArMDIwMAorKysgY29k ZTJodG1sLmFkYV9pZGVudGlmaWVyc19maXhlZAkyMDA2LTA1LTEzIDEwOjAzOjI3LjAwMDAwMDAw MCArMDIwMApAQCAtMTk2OCw1ICsxOTY4LDUgQEAKICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICB7CiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAnbmFtZScgICAgICAgPT4gJ0lkZW50aWZpZXJzJywKLSAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICdyZWdleCcgICAgICA9PiAnXFxi W2EtekEtWl1bYS16QS1aMC05X10qXFxiJywKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICdyZWdleCcgICAgICA9PiAnXFxiW2EtekEtWl0oXz9bYS16QS1a MC05XSkqXFxiJywKIAkJCQkJICAgICAgICAnc3R5bGUnICAgICAgPT4gJ2lkZW50aWZpZXInLAog ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgJ2NoaWxkcmVn ZXgnID0+IFtdCg== 86708 2006-05-13 10:03 0000 Patch that fixes the first part of the problem. ada_identifiers_fix_partial-1.diff text/plain LS0tIGNvZGUyaHRtbAkyMDA2LTA1LTEzIDAzOjE3OjM1LjAwMDAwMDAwMCArMDIwMAorKysgY29k ZTJodG1sLmFkYV9pZGVudGlmaWVyc19maXhlZAkyMDA2LTA1LTEzIDE4OjM3OjU3LjAwMDAwMDAw MCArMDIwMApAQCAtMSwzICsxLDUgQEAKICMhL3Vzci9iaW4vcGVybCAtdwordXNlIGxvY2FsZTsK KyN1c2UgZW5jb2RpbmcgJ2xhdGluMSc7CiBteSAkdmVybnIgPSAiMC45LjEiOwogbXkgJG1vbnRo c2hvcnQgPSAiSmFuIjsKQEAgLTE4OTksNSArMTkwMSw0IEBACiAKIAotCiAjIHRha2VuIGZyb20g bmVkaXQKICMgbW9kaWZpZWQgYnkgUFAKQEAgLTE5NjgsNSArMTk2OSw1IEBACiAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgewogICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgJ25hbWUnICAgICAgID0+ICdJZGVudGlmaWVy cycsCi0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAncmVn ZXgnICAgICAgPT4gJ1xcYlthLXpBLVpdW2EtekEtWjAtOV9dKlxcYicsCisgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAncmVnZXgnICAgICAgPT4gJ1xcYltb OmFscGhhOl1dKD86Xz9bXlxXX10pKlxcYicsCiAJCQkJCSAgICAgICAgJ3N0eWxlJyAgICAgID0+ ICdpZGVudGlmaWVyJywKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICdjaGlsZHJlZ2V4JyA9PiBbXQo= 86744 2006-05-14 04:41 0000 Patch that fixes the problem for me if I have LANG set to swedish. ada_identifiers_fix-2.diff text/plain LS0tIGNvZGUyaHRtbAkyMDA2LTA1LTEzIDAzOjE3OjM1LjAwMDAwMDAwMCArMDIwMAorKysgY29k ZTJodG1sLmFkYV9pZGVudGlmaWVyc19maXhlZAkyMDA2LTA1LTE0IDEyOjE5OjIzLjAwMDAwMDAw MCArMDIwMApAQCAtMSwzICsxLDQgQEAKICMhL3Vzci9iaW4vcGVybCAtdwordXNlIGxvY2FsZTsK IG15ICR2ZXJuciA9ICIwLjkuMSI7CiBteSAkbW9udGhzaG9ydCA9ICJKYW4iOwpAQCAtMTMyNiw0 ICsxMzI3LDUgQEAKICc8aHRtbD4KIDxoZWFkPgorICA8bWV0YSBodHRwLWVxdWl2PSJDb250ZW50 LVR5cGUiIGNvbnRlbnQ9InRleHQvaHRtbDsgY2hhcnNldD1JU08tODg1OS0xIj4KICAgPHRpdGxl PiUldGl0bGUlJTwvdGl0bGU+CiA8L2hlYWQ+CkBAIC0xNDc0LDQgKzE0NzYsNSBAQAogJHsgJFNU WUxFU0hFRVR7J2h0bWwtbm9iZyd9fSB7J3RlbXBsYXRlJ30gPSAnPGh0bWw+CiA8aGVhZD4KKyAg PG1ldGEgaHR0cC1lcXVpdj0iQ29udGVudC1UeXBlIiBjb250ZW50PSJ0ZXh0L2h0bWw7IGNoYXJz ZXQ9SVNPLTg4NTktMSI+CiAgIDx0aXRsZT4lJXRpdGxlJSU8L3RpdGxlPgogPC9oZWFkPgpAQCAt MTQ5NCw0ICsxNDk3LDUgQEAKICR7ICRTVFlMRVNIRUVUeydodG1sLWRhcmsnfX0geyd0ZW1wbGF0 ZSd9ID0gJzxodG1sPgogPGhlYWQ+CisgIDxtZXRhIGh0dHAtZXF1aXY9IkNvbnRlbnQtVHlwZSIg Y29udGVudD0idGV4dC9odG1sOyBjaGFyc2V0PUlTTy04ODU5LTEiPgogICA8dGl0bGU+JSV0aXRs ZSUlPC90aXRsZT4KIDwvaGVhZD4KQEAgLTE3NTEsNCArMTc1NSw1IEBACiAkeyAkU1RZTEVTSEVF VHsnaHRtbC1zaW1wbGUnfX0geyd0ZW1wbGF0ZSd9ID0gJzxodG1sPgogICA8aGVhZD4KKyAgICA8 bWV0YSBodHRwLWVxdWl2PSJDb250ZW50LVR5cGUiIGNvbnRlbnQ9InRleHQvaHRtbDsgY2hhcnNl dD1JU08tODg1OS0xIj4KICAgICA8dGl0bGU+JSV0aXRsZSUlPC90aXRsZT4KICAgPC9oZWFkPgpA QCAtMTc3NCw0ICsxNzc5LDUgQEAKICR7ICRTVFlMRVNIRUVUeydodG1sLWZudGxjayd9fSB7J3Rl bXBsYXRlJ30gPSAnPGh0bWw+CiA8aGVhZD4KKyAgPG1ldGEgaHR0cC1lcXVpdj0iQ29udGVudC1U eXBlIiBjb250ZW50PSJ0ZXh0L2h0bWw7IGNoYXJzZXQ9SVNPLTg4NTktMSI+CiAgIDx0aXRsZT4l JXRpdGxlJSU8L3RpdGxlPgogPC9oZWFkPgpAQCAtMTk2OCw1ICsxOTc0LDUgQEAKICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICB7CiAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAnbmFtZScgICAgICAgPT4gJ0lkZW50aWZp ZXJzJywKLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICdy ZWdleCcgICAgICA9PiAnXFxiW2EtekEtWl1bYS16QS1aMC05X10qXFxiJywKKyAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICdyZWdleCcgICAgICA9PiAnXFxi W1s6YWxwaGE6XV0oPzpfP1teXFdfXSkqXFxiJywKIAkJCQkJICAgICAgICAnc3R5bGUnICAgICAg PT4gJ2lkZW50aWZpZXInLAogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgJ2NoaWxkcmVnZXgnID0+IFtdCg==