127890 2006-03-28 11:55 0000 epiphany-extensions-2.14.0.1: adblock: segfault closing window with multiple recovered tabs [PATCH] 2006-03-29 09:06:28 0000 1 1 1 Unclassified Gentoo Linux GNOME 2006.0 All Linux RESOLVED FIXED P2 normal --- 119872 1 ed@catmur.co.uk gnome@gentoo.org zedek@gnu.org ed@catmur.co.uk 2006-03-28 11:55:16 0000 From http://bugzilla.gnome.org/show_bug.cgi?id=336111 When adblock is enabled, epiphany segfaults when a window containing multiple tabs recovered from a previous crash is closed. The fix is in Gnome CVS and will be released in 2.14.0.2, but I would suggest adding the patch to the ebuild, as it's a nasty bug and an easy fix. Commit URL: http://cvs.gnome.org/viewcvs/epiphany-extensions/extensions/adblock/ephy-adblock-extension.c?r1=1.10&r2=1.10.2.1 I can confirm that applying the commit as a patch fixes the bug. zedek@gnu.org 2006-03-28 14:26:55 0000 I confirm the behaviour on one of my machines. Patching it solved my problem. foser@gentoo.org 2006-03-29 03:25:56 0000 added the patch, thnx for the notification. ed@catmur.co.uk 2006-03-29 08:22:20 0000 Created an attachment (id=83377) epiphany-extensions-2.14.0.1-adblock.patch Unfortunately the first hunk in that commit contains an $Id: $ tag, so the patch got tagged with your commit ID, and so fails to apply. This is the same patch with the first hunk removed. ed@catmur.co.uk 2006-03-29 08:23:14 0000 Reopening so that patch can get fixed. ed@catmur.co.uk 2006-03-29 08:27:59 0000 Created an attachment (id=83378) epiphany-extensions-2.14.0.1-adblock.patch I'm really not awake today... foser@gentoo.org 2006-03-29 09:06:28 0000 you are correct sir, obviously I wasn't too awake either at the time. Should be fixed now for real. 83377 2006-03-29 08:22 0000 epiphany-extensions-2.14.0.1-adblock.patch epiphany-extensions-2.14.0.1-adblock.patch text/plain PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQpSQ1MgZmlsZTogL2N2cy9nbm9tZS9lcGlwaGFueS1leHRlbnNpb25zL2V4dGVu c2lvbnMvYWRibG9jay9lcGh5LWFkYmxvY2stZXh0ZW5zaW9uLmMsdgpyZXRyaWV2aW5nIHJldmlz aW9uIDEuMTAKcmV0cmlldmluZyByZXZpc2lvbiAxLjEwLjIuMQpkaWZmIC11IC1yMS4xMCAtcjEu MTAuMi4xCkBAIC0yNzAsMTEgKzI3MCw4IEBACiAJc3RhdHVzYmFyID0gRVBIWV9TVEFUVVNCQVIg KGVwaHlfd2luZG93X2dldF9zdGF0dXNiYXIgKHdpbmRvdykpOwogCWdfcmV0dXJuX2lmX2ZhaWwg KHN0YXR1c2JhciAhPSBOVUxMKTsKIAotCWZyYW1lID0gZ19vYmplY3RfZ2V0X2RhdGEgKEdfT0JK RUNUIChzdGF0dXNiYXIpLCBTVEFUVVNCQVJfRlJBTUVfS0VZKTsKLQlldmJveCA9IGdfb2JqZWN0 X2dldF9kYXRhIChHX09CSkVDVCAoc3RhdHVzYmFyKSwgU1RBVFVTQkFSX0VWQk9YX0tFWSk7Ci0K LQlnX29iamVjdF9zZXRfZGF0YSAoR19PQkpFQ1QgKHN0YXR1c2JhciksIFNUQVRVU0JBUl9GUkFN RV9LRVksIE5VTEwpOwotCWdfb2JqZWN0X3NldF9kYXRhIChHX09CSkVDVCAoc3RhdHVzYmFyKSwg U1RBVFVTQkFSX0VWQk9YX0tFWSwgTlVMTCk7CisJZnJhbWUgPSBnX29iamVjdF9zdGVhbF9kYXRh IChHX09CSkVDVCAoc3RhdHVzYmFyKSwgU1RBVFVTQkFSX0ZSQU1FX0tFWSk7CisJZXZib3ggPSBn X29iamVjdF9zdGVhbF9kYXRhIChHX09CSkVDVCAoc3RhdHVzYmFyKSwgU1RBVFVTQkFSX0VWQk9Y X0tFWSk7CiAKIAlnX3JldHVybl9pZl9mYWlsIChmcmFtZSAhPSBOVUxMKTsKIAlnX3JldHVybl9p Zl9mYWlsIChldmJveCAhPSBOVUxMKTsKQEAgLTM2NSw3ICszNjIsOCBAQAogfQogCiBzdGF0aWMg QWRCbG9ja2VyICoKLWVuc3VyZV9hZGJsb2NrZXIgKEVwaHlXaW5kb3cgKndpbmRvdywgRXBoeUVt YmVkICplbWJlZCkKK2Vuc3VyZV9hZGJsb2NrZXIgKEVwaHlXaW5kb3cgKndpbmRvdywKKwkJICBF cGh5RW1iZWQgKmVtYmVkKQogewogCUFkQmxvY2tlciAqYmxvY2tlcjsKIApAQCAtMzgyLDE5ICsz ODAsMTkgQEAKIAkJYmxvY2tlciA9IGFkX2Jsb2NrZXJfbmV3IChleHQtPnByaXYtPnRlc3Rlcik7 CiAJCWdfcmV0dXJuX3ZhbF9pZl9mYWlsIChibG9ja2VyICE9IE5VTEwsIE5VTEwpOwogCi0JCWdf b2JqZWN0X3NldF9kYXRhIChHX09CSkVDVCAoZW1iZWQpLCBBRF9CTE9DS0VSX0tFWSwgYmxvY2tl cik7CisJCWdfb2JqZWN0X3NldF9kYXRhX2Z1bGwgKEdfT0JKRUNUIChlbWJlZCksIEFEX0JMT0NL RVJfS0VZLAorCQkJCQlibG9ja2VyLCAoR0Rlc3Ryb3lOb3RpZnkpIGdfb2JqZWN0X3VucmVmKTsK IAogCQlnX3NpZ25hbF9jb25uZWN0IChlbWJlZCwgImdlLWxvY2F0aW9uIiwKLQkJCQlHX0NBTExC QUNLIChsb2NhdGlvbl9jaGFuZ2VkX2NiKSwgYmxvY2tlcik7CisJCQkJICBHX0NBTExCQUNLIChs b2NhdGlvbl9jaGFuZ2VkX2NiKSwgYmxvY2tlcik7CiAKIAkJZ19zaWduYWxfY29ubmVjdCAoZW1i ZWQsICJjb250ZW50LWJsb2NrZWQiLAotCQkJCUdfQ0FMTEJBQ0sgKGNvbnRlbnRfYmxvY2tlZF9j YiksIGJsb2NrZXIpOworCQkJCSAgR19DQUxMQkFDSyAoY29udGVudF9ibG9ja2VkX2NiKSwgYmxv Y2tlcik7CiAJfQogCiAJcmV0dXJuIGJsb2NrZXI7CiB9CiAKLQogc3RhdGljIHZvaWQKIGltcGxf YXR0YWNoX3RhYiAoRXBoeUV4dGVuc2lvbiAqZXh0LAogCQkgRXBoeVdpbmRvdyAqd2luZG93LApA QCAtNDIyLDE1ICs0MjAsMTUgQEAKIAkKIAllbWJlZCA9IGVwaHlfdGFiX2dldF9lbWJlZCAodGFi KTsKIAotCWJsb2NrZXIgPSBnX29iamVjdF9nZXRfZGF0YSAoR19PQkpFQ1QgKGVtYmVkKSwgQURf QkxPQ0tFUl9LRVkpOworCWJsb2NrZXIgPSBnX29iamVjdF9zdGVhbF9kYXRhIChHX09CSkVDVCAo ZW1iZWQpLCBBRF9CTE9DS0VSX0tFWSk7CiAJZ19yZXR1cm5faWZfZmFpbCAoYmxvY2tlciAhPSBO VUxMKTsKIAogCWdfc2lnbmFsX2hhbmRsZXJzX2Rpc2Nvbm5lY3RfYnlfZnVuYwotCQkoR19PQkpF Q1QgKGVtYmVkKSwgR19DQUxMQkFDSyAoY29udGVudF9ibG9ja2VkX2NiKSwgYmxvY2tlcik7CisJ CShlbWJlZCwgR19DQUxMQkFDSyAoY29udGVudF9ibG9ja2VkX2NiKSwgYmxvY2tlcik7CiAJZ19z aWduYWxfaGFuZGxlcnNfZGlzY29ubmVjdF9ieV9mdW5jCi0JCShHX09CSkVDVCAoZW1iZWQpLCBH X0NBTExCQUNLIChsb2NhdGlvbl9jaGFuZ2VkX2NiKSwgYmxvY2tlcik7CisJCShlbWJlZCwgR19D QUxMQkFDSyAobG9jYXRpb25fY2hhbmdlZF9jYiksIGJsb2NrZXIpOwogCWdfc2lnbmFsX2hhbmRs ZXJzX2Rpc2Nvbm5lY3RfYnlfZnVuYwotCQkoR19PQkpFQ1QgKGJsb2NrZXIpLCBHX0NBTExCQUNL IChudW1fYmxvY2tlZF9jYiksIGJsb2NrZXIpOworCQkoYmxvY2tlciwgR19DQUxMQkFDSyAobnVt X2Jsb2NrZWRfY2IpLCBlbWJlZCk7CiAKIAlnX29iamVjdF91bnJlZiAoYmxvY2tlcik7CiB9Cg== 83378 2006-03-29 08:27 0000 epiphany-extensions-2.14.0.1-adblock.patch epiphany-extensions-2.14.0.1-adblock.patch text/plain PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQpSQ1MgZmlsZTogL2N2cy9nbm9tZS9lcGlwaGFueS1leHRlbnNpb25zL2V4dGVu c2lvbnMvYWRibG9jay9lcGh5LWFkYmxvY2stZXh0ZW5zaW9uLmMsdgpyZXRyaWV2aW5nIHJldmlz aW9uIDEuMTAKcmV0cmlldmluZyByZXZpc2lvbiAxLjEwLjIuMQpkaWZmIC11IC1yMS4xMCAtcjEu MTAuMi4xCi0tLSBlcGh5LWFkYmxvY2stZXh0ZW5zaW9uLmMJMjAwNi8wMy8xMSAxODo0MToyMAkx LjEwCisrKyBlcGh5LWFkYmxvY2stZXh0ZW5zaW9uLmMJMjAwNi8wMy8xNiAxNDo1OToyMgkxLjEw LjIuMQpAQCAtMjcwLDExICsyNzAsOCBAQAogCXN0YXR1c2JhciA9IEVQSFlfU1RBVFVTQkFSIChl cGh5X3dpbmRvd19nZXRfc3RhdHVzYmFyICh3aW5kb3cpKTsKIAlnX3JldHVybl9pZl9mYWlsIChz dGF0dXNiYXIgIT0gTlVMTCk7CiAKLQlmcmFtZSA9IGdfb2JqZWN0X2dldF9kYXRhIChHX09CSkVD VCAoc3RhdHVzYmFyKSwgU1RBVFVTQkFSX0ZSQU1FX0tFWSk7Ci0JZXZib3ggPSBnX29iamVjdF9n ZXRfZGF0YSAoR19PQkpFQ1QgKHN0YXR1c2JhciksIFNUQVRVU0JBUl9FVkJPWF9LRVkpOwotCi0J Z19vYmplY3Rfc2V0X2RhdGEgKEdfT0JKRUNUIChzdGF0dXNiYXIpLCBTVEFUVVNCQVJfRlJBTUVf S0VZLCBOVUxMKTsKLQlnX29iamVjdF9zZXRfZGF0YSAoR19PQkpFQ1QgKHN0YXR1c2JhciksIFNU QVRVU0JBUl9FVkJPWF9LRVksIE5VTEwpOworCWZyYW1lID0gZ19vYmplY3Rfc3RlYWxfZGF0YSAo R19PQkpFQ1QgKHN0YXR1c2JhciksIFNUQVRVU0JBUl9GUkFNRV9LRVkpOworCWV2Ym94ID0gZ19v YmplY3Rfc3RlYWxfZGF0YSAoR19PQkpFQ1QgKHN0YXR1c2JhciksIFNUQVRVU0JBUl9FVkJPWF9L RVkpOwogCiAJZ19yZXR1cm5faWZfZmFpbCAoZnJhbWUgIT0gTlVMTCk7CiAJZ19yZXR1cm5faWZf ZmFpbCAoZXZib3ggIT0gTlVMTCk7CkBAIC0zNjUsNyArMzYyLDggQEAKIH0KIAogc3RhdGljIEFk QmxvY2tlciAqCi1lbnN1cmVfYWRibG9ja2VyIChFcGh5V2luZG93ICp3aW5kb3csIEVwaHlFbWJl ZCAqZW1iZWQpCitlbnN1cmVfYWRibG9ja2VyIChFcGh5V2luZG93ICp3aW5kb3csCisJCSAgRXBo eUVtYmVkICplbWJlZCkKIHsKIAlBZEJsb2NrZXIgKmJsb2NrZXI7CiAKQEAgLTM4MiwxOSArMzgw LDE5IEBACiAJCWJsb2NrZXIgPSBhZF9ibG9ja2VyX25ldyAoZXh0LT5wcml2LT50ZXN0ZXIpOwog CQlnX3JldHVybl92YWxfaWZfZmFpbCAoYmxvY2tlciAhPSBOVUxMLCBOVUxMKTsKIAotCQlnX29i amVjdF9zZXRfZGF0YSAoR19PQkpFQ1QgKGVtYmVkKSwgQURfQkxPQ0tFUl9LRVksIGJsb2NrZXIp OworCQlnX29iamVjdF9zZXRfZGF0YV9mdWxsIChHX09CSkVDVCAoZW1iZWQpLCBBRF9CTE9DS0VS X0tFWSwKKwkJCQkJYmxvY2tlciwgKEdEZXN0cm95Tm90aWZ5KSBnX29iamVjdF91bnJlZik7CiAK IAkJZ19zaWduYWxfY29ubmVjdCAoZW1iZWQsICJnZS1sb2NhdGlvbiIsCi0JCQkJR19DQUxMQkFD SyAobG9jYXRpb25fY2hhbmdlZF9jYiksIGJsb2NrZXIpOworCQkJCSAgR19DQUxMQkFDSyAobG9j YXRpb25fY2hhbmdlZF9jYiksIGJsb2NrZXIpOwogCiAJCWdfc2lnbmFsX2Nvbm5lY3QgKGVtYmVk LCAiY29udGVudC1ibG9ja2VkIiwKLQkJCQlHX0NBTExCQUNLIChjb250ZW50X2Jsb2NrZWRfY2Ip LCBibG9ja2VyKTsKKwkJCQkgIEdfQ0FMTEJBQ0sgKGNvbnRlbnRfYmxvY2tlZF9jYiksIGJsb2Nr ZXIpOwogCX0KIAogCXJldHVybiBibG9ja2VyOwogfQogCi0KIHN0YXRpYyB2b2lkCiBpbXBsX2F0 dGFjaF90YWIgKEVwaHlFeHRlbnNpb24gKmV4dCwKIAkJIEVwaHlXaW5kb3cgKndpbmRvdywKQEAg LTQyMiwxNSArNDIwLDE1IEBACiAJCiAJZW1iZWQgPSBlcGh5X3RhYl9nZXRfZW1iZWQgKHRhYik7 CiAKLQlibG9ja2VyID0gZ19vYmplY3RfZ2V0X2RhdGEgKEdfT0JKRUNUIChlbWJlZCksIEFEX0JM T0NLRVJfS0VZKTsKKwlibG9ja2VyID0gZ19vYmplY3Rfc3RlYWxfZGF0YSAoR19PQkpFQ1QgKGVt YmVkKSwgQURfQkxPQ0tFUl9LRVkpOwogCWdfcmV0dXJuX2lmX2ZhaWwgKGJsb2NrZXIgIT0gTlVM TCk7CiAKIAlnX3NpZ25hbF9oYW5kbGVyc19kaXNjb25uZWN0X2J5X2Z1bmMKLQkJKEdfT0JKRUNU IChlbWJlZCksIEdfQ0FMTEJBQ0sgKGNvbnRlbnRfYmxvY2tlZF9jYiksIGJsb2NrZXIpOworCQko ZW1iZWQsIEdfQ0FMTEJBQ0sgKGNvbnRlbnRfYmxvY2tlZF9jYiksIGJsb2NrZXIpOwogCWdfc2ln bmFsX2hhbmRsZXJzX2Rpc2Nvbm5lY3RfYnlfZnVuYwotCQkoR19PQkpFQ1QgKGVtYmVkKSwgR19D QUxMQkFDSyAobG9jYXRpb25fY2hhbmdlZF9jYiksIGJsb2NrZXIpOworCQkoZW1iZWQsIEdfQ0FM TEJBQ0sgKGxvY2F0aW9uX2NoYW5nZWRfY2IpLCBibG9ja2VyKTsKIAlnX3NpZ25hbF9oYW5kbGVy c19kaXNjb25uZWN0X2J5X2Z1bmMKLQkJKEdfT0JKRUNUIChibG9ja2VyKSwgR19DQUxMQkFDSyAo bnVtX2Jsb2NrZWRfY2IpLCBibG9ja2VyKTsKKwkJKGJsb2NrZXIsIEdfQ0FMTEJBQ0sgKG51bV9i bG9ja2VkX2NiKSwgZW1iZWQpOwogCiAJZ19vYmplY3RfdW5yZWYgKGJsb2NrZXIpOwogfQo=