124791 2006-03-03 06:11 0000 pdb2pqr ebuild request 2006-03-21 15:17:36 0000 1 1 1 Unclassified Gentoo Linux Applications 2005.1 AMD64 Linux RESOLVED FIXED http://sourceforge.net/project/showfiles.php?group_id=144228 REQUEST P2 enhancement --- 1 je_fro@gentoo.org sci@gentoo.org je_fro@gentoo.org je_fro@gentoo.org 2006-03-03 06:11:41 0000 I've got pdb2pqr running just fine with a default install (as per the instructions) using the package from sourceforge. pdb2pqr is a useful package used in manipulating protein structure files for electrostatics calculations. (I'll file another feature request for apbs too...) Thanks, je_fro je_fro@gentoo.org 2006-03-03 06:13:49 0000 If you guys want me to generate the ebuild, just tell me....I'll attach it when I'm done. jakub@gentoo.org 2006-03-03 06:19:57 0000 Sure, attach an ebuild. je_fro@gentoo.org 2006-03-05 01:41:07 0000 Created an attachment (id=81372) ebuild for pdb2pqr Here's an ebuild for pdb2pqr...I'm sure there's a better way to achieve the install, but I couldn't figure out how to split it up (/usr/share, /usr/bin, etc...) so I put it all in /usr/lib/python-2.4/site-packages (like pymol) even though it's not a "distutils package". Or I may not have a complete understanding of distutils. Anyway, my other option was to put it in /opt, but this way seems better... Later, je_fro markusle@gentoo.org 2006-03-12 04:33:54 0000 Hi Jeff, Thanks for your ebuild. It looks nice and here are several improvements which I would like to suggest: - generally, whenever the package name/version, e.g., pdb2pqr appears in the ebuild, replace it by ${P},${PV},.. (see docs). - the description should be shorter if possible - the call to need_fortran f77 should be sufficient, and you don't need the additional build_with_use check. Furthermore, you might already want to think of a way to handle the new gfortran that will come with gcc-4.x. - the local variable myconf in src_compile doesn't do anything and should be left out. - the call to doins propka/*propka* installs f77-source/swig interface files which don't belong there. - each of the doins calls would benefit from a 'die "failed to install ...."' - instead of hardcoding python-2.4 you might want to consider inheriting the python.eclass and using the variables (e.g. ${PYVER}) provided by it. - make sure to use tabs instead of whitespaces (lines 19 and 49) Thank you very much, Markus je_fro@gentoo.org 2006-03-12 05:43:59 0000 Thanks for the constructive criticism! I'll fix the ebuild and submit a new one when I get time....working in the lab today... :D je_fro@gentoo.org 2006-03-13 03:14:34 0000 Created an attachment (id=82020) ebuild for pdb2pqr Here's an updated ebuild for pdb2pqr. I think it incorporates all your fixes, and I'll look into gfortran after I can google up some good information... je_fro je_fro@gentoo.org 2006-03-14 00:21:12 0000 Created an attachment (id=82074) ebuild for pdb2pqr whoops...forgot python_version... markusle@gentoo.org 2006-03-14 07:04:14 0000 Hi Jeff, Thanks for your updated ebuild. I hope I can have a closer look at it tonight. One of the issues with fortran and gcc-4.x is the fact that it does not provide g77 any more but rather gfortran. Hence, first of all you should check if the package compiles and works using gfortran. If it compiles the need_fortran part in the ebuild should be changed to need_fortran gfortran g77 However, if you look at the fortran.eclass you will notice that this is the default anyway, hence you can leave the whole pkg_setup() stuff out. As long as you inherit the fortran eclass it will be executed automatically. In case it doesn't compile with gfortran it might be a good idea checking into what the problem could be. best, Markus dberkholz@gentoo.org 2006-03-14 13:46:28 0000 Instead of running need_fortran I prefer to set FORTRAN="g77 gfortran" in the global variables. That automagically takes care of the pkg_setup stuff. This ebuild also needs to get multilib intelligence -- get_libdir() from multilib.eclass Also relative symlinks should be used instead of absolute. The src_compile is redundant. je_fro@gentoo.org 2006-03-15 03:10:58 0000 Created an attachment (id=82200) revised pdb2pqr ebuild I think I've implemented all the recommended changes. It still works here :D markusle@gentoo.org 2006-03-19 11:24:06 0000 Hi Jeff, Thanks and looks nice now. I'll see that I test it soon with some of my favorite pdbs. Thanks, Markus markusle@gentoo.org 2006-03-21 09:17:43 0000 Hi Jeff, I just commited pdb2pqr to portage. Many thanks again for your ebuild and help! The final ebuild has several modifications from the last one you posted; please have a look at them: - even though you specified gfortran in the ebuild, pdb2pqr did not compile with it! I had to create a small patch to fix this. - the way the files are installed in the python/site-packages directory, pdb2pqr did not "find" the propka stuff and I needed to patch the main pdb2pqr.py file to fix this. - your ebuild still installed much of the content of propka, including the source and object files. All that is needed is the *.so and the python wrapper, the rest should not end up on the life file system. Otherwise, great work and thanks again. Please give it a spin once it hits the mirrors. It seems to work fine for the pdbs I've tried so far. I really like the package! best, Markus je_fro@gentoo.org 2006-03-21 14:15:44 0000 hmm....maybe I had some leftover propka stuff that wasn't uninstalled and gave me the appearance the ebuild worked... anyway, can you add ~amd64 when you can? Thanks! je_fro markusle@gentoo.org 2006-03-21 15:17:36 0000 (In reply to comment #13) > anyway, can you add ~amd64 when you can? Hi Jeff, I can't, since I only have a x86 box to test. Gentoo policy is that developers should only mark packages ~arch on the architectures they can test and verify that the ebuild works. In this case, the proper way to have the package marked ~arch is to file a bug with the respective arch team asking them to test and do this for you. It is always very helpful to attach a small test example to assist the arch folks with the testing. In this case this might be a small pdb file, the command line to run pdb2pqr and the expected results (in words). Hence, if you know that the pdb2pqr ebuild works fine on amd64 please file a bug with the amd64 herd and they'll take care of it. Thanks, Markus 81372 2006-03-05 01:41 0000 ebuild for pdb2pqr pdb2pqr-1.0.2.ebuild text/plain IyBDb3B5cmlnaHQgMTk5OS0yMDA2IEdlbnRvbyBGb3VuZGF0aW9uCiMgRGlzdHJpYnV0ZWQgdW5k ZXIgdGhlIHRlcm1zIG9mIHRoZSBHTlUgR2VuZXJhbCBQdWJsaWMgTGljZW5zZSB2MgojICRIZWFk ZXI6ICQKCmluaGVyaXQgZXV0aWxzIGZvcnRyYW4KCkRFU0NSSVBUSU9OPSJQREIyUFFSIGlzIGEg UHl0aG9uIHNvZnR3YXJlIHBhY2thZ2UgdGhhdCBhdXRvbWF0ZXMgbWFueSBvZiB0aGUgY29tbW9u IHRhc2tzIG9mIHByZXBhcmluZyBzdHJ1Y3R1cmVzIGZvciBjb250aW51dW0gZWxlY3Ryb3N0YXRp Y3MgY2FsY3VsYXRpb25zLiIKTElDRU5TRT0iR1BMLTIiCkhPTUVQQUdFPSJodHRwOi8vcGRiMnBx ci5zb3VyY2Vmb3JnZS5uZXQvIgpTUkNfVVJJPSJodHRwOi8vdW1uLmRsLnNvdXJjZWZvcmdlLm5l dC9zb3VyY2Vmb3JnZS9wZGIycHFyLyR7UH0udGFyLmd6IgoKU0xPVD0iMCIKSVVTRT0iIgpLRVlX T1JEUz0ifng4NiB+YW1kNjQiCgpERVBFTkQ9Ij49ZGV2LWxhbmcvcHl0aG9uLTIuNC4yIgoKcGtn X3NldHVwKCkgewogICAgICAgIG5lZWRfZm9ydHJhbiBnNzcKCWlmICEgYnVpbHRfd2l0aF91c2Ug PXN5cy1kZXZlbC9nY2MtKiBmb3J0cmFuIDsgdGhlbgoJCWRpZSAic3lzLWRldmVsL2djYyBtdXN0 IGJlIGJ1aWx0IHdpdGggVVNFPWZvcnRyYW4uIgoJZmkKfQoKCnNyY19jb21waWxlKCkgewoJbG9j YWwgbXljb25mCgllY29uZiAke215Y29uZn0gfHwgZGllICJjb25maWd1cmUgZmFpbGVkIgoJZW1h a2UgfHwgZGllICJtYWtlIGZhaWxlZCIKfQoKc3JjX2luc3RhbGwoKSB7CgoJZXhlaW50byAvdXNy L2xpYi9weXRob24yLjQvc2l0ZS1wYWNrYWdlcy9wZGIycHFyCglkb2V4ZSAqLnB5ICAKCglpbnNp bnRvIC91c3IvbGliL3B5dGhvbjIuNC9zaXRlLXBhY2thZ2VzL3BkYjJwcXIvcHJvcGthCglkb2lu cyBwcm9wa2EvKnByb3BrYSogcHJvcGthL19faW5pdF9fLnB5CgoJaW5zaW50byAvdXNyL2xpYi9w eXRob24yLjQvc2l0ZS1wYWNrYWdlcy9wZGIycHFyL3NyYwoJZG9pbnMgc3JjLyoKCglpbnNpbnRv IC91c3IvbGliL3B5dGhvbjIuNC9zaXRlLXBhY2thZ2VzL3BkYjJwcXIvZGF0Cglkb2lucyBkYXQv KgoKCWludG8gL3Vzci9iaW4KCWRvc3ltIC91c3IvbGliL3B5dGhvbjIuNC9zaXRlLXBhY2thZ2Vz L3BkYjJwcXIvcGRiMnBxci5weSAvdXNyL2Jpbi9wZGIycHFyCgogICAgICAgIGRvaHRtbCBkb2Mv KiB8fCBkaWUgImZhaWxlZCB0byBpbnN0YWxsIGh0bWwgZG9jcyIKfQoK 82020 2006-03-13 03:14 0000 ebuild for pdb2pqr pdb2pqr-1.0.2.ebuild text/plain IyBDb3B5cmlnaHQgMTk5OS0yMDA2IEdlbnRvbyBGb3VuZGF0aW9uCiMgRGlzdHJpYnV0ZWQgdW5k ZXIgdGhlIHRlcm1zIG9mIHRoZSBHTlUgR2VuZXJhbCBQdWJsaWMgTGljZW5zZSB2MgojICRIZWFk ZXI6ICQKCmluaGVyaXQgZXV0aWxzIGZvcnRyYW4gcHl0aG9uCgpERVNDUklQVElPTj0iUERCMlBR UiBlYXNlcyBwcmVwYXJhdGlvbiBvZiBzdHJ1Y3R1cmVzIGZvciBjb250aW51dW0gZWxlY3Ryb3N0 YXRpY3MgY2FsY3VsYXRpb25zLiIKTElDRU5TRT0iR1BMLTIiCkhPTUVQQUdFPSJodHRwOi8vcGRi MnBxci5zb3VyY2Vmb3JnZS5uZXQvIgpTUkNfVVJJPSJodHRwOi8vdW1uLmRsLnNvdXJjZWZvcmdl Lm5ldC9zb3VyY2Vmb3JnZS8ke1BOfS8ke1B9LnRhci5neiIKClNMT1Q9IjAiCklVU0U9IiIKS0VZ V09SRFM9In54ODYgfmFtZDY0IgoKREVQRU5EPSI+PWRldi1sYW5nL3B5dGhvbi0yLjQuMiIKCnBr Z19zZXR1cCgpIHsKCW5lZWRfZm9ydHJhbiBnNzcKfQoKCnNyY19jb21waWxlKCkgewoJZWNvbmYg JiYgZW1ha2UgfHwgZGllICJtYWtlIGZhaWxlZCIKfQoKc3JjX2luc3RhbGwoKSB7CgoJZXhlaW50 byAvdXNyL2xpYi8ke1BZVkVSfS9zaXRlLXBhY2thZ2VzL3BkYjJwcXIKCWRvZXhlICoucHkgfHwg ZGllICJJbnN0YWxsaW5nIHBkYjJwcXIgZmFpbGVkLiIKCglpbnNpbnRvIC91c3IvbGliLyR7UFlW RVJ9L3NpdGUtcGFja2FnZXMvcGRiMnBxci9wcm9wa2EKCWRvaW5zIHByb3BrYS9wcm9wa2FjIHBy b3BrYS9wcm9wa2FsaWIgcHJvcGthL19faW5pdF9fLnB5IFwKCQl8fCBkaWUgIkZhaWxlZCB0byBp bnN0YWxsIHByb3BrYS4iCgoJaW5zaW50byAvdXNyL2xpYi8ke1BZVkVSfS9zaXRlLXBhY2thZ2Vz L3BkYjJwcXIvc3JjCglkb2lucyBzcmMvKiB8fCBkaWUgIkluc3RhbGxpbmcgc3JjIGZhaWxlZC4i CgoJaW5zaW50byAvdXNyL2xpYi8ke1BZVkVSfS9zaXRlLXBhY2thZ2VzL3BkYjJwcXIvZGF0Cglk b2lucyBkYXQvKiB8fCBkaWUgIkluc3RhbGxpbmcgZGF0YSBmYWlsZWQuIgoKCWludG8gL3Vzci9i aW4KCWRvc3ltIC91c3IvbGliLyR7UFlWRVJ9L3NpdGUtcGFja2FnZXMvcGRiMnBxci9wZGIycHFy LnB5IC91c3IvYmluL3BkYjJwcXIgXAoJCXx8IGRpZSAiRmFpbGVkIHRvIGluc3RhbGwgc3ltbGlu ayBpbnRvIC91c3IvYmluLiIKCglkb2h0bWwgZG9jLyogfHwgZGllICJmYWlsZWQgdG8gaW5zdGFs bCBodG1sIGRvY3MiCn0KCg== 82074 2006-03-14 00:21 0000 ebuild for pdb2pqr pdb2pqr-1.0.2.ebuild text/plain IyBDb3B5cmlnaHQgMTk5OS0yMDA2IEdlbnRvbyBGb3VuZGF0aW9uCiMgRGlzdHJpYnV0ZWQgdW5k ZXIgdGhlIHRlcm1zIG9mIHRoZSBHTlUgR2VuZXJhbCBQdWJsaWMgTGljZW5zZSB2MgojICRIZWFk ZXI6ICQKCmluaGVyaXQgZXV0aWxzIGZvcnRyYW4gcHl0aG9uCgpERVNDUklQVElPTj0iUERCMlBR UiBlYXNlcyBwcmVwYXJhdGlvbiBvZiBzdHJ1Y3R1cmVzIGZvciBjb250aW51dW0gZWxlY3Ryb3N0 YXRpY3MgY2FsY3VsYXRpb25zLiIKTElDRU5TRT0iR1BMLTIiCkhPTUVQQUdFPSJodHRwOi8vcGRi MnBxci5zb3VyY2Vmb3JnZS5uZXQvIgpTUkNfVVJJPSJodHRwOi8vdW1uLmRsLnNvdXJjZWZvcmdl Lm5ldC9zb3VyY2Vmb3JnZS8ke1BOfS8ke1B9LnRhci5neiIKClNMT1Q9IjAiCklVU0U9IiIKS0VZ V09SRFM9In54ODYgfmFtZDY0IgoKREVQRU5EPSI+PWRldi1sYW5nL3B5dGhvbi0yLjQuMiIKCnBr Z19zZXR1cCgpIHsKCW5lZWRfZm9ydHJhbiBnNzcKfQoKCnNyY19jb21waWxlKCkgewoJZWNvbmYg JiYgZW1ha2UgfHwgZGllICJtYWtlIGZhaWxlZCIKfQoKc3JjX2luc3RhbGwoKSB7CglweXRob25f dmVyc2lvbgoJZXhlaW50byAvdXNyL2xpYi9weXRob24ke1BZVkVSfS9zaXRlLXBhY2thZ2VzL3Bk YjJwcXIKCWRvZXhlICoucHkgfHwgZGllICJJbnN0YWxsaW5nIHBkYjJwcXIgZmFpbGVkLiIKCglp bnNpbnRvIC91c3IvbGliL3B5dGhvbiR7UFlWRVJ9L3NpdGUtcGFja2FnZXMvcGRiMnBxci9wcm9w a2EKCWRvaW5zIHByb3BrYS9wcm9wa2FjIHByb3BrYS9wcm9wa2FsaWIgcHJvcGthL19faW5pdF9f LnB5IFwKCQl8fCBkaWUgIkZhaWxlZCB0byBpbnN0YWxsIHByb3BrYS4iCgoJaW5zaW50byAvdXNy L2xpYi9weXRob24ke1BZVkVSfS9zaXRlLXBhY2thZ2VzL3BkYjJwcXIvc3JjCglkb2lucyBzcmMv KiB8fCBkaWUgIkluc3RhbGxpbmcgc3JjIGZhaWxlZC4iCgoJaW5zaW50byAvdXNyL2xpYi9weXRo b24ke1BZVkVSfS9zaXRlLXBhY2thZ2VzL3BkYjJwcXIvZGF0Cglkb2lucyBkYXQvKiB8fCBkaWUg Ikluc3RhbGxpbmcgZGF0YSBmYWlsZWQuIgoKCWludG8gL3Vzci9iaW4KCWRvc3ltIC91c3IvbGli L3B5dGhvbiR7UFlWRVJ9L3NpdGUtcGFja2FnZXMvcGRiMnBxci9wZGIycHFyLnB5IC91c3IvYmlu L3BkYjJwcXIgXAoJCXx8IGRpZSAiRmFpbGVkIHRvIGluc3RhbGwgc3ltbGluayBpbnRvIC91c3Iv YmluLiIKCglkb2h0bWwgZG9jLyogfHwgZGllICJGYWlsZWQgdG8gaW5zdGFsbCBodG1sIGRvY3Mu Igp9Cgo= 82200 2006-03-15 03:10 0000 revised pdb2pqr ebuild pdb2pqr-1.0.2.ebuild text/plain IyBDb3B5cmlnaHQgMTk5OS0yMDA2IEdlbnRvbyBGb3VuZGF0aW9uCiMgRGlzdHJpYnV0ZWQgdW5k ZXIgdGhlIHRlcm1zIG9mIHRoZSBHTlUgR2VuZXJhbCBQdWJsaWMgTGljZW5zZSB2MgojICRIZWFk ZXI6ICQKCmluaGVyaXQgZXV0aWxzIGZvcnRyYW4gcHl0aG9uIG11bHRpbGliCgpERVNDUklQVElP Tj0iUERCMlBRUiBlYXNlcyBwcmVwYXJhdGlvbiBvZiBzdHJ1Y3R1cmVzIGZvciBjb250aW51dW0g ZWxlY3Ryb3N0YXRpY3MgY2FsY3VsYXRpb25zLiIKTElDRU5TRT0iR1BMLTIiCkhPTUVQQUdFPSJo dHRwOi8vcGRiMnBxci5zb3VyY2Vmb3JnZS5uZXQvIgpTUkNfVVJJPSJodHRwOi8vdW1uLmRsLnNv dXJjZWZvcmdlLm5ldC9zb3VyY2Vmb3JnZS8ke1BOfS8ke1B9LnRhci5neiIKClNMT1Q9IjAiCklV U0U9IiIKS0VZV09SRFM9In54ODYgfmFtZDY0IgoKREVQRU5EPSI+PWRldi1sYW5nL3B5dGhvbi0y LjQuMiIKCkZPUlRSQU49Imc3NyBnZm9ydHJhbiIKCgpzcmNfaW5zdGFsbCgpIHsKCXB5dGhvbl92 ZXJzaW9uCglleGVpbnRvIC91c3IvJChnZXRfbGliZGlyKS9weXRob24ke1BZVkVSfS9zaXRlLXBh Y2thZ2VzLyR7UE59Cglkb2V4ZSAqLnB5IHx8IGRpZSAiSW5zdGFsbGluZyBwZGIycHFyIGZhaWxl ZC4iCgoJaW5zaW50byAvdXNyLyQoZ2V0X2xpYmRpcikvcHl0aG9uJHtQWVZFUn0vc2l0ZS1wYWNr YWdlcy8ke1BOfS9wcm9wa2EKCWRvaW5zIHByb3BrYS9wcm9wa2FjLiogcHJvcGthL3Byb3BrYWxp Yi4qIHByb3BrYS9fX2luaXRfXy5weSB8fCBcCgkJZGllICJGYWlsZWQgdG8gaW5zdGFsbCBwcm9w a2EuIgoKCWluc2ludG8gL3Vzci8kKGdldF9saWJkaXIpL3B5dGhvbiR7UFlWRVJ9L3NpdGUtcGFj a2FnZXMvJHtQTn0vc3JjCglkb2lucyBzcmMvKiB8fCBkaWUgIkluc3RhbGxpbmcgc3JjIGZhaWxl ZC4iCgoJaW5zaW50byAvdXNyLyQoZ2V0X2xpYmRpcikvcHl0aG9uJHtQWVZFUn0vc2l0ZS1wYWNr YWdlcy8ke1BOfS9kYXQgCglkb2lucyBkYXQvKiB8fCBkaWUgIkluc3RhbGxpbmcgZGF0YSBmYWls ZWQuIgoKCWludG8gL3Vzci9iaW4KCWRvc3ltIC4uLyQoZ2V0X2xpYmRpcikvcHl0aG9uJHtQWVZF Un0vc2l0ZS1wYWNrYWdlcy8ke1BOfS8ke1BOfS5weSAvdXNyL2Jpbi9wZGIycHFyIFwKCQl8fCBk aWUgIkZhaWxlZCB0byBpbnN0YWxsIHN5bWxpbmsgaW50byAvdXNyL2Jpbi4iCgoJZG9odG1sIGRv Yy8qIHx8IGRpZSAiRmFpbGVkIHRvIGluc3RhbGwgaHRtbCBkb2NzLiIKfQoK