122849 2006-02-14 15:05 0000 app-arch/zip - use flag "crypt" does no longer work as expected for version 2.31 2006-03-13 19:13:47 0000 1 1 1 Unclassified Gentoo Linux Applications unspecified All Linux RESOLVED FIXED P2 trivial --- 1 robteichmann@gmx.de maintainer-needed@gentoo.org vanquirius@gentoo.org vapier@gentoo.org robteichmann@gmx.de 2006-02-14 15:05:32 0000 US export restrictions for encryption/decryption have been relaxed, so unlike version 2.3, version 2.31 of app-arch/zip enables crypt support by default. The necessary files for encryption support are now part of the source tarball (as mentioned in the files WHATSNEW and CHANGES). With previous versions, they were distributed in a separate file and encryption support was not enabled by default. The current ebuild for version 2.31 has a "crypt" use flag, which does not work as expected: On the one hand, encryption support gets built into zip even when the flag is not set. The expected behaviour would be that it's optional. On the other hand, using the "crypt" flag overwrites the files crypt.c and crypt.h of the standard zip source with slightly older versions of these two files (the diffs are minimal, though). The ebuild shouldn't overwrite these files and use the ones provided by the zip source tree. By adding -DNO_CRYPT as a compilation option, encryption support can be disabled (mentioned in the file INSTALL of the zip source tree). --- Attached are two different patches to the ebuild, pick which way to solve the problem you like better - consider applying only _one_ of them: - The first version of the patch simply removes the "crypt" use flag. I prefer this way since the difference between a zip binary with encryption support and one without is only about 2 kb on my machine. Making it optional seems a bit like overkill. - The second version of the patch keeps the "crypt" use flag but compiles zip with -DNO_CRYPT when not supplying the "crypt" flag, thus making it optional and disabling encryption support as one would expect. This patch also makes the following small changes (suggestions) to the current ebuild: - added manpage symlinks for zipcloak.1, zipnote.1 and zipsplit.1 - docs README.CR (encryption information) and proginfo/algorith.txt get installed - doc MANUAL doesn't get installed - it's only a pre-formatted version of zip.1 for users without groff - zipcloak doesn't get installed when there is no encryption support. Without encryption the binary is useless and only emits an error message (only applies to the second version of the patch, obviously) robteichmann robteichmann@gmx.de 2006-02-14 15:06:59 0000 Created an attachment (id=79805) zip-2.31-without-useflag-crypt.patch remove the "crypt" use flag robteichmann@gmx.de 2006-02-14 15:08:00 0000 Created an attachment (id=79806) zip-2.31-with-useflag-crypt.patch or maybe use this to make the use flag work as expected vanquirius@gentoo.org 2006-02-20 13:01:09 0000 Whomever picks this up, the second solution is probably the best one (since we want to give this option to users). vapier@gentoo.org 2006-03-13 19:13:47 0000 thanks, 2.31-r1 includes your second patch 79805 2006-02-14 15:06 0000 zip-2.31-without-useflag-crypt.patch zip-2.31-without-useflag-crypt.patch text/plain LS0tIHppcC0yLjMxLmVidWlsZAkyMDA1LTA3LTI0IDAxOjM1OjE3LjAwMDAwMDAwMCArMDIwMAor KysgemlwLTIuMzEtbm8tdXNlZmxhZy5lYnVpbGQJMjAwNi0wMi0xNCAyMDoxOTozNi4wMDAwMDAw MDAgKzAxMDAKQEAgLTYsMTkgKzYsMTQgQEAKIAogREVTQ1JJUFRJT049IkluZm8gWklQIChlbmNy eXB0aW9uIHN1cHBvcnQpIgogSE9NRVBBR0U9ImZ0cDovL2Z0cC5mcmVlc29mdHdhcmUuY29tL3B1 Yi9pbmZvemlwL1ppcC5odG1sIgotU1JDX1VSST0iZnRwOi8vZnRwLmluZm8temlwLm9yZy9wdWIv aW5mb3ppcC9zcmMvemlwJHtQVi8vLn0udGFyLmd6Ci0JY3J5cHQ/ICggZnRwOi8vZnRwLmljY2Uu cnVnLm5sL2luZm96aXAvc3JjL3pjcnlwdDI5LnppcCApIgorU1JDX1VSST0iZnRwOi8vZnRwLmlu Zm8temlwLm9yZy9wdWIvaW5mb3ppcC9zcmMvemlwJHtQVi8vLn0udGFyLmd6IgogCiBMSUNFTlNF PSJJbmZvLVpJUCIKIFNMT1Q9IjAiCiBLRVlXT1JEUz0ifmFscGhhIH5hbWQ2NCB+YXJtIH5ocHBh IH5pYTY0IH5tNjhrIH5taXBzIH5wcGMgfnBwYy1tYWNvcyB+cHBjNjQgfnMzOTAgfnNoIH5zcGFy YyB+eDg2IgotSVVTRT0iY3J5cHQiCi0KLURFUEVORD0iY3J5cHQ/ICggYXBwLWFyY2gvdW56aXAg KSIKIAogc3JjX3VucGFjaygpIHsKIAl1bnBhY2sgJHtBfQotCXVzZSBjcnlwdCAmJiBtdiAtZiBj cnlwdC5bY2hdICIke1N9IgogCWNkICIke1N9IgogCWVwYXRjaCAiJHtGSUxFU0RJUn0iL3ppcC0y LjMtdW5peF9jb25maWd1cmUtcGljLnBhdGNoCiAJY2QgdW5peApAQCAtMzYsNSArMzEsOCBAQAog c3JjX2luc3RhbGwoKSB7CiAJZG9iaW4gemlwIHppcGNsb2FrIHppcG5vdGUgemlwc3BsaXQgfHwg ZGllCiAJZG9tYW4gbWFuL3ppcC4xCi0JZG9kb2MgQlVHUyBDSEFOR0VTIE1BTlVBTCBSRUFETUUg VE9ETyBXSEFUU05FVyBXSEVSRQorCWRvc3ltIHppcC4xIC91c3Ivc2hhcmUvbWFuL21hbjEvemlw Y2xvYWsuMQorCWRvc3ltIHppcC4xIC91c3Ivc2hhcmUvbWFuL21hbjEvemlwbm90ZS4xCisJZG9z eW0gemlwLjEgL3Vzci9zaGFyZS9tYW4vbWFuMS96aXBzcGxpdC4xCisJZG9kb2MgQlVHUyBDSEFO R0VTIFJFQURNRXssLkNSfSBUT0RPIFdIQVRTTkVXIFdIRVJFIHByb2dpbmZvL2FsZ29yaXRoLnR4 dAogfQo= 79806 2006-02-14 15:08 0000 zip-2.31-with-useflag-crypt.patch zip-2.31-with-useflag-crypt.patch text/plain LS0tIHppcC0yLjMxLmVidWlsZAkyMDA1LTA3LTI0IDAxOjM1OjE3LjAwMDAwMDAwMCArMDIwMAor KysgemlwLTIuMzEuZWJ1aWxkLm5ldwkyMDA2LTAyLTE0IDIyOjIwOjU1LjAwMDAwMDAwMCArMDEw MApAQCAtMiwyMyArMiwyMCBAQAogIyBEaXN0cmlidXRlZCB1bmRlciB0aGUgdGVybXMgb2YgdGhl IEdOVSBHZW5lcmFsIFB1YmxpYyBMaWNlbnNlIHYyCiAjICRIZWFkZXI6IC92YXIvY3Zzcm9vdC9n ZW50b28teDg2L2FwcC1hcmNoL3ppcC96aXAtMi4zMS5lYnVpbGQsdiAxLjIgMjAwNS8wNy8yMyAy MzoxMTozNSBraXRvIEV4cCAkCiAKLWluaGVyaXQgdG9vbGNoYWluLWZ1bmNzIGV1dGlscworaW5o ZXJpdCB0b29sY2hhaW4tZnVuY3MgZXV0aWxzIGZsYWctby1tYXRpYwogCiBERVNDUklQVElPTj0i SW5mbyBaSVAgKGVuY3J5cHRpb24gc3VwcG9ydCkiCiBIT01FUEFHRT0iZnRwOi8vZnRwLmZyZWVz b2Z0d2FyZS5jb20vcHViL2luZm96aXAvWmlwLmh0bWwiCi1TUkNfVVJJPSJmdHA6Ly9mdHAuaW5m by16aXAub3JnL3B1Yi9pbmZvemlwL3NyYy96aXAke1BWLy8ufS50YXIuZ3oKLQljcnlwdD8gKCBm dHA6Ly9mdHAuaWNjZS5ydWcubmwvaW5mb3ppcC9zcmMvemNyeXB0MjkuemlwICkiCitTUkNfVVJJ PSJmdHA6Ly9mdHAuaW5mby16aXAub3JnL3B1Yi9pbmZvemlwL3NyYy96aXAke1BWLy8ufS50YXIu Z3oiCiAKIExJQ0VOU0U9IkluZm8tWklQIgogU0xPVD0iMCIKIEtFWVdPUkRTPSJ+YWxwaGEgfmFt ZDY0IH5hcm0gfmhwcGEgfmlhNjQgfm02OGsgfm1pcHMgfnBwYyB+cHBjLW1hY29zIH5wcGM2NCB+ czM5MCB+c2ggfnNwYXJjIH54ODYiCiBJVVNFPSJjcnlwdCIKIAotREVQRU5EPSJjcnlwdD8gKCBh cHAtYXJjaC91bnppcCApIgotCiBzcmNfdW5wYWNrKCkgewogCXVucGFjayAke0F9Ci0JdXNlIGNy eXB0ICYmIG12IC1mIGNyeXB0LltjaF0gIiR7U30iCisJdXNlIGNyeXB0IHx8IGFwcGVuZC1mbGFn cyAtRE5PX0NSWVBUCiAJY2QgIiR7U30iCiAJZXBhdGNoICIke0ZJTEVTRElSfSIvemlwLTIuMy11 bml4X2NvbmZpZ3VyZS1waWMucGF0Y2gKIAljZCB1bml4CkBAIC0zNCw3ICszMSwxNSBAQAogfQog CiBzcmNfaW5zdGFsbCgpIHsKLQlkb2JpbiB6aXAgemlwY2xvYWsgemlwbm90ZSB6aXBzcGxpdCB8 fCBkaWUKKwlkb2JpbiB6aXAgemlwbm90ZSB6aXBzcGxpdCB8fCBkaWUKIAlkb21hbiBtYW4vemlw LjEKLQlkb2RvYyBCVUdTIENIQU5HRVMgTUFOVUFMIFJFQURNRSBUT0RPIFdIQVRTTkVXIFdIRVJF CisJZG9zeW0gemlwLjEgL3Vzci9zaGFyZS9tYW4vbWFuMS96aXBub3RlLjEKKwlkb3N5bSB6aXAu MSAvdXNyL3NoYXJlL21hbi9tYW4xL3ppcHNwbGl0LjEKKwlkb2RvYyBCVUdTIENIQU5HRVMgUkVB RE1FIFRPRE8gV0hBVFNORVcgV0hFUkUgcHJvZ2luZm8vYWxnb3JpdGgudHh0CisKKwlpZiB1c2Ug Y3J5cHQ7IHRoZW4KKwkJZG9iaW4gemlwY2xvYWsgfHwgZGllCisJCWRvc3ltIHppcC4xIC91c3Iv c2hhcmUvbWFuL21hbjEvemlwY2xvYWsuMQorCQlkb2RvYyBSRUFETUUuQ1IKKwlmaQogfQo=