119890 2006-01-22 00:55 0000 Procmail's formail incorrectly implements maxprocs 2006-05-12 00:05:08 0000 1 1 1 Unclassified Gentoo Linux Applications unspecified All Linux RESOLVED FIXED P2 critical --- 1 ahbritto@iat.com net-mail@gentoo.org ahbritto@iat.com 2006-01-22 00:55:10 0000 Procmail's formail command's "-n X" creates too many jobs. This can hang the machine by: (1) causing processess to be killed due to out of memory errors, (2) causing thrashing by forcing jobs to swap, (3) prevent new processes from spawning. Steps to reproduce: In a window: watch -n .1 pgrep '[s]leep' In another window: formail -n 2 -s sleep 2 < AN_MBOX_WITH_AT_LEAST_10_MESSAGES Actual results: more than two processes show up in watch command. Expected results: two processes show up at most in watch command. Procmail version: mail-filter/procmail-3.22-r7 ahbritto@iat.com 2006-01-22 00:59:18 0000 Created an attachment (id=77783) Fix for bug. Obvious fix. Previously, each time there were too many children, the code would allow one more child to be created the next time there were too many children. This fix removes the extra decrement on a variable containing the number of outstanding children. Such that, a decrement only occurs once per child reaped. ferdy@gentoo.org 2006-05-12 00:05:08 0000 Done, thanks and sorry for the looooong delay. - ferdy 77783 2006-01-22 00:59 0000 Fix for bug. procmail_formail_maxprocs_fix.diff text/plain LS0tIHNyYy9mb3JtaXNjLmMub3JpZwkyMDA2LTAxLTIyIDAwOjM1OjMwLjAwMDAwMDAwMCAtMDgw MAorKysgc3JjL2Zvcm1pc2MuYwkyMDA2LTAxLTIyIDAwOjM1OjU1LjAwMDAwMDAwMCAtMDgwMApA QCAtMTgzLDcgKzE4Myw3IEBACiAJCSByZXR2YWw9ZXhjb2RlOwogCSAgICB9CQkJCQkgICAgICAg LyogcmVhcCBzb21lIGNoaWxkcmVuICovCiAJd2hpbGUoY2hpbGRsaW1pdCYmY2hpbGRyZW4+PWNo aWxkbGltaXR8fChjaGlsZD1mb3JrKCkpPT0tMSYmY2hpbGRyZW4pCi0JICAgZm9yKC0tY2hpbGRy ZW47KGV4Y29kZT13YWl0Zm9yKChwaWRfdCkwKSkhPU5PX1BST0NFU1M7KQorCSAgIGZvcig7KGV4 Y29kZT13YWl0Zm9yKChwaWRfdCkwKSkhPU5PX1BST0NFU1M7KQogCSAgICB7IGlmKGV4Y29kZSE9 RVhJVF9TVUNDRVNTKQogCQkgcmV0dmFsPWV4Y29kZTsKIAkgICAgICBpZigtLWNoaWxkcmVuPD1t YXhjaGlsZCkK