117528 2006-01-02 19:23 0000 net-proxy/pingtunnel minor ebuild fix 2006-01-06 03:40:12 0000 1 1 1 Unclassified Gentoo Linux Ebuilds unspecified All Linux RESOLVED FIXED P2 enhancement --- 1 covracer@gmail.com net-proxy@gentoo.org covracer@gmail.com 2006-01-02 19:23:08 0000 I just spent my evening writing an ebuild for this app before realizing it was in portage. The ebuild might be able to be improved. 1. There is a libpcap virtual which could be used. I can't test it though, I found--can't create _any_ sockets on my web server :(. 2. The package is called pingtunnel but the binary and man page are called ptunnel. There are some other apps out there (but I don't think in portage) that go by the name of ptunnel so probably pingtunnel is better. 3. There is some html documentation that isn't installed. 4. Lastly, I don't know if this is really an important style thing or not, but in the patch I used the $MY_P and $MY_PN instead of static strings. covracer@gmail.com 2006-01-02 19:26:26 0000 Created an attachment (id=76035) proposed patch mrness@gentoo.org 2006-01-06 03:40:12 0000 (In reply to comment #0) > 1. There is a libpcap virtual which could be used. I can't test it though, I > found--can't create _any_ sockets on my web server :(. the net-libs/libpcap-ringbuffer package is broken and it shouldn't provide virtual/libpcap (see bug #117898) > 2. The package is called pingtunnel but the binary and man page are called > ptunnel. There are some other apps out there (but I don't think in portage) > that go by the name of ptunnel so probably pingtunnel is better. unless there is a conflict, I prefer to stick with whatever names were chosed by upstream. It would mean more than a simple file rename. > 3. There is some html documentation that isn't installed. added depending on "doc" useflag. > 4. Lastly, I don't know if this is really an important style thing or not, but > in the patch I used the $MY_P and $MY_PN instead of static strings. I prefer the other way. It is more readable and I doubt "PingTunnel" will be ever changed by upstream. I've commited 3) along with a minor modification in Makefile sed, but I didn't bump the revision. The doc useflag is the only change worth reemerging for and "emerge -uDN world" will do that anyway. 76035 2006-01-02 19:26 0000 proposed patch pingtunnel-0.61-to-0.61-r1.patch text/plain LS0tIC91c3IvcG9ydGFnZS9uZXQtcHJveHkvcGluZ3R1bm5lbC9waW5ndHVubmVsLTAuNjEuZWJ1 aWxkCTIwMDUtMDctMTcgMTU6MDU6NTEuMDAwMDAwMDAwIC0wNDAwCisrKyAvdXNyL2xvY2FsL3Bv cnRhZ2UvbmV0LXByb3h5L3Bpbmd0dW5uZWwvcGluZ3R1bm5lbC0wLjYxLXIxLmVidWlsZAkyMDA2 LTAxLTAyIDIyOjEyOjM0LjkyMTQ0MTc1MCAtMDUwMApAQCAtMiwxOSArMiwyMSBAQAogIyBEaXN0 cmlidXRlZCB1bmRlciB0aGUgdGVybXMgb2YgdGhlIEdOVSBHZW5lcmFsIFB1YmxpYyBMaWNlbnNl IHYyCiAjICRIZWFkZXI6IC92YXIvY3Zzcm9vdC9nZW50b28teDg2L25ldC1wcm94eS9waW5ndHVu bmVsL3Bpbmd0dW5uZWwtMC42MS5lYnVpbGQsdiAxLjIgMjAwNS8wNy8xNyAxODo0OTozMyBkaG9s bSBFeHAgJAogCitNWV9QTj1QaW5nVHVubmVsCitNWV9QPSR7TVlfUE59LSR7UFZ9CisKIERFU0NS SVBUSU9OPSJUdW5uZWwgVENQIG92ZXIgSUNNUCIKIEhPTUVQQUdFPSJodHRwOi8vd3d3LmNzLnVp dC5uby9+ZGFuaWVscy9QaW5nVHVubmVsIgotU1JDX1VSST0iaHR0cDovL3d3dy5jcy51aXQubm8v fmRhbmllbHMvUGluZ1R1bm5lbC9QaW5nVHVubmVsLSR7UFZ9LnRhci5neiIKK1NSQ19VUkk9Imh0 dHA6Ly93d3cuY3MudWl0Lm5vL35kYW5pZWxzLyR7TVlfUE59LyR7TVlfUH0udGFyLmd6IgogCiBM SUNFTlNFPSJCU0QiCiBTTE9UPSIwIgogS0VZV09SRFM9In5wcGMgfng4NiIKIElVU0U9IiIKIAot UkRFUEVORD0ibmV0LWxpYnMvbGlicGNhcCIKLURFUEVORD0iJHtSREVQRU5EfSIKK1JERVBFTkQ9 InZpcnR1YWwvbGlicGNhcCIKIAotUz0iJHtXT1JLRElSfS9QaW5nVHVubmVsIgorUz0iJHtXT1JL RElSfS8ke01ZX1BOfSIKIAogc3JjX3VucGFjaygpIHsKIAl1bnBhY2sgJHtBfQpAQCAtMjMsNiAr MjUsOCBAQAogfQogCiBzcmNfaW5zdGFsbCgpIHsKLQltYWtlIHByZWZpeD0iJHtEfS91c3IiIGlu c3RhbGwgfHwgZGllICJtYWtlIGluc3RhbGwgaGFzIGZhaWxlZCIKKwluZXdiaW4gcHR1bm5lbCBw aW5ndHVubmVsCisJbmV3bWFuIHB0dW5uZWwuOCBwaW5ndHVubmVsLjgKIAlkb2RvYyBDSEFOR0VM T0cgUkVBRE1FCisJZG9odG1sIHdlYi8qCiB9Cg==