113747 2005-11-27 14:30 0000 Bump sys-fs/fuse to 2.4.2, please 2005-12-03 16:08:21 0000 1 1 1 Unclassified Gentoo Linux Ebuilds unspecified All Linux RESOLVED FIXED P2 enhancement --- 1 radek@podgorny.cz genstef@gentoo.org pete4abw@comcast.net radek@podgorny.cz 2005-11-27 14:30:09 0000 ...as it fixes some security bugs. Thanks... jakub@gentoo.org 2005-11-27 14:38:04 0000 This is already fixed in 2.4.1-r1 (Bug 112902) pete4abw@comcast.net 2005-12-03 15:06:31 0000 You may wish to include this patch which fixes a bad memory leak then. And 2.4.2 IS a new release not included in 2.4.1-r1. From fuse-devel newsgroup by author, Miklos Szeredi Index: lib/fuse.c =================================================================== RCS file: /cvsroot/fuse/fuse/lib/fuse.c,v retrieving revision 1.148 diff -u -r1.148 fuse.c --- lib/fuse.c 28 Nov 2005 16:02:27 -0000 1.148 +++ lib/fuse.c 2 Dec 2005 11:00:31 -0000 @@ -1742,6 +1742,7 @@ void fuse_process_cmd(struct fuse *f, struct fuse_cmd *cmd) { fuse_session_process(f->se, cmd->buf, cmd->buflen, cmd->ch); + free_cmd(cmd); } int fuse_exited(struct fuse *f) @@ -1779,6 +1780,8 @@ int res = fuse_chan_receive(ch, cmd->buf, bufsize); if (res <= 0) { free_cmd(cmd); + if (res == -1) + fuse_exit(f); return NULL; } cmd->buflen = res; This is a bad one. Line #s against 2.4.1 are very different though. See functions: void fuse_process_cmd (diff begins at line 1656) struct fuse_cmd *fuse_read_cmd (diff begins at line 1693) I strongly recommend upgrading to 2.4.2 and modifying the above patch to repair the leak. pete4abw@comcast.net 2005-12-03 15:33:31 0000 Created an attachment (id=74016) fuse-2.4.1.patch fix memory leak pete4abw@comcast.net 2005-12-03 15:34:43 0000 Created an attachment (id=74017) fuse-2.4.2.patch fix memory leak. I strongly recommend implementing 2.4.2. Lots of changes. In addition, I also suggest having a cvs version as is done with enlightenment. Have a version 2.4.9999 which will pull in cvs for this series on demand by user. genstef@gentoo.org 2005-12-03 16:08:21 0000 Thanks, fixed 74016 2005-12-03 15:33 0000 fuse-2.4.1.patch fuse-2.4.1.patch text/plain LS0tIC90bXAvZnVzZS5jLjIuNC4xCTIwMDUtMTItMDMgMTg6MjY6NTMuMDAwMDAwMDAwIC0wNTAw CisrKyAvdG1wL2Z1c2UuYy4yLjQuMS5wYXRjaAkyMDA1LTEyLTAzIDE4OjI2OjUzLjAwMDAwMDAw MCAtMDUwMApAQCAtMTY0Nyw2ICsxNjQ3LDcgQEAKIHZvaWQgZnVzZV9wcm9jZXNzX2NtZChzdHJ1 Y3QgZnVzZSAqZiwgc3RydWN0IGZ1c2VfY21kICpjbWQpCiB7CiAgICAgZnVzZV9zZXNzaW9uX3By b2Nlc3MoZi0+c2UsIGNtZC0+YnVmLCBjbWQtPmJ1ZmxlbiwgY21kLT5jaCk7CisgICAgZnJlZShj bWQpOwogfQogCiBpbnQgZnVzZV9leGl0ZWQoc3RydWN0IGZ1c2UgKmYpCkBAIC0xNjg0LDYgKzE2 ODUsOCBAQAogICAgICAgICBpbnQgcmVzID0gZnVzZV9jaGFuX3JlY2VpdmUoY2gsIGNtZC0+YnVm LCBidWZzaXplKTsKICAgICAgICAgaWYgKHJlcyA8PSAwKSB7CiAgICAgICAgICAgICBmcmVlX2Nt ZChjbWQpOworCSAgICBpZiAocmVzID09IC0xKQorCQlmdXNlX2V4aXQoZik7CiAgICAgICAgICAg ICByZXR1cm4gTlVMTDsKICAgICAgICAgfQogICAgICAgICBjbWQtPmJ1ZmxlbiA9IHJlczsKCg== 74017 2005-12-03 15:34 0000 fuse-2.4.2.patch fuse-2.4.2.patch text/plain LS0tIC90bXAvZnVzZS5jLjIuNC4yCTIwMDUtMTItMDMgMTg6MTk6MzMuMDAwMDAwMDAwIC0wNTAw CisrKyAvdG1wL2Z1c2UuYy4yLjQuMi5wYXRjaGVkCTIwMDUtMTItMDMgMTg6MTk6MzMuMDAwMDAw MDAwIC0wNTAwCkBAIC0xNjU2LDYgKzE2NTYsNyBAQAogdm9pZCBmdXNlX3Byb2Nlc3NfY21kKHN0 cnVjdCBmdXNlICpmLCBzdHJ1Y3QgZnVzZV9jbWQgKmNtZCkKIHsKICAgICBmdXNlX3Nlc3Npb25f cHJvY2VzcyhmLT5zZSwgY21kLT5idWYsIGNtZC0+YnVmbGVuLCBjbWQtPmNoKTsKKyAgICBmcmVl X2NtZChjbWQpOwogfQogCiBpbnQgZnVzZV9leGl0ZWQoc3RydWN0IGZ1c2UgKmYpCkBAIC0xNjkz LDYgKzE2OTQsOCBAQAogICAgICAgICBpbnQgcmVzID0gZnVzZV9jaGFuX3JlY2VpdmUoY2gsIGNt ZC0+YnVmLCBidWZzaXplKTsKICAgICAgICAgaWYgKHJlcyA8PSAwKSB7CiAgICAgICAgICAgICBm cmVlX2NtZChjbWQpOworCSAgICBpZiAocmVzID09IC0xKQorCQlmdXNlX2V4aXQoZik7CiAgICAg ICAgICAgICByZXR1cm4gTlVMTDsKICAgICAgICAgfQogICAgICAgICBjbWQtPmJ1ZmxlbiA9IHJl czsKCg==