11194 2002-11-25 07:10 0000 lame-3.93.0 sound quality problem (and fix) 2002-12-12 12:04:49 0000 1 1 1 Unclassified Gentoo Linux Ebuilds unspecified All Linux RESOLVED FIXED P2 critical --- 1 sebastian.droege@gmx.de fisi.tilman.klar@gmx.de nall@themountaingoats.net sebastian.droege@gmx.de sebastian.droege@gmx.de 2002-11-25 07:10:37 0000 Hi, look here for a description of the problem: http://www.hydrogenaudio.org/index.php?act=ST&f=16&t=4455&s=92606aafd68b383e83a4e2c24d639774 Attached is a patch from the current lame CVS which solves this problem and an ebuild which patches lame lame will be soon released as version 3.93.1 with this patch Bye sebastian.droege@gmx.de 2002-11-25 07:11:26 0000 Created an attachment (id=5932) the patch, to fix the problem sebastian.droege@gmx.de 2002-11-25 07:12:03 0000 Created an attachment (id=5933) the ebuild, which uses the patch sebastian.droege@gmx.de 2002-11-28 15:14:20 0000 Now there's another patch in the lame cvs to work around a quality problem with -q0 The patch sets -q0 to -q1 sebastian.droege@gmx.de 2002-11-28 15:15:30 0000 Created an attachment (id=6025) patch to work around the -q0 problem sebastian.droege@gmx.de 2002-11-28 15:16:35 0000 Created an attachment (id=6026) ebuild with both patches fisi.tilman.klar@gmx.de 2002-12-01 04:36:11 0000 Hey Sebastian, i added it to the official tree. Thanks for the contribution. You might want to take a look at the src_unpack(), i made it more portage conform. -phoen][x- nall@themountaingoats.net 2002-12-01 20:54:33 0000 phoenix, this doesn't work for me: bash-2.05b# ebuild lame-3.93.0-r1.ebuild unpack >>> md5 ;-) lame-3.93.0.tar.gz >>> Unpacking source... >>> Unpacking lame-3.93.0.tar.gz patching file libmp3lame/lame.c Hunk #1 FAILED at 20. 1 out of 2 hunks FAILED -- saving rejects to file libmp3lame/lame.c.rej patching file libmp3lame/psymodel.c Hunk #1 FAILED at 19. 1 out of 3 hunks FAILED -- saving rejects to file libmp3lame/psymodel.c.rej >>> Source unpacked. bash-2.05b# fisi.tilman.klar@gmx.de 2002-12-01 23:40:47 0000 Impressive fix, no? ;) Jonathan, give me an "emerge info" please. -phoen][x- sebastian.droege@gmx.de 2002-12-05 03:52:21 0000 Hmm... it works for me with the standard lame-3.93.0.tar.bz2... But now there's version 3.93.1 so this bug can be closed :) nall@themountaingoats.net 2002-12-06 17:50:38 0000 phoen][x, just for you... bash-2.05b# emerge info Portage 2.0.44 (default-ppc-1.4, gcc-sh: line 1: /usr/bin/gcc: No such file or directory, glibc-2.2.5-r7) ================================================================= System uname: 2.4.19-r6 ppc USE="dvd xv jpeg mitshm gif ppc gnome-libs gdbm berkdb slang aalib guile pam libwww ssl perl python esd imlib oggvorbis qt opengl mozilla X gtk gtk2 gnome bonobo evo gb gtkhtml tcltk ncurses sdl png tiff gd mpeg quicktime oss xmms flash encode crypt imap ldap mbox tcpd cups readline spell truetype xml xml2 pdflib plotutils tetex mysql samba gpm zlib pcmcia moznomail java directfb -motif -nls -avi -alsa -arts -kde" ARCH="ppc" COMPILER="gcc3" CHOST="powerpc-unknown-linux-gnu" CFLAGS="-O2 -pipe -mcpu=7400 -maltivec -mabi=altivec -mpowerpc-gfxopt -fsigned-char" CXXFLAGS="-O2 -pipe -mcpu=7400 -maltivec -mabi=altivec -mpowerpc-gfxopt -fsigned-char" ACCEPT_KEYWORDS="ppc ~ppc" CONFIG_PROTECT="/etc /var/qmail/control /usr/share/config /usr/kde/2/share/config /usr/kde/3/share/config /usr/kde/3/share/config:/usr/share/config" CONFIG_PROTECT_MASK="/etc/gconf /etc/env.d" MAKEOPTS="-j2" JDK_HOME="/opt/blackdown-jdk-1.3.1" JAVA_HOME="/opt/blackdown-jdk-1.3.1" AUTOCLEAN="yes" SYNC="rsync://rsync.gentoo.org/gentoo-portage" GENTOO_MIRRORS="http://www.ibiblio.org/gentoo" nall@themountaingoats.net 2002-12-08 20:47:21 0000 added myself to CC list fisi.tilman.klar@gmx.de 2002-12-11 10:22:53 0000 Added lame-3.93.1 to the tree. Give it a try, please. -phoen][x- nall@themountaingoats.net 2002-12-12 06:23:11 0000 phoenix, 3.93.1 compiles just fine. are you going to remove the patch from 3.93.0-r1 and just let it have the quality issue? fisi.tilman.klar@gmx.de 2002-12-12 12:04:49 0000 I removed lame-3.93.0-r1 and tagged lame-3.93.1 stable for x86. I ~hope~ it's safe to close this bug now. Just REOP it again if you need something. :) -phoen][x- 5932 2002-11-25 07:11 0000 the patch, to fix the problem lame-3.93.0-npsytunefix.diff text/plain PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQpSQ1MgZmlsZTogL2N2c3Jvb3QvbGFtZS9sYW1lL2xpYm1wM2xhbWUvcHN5bW9k ZWwuYyx2CnJldHJpZXZpbmcgcmV2aXNpb24gMS4xMTMKcmV0cmlldmluZyByZXZpc2lvbiAxLjEx NApkaWZmIC11IC1yMS4xMTMgLXIxLjExNAotLS0gbGFtZS9sYW1lL2xpYm1wM2xhbWUvcHN5bW9k ZWwuYwkyMDAyLzEwLzE1IDE5OjE2OjIyCTEuMTEzCisrKyBsYW1lL2xhbWUvbGlibXAzbGFtZS9w c3ltb2RlbC5jCTIwMDIvMTEvMjMgMTg6NTQ6MDYJMS4xMTQKQEAgLTE5LDcgKzE5LDcgQEAKICAq IEJvc3RvbiwgTUEgMDIxMTEtMTMwNywgVVNBLgogICovCiAKLS8qICRJZDogcHN5bW9kZWwuYyx2 IDEuMTEzIDIwMDIvMTAvMTUgMTk6MTY6MjIgcm9iZXJ0IEV4cCAkICovCisvKiAkSWQ6IHBzeW1v ZGVsLmMsdiAxLjExNCAyMDAyLzExLzIzIDE4OjU0OjA2IGJvdXZpZ25lIEV4cCAkICovCiAKIAog LyoKQEAgLTE3ODksNiArMTc4OSw5IEBACiAJCX0KIAogLyogMjAwMS0wNy0xMyAqLworICAgICAg ICAgIHRocltiXSA9IE1heCgxZS02LCBlY2IpOworCisgICAgICAgICAgaWYgKGdmcC0+VkJSID09 IHZicl9tdHJoKSB7CiAgICAgICAgICAgICAgICAgdGhyW2JdID0gTWluKCBlY2IsIHJwZWxldl9z ICAqIGdmYy0+bmJfczFbY2huXVtiXSApOwogICAgICAgICAgICAgICAgIGlmIChnZmMtPmJsb2Nr dHlwZV9vbGRbY2huPjEgPyBjaG4tMiA6IGNobl0gPT0gU0hPUlRfVFlQRSApIHsKICAgICAgICAg ICAgICAgICAgICB0aHJbYl0gPSBNaW4oIHRocltiXSwgcnBlbGV2Ml9zICogZ2ZjLT5uYl9zMltj aG5dW2JdICk7CkBAIC0xNzk2LDYgKzE3OTksNyBAQAogICAgICAgICAgICAgICAgIHRocltiXSA9 IE1heCggdGhyW2JdLCAxZS0zNyApOwogICAgICAgICAgICAgICAgIGdmYy0+bmJfczJbY2huXVti XSA9IGdmYy0+bmJfczFbY2huXVtiXTsKICAgICAgICAgICAgICAgICBnZmMtPm5iX3MxW2Nobl1b Yl0gPSBlY2I7CisgICAgICAgICAgfQogCSAgICB9CiAJfQogCWZvciAoIHNiID0gMDsgc2IgPCBO QlBTWV9zOyBzYisrICkKCg== 5933 2002-11-25 07:12 0000 the ebuild, which uses the patch lame-3.93.0-r1.ebuild text/plain IyBDb3B5cmlnaHQgMTk5OS0yMDAyIEdlbnRvbyBUZWNobm9sb2dpZXMsIEluYy4KIyBEaXN0cmli dXRlZCB1bmRlciB0aGUgdGVybXMgb2YgdGhlIEdOVSBHZW5lcmFsIFB1YmxpYyBMaWNlbnNlIHYy CiMgJEhlYWRlcjogL2hvbWUvY3Zzcm9vdC9nZW50b28teDg2L21lZGlhLXNvdW5kL2xhbWUvbGFt ZS0zLjkzLjAuZWJ1aWxkLHYgMS4xIDIwMDIvMTEvMjQgMDA6MTM6MzQgc3BpZGVyIEV4cCAkCgpJ VVNFPSJndGsiCgppbmhlcml0IGxpYnRvb2wKTVlfUFY9YGVjaG8gJHtQVn18Y3V0IC1kIC4gLWYg LTJgClM9JHtXT1JLRElSfS9sYW1lLSR7TVlfUFZ9CkRFU0NSSVBUSU9OPSJMQU1FIEFpbid0IGFu IE1wMyBFbmNvZGVyIgpTUkNfVVJJPSJtaXJyb3I6Ly9zb3VyY2Vmb3JnZS9sYW1lLyR7UH0udGFy Lmd6IgpIT01FUEFHRT0iaHR0cDovL3d3dy5tcDNkZXYub3JnL21wMy8iCgpERVBFTkQ9InZpcnR1 YWwvZ2xpYmMKCXg4Nj8gKCBkZXYtbGFuZy9uYXNtICkKCT49c3lzLWxpYnMvbmN1cnNlcy01LjIK CWd0az8gKCA9eDExLWxpYnMvZ3RrKy0xLjIqICkiCiMgdGhpcyByZWxlYXNlIGNvbXBsZXRlbHkg cmVtb3ZlZCBvZ2d2b3JiaXMgc3VwcG9ydCBhcyBpdCB3YXMgdG9vIG91dGRhdGVkLgoKUkRFUEVO RD0idmlydHVhbC9nbGliYwoJPj1zeXMtbGlicy9uY3Vyc2VzLTUuMgoJZ3RrPyAoID14MTEtbGli cy9ndGsrLTEuMiogKSIKCkxJQ0VOU0U9IkxHUEwtMi4xIgpTTE9UPSIwIgpLRVlXT1JEUz0ifng4 NiB+cHBjIH5zcGFyYyB+c3BhcmM2NCIKCnNyY191bnBhY2soKSB7CgkKCXVucGFjayAke1B9LnRh ci5negoKCWNkICR7U30KCgljYXQgJHtGSUxFU0RJUn0vbGFtZS0zLjkzLjAtbnBzeXR1bmVmaXgu ZGlmZiB8IHBhdGNoIC1wMiA+IC9kZXYvbnVsbCB8fCBkaWUKfQoKc3JjX2NvbXBpbGUoKSB7Cgll bGlidG9vbGl6ZQoKCWxvY2FsIG15Y29uZj0iIgoJaWYgWyAiYHVzZSBndGtgIiBdIDsgdGhlbgoJ CW15Y29uZj0iJHtteWNvbmZ9IC0tZW5hYmxlLW1wM3giCglmaQoJaWYgWyAiJHtERUJVR30iIF0g OyB0aGVuCgkJbXljb25mPSIke215Y29uZn0gLS1lbmFibGUtZGVidWc9eWVzIgoJZWxzZQoJCW15 Y29uZj0iJHtteWNvbmZ9IC0tZW5hYmxlLWRlYnVnPW5vIgoJZmkKCQoJLi9jb25maWd1cmUgLS1w cmVmaXg9L3VzciBcCgkJLS1tYW5kaXI9L3Vzci9zaGFyZS9tYW4gXAoJCS0tZW5hYmxlLXNoYXJl ZCBcCgkJLS1lbmFibGUtbmFzbSBcCgkJLS1lbmFibGUtbXAzcnRwIFwKCQktLWVuYWJsZS1leHRv cHQ9ZnVsbCBcCgkJJHtteWNvbmZ9IHx8IGRpZQoJCQoJZW1ha2UgfHwgZGllCn0KCnNyY19pbnN0 YWxsICgpIHsKCgltYWtlIHByZWZpeD0ke0R9L3VzciBcCgkJbWFuZGlyPSR7RH0vdXNyL3NoYXJl L21hbiBcCgkJcGtnaHRtbGRpcj0ke0R9L3Vzci9zaGFyZS9kb2MvJHtQRn0vaHRtbCBcCgkJaW5z dGFsbCB8fCBkaWUKCglkb2RvYyBBUEkgQ09QWUlORyBIQUNLSU5HIFBSRVNFVFMuZHJhZnQgTElD RU5TRSBSRUFETUUqIFRPRE8gVVNBR0UKCWRvaHRtbCAtciAuLwp9Cgo= 6025 2002-11-28 15:15 0000 patch to work around the -q0 problem lame-3.93.0-q0fix.diff text/plain PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQpSQ1MgZmlsZTogL2N2c3Jvb3QvbGFtZS9sYW1lL2xpYm1wM2xhbWUvbGFtZS5j LHYKcmV0cmlldmluZyByZXZpc2lvbiAxLjE5MwpyZXRyaWV2aW5nIHJldmlzaW9uIDEuMTk0CmRp ZmYgLXUgLXIxLjE5MyAtcjEuMTk0Ci0tLSBsYW1lL2xhbWUvbGlibXAzbGFtZS9sYW1lLmMJMjAw Mi8xMS8xMyAyMDoyNDowNAkxLjE5MworKysgbGFtZS9sYW1lL2xpYm1wM2xhbWUvbGFtZS5jCTIw MDIvMTEvMjggMTg6MDQ6MTgJMS4xOTQKQEAgLTIwLDcgKzIwLDcgQEAKICAqIEJvc3RvbiwgTUEg MDIxMTEtMTMwNywgVVNBLgogICovCiAKLS8qICRJZDogbGFtZS5jLHYgMS4xOTMgMjAwMi8xMS8x MyAyMDoyNDowNCBib3V2aWduZSBFeHAgJCAqLworLyogJElkOiBsYW1lLmMsdiAxLjE5NCAyMDAy LzExLzI4IDE4OjA0OjE4IGJvdXZpZ25lIEV4cCAkICovCiAKICNpZmRlZiBIQVZFX0NPTkZJR19I CiAjIGluY2x1ZGUgPGNvbmZpZy5oPgpAQCAtNDc0LDcgKzQ3NCw3IEBACiAgICAgICAgIGdmYy0+ cXVhbnRpemF0aW9uID0gMTsKICAgICAgICAgZ2ZjLT5ub2lzZV9zaGFwaW5nID0gMTsgLyogMj11 c3VhbGx5IGxvd2VycyBxdWFsaXR5ICovCiAgICAgICAgIGdmYy0+c3Vic3RlcF9zaGFwaW5nID0g MjsKLSAgICAgICAgZ2ZjLT5ub2lzZV9zaGFwaW5nX2FtcCA9IDM7CisgICAgICAgIGdmYy0+bm9p c2Vfc2hhcGluZ19hbXAgPSAyOwogICAgICAgICBnZmMtPm5vaXNlX3NoYXBpbmdfc3RvcCA9IDE7 CiAgICAgICAgIGdmYy0+dXNlX2Jlc3RfaHVmZm1hbiA9IDE7IC8qIDIgbm90IHlldCBjb2RlZCAq LwogICAgIH0K 6026 2002-11-28 15:16 0000 ebuild with both patches lame-3.93.0-r1.ebuild text/plain IyBDb3B5cmlnaHQgMTk5OS0yMDAyIEdlbnRvbyBUZWNobm9sb2dpZXMsIEluYy4KIyBEaXN0cmli dXRlZCB1bmRlciB0aGUgdGVybXMgb2YgdGhlIEdOVSBHZW5lcmFsIFB1YmxpYyBMaWNlbnNlIHYy CiMgJEhlYWRlcjogL2hvbWUvY3Zzcm9vdC9nZW50b28teDg2L21lZGlhLXNvdW5kL2xhbWUvbGFt ZS0zLjkzLjAuZWJ1aWxkLHYgMS4xIDIwMDIvMTEvMjQgMDA6MTM6MzQgc3BpZGVyIEV4cCAkCgpJ VVNFPSJndGsiCgppbmhlcml0IGxpYnRvb2wKTVlfUFY9YGVjaG8gJHtQVn18Y3V0IC1kIC4gLWYg LTJgClM9JHtXT1JLRElSfS9sYW1lLSR7TVlfUFZ9CkRFU0NSSVBUSU9OPSJMQU1FIEFpbid0IGFu IE1wMyBFbmNvZGVyIgpTUkNfVVJJPSJtaXJyb3I6Ly9zb3VyY2Vmb3JnZS9sYW1lLyR7UH0udGFy Lmd6IgpIT01FUEFHRT0iaHR0cDovL3d3dy5tcDNkZXYub3JnL21wMy8iCgpERVBFTkQ9InZpcnR1 YWwvZ2xpYmMKCXg4Nj8gKCBkZXYtbGFuZy9uYXNtICkKCT49c3lzLWxpYnMvbmN1cnNlcy01LjIK CWd0az8gKCA9eDExLWxpYnMvZ3RrKy0xLjIqICkiCiMgdGhpcyByZWxlYXNlIGNvbXBsZXRlbHkg cmVtb3ZlZCBvZ2d2b3JiaXMgc3VwcG9ydCBhcyBpdCB3YXMgdG9vIG91dGRhdGVkLgoKUkRFUEVO RD0idmlydHVhbC9nbGliYwoJPj1zeXMtbGlicy9uY3Vyc2VzLTUuMgoJZ3RrPyAoID14MTEtbGli cy9ndGsrLTEuMiogKSIKCkxJQ0VOU0U9IkxHUEwtMi4xIgpTTE9UPSIwIgpLRVlXT1JEUz0ifng4 NiB+cHBjIH5zcGFyYyB+c3BhcmM2NCIKCnNyY191bnBhY2soKSB7CgkKCXVucGFjayAke1B9LnRh ci5negoKCWNkICR7U30KCgljYXQgJHtGSUxFU0RJUn0vbGFtZS0zLjkzLjAtbnBzeXR1bmVmaXgu ZGlmZiB8IHBhdGNoIC1wMiA+IC9kZXYvbnVsbCB8fCBkaWUKCWNhdCAke0ZJTEVTRElSfS9sYW1l LTMuOTMuMC1xMGZpeC5kaWZmIHwgcGF0Y2ggLXAyID4gL2Rldi9udWxsIHx8IGRpZQp9CgpzcmNf Y29tcGlsZSgpIHsKCWVsaWJ0b29saXplCgoJbG9jYWwgbXljb25mPSIiCglpZiBbICJgdXNlIGd0 a2AiIF0gOyB0aGVuCgkJbXljb25mPSIke215Y29uZn0gLS1lbmFibGUtbXAzeCIKCWZpCglpZiBb ICIke0RFQlVHfSIgXSA7IHRoZW4KCQlteWNvbmY9IiR7bXljb25mfSAtLWVuYWJsZS1kZWJ1Zz15 ZXMiCgllbHNlCgkJbXljb25mPSIke215Y29uZn0gLS1lbmFibGUtZGVidWc9bm8iCglmaQoJCgku L2NvbmZpZ3VyZSAtLXByZWZpeD0vdXNyIFwKCQktLW1hbmRpcj0vdXNyL3NoYXJlL21hbiBcCgkJ LS1lbmFibGUtc2hhcmVkIFwKCQktLWVuYWJsZS1uYXNtIFwKCQktLWVuYWJsZS1tcDNydHAgXAoJ CS0tZW5hYmxlLWV4dG9wdD1mdWxsIFwKCQkke215Y29uZn0gfHwgZGllCgkJCgllbWFrZSB8fCBk aWUKfQoKc3JjX2luc3RhbGwgKCkgewoKCW1ha2UgcHJlZml4PSR7RH0vdXNyIFwKCQltYW5kaXI9 JHtEfS91c3Ivc2hhcmUvbWFuIFwKCQlwa2dodG1sZGlyPSR7RH0vdXNyL3NoYXJlL2RvYy8ke1BG fS9odG1sIFwKCQlpbnN0YWxsIHx8IGRpZQoKCWRvZG9jIEFQSSBDT1BZSU5HIEhBQ0tJTkcgUFJF U0VUUy5kcmFmdCBMSUNFTlNFIFJFQURNRSogVE9ETyBVU0FHRQoJZG9odG1sIC1yIC4vCn0KCg==