111395 2005-11-03 13:09 0000 sdl-mixer has smpeg as static dependency, ignoring -mp3 2005-11-04 10:57:18 0000 1 1 1 Unclassified Gentoo Linux Ebuilds 2005.1 All Linux RESOLVED FIXED P2 normal --- 1 arc@pysoy.org games@gentoo.org arc@pysoy.org 2005-11-03 13:09:20 0000 This is a simple fix to allow people who choose to turn mp3 support off (ie, not installing mad/smpeg/etc) while still using sdl-mixer. This is in order to comply with section 11 of the LGPL, which restricts distribution when the software's use and/or distribution is impeded by software patents, whereas the MP3 licensing authority allows only cost-free decoders to be distributed without royalties and the GPL/LGPL permit for-cost distribution. In countries where their patents are recognized, all GPL/LGPL MP3 decoders are therefor not legally permitted to be distributed. arc@pysoy.org 2005-11-03 13:09:46 0000 Created an attachment (id=72048) /usr/local/portage/media-libs/sdl-mixer/sdl-mixer-1.2.6-r2.ebuild jakub@gentoo.org 2005-11-03 13:48:01 0000 We are not crippling software because of stupid laws. arc@pysoy.org 2005-11-04 05:18:48 0000 This is *NOT* an issue of crippling software in any way, this is only permitting users of sdl-mixer to choose not to compile it with mp3 support. This patch only has effect if the -mp3 flag is set, that is, if users wish to run a system without this proprietary codec installed. Most games/etc which use sdl-mixer use only Ogg Vorbis or PCM audio, and with those games, a version of sdl-mixer compiled with -mp3 works perfectly fine. The current ebuild, which installs MP3 decoding software even when the -mp3 flag is set, is clearly wrong behavior and is misleading to users who choose to set the -mp3 USE variable. wolf31o2@gentoo.org 2005-11-04 07:09:34 0000 So what *exactly* did you change? If it is trivial, a patch against the ebuild would have been easier. arc@pysoy.org 2005-11-04 07:14:58 0000 This is all that was changed: $ diff /usr/portage/media-libs/sdl-mixer/sdl-mixer-1.2.6-r1.ebuild /usr/local/portage/media-libs/sdl-mixer/sdl-mixer-1.2.6-r2.ebuild 18c18 < >=media-libs/smpeg-0.4.4-r1 --- > mp3? ( >=media-libs/smpeg-0.4.4-r1 ) wolf31o2@gentoo.org 2005-11-04 07:44:46 0000 ...and now for the painful question. Do you have a list of the packages in the tree that *do* require SDL_mixer to be linked again smpeg? I don't want to make changes in the name of "choice" that end up breaking other packages and causing more work for myself and the rest of the games team. vapier@gentoo.org 2005-11-04 07:59:28 0000 if it was a real issue we would have seen it by now ... the ebuild has been passing --disable-music-mp3 for users with USE=-mp3 for a while now this bug is just fixing the DEPEND wolf31o2@gentoo.org 2005-11-04 08:01:23 0000 Also, you'll need a patch for the configure scripts to make it actually allow one to build without smpeg, so it won't use any system smpeg already on the system. Essentially, I would say that this is well beyond the scope of what the games team wants to undertake. It means countless hours of work verifying each and every game in the tree that uses SDL_mixer in any way to ensure that they do not require this support. If you're willing to put in the work to do this on every game in the tree currently, then I have no problem adding this support to SDL_mixer. I will not, however, agree to dump this kind of a workload on my fellow developers. Feel free to REOPEN this with the requested information/patches. vapier@gentoo.org 2005-11-04 08:12:01 0000 re-opening because wolf is a tool wolf31o2@gentoo.org 2005-11-04 08:21:07 0000 Yup. I'm a tool. Sorry about that. Your explanation wasn't very good on what really needed to be done and I didn't bother actually looking at what the ebuild was doing. From what I read, it sounded like we needed to *add* a way to remove mp3 support from sdl-mixer. Sorry about that. Anyway, I've fixed this in CVS now. Sorry for being such a dense asshat. arc@pysoy.org 2005-11-04 10:14:00 0000 Thanks. After 8 months or so, it feels good to no longer have to patch my local copy everytime a version bump happens.. :-) wolf31o2@gentoo.org 2005-11-04 10:57:18 0000 You could have filed the bug months ago... :P 72048 2005-11-03 13:09 0000 /usr/local/portage/media-libs/sdl-mixer/sdl-mixer-1.2.6-r2.ebuild sdl-mixer-1.2.6-r2.ebuild text/plain IyBDb3B5cmlnaHQgMTk5OS0yMDA1IEdlbnRvbyBGb3VuZGF0aW9uCiMgRGlzdHJpYnV0ZWQgdW5k ZXIgdGhlIHRlcm1zIG9mIHRoZSBHTlUgR2VuZXJhbCBQdWJsaWMgTGljZW5zZSB2MgojICRIZWFk ZXI6IC92YXIvY3Zzcm9vdC9nZW50b28teDg2L21lZGlhLWxpYnMvc2RsLW1peGVyL3NkbC1taXhl ci0xLjIuNi1yMS5lYnVpbGQsdiAxLjIgMjAwNS8xMC8xMCAxNTowMjoxNCB2YXBpZXIgRXhwICQK CmluaGVyaXQgZXV0aWxzCgpNWV9QPSR7UC9zZGwtL1NETF99CkRFU0NSSVBUSU9OPSJTaW1wbGUg RGlyZWN0IE1lZGlhIExheWVyIE1peGVyIExpYnJhcnkiCkhPTUVQQUdFPSJodHRwOi8vd3d3Lmxp YnNkbC5vcmcvcHJvamVjdHMvU0RMX21peGVyL2luZGV4Lmh0bWwiClNSQ19VUkk9Imh0dHA6Ly93 d3cubGlic2RsLm9yZy9wcm9qZWN0cy9TRExfbWl4ZXIvcmVsZWFzZS8ke01ZX1B9LnRhci5neiIK CkxJQ0VOU0U9IkxHUEwtMiIKU0xPVD0iMCIKS0VZV09SRFM9In5hbHBoYSB+YW1kNjQgfmFybSB+ aHBwYSB+aWE2NCB+bWlwcyB+cHBjIH5wcGM2NCB+c3BhcmMgfng4NiIKSVVTRT0ibXAzIG1pa21v ZCB2b3JiaXMiCgpERVBFTkQ9Ij49bWVkaWEtbGlicy9saWJzZGwtMS4yLjUKCW1wMz8gKCA+PW1l ZGlhLWxpYnMvc21wZWctMC40LjQtcjEgKQoJdm9yYmlzPyAoID49bWVkaWEtbGlicy9saWJ2b3Ji aXMtMS4wX2JldGE0IG1lZGlhLWxpYnMvbGlib2dnICkKCW1pa21vZD8gKCA+PW1lZGlhLWxpYnMv bGlibWlrbW9kLTMuMS4xMCApIgoKUz0ke1dPUktESVJ9LyR7TVlfUH0KCnNyY191bnBhY2soKSB7 Cgl1bnBhY2sgJHtBfQoJY2QgIiR7U30iCgllcGF0Y2ggIiR7RklMRVNESVJ9Ii9zZGwtbWl4ZXIt MS4yLjYtbWlrbW9kLW11c2ljLWluaXQucGF0Y2gKCXNlZCAtaSBcCgkJLWUgJ3M6L3Vzci9sb2Nh bC9saWIvdGltaWRpdHk6L3Vzci9zaGFyZS90aW1pZGl0eTonIFwKCQl0aW1pZGl0eS9jb25maWcu aCBcCgkJfHwgZGllICJzZWQgdGltaWRpdHkvY29uZmlnLmggZmFpbGVkIgp9CgpzcmNfY29tcGls ZSgpIHsKCWVjb25mIFwKCQktLWRpc2FibGUtZGVwZW5kZW5jeS10cmFja2luZyBcCgkJJCh1c2Vf ZW5hYmxlIG1pa21vZCBtdXNpYy1saWJtaWttb2QpIFwKCQkkKHVzZV9lbmFibGUgbXAzIG11c2lj LW1wMykgXAoJCSQodXNlX2VuYWJsZSB2b3JiaXMgbXVzaWMtb2dnKSBcCgkJfHwgZGllCgllbWFr ZSB8fCBkaWUgImVtYWtlIGZhaWxlZCIKfQoKc3JjX2luc3RhbGwoKSB7CgltYWtlIERFU1RESVI9 IiR7RH0iIGluc3RhbGwgfHwgZGllICJtYWtlIGluc3RhbGwgZmFpbGVkIgoJZG9kb2MgQ0hBTkdF UyBSRUFETUUKfQo=