105127 2005-09-07 02:43 0000 media-libs/netpbm-10.28 - anytopnm buggy 2005-09-26 18:13:52 0000 1 1 1 Unclassified Gentoo Linux Applications unspecified All All RESOLVED FIXED P2 normal --- 1 erik@thiele-hydraulik.de maintainer-needed@gentoo.org mmlange@gmail.com vapier@gentoo.org erik@thiele-hydraulik.de 2005-09-07 02:43:16 0000 line 76 sais: mimeType=`file --mime "$1" | cut -d: -f2-` this is wrong. mimeType variable always contains a whitespace at first position. for example: mimeType=" image/png" for that reason the code in line 93 until 112 is never executed. it consists of commands like this: type = "jfif" this is not legal shell code! correct would be: type="jfif" (without whitespace) but due to the first bug, this wrong code is never executed. as i fixed the first bug the script bailed out at the second bug ;) isn't it strange that such an error can last for years without ever being noticed ;) never executed untested code.... :-) i found this bug, because i have a PNG image file with the following strange behaviour: erik@goofy:~/filebug$ file --mime 28 28: image/png erik@goofy:~/filebug$ file 28 28: Minix filesystem erik@goofy:~/filebug$ the file utility uses two different databases for mime output and human readable output. in the mime database there is no "minix file type" and in the human readable database there is a minix file type. unfortunately file gives favour for minix over png, but that is another discussion. anyway what anytopnm sais here is: erik@goofy:~/filebug$ anytopnm 28 /usr/bin/anytopnm: unknown file type. 'file' says mime type is ' image/png', type description is ' Minix filesystem' you see the whitespaces??? these whitespaces confuse anytopnm. normaly anytopnm would see that file --mime myfile returns image/png and just go on read the file. but the mime type is always ignored by the script due to the bug in the "cut" statement. instead the script ALWAYS uses the human readable description and in this case the human readable description is wrong, so the script fails. Reproducible: Always Steps to Reproduce: jakub@gentoo.org 2005-09-07 02:44:47 0000 Please, *always* include ebuild name and version in the bug summary. Otherwise, I cannot assign the bug. erik@thiele-hydraulik.de 2005-09-07 03:56:37 0000 * media-libs/netpbm Latest version available: 10.28 Latest version installed: 10.28 Size of downloaded files: 2,270 kB Homepage: http://netpbm.sourceforge.net/ Description: A set of utilities for converting to/from the netpbm (and related) formats License: GPL-2 root@gf:~# emerge info Portage 2.0.51.22-r2 (default-linux/x86/2005.0, gcc-3.3.6, glibc-2.3.5-r1, 2.6.12-gentoo-r10 i686) ================================================================= System uname: 2.6.12-gentoo-r10 i686 Intel(R) Pentium(R) 4 CPU 1.80GHz Gentoo Base System version 1.6.13 ccache version 2.3 [enabled] dev-lang/python: 2.3.5 sys-apps/sandbox: 1.2.12 sys-devel/autoconf: 2.13, 2.59-r6 sys-devel/automake: 1.4_p6, 1.5, 1.6.3, 1.7.9-r1, 1.8.5-r3, 1.9.6 sys-devel/binutils: 2.15.92.0.2-r10 sys-devel/libtool: 1.5.18-r1 virtual/os-headers: 2.6.11-r2 ACCEPT_KEYWORDS="x86" AUTOCLEAN="yes" CBUILD="i686-pc-linux-gnu" CFLAGS="-O2 -march=pentium4 -pipe -fomit-frame-pointer" CHOST="i686-pc-linux-gnu" CONFIG_PROTECT="/etc /usr/kde/2/share/config /usr/kde/3.3/env /usr/kde/3.3/share/config /usr/kde/3.3/shutdown /usr/kde/3.4/env /usr/kde/3.4/share/config /usr/kde/3.4/shutdown /usr/kde/3/share/config /usr/lib/X11/xkb /usr/lib/mozilla/defaults/pref /usr/share/config /usr/share/texmf/dvipdfm/config/ /usr/share/texmf/dvips/config/ /usr/share/texmf/tex/generic/config/ /usr/share/texmf/tex/platex/config/ /usr/share/texmf/xdvi/ /var/qmail/control" CONFIG_PROTECT_MASK="/etc/gconf /etc/terminfo /etc/env.d" CXXFLAGS="-O2 -march=pentium4 -pipe -fomit-frame-pointer" DISTDIR="/usr/portage/distfiles" FEATURES="autoconfig ccache distlocks nostrip sandbox sfperms strict" GENTOO_MIRRORS="http://distfiles.gentoo.org http://distro.ibiblio.org/pub/Linux/distributions/gentoo" LANG="de_DE" LINGUAS="de" MAKEOPTS="-j2" PKGDIR="/usr/portage/packages" PORTAGE_TMPDIR="/var/tmp" PORTDIR="/usr/portage" SYNC="rsync://rsync.gentoo.org/gentoo-portage" USE="x86 X alsa apm arts avi berkdb bitmap-fonts cdr crypt cups curl doc dvd eds emboss encode esd fam flac font-server foomaticdb fortran gd gdbm gif gimpprint gnome gphoto2 gpm gstreamer gtk gtk2 imagemagick imlib java jpeg kde ldap libg++ libwww mad mikmod motif mozilla mp3 mpeg ncurses nls ogg oggvorbis opengl oss pam pdflib perl png postgres ppds python qt quicktime readline samba scanner sdl slang spell ssl tcltk tcpd tetex tiff truetype truetype-fonts type1-fonts usb vorbis xine xml2 xmms xv zlib linguas_de userland_GNU kernel_linux elibc_glibc" Unset: ASFLAGS, CTARGET, LC_ALL, LDFLAGS, PORTDIR_OVERLAY jakub@gentoo.org 2005-09-07 04:08:29 0000 You forgot to reopen. mmlange@gmail.com 2005-09-11 21:02:36 0000 Created an attachment (id=68221) Patch to fix anytopnm Patch to fix anytopnm. Compiles and works fine on my box. Ebuild to follow. mmlange@gmail.com 2005-09-11 21:04:08 0000 Created an attachment (id=68222) media-libs/netpbm ebuild Ebuild that works with 105127-r2.patch vapier@gentoo.org 2005-09-26 18:13:52 0000 thanks, patch now in 10.29-r1 68221 2005-09-11 21:02 0000 Patch to fix anytopnm 105127-r2.patch text/plain LS0tIGNvbnZlcnRlci9vdGhlci9hbnl0b3BubQkyMDA1LTA1LTI2IDE3OjEwOjM5LjAwMDAwMDAw MCAtMDUwMAorKysgY29udmVydGVyL290aGVyL2FueXRvcG5tLmdlbnRvby4xMDUxMjcJMjAwNS0w OS0xMSAyMjozNjo1Ni4wMDAwMDAwMDAgLTA1MDAKQEAgLTczLDcgKzczLDcgQEAKICAgICBmaWxl IC0tbWltZSAvZGV2L251bGwgPi9kZXYvbnVsbCAyPi9kZXYvbnVsbAogICAgIGlmIFsgJD8gLWVx IDAgXTsgdGhlbgogICAgICAgICAjIE5vdyB0aGF0IHdlIGtub3cgdGhlIC0tbWltZSBvcHRpb24g ZXhpc3RzLCB1c2UgaXQuCi0gICAgICAgIG1pbWVUeXBlPWBmaWxlIC0tbWltZSAiJDEiIHwgY3V0 IC1kOiAtZjItYAorICAgICAgICBtaW1lVHlwZT1gZmlsZSAtLW1pbWUgIiQxIiB8IGN1dCAtZDog LWYyLSB8IGN1dCAtYzItYAogICAgIGVsc2UKICAgICAgICAgIyBmaWxlIC0tbWltZSBmYWlsZWQ7 IHdlIGRvbid0IGtub3cgd2h5LCBidXQgd2UgYXNzdW1lIGl0J3MgYmVjYXVzZSBpdAogICAgICAg ICAjIGlzIGEgdHJhZGl0aW9uYWwgJ2ZpbGUnIHByb2dyYW0gdGhhdCBkb2Vzbid0IGhhdmUgYSAt LW1pbWUgb3B0aW9uLgpAQCAtOTAsMjYgKzkwLDI2IEBACiAgICAgY2FzZSAiJDEiIGluCiAKICAg ICAgICAgaW1hZ2UvanBlZyApCi0gICAgICAgICAgICB0eXBlID0gImpmaWYiCisgICAgICAgICAg ICB0eXBlPSJqZmlmIgogICAgICAgICAgICAgOzsKICAgICAgICAgaW1hZ2UvZ2lmICkKLSAgICAg ICAgICAgIHR5cGUgPSAiZ2lmIgorICAgICAgICAgICAgdHlwZT0iZ2lmIgogICAgICAgICAgICAg OzsKICAgICAgICAgaW1hZ2UvdGlmZiApCi0gICAgICAgICAgICB0eXBlID0gInRpZmYiCisgICAg ICAgICAgICB0eXBlPSJ0aWZmIgogICAgICAgICAgICAgOzsKICAgICAgICAgaW1hZ2UvYm1wICkK LSAgICAgICAgICAgIHR5cGUgPSAiYm1wIgorICAgICAgICAgICAgdHlwZT0iYm1wIgogICAgICAg ICAgICAgOzsKICAgICAgICAgaW1hZ2UvcG5nICkKLSAgICAgICAgICAgIHR5cGUgPSAicG5nIgor ICAgICAgICAgICAgdHlwZT0icG5nIgogICAgICAgICAgICAgOzsKICAgICAgICAgaW1hZ2UveC1w b3J0YWJsZS1iaXRtYXAgfCBpbWFnZS94LXBvcnRhYmxlLXBpeG1hcCB8IFwKICAgICAgICAgICAg ICAgICBpbWFnZS94LXBvcnRhYmxlLWdyZXltYXApCi0gICAgICAgICAgICB0eXBlID0gInBubSIK KyAgICAgICAgICAgIHR5cGU9InBubSIKICAgICAgICAgICAgIDs7CiAgICAgICAgIGltYWdlL3gt eHBtICkKLSAgICAgICAgICAgIHR5cGUgPSAieHBtIgorICAgICAgICAgICAgdHlwZT0ieHBtIgog ICAgICAgICAgICAgOzsKICAgICAgICAgKiApCiAgICAgICAgICAgICBmaWxldHlwZT11bmtub3du CkBAIC01NDEsNyArNTQxLDcgQEAKIAogc2V0TWltZVR5cGUgIiRmaWxlIgogCi10eXBlRGVzY3Jp cHRpb249YGZpbGUgIiRmaWxlIiB8IGN1dCAtZDogLWYyLWAKK3R5cGVEZXNjcmlwdGlvbj1gZmls ZSAiJGZpbGUiIHwgY3V0IC1kOiAtZjItIHwgY3V0IC1jMmAKIAogZGV0ZXJtaW5lVHlwZSAiJGZp bGUiICIkbWltZVR5cGUiICIkdHlwZURlc2NyaXB0aW9uIiAiJGZpbGVFeHRlbnNpb24iCiAK 68222 2005-09-11 21:04 0000 media-libs/netpbm ebuild netpbm-10.28-r1.ebuild text/plain IyBDb3B5cmlnaHQgMTk5OS0yMDA1IEdlbnRvbyBGb3VuZGF0aW9uCiMgRGlzdHJpYnV0ZWQgdW5k ZXIgdGhlIHRlcm1zIG9mIHRoZSBHTlUgR2VuZXJhbCBQdWJsaWMgTGljZW5zZSB2MgojICRIZWFk ZXI6IC92YXIvY3Zzcm9vdC9nZW50b28teDg2L21lZGlhLWxpYnMvbmV0cGJtL25ldHBibS0xMC4y OC5lYnVpbGQsdiAxLjExIDIwMDUvMDgvMTYgMDU6MDI6NDUgdmFwaWVyIEV4cCAkCgppbmhlcml0 IGZsYWctby1tYXRpYyB0b29sY2hhaW4tZnVuY3MgZXV0aWxzCgpERVNDUklQVElPTj0iQSBzZXQg b2YgdXRpbGl0aWVzIGZvciBjb252ZXJ0aW5nIHRvL2Zyb20gdGhlIG5ldHBibSAoYW5kIHJlbGF0 ZWQpIGZvcm1hdHMiCkhPTUVQQUdFPSJodHRwOi8vbmV0cGJtLnNvdXJjZWZvcmdlLm5ldC8iClNS Q19VUkk9Im1pcnJvcjovL3NvdXJjZWZvcmdlLyR7UE59LyR7UH0udGd6IgoKTElDRU5TRT0iR1BM LTIiClNMT1Q9IjAiCktFWVdPUkRTPSJhbHBoYSBhbWQ2NCBhcm0gaHBwYSBpYTY0IG1pcHMgcHBj IHBwYzY0IHNwYXJjIHg4NiIKSVVTRT0ic3ZnYSBqcGVnIHRpZmYgcG5nIHpsaWIiCgpERVBFTkQ9 ImpwZWc/ICggPj1tZWRpYS1saWJzL2pwZWctNmIgKQoJdGlmZj8gKCA+PW1lZGlhLWxpYnMvdGlm Zi0zLjUuNSApCglwbmc/ICggPj1tZWRpYS1saWJzL2xpYnBuZy0xLjIuMSApCgl6bGliPyAoIHN5 cy1saWJzL3psaWIgKQoJc3ZnYT8gKCBtZWRpYS1saWJzL3N2Z2FsaWIgKSIKCnNyY191bnBhY2so KSB7Cgl1bnBhY2sgJHtBfQoJY2QgJHtTfQoJY3AgTWFrZWZpbGUuY29uZmlnLmluIE1ha2VmaWxl LmNvbmZpZwoKCWlmIHVzZSBzdmdhIDsgdGhlbgoJCWVjaG8gIkxJTlVYU1ZHQUhEUl9ESVIgPSAv dXNyL2luY2x1ZGUiID4+IE1ha2VmaWxlLmNvbmZpZwoJCWVjaG8gIkxJTlVYU1ZHQUxJQiA9IC91 c3IvJChnZXRfbGliZGlyKS9saWJ2Z2Euc28iID4+IE1ha2VmaWxlLmNvbmZpZwoJZmkKCglpZiB1 c2UganBlZyA7IHRoZW4KCQllY2hvICJKUEVHTElCID0gbGlianBlZy5zbyIgPj4gTWFrZWZpbGUu Y29uZmlnCglmaQoKCWlmIHVzZSBwbmcgOyB0aGVuCgkJZWNobyAiUE5HTElCID0gbGlicG5nLnNv IiA+PiBNYWtlZmlsZS5jb25maWcKCWZpCgoJaWYgdXNlIHRpZmYgOyB0aGVuCgkJZWNobyAiVElG RkxJQiA9IGxpYnRpZmYuc28iID4+IE1ha2VmaWxlLmNvbmZpZwoJZmkKCglpZiB1c2UgemxpYiA7 IHRoZW4KCQllY2hvICJaTElCID0gbGliei5zbyIgPj4gTWFrZWZpbGUuY29uZmlnCglmaQoKCSMg U3BhcmMgc3VwcG9ydCAuLi4KCXJlcGxhY2UtZmxhZ3MgIi1tY3B1PXVsdHJhc3BhcmMiICItbWNw dT12OCAtbXR1bmU9dWx0cmFzcGFyYyIKCXJlcGxhY2UtZmxhZ3MgIi1tY3B1PXY5IiAiLW1jcHU9 djggLW10dW5lPXY5IgoKCXNlZCAtaSBcCgkJLWUgJ3M6JChDRkxBR1MpOiQoQ0ZMQUdTKSAtZlBJ QzonIFwKCQktZSAnczokKExERkxBR1MpOiQoTERGTEFHUykgLWZQSUM6JyBcCgkJbGliL01ha2Vm aWxlCgkgc2VkIC1pIC1lICdzOiQoQ0NPUFQpOiQoQ0NPUFQpIC1mUElDOicgXAoJIAlsaWIvdXRp bC9NYWtlZmlsZQoKCWVwYXRjaCAke0ZJTEVTRElSfS8ke1BOfS1kU0FGRVIucGF0Y2gKCWVwYXRj aCAke0ZJTEVTRElSfS8xMDUxMjctcjIucGF0Y2gKfQoKc3JjX2NvbXBpbGUoKSB7CgllbWFrZSAt ajEgQ0M9IiQodGMtZ2V0Q0MpIiBDWFg9IiQodGMtZ2V0Q1hYKSIgfHwgZGllICJlbWFrZSBmYWls ZWQiCn0KCnNyY19pbnN0YWxsKCkgewoJbWFrZSBwYWNrYWdlIHBrZ2Rpcj0ke0R9L3Vzci8gfHwg ZGllICJtYWtlIHBhY2thZ2UgZmFpbGVkIgoKCWlmIFsgIiQoZ2V0X2xpYmRpcikiICE9ICJsaWIi IF07IHRoZW4KCQltdiAke0R9L3Vzci9saWIgJHtEfS91c3IvJChnZXRfbGliZGlyKQoJZmkKCgkj IEZpeCBzeW1saW5rIG5vdCBiZWluZyBjcmVhdGVkLgoJZG9zeW0gYGJhc2VuYW1lICR7RH0vdXNy LyQoZ2V0X2xpYmRpcikvbGlibmV0cGJtLnNvLipgIC91c3IvJChnZXRfbGliZGlyKS9saWJuZXRw Ym0uc28KCglybSAtcmYgJHtEfS91c3IvYmluL2RvYy51cmwKCXJtIC1yZiAke0R9L3Vzci9tYW4v d2ViCglybSAtcmYgJHtEfS91c3IvbGluawoJcm0gLXJmICR7RH0vdXNyL1JFQURNRQoJcm0gLXJm ICR7RH0vdXNyL1ZFUlNJT04KCXJtIC1yZiAke0R9L3Vzci9wa2dpbmZvCglybSAtZiAke0R9L3Vz ci9jb25maWdfdGVtcGxhdGUKCWRvZGlyIC91c3Ivc2hhcmUKCW12ICR7RH0vdXNyL21hbiAke0R9 L3Vzci9zaGFyZS9tYW4KCgkjIEluc3RhbGwgdGhlIG1hcHMgaW4gL3Vzci9zaGFyZS9uZXRwYm0g c28gb3RoZXIgcHJvZ3JhbXMgKGxpa2UgcGx1Y2tlcikgY2FuCgkjIHVzZSB0aGVtLiAgIzc3Nzk3 CgltdiAke0R9L3Vzci9taXNjICR7RH0vdXNyL3NoYXJlL25ldHBibQoKCWRvZG9jIFJFQURNRQoJ ZXhwb3J0IEdMT0JJR05PUkU9JyouaHRtbDouKicKCWNkIGRvYyAmJiBcCgkJZG9kb2MgKiAmJiBc CgkJZG9odG1sIC1yIC4gfHwgZGllICJkb2MgaW5zdGFsbCBmYWlsZWQiCn0K