1044 2002-03-10 08:23 0000 sys-apps/hdparm-4.6.ebuild fails with Crusoe optimizations 2003-02-04 19:42:18 0000 1 1 1 Unclassified Gentoo Linux Ebuilds unspecified x86 Linux RESOLVED FIXED P2 critical --- 1 robm@flipturn.org g2boojum@gentoo.org robm@flipturn.org 2002-03-10 08:23:43 0000 With the optimizations I wanted to use for compiling on the Crusoe processor: -O2 -fno-strict-aliasing -fno-common -fomit-frame-pointer -pipe -mpreferred-stack-boundary=2 -march=i686 -malign-functions=0 -malign-jumps=0 -malign-loops=0 the sys-apps/hdparm ebuild fails because in src_unpack(), the sed command replaces the -mpreferred-stack-boundary with '-mpreferredtack-boundary' instead of removing the '-s' flag from the command line as was intended. In general, any time sed is used to place the CFLAGS in a Makefile, we ought to do any changes/deletions to the file before we insert the CFLAGS. In other words, unless you really mean to potentially change the user's CFLAGS, the CFLAGS insertion ought to come last in the sed command. Here's a fix for hdparm. --- hdparm-4.6.ebuild Sun Mar 10 07:53:31 2002 +++ hdparm-4.6-r1.ebuild Sun Mar 10 07:50:15 2002 @@ -12,7 +12,7 @@ unpack ${A} cd ${S} mv Makefile Makefile.orig - sed -e "s/-O2/${CFLAGS}/" -e "s:-s::" \ + sed -e "s:-s::" -e "s/-O2/${CFLAGS}/" \ Makefile.orig > Makefile } drobbins@gentoo.org 2002-03-12 10:01:03 0000 Grant -- I fixed this bug on CVS, but I'm reassigning it to you because we really need to add this info to our Development HOWTO. It's something that never occurred to me. blizzy-keyword-gentoo_bugs2.a8a736@blizzy.de 2002-05-29 10:31:37 0000 What's so different about this patch now? It still replaces things like "-fkeep-static-consts" with "-fkeeptatic-consts" :-/ Better make that ... -e 's| -s||' ... (note the space) g2boojum@gentoo.org 2002-07-19 10:13:14 0000 Killed old version, thereby fixing the problem. Good catch!