101875 2005-08-09 09:32 0000 games-engines/stratagus-2.1 superfluous ogg use flag 2005-09-23 23:36:41 0000 1 1 1 Unclassified Gentoo Linux Games unspecified All Linux RESOLVED FIXED P2 normal --- 1 carlo@gentoo.org games@gentoo.org carlo@gentoo.org 2005-08-09 09:32:22 0000 The vorbis use flag denotes ogg/vorbis support (libvorbis depends on libogg). carlo@gentoo.org 2005-08-09 09:34:24 0000 Created an attachment (id=65540) The vorbis use flag denotes ogg/vorbis support, not the other way around (libvorbis depends on libogg). vapier@gentoo.org 2005-08-09 10:11:40 0000 just because libvorbis depends on ogg now doesnt mean it always will does it ? stragus looks for ogg.h and vorbisfile.h as well as libogg.so and libvorbis.so carlo@gentoo.org 2005-08-09 10:48:09 0000 >just because libvorbis depends on ogg now doesnt mean it always will does it ? And in another hypothetical case the stratagus devs may be audiophilists and feel it's time switch to flac. ;p Enabling vorbis support via ogg use flag is simply wrong. It denotes only the container format, not the vorbis codec. mr_bones_@gentoo.org 2005-09-23 23:36:41 0000 Yeah, it's ugly, but I agree. Especially since the configure script support flac as well. I changed the ebuild to only turn on oggvorbis support if both the ogg and vorbis use flags are set. I think that allows the ogg/flac possibility and represents reality a little better. Thanks for the bug report. 65540 2005-08-09 09:34 0000 The vorbis use flag denotes ogg/vorbis support, not the other way around (libvorbis depends on libogg). stratagus-2.1.ebuild.diff text/plain LS0tIHN0cmF0YWd1cy0yLjEuZWJ1aWxkLm9yaWcJMjAwNS0wOC0wOSAxODoxMDo1Ny4wMDAwMDAw MDAgKzAyMDAKKysrIHN0cmF0YWd1cy0yLjEuZWJ1aWxkCTIwMDUtMDgtMDkgMTg6MzE6MjIuMDAw MDAwMDAwICswMjAwCkBAIC0xMiw3ICsxMiw3IEBACiBMSUNFTlNFPSJHUEwtMiIKIFNMT1Q9IjAi CiBLRVlXT1JEUz0ifmFtZDY0IH5wcGMgfng4NiIKLUlVU0U9ImRlYnVnIGRvYyBmbGFjIG1wMyBt aWttb2Qgb2dnIHZvcmJpcyBvcGVuZ2wiCitJVVNFPSJkZWJ1ZyBkb2MgZmxhYyBtcDMgbWlrbW9k IHZvcmJpcyBvcGVuZ2wiCiAKIFJERVBFTkQ9InZpcnR1YWwveDExCiAJYXBwLWFyY2gvYnppcDIK QEAgLTIzLDI1ICsyMywyMCBAQAogCWZsYWM/ICggbWVkaWEtbGlicy9mbGFjICkKIAltcDM/ICgg bWVkaWEtbGlicy9saWJtYWQgKQogCW1pa21vZD8gKCBtZWRpYS1saWJzL2xpYm1pa21vZCApCi0J b2dnPyAoIG1lZGlhLWxpYnMvbGlib2dnIG1lZGlhLWxpYnMvbGlidm9yYmlzICkKLQl2b3JiaXM/ ICggbWVkaWEtbGlicy9saWJvZ2cgbWVkaWEtbGlicy9saWJ2b3JiaXMgKSIKKwl2b3JiaXM/ICgg bWVkaWEtbGlicy9saWJ2b3JiaXMgKSIKIERFUEVORD0iJHtSREVQRU5EfQogCWRvYz8gKCBhcHAt ZG9jL2RveHlnZW4gKSIKIAogUz0ke1dPUktESVJ9L3N0cmF0YWd1cy0ke01ZX1BWfQogCiBzcmNf Y29tcGlsZSgpIHsKLQlsb2NhbCBteWNvbmY9IiIKLQkodXNlIG9nZyB8fCB1c2Ugdm9yYmlzKSBc Ci0JCSYmIG15Y29uZj0iLS1lbmFibGUtb2dnIiBcCi0JCXx8IG15Y29uZj0iLS1kaXNhYmxlLW9n ZyIKIAllY29uZiBcCisJCSQodXNlX2VuYWJsZSB2b3JiaXMgb2dnKSBcCiAJCSQodXNlX2VuYWJs ZSBkZWJ1ZykgXAogCQkkKHVzZV93aXRoIG1pa21vZCkgXAogCQkkKHVzZV93aXRoIGZsYWMpIFwK IAkJJCh1c2Vfd2l0aCBtcDMgbWFkKSBcCiAJCSQodXNlX3dpdGggb3BlbmdsKSBcCi0JCSR7bXlj b25mfSBcCiAJCXx8IGRpZSAiZWNvbmYgZmFpbGVkIgogCWVtYWtlIC1qMSB8fCBkaWUgImVtYWtl IGZhaWxlZCIKIAo=