review log by solar and SpanKY

irc-tailed.log (text/plain), 1.80 KB, created by hiyuh on 2006-05-25 21:26:52 UTC

5/26 12:42:39 hiyuh
   solar: groff-1.19 + japanese patch is. please see bug 134377
5/26 12:42:40 jeeves
   hiyuh: http://bugs.gentoo.org/134377 nor, P2, All, [e-mail][e-mail], NEW, pending, groff-1.19.1 CJK patch
5/26 12:43:15 hiyuh
   or SpanKY? :9
5/26 12:48:54 solar
   hiyuh: do you have to use use cjk && epatch "${FILESDIR}"/${P}-japanese-r5111.patch ?
5/26 12:49:09 solar
   ie is the conditional patching a must?
5/26 12:52:04 solar
   ahh it forces wchar.
5/26 12:53:25 hiyuh
   solar: yeah, but maybe it's not unnecessarily for non-cjk peaple. and then, the patch seems be so huge, though. :P
5/26 12:53:37 solar
   it is very large
5/26 12:54:26 hiyuh
   yeah, should it be in distfiles dir?
5/26 12:54:34 solar
   sorta would worrie that with it being so large and conditional that it would prevent any other patching which we may have todo
5/26 12:54:46 solar
   prevent as in conflict easy
5/26 12:55:21 solar
   looking at the .18.1 ebuild it did not look like you had todo any condtional patching at all
5/26 12:55:34 solar
   know what happened betwen the releases?
5/26 12:57:11 hiyuh
   sorry, dunno that detail. but cjk patch for 1.18 which is in portage couldn't apply to 1.19.
5/26 13:01:30 solar
   understood thats fine.
5/26 13:03:43 hiyuh
   solar: k, some japanese users can test/poke it at this weekend or so on. then, you can put it into tree?
5/26 13:05:31 solar
   I'd rather SpanKY review and decide on the conditional patching
5/26 13:05:41 hiyuh
   I see.
5/26 13:06:01 solar
   also any idea why it's not gone upstream?
5/26 13:07:13 hiyuh
   well, one of the problems is the patch is very large, IMHO.
5/26 13:07:40 SpanKY
   yeah, it'd have to be compressed and put on mirrors
5/26 13:07:46 SpanKY
   i'd prefer one of our cjk devs review it
5/26 13:08:35 hiyuh
   SpanKY++