Go to:
Gentoo Home
Documentation
Forums
Lists
Bugs
Planet
Store
Wiki
Get Gentoo!
Gentoo's Bugzilla – Attachment 67471 Details for
Bug 104565
app-admin/gtkdiskfree <= 1.9.3 unsecure tmp file creation
Home
|
New
–
[Ex]
|
Browse
|
Search
|
Privacy Policy
|
[?]
|
Reports
|
Requests
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
temp file fix
gtkdiskfree-temp-sec.diff (text/plain), 1.18 KB, created by
Tavis Ormandy (RETIRED)
on 2005-09-02 05:12:58 UTC
(
hide
)
Description:
temp file fix
Filename:
MIME Type:
Creator:
Tavis Ormandy (RETIRED)
Created:
2005-09-02 05:12:58 UTC
Size:
1.18 KB
patch
obsolete
>--- gtkdiskfree-1.9.3/src/mount.c 2002-11-17 15:08:27.000000000 +0000 >+++ gtkdiskfree-1.9.3.new/src/mount.c 2005-09-02 13:05:25.636363128 +0100 >@@ -31,41 +31,21 @@ > void > open_cmd_tube (const gchar *cmd, const gchar *mount_point) > { >- gint status; >- gchar error[MAXLINE], *line; >- FILE *sh, *tmp; >+ gchar error[MAXLINE], *line, *status; >+ FILE *sh; > > setbuf(stdout, error); >- line = g_strconcat(cmd, " ", mount_point, " &> ", TUBE_NAME, NULL); >+ line = g_strconcat(cmd, " ", mount_point, " 2>&1", NULL); > sh = popen(line, "r"); > g_free(line); > >- status = pclose(sh); >- >- if (status == 0) { >- remove(TUBE_NAME); >- gui_list_main_update(GTK_TREE_VIEW(list_treeview)); >- >- return; >- } else { >- if ((tmp = fopen(TUBE_NAME, "r")) == NULL) { >- gui_list_main_update(GTK_TREE_VIEW(list_treeview)); >- >- return; >- } >- if (fgets(error, MAXLINE-1, tmp) == NULL) { >- fclose(tmp); >- remove(TUBE_NAME); >- gui_list_main_update(GTK_TREE_VIEW(list_treeview)); >- >- return; >- } >- fclose(tmp); >- remove(TUBE_NAME); >+ status = fgets(error, MAXLINE-1, sh); >+ >+ if (status && (pclose(sh) != 0)) > error_window(error); >- } >+ > gui_list_main_update(GTK_TREE_VIEW(list_treeview)); >- >+ > return; > } >
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
Attachments on
bug 104565
: 67471