Attachment #29470 for bug #48107

View | Details | Raw Unified | Return to bug 48107
Collapse All | Expand All

Lines 969-974 Link Here

(-)src/xine-engine/configfile.c (+9 lines)
969	int handled = 0;	969	int handled = 0;
970		970
971	lprintf ("change_opt '%s'\n", opt);	971	lprintf ("change_opt '%s'\n", opt);
		972
		973	if ((entry = config->lookup_entry(config, "misc.implicit_config")) &&
		974	entry->type == CONFIG_TYPE_BOOL) {
		975	if (!entry->num_value)
		976	/* changing config entries implicitly is denied */
		977	return -1;
		978	} else
		979	/* someone messed with the config entry */
		980	return -1;
972		981
973	if(config && opt) {	982	if(config && opt) {
974	char key, value;	983	char key, value;




      _("Path for saving streams"),
      _("Streams will be saved only into this directory"),
      XINE_CONFIG_SECURITY, __config_save_cb, this);
  
  /*
   * implicit configuration changes
   */
  this->config->register_bool(this->config,
      "misc.implicit_config", 0,
      _("allow implicit changes to the configuration (e.g. by MRL)"),
      _("If enabled, you allow xine to change your configuration without "
	"explicit actions from your side. For example configuration changes "
	"demanded by MRLs or embedded into playlist will be executed.\n"
	"This setting is security critcal, because xine can receive MRLs or "
	"playlists from untrusted remote sources. If you allow them to "
	"arbitrarily change your configuration, you might end with a totally "
	"messed up xine."),
      XINE_CONFIG_SECURITY, NULL, this);

  /*
   * keep track of all opened streams

Return to bug 48107

Lines 1429-1434 Link Here

(-)src/xine-engine/xine.c (+15 lines)
1429	_("Path for saving streams"),	1429	_("Path for saving streams"),
1430	_("Streams will be saved only into this directory"),	1430	_("Streams will be saved only into this directory"),
1431	XINE_CONFIG_SECURITY, __config_save_cb, this);	1431	XINE_CONFIG_SECURITY, __config_save_cb, this);
		1432
		1433	/*
		1434	* implicit configuration changes
		1435	*/
		1436	this->config->register_bool(this->config,
		1437	"misc.implicit_config", 0,
		1438	_("allow implicit changes to the configuration (e.g. by MRL)"),
		1439	_("If enabled, you allow xine to change your configuration without "
		1440	"explicit actions from your side. For example configuration changes "
		1441	"demanded by MRLs or embedded into playlist will be executed.\n"
		1442	"This setting is security critcal, because xine can receive MRLs or "
		1443	"playlists from untrusted remote sources. If you allow them to "
		1444	"arbitrarily change your configuration, you might end with a totally "
		1445	"messed up xine."),
		1446	XINE_CONFIG_SECURITY, NULL, this);
1432		1447
1433	/*	1448	/*
1434	* keep track of all opened streams	1449	* keep track of all opened streams