[patch] Patch to fix the bug and s/sprintf/snprintf/

grip-3.3.1-invalid-genre-size.patch (text/plain), 799 bytes, created by Frédéric Fauberteau on 2010-04-24 09:17:17 UTC

diff -ur grip-3.3.1.orig/src/id3.c grip-3.3.1/src/id3.c
--- grip-3.3.1.orig/src/id3.c	2010-04-24 10:17:23.000000000 +0200
+++ grip-3.3.1/src/id3.c	2010-04-24 10:16:42.000000000 +0200
@@ -252,8 +252,8 @@
       
       if ( frames[ i ] ) {
 	char *c_data = NULL;
-	char gen[ 5 ] = "(   )";
-	char trk[ 4 ] = "   ";
+	char gen[ 6 ] = "(   )"; /* max unsigned char: 255 */
+	char trk[ 3 ] = "  "; /* max CDDA tracks: 99 */
 	
 	switch( frameids[ i ] ) {
 	case ID3FID_TITLE:
@@ -278,12 +278,12 @@
 	  
 	case ID3FID_CONTENTTYPE:
 	  c_data = gen;
-	  sprintf( gen, "(%d)", genre ); /* XXX */
+	  snprintf( gen, 6, "(%d)", genre );
 	  break;
 	  
 	case ID3FID_TRACKNUM:
 	  c_data = trk;
-	  sprintf( trk, "%d", tracknum ); /* XXX */
+	  snprintf( trk, 3, "%d", tracknum );
 	  break;
 	  
 	default: