Attachment #228969 for bug #285105




      
      if ( frames[ i ] ) {
	char *c_data = NULL;
	char gen[ 6 ] = "(   )"; /* max unsigned char: 255 */
	char trk[ 3 ] = "  "; /* max CDDA tracks: 99 */
	
	switch( frameids[ i ] ) {
	case ID3FID_TITLE:

	  
	case ID3FID_CONTENTTYPE:
	  c_data = gen;
	  snprintf( gen, 6, "(%d)", genre );
	  break;
	  
	case ID3FID_TRACKNUM:
	  c_data = trk;
	  snprintf( trk, 3, "%d", tracknum );
	  break;
	  
	default:

Return to bug 285105

Lines 252-259 Link Here

(-)grip-3.3.1.orig/src/id3.c (-4 / +4 lines)
252		252
253	if ( frames[ i ] ) {	253	if ( frames[ i ] ) {
254	char *c_data = NULL;	254	char *c_data = NULL;
255	char gen[ 5 ] = "( )";	255	char gen[ 6 ] = "( )"; /* max unsigned char: 255 */
256	char trk[ 4 ] = " ";	256	char trk[ 3 ] = " "; /* max CDDA tracks: 99 */
257		257
258	switch( frameids[ i ] ) {	258	switch( frameids[ i ] ) {
259	case ID3FID_TITLE:	259	case ID3FID_TITLE:
Lines 278-289 Link Here
278		278
279	case ID3FID_CONTENTTYPE:	279	case ID3FID_CONTENTTYPE:
280	c_data = gen;	280	c_data = gen;
281	sprintf( gen, "(%d)", genre ); /* XXX */	281	snprintf( gen, 6, "(%d)", genre );
282	break;	282	break;
283		283
284	case ID3FID_TRACKNUM:	284	case ID3FID_TRACKNUM:
285	c_data = trk;	285	c_data = trk;
286	sprintf( trk, "%d", tracknum ); /* XXX */	286	snprintf( trk, 3, "%d", tracknum );
287	break;	287	break;
288		288
289	default:	289	default: