[patch] Patch to fix race condition

eog-2.26.2-exif-race.patch (text/plain), 1.10 KB, created by Frank on 2009-07-04 12:17:57 UTC

https://bugzilla.gnome.org/show_bug.cgi?id=583448
https://bugs.gentoo.org/show_bug.cgi?id=273884

diff -urN eog-2.26.2/ChangeLog eog-2.26.2-r1/ChangeLog
--- eog-2.26.2/ChangeLog	2009-07-04 13:59:18.000000000 +0200
+++ eog-2.26.2-r1/ChangeLog	2009-07-04 13:56:44.000000000 +0200
@@ -1,3 +1,9 @@
[phone]  Felix Riemann  <[e-mail]>
+
+	* src/eog-image.c (eog_image_set_exif_data):
+	Secure Exif data updating with a mutex. Should fix crashes when
+	reading the Exif block during the update. Fixes bug #583448.
+
 2009-05-18  Felix Riemann  <[e-mail]>
 
 	* NEWS: Update for 2.26.2.
diff -urN eog-2.26.2/src/eog-image.c eog-2.26.2-r1/src/eog-image.c
--- eog-2.26.2/src/eog-image.c	2009-07-04 13:59:16.000000000 +0200
+++ eog-2.26.2-r1/src/eog-image.c	2009-07-04 13:58:43.000000000 +0200
@@ -754,10 +754,12 @@
 	priv = img->priv;
 
 #ifdef HAVE_EXIF
+	g_mutex_lock (priv->status_mutex);
 	if (priv->exif) {
 		exif_data_unref (priv->exif);
 	}
 	priv->exif = eog_metadata_reader_get_exif_data (md_reader);
+	g_mutex_unlock (priv->status_mutex);
 
 	priv->exif_chunk = NULL;
 	priv->exif_chunk_len = 0;