Attachment #178936 for bug #255358

View | Details | Raw Unified | Return to bug 255358
Collapse All | Expand All




		if match:
			return "Quoted \"${A}\" on line: %d"

class ImplicitRuntimeDeps(LineCheck):
	"""
	Detect the case where DEPEND is set and RDEPEND is unset in the ebuild,
	since this triggers implicit RDEPEND=$DEPEND assignment.
	"""

	repoman_check_name = 'RDEPEND.implicit'
	_assignment_re = re.compile(r'^\s*(R?DEPEND)=')

	def new(self, pkg):
		self._rdepend = False
		self._depend = False

	def check(self, num, line):
		if not self._rdepend:
			m = self._assignment_re.match(line)
			if m is None:
				pass
			elif m.group(1) == "RDEPEND":
				self._rdepend = True
			elif m.group(1) == "DEPEND":
				self._depend = True

	def end(self):
		if self._depend and not self._rdepend:
			yield 'RDEPEND is not explicitly assigned'

class InheritAutotools(LineCheck):
	"""
	Make sure appropriate functions are called in

	EbuildAssignment, EbuildUselessDodoc,
	EbuildUselessCdS, EbuildNestedDie,
	EbuildPatches, EbuildQuotedA,
	IUseUndefined, ImplicitRuntimeDeps, InheritAutotools,
	EMakeParallelDisabled, DeprecatedBindnowFlags)))

def run_checks(contents, pkg):

Lines 305-310 Link Here

(-)bin/repoman (+2 lines)
305	"IUSE.undefined":"This ebuild does not define IUSE (style guideline says to define IUSE even when empty)",	305	"IUSE.undefined":"This ebuild does not define IUSE (style guideline says to define IUSE even when empty)",
306	"LICENSE.invalid":"This ebuild is listing a license that doesnt exist in portages license/ dir.",	306	"LICENSE.invalid":"This ebuild is listing a license that doesnt exist in portages license/ dir.",
307	"KEYWORDS.invalid":"This ebuild contains KEYWORDS that are not listed in profiles/arch.list or for which no valid profile was found",	307	"KEYWORDS.invalid":"This ebuild contains KEYWORDS that are not listed in profiles/arch.list or for which no valid profile was found",
		308	"RDEPEND.implicit":"RDEPEND is unset in the ebuild which triggers implicit RDEPEND=$DEPEND assignment",
308	"RDEPEND.suspect":"RDEPEND contains a package that usually only belongs in DEPEND.",	309	"RDEPEND.suspect":"RDEPEND contains a package that usually only belongs in DEPEND.",
309	"RESTRICT.invalid":"This ebuild contains invalid RESTRICT values.",	310	"RESTRICT.invalid":"This ebuild contains invalid RESTRICT values.",
310	"digestentry.unused":"Some files listed in the Manifest aren't referenced in SRC_URI",	311	"digestentry.unused":"Some files listed in the Manifest aren't referenced in SRC_URI",
Lines 343-348 Link Here
343	"KEYWORDS.stupid",	344	"KEYWORDS.stupid",
344	"KEYWORDS.missing",	345	"KEYWORDS.missing",
345	"IUSE.undefined",	346	"IUSE.undefined",
		347	"RDEPEND.implicit",
346	"RDEPEND.suspect",	348	"RDEPEND.suspect",
347	"RESTRICT.invalid",	349	"RESTRICT.invalid",
348	"SRC_URI.mirror",	350	"SRC_URI.mirror",

Lines 168-173 Link Here

(-)man/repoman.1 (+4 lines)
168	.B RDEPEND.badmaskedindev	168	.B RDEPEND.badmaskedindev
169	Masked ebuilds with RDEPEND settings (matched against all ebuilds) in developing arch	169	Masked ebuilds with RDEPEND settings (matched against all ebuilds) in developing arch
170	.TP	170	.TP
		171	.B RDEPEND.implicit
		172	RDEPEND is unset in the ebuild which triggers implicit RDEPEND=$DEPEND
		173	assignment
		174	.TP
171	.B RDEPEND.suspect	175	.B RDEPEND.suspect
172	RDEPEND contains a package that usually only belongs in DEPEND	176	RDEPEND contains a package that usually only belongs in DEPEND
173	.TP	177	.TP

Return to bug 255358

Lines 230-235 Link Here

(-)pym/repoman/checks.py (-1 / +28 lines)
230	if match:	230	if match:
231	return "Quoted \"${A}\" on line: %d"	231	return "Quoted \"${A}\" on line: %d"
232		232
		233	class ImplicitRuntimeDeps(LineCheck):
		234	"""
		235	Detect the case where DEPEND is set and RDEPEND is unset in the ebuild,
		236	since this triggers implicit RDEPEND=$DEPEND assignment.
		237	"""
		238
		239	repoman_check_name = 'RDEPEND.implicit'
		240	_assignment_re = re.compile(r'^\s*(R?DEPEND)=')
		241
		242	def new(self, pkg):
		243	self._rdepend = False
		244	self._depend = False
		245
		246	def check(self, num, line):
		247	if not self._rdepend:
		248	m = self._assignment_re.match(line)
		249	if m is None:
		250	pass
		251	elif m.group(1) == "RDEPEND":
		252	self._rdepend = True
		253	elif m.group(1) == "DEPEND":
		254	self._depend = True
		255
		256	def end(self):
		257	if self._depend and not self._rdepend:
		258	yield 'RDEPEND is not explicitly assigned'
		259
233	class InheritAutotools(LineCheck):	260	class InheritAutotools(LineCheck):
234	"""	261	"""
235	Make sure appropriate functions are called in	262	Make sure appropriate functions are called in
Lines 306-312 Link Here
306	EbuildAssignment, EbuildUselessDodoc,	333	EbuildAssignment, EbuildUselessDodoc,
307	EbuildUselessCdS, EbuildNestedDie,	334	EbuildUselessCdS, EbuildNestedDie,
308	EbuildPatches, EbuildQuotedA,	335	EbuildPatches, EbuildQuotedA,
309	IUseUndefined, InheritAutotools,	336	IUseUndefined, ImplicitRuntimeDeps, InheritAutotools,
310	EMakeParallelDisabled, DeprecatedBindnowFlags)))	337	EMakeParallelDisabled, DeprecatedBindnowFlags)))
311		338
312	def run_checks(contents, pkg):	339	def run_checks(contents, pkg):