======================================================== 01_all_manpage-in-right-section.patch ======================================================== Very minor and cosmetic. Should be submitted upstream as well debian changelog dspam 3.6.4-1 ========================================================= 02_all_link-dynamically.patch ========================================================= I don't think this should be applied at all. --disable-static is the correct way to compile dspam with dynamic links, not a patch to do it. Use --disable-static debian changlog dspam 3.6.2-2 * Updated link-dynamically patch to link all tools dynamically to libdspam7 ========================================================= 03_all_clean-warnings.patch ========================================================= dspam CHANGELOG Version 3.6.6 ------------- [20060513.1100] jonz: fixed compiler warnings on sqlite drivers signed-ness warnings, nothing significant debian bugreport: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=369426 (actual bug text below) debian changelog dspam 3.6.6-2 * Clean up minor warnings in dspam. Patch from Daniel Kahn Gillmor (Closes: #369426) Its a wishlist!!! Why is mysql being patched if this is a sqlite issue? Have sqlite users complaining about compiler errors? Looks like its been taken care of already per upstream changelog. ========================================================= 04_all_make-daemon-quiet.patch ========================================================= Looks cosmetic to me debian bug http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=368822 from changelog dspam 3.6.8-r1 * Updated patch make-daemon-quiet. ========================================================= 05_all_make-dspam_clean-quiet.patch ========================================================= debian bug http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=368822 debian changelog dspam 3.6.6-1 * Make dspam_clean a bit more quiet. (Closes: #368822) Patch the source code because anacron sends a notification message? Better to have the cron job redirect the notice to /dev/null instead if that is desired behavior. Doesn't dspam.cron already do that? /usr/portage/mail-filter/dspam/files/dspam.cron: ... [[ ! -f "/usr/bin/dspam_clean" ]] && exit 4 /usr/bin/dspam_clean -s -p -u 1>/dev/null 2>&1 exit $? ========================================================= 06_all_improper-quotation-fix.patch ========================================================= It's still in CVS. edits src/pgsql.drv. Postgres bug. No need to patch unless one is using pgsql. Submit upstream? debian bugreport http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=369179 ========================================================= 07_all_default-server-pidfile.patch ========================================================= This patch from the same guy who did the link-dynamically patch and anacron notice (dspam-clean) patch. debian changelog dspam 3.6.2-2 * When starting as daemon and no pidfile was given the pidfile isn't created. Added a patch that fixes this problem Looks like gentoo patch is modified version of the debian patch. Is this still an issue with 3.6.8? pidfile is specified in dspam.conf. ========================================================= 08_all_virus-notifications.patch ========================================================= debian bug http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=369434 debian changelog dspam 3.6.6-2 * Add a patch that adds a virus notification to the log. Patch from Julien Valrof (Closes: #369434) found reference here: http://www.archivesat.com/dspam_dev/thread1336409.htm http://www.archivesat.com/dspam_dev/thread1712125.htm dspam CHANGELOG: [20060418.1435] jonz: fix for segfault on clamav connect error fixed a bug where certain problems establishing connectivity to clamav can segfault dspam [20060412.0900] jonz: fix for segfault on empty username fixed a bug where a NULL username can sneak in and cause a segfault on strdup [20060331.0800] jonz: fix for ClamAV applied patch to fix clamav issues Looks like another cosmetic thing, adding virus notifications to log. I use amavis for virus scanning so I get email notification via amavis. ========================================================= 09_all_enable-domain-quarantine.patch ========================================================= looks like its for cyrus + addressed mails debian bugreport dsapm 3.6.6-2 http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=369432 debian changelog dspam 3.6.6-2 * The QuarantaineMailbox option does not work properly if the user is domain qualified. Added patch from Daniel Kahn Gillmor. (Closes: #369432) ========================================================= 10_all_update-dspam.conf.patch ========================================================= debian changelog dspam 3.6.2-2 * Updated the dspam.conf and Trust user dspam. (Otherwise it isn't possible to train messages in the web interface) debian changelog dspam 3.6.8-3 Update update-dspam.conf ServerPID parameter, pidfile is now in /var/run/dspam. (Not in gentoo patch) Gentoo version of this patch changes dspam.conf file value of /usr/lib/storagedriver to /usr/lib/dspam/storagedriver and adds dspam and apache to "Trust" Use --libdir=/usr/lib/dspam and remove that section. "--libdir=" also eliminates the need for the section in the ebuild: dodir /usr/lib/dspam mv "${D}"/usr/lib/*drv* "${D}"/usr/lib/dspam/ dspam and apache users should be added with dspam-web ebuild since this is a webui related issue. May be wise to use sed in case of dspam.conf file changes in future. Overall, this isn't critical as far as the StorageDriver parameter is concerned unless two or more backends are specified in configure options/use flags. ========================================================= 11_all_fix-nav-performance.patch ========================================================= Fine, changes yourdomain to $LOCALDOMAIN$ in cgi. minor and cosmetic ========================================================= 12_all_logrotate-preserve-state.patch ========================================================= Works fine. Upstream may supply different fix in future. Why don't you submit your solution? ========================================================= 13_all_txt-confdir.patch ========================================================= Moves txt/ to confdir as well as homedir. Edits both dspam.c and src/Makefile.am ebuilds changed from $HOMEDIR/txt in dspam 3.4-rc3 to $CONFDIR/txt in dspam-3.6.0 Why? For Linux Filesystem Hierchy compliance? It works in dspamhome/txt, so why patch to move it and make it differ from upstream/source? I don't see the need to patch to move it if it already works in the original location. Also, the ebuild has a statement: "The documentation is wrong! The files need to be in ./txt in README: These notifications can be activated by copying the txt/ directory from the distribution into DSPAM's home (by default /usr/local/var/dspam)." copy the txt/ dir to HOMEDIR isn't wrong, unless one applies this patch. ========================================================= 14_all_autodetect-conf.patch ========================================================= Edits configure.ac Doesn't restore default behavior and add quotes and other config options that were NOT originally present ie: 'build_alias=i686-pc-linux-gnu' 'host_alias=i686-pc-linux-gnu' 'CFLAGS=-march=athlon-xp -O2 -msse2 -pipe -Wl,-z,now' 'CXXFLAGS=-march=athlon-xp -O2 -msse2 -pipe -Wl,-z,now' Changes configure.ac: -AC_DEFINE_UNQUOTED(CONFIGURE_ARGS, ["$CONFIGURE_ARGS"], +AC_DEFINE_UNQUOTED(CONFIGURE_ARGS,["$ac_configure_args"], This patch is not required if patches 02, 03, and 13 aren't used, which are questionable patches at best. Those patches require eautoreconf in the ebuild, which then corrupts the output of the command "dspam --version. I tracked this behavior down to autoconf-2.60 and submitted a bug report for autoconf-2.60. bug 159296 So, in summary: NO = 02, 03, 05, 10*, 13, 14 YES= 01, 04, 06**, 07, 08, 09, 11, 12 * 10 - dspam, apache users should be added to "Trust" in dspam.conf with the dspam-web ebuild. The StorageDriver portion can be removed and replaced with "--libdir=/usr/lib/dspam" configure option. ** 06 - patch for "if use postgres"